April 2014 - Pharo-dev - lists.pharo.org

Nautilus is cool

by Alexandre Bergel

Hi! Just to say that I am happy to have nautilus. It works well even for details. For example I selected all the methods of a class, and did a push up refactoring. It works perfectly. I then selected all the method categories, and do a remove all. No error ! Nautilus is cool :-) Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 24, 2014

Re: [Pharo-dev] [pharo-project/pharo-core] 6f764a: 30830

by Henrik Johansen

On 24 Apr 2014, at 2:24 , Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 24 Apr 2014, at 14:21, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > >> GitHub wrote >>> Log Message: >>> ----------- >>> 30830 >>> >>> http://files.pharo.org/image/30/30830.zip >> >> Which issues did this include? >> > https://pharo.fogbugz.com/f/cases/13028/ > > I integrated it with a .cs as it did not work as a slice. > > I will rever 830, 831 and 832 (which is just that + reload of dirty + the postscript for the change). > > But then we need to fix the issue of 13028â¦ > > Marcus Maybe itâs just me, but isnât it entirely wrong to fix subclasses being kept unmodified when a Shared Variable is added using change propagation? To me, it seems that mechanism is intended only to be used when a class change actually affects its subclassâ definition (iow, when Fields are modified...). I mean, it *should* be possible to setup the new class being migrated to with proper subclasses instvar, though I canât exactly see where that is through all the layers of indirectionâ¦ Cheers, Henry

April 24, 2014

Re: [Pharo-dev] Pharo crashes

by Marcus Denker

On 24 Apr 2014, at 14:57, Camille Teruel <camille.teruel(a)gmail.com> wrote: > > On 24 avr. 2014, at 14:37, Henrik Johansen <henrik.s.johansen(a)veloxit.no> wrote: > >> >> On 24 Apr 2014, at 2:21 , Marcus Denker <marcus.denker(a)inria.fr> wrote: >> >>> >>> On 24 Apr 2014, at 14:04, Christophe Demarey <Christophe.Demarey(a)inria.fr> wrote: >>> >>>> Yes it looks like there is a bug in the slot class builder. >>>> I also have a job failing since #30830 >>>> >>> >>> Yes, this is already here: >>> >>> https://pharo.fogbugz.com/f/cases/13223/Error-Should-not-happen-in-rebase-to >>> >>> >>> Marcus >>> >> >> >> If I revert (comment out classModification propagate) >> SlotClassBuilder >> #applyAndUpdateSharedVariableOrSharedPool: classModification >> ^ self track: classModification during: [ :old :new | >> installer classDefinitionChangedFrom: old to: new by: classModification. >> classModification propagate ]. >> >> in a 80830 image, loading works fine. >> >> â¦ but I guess that change might be the entire point of the patch? > > Yes removing this line will reintroduce the subclass bug. Moreover I think this line is not the cause but a symptom revealer (cf my other mails about classes that have wrong layout). > Now I think the segfault is because of a wrong class format somewhere. So we do another update with the postscript. if that fails, we revert so not all builds are broken. Do we then revert just that method? Or really all updates to 829? Marcus

April 24, 2014

Re: [Pharo-dev] Pharo crashes

by Camille Teruel

On 24 avr. 2014, at 14:37, Henrik Johansen <henrik.s.johansen(a)veloxit.no> wrote: > > On 24 Apr 2014, at 2:21 , Marcus Denker <marcus.denker(a)inria.fr> wrote: > >> >> On 24 Apr 2014, at 14:04, Christophe Demarey <Christophe.Demarey(a)inria.fr> wrote: >> >>> Yes it looks like there is a bug in the slot class builder. >>> I also have a job failing since #30830 >>> >> >> Yes, this is already here: >> >> https://pharo.fogbugz.com/f/cases/13223/Error-Should-not-happen-in-rebase-to >> >> >> Marcus >> > > > If I revert (comment out classModification propagate) > SlotClassBuilder >> #applyAndUpdateSharedVariableOrSharedPool: classModification > ^ self track: classModification during: [ :old :new | > installer classDefinitionChangedFrom: old to: new by: classModification. > classModification propagate ]. > > in a 80830 image, loading works fine. > > â¦ but I guess that change might be the entire point of the patch? Yes removing this line will reintroduce the subclass bug. Moreover I think this line is not the cause but a symptom revealer (cf my other mails about classes that have wrong layout). Now I think the segfault is because of a wrong class format somewhere. > > Cheers, > Henry

April 24, 2014

What is forum (was Re: Pharo Crashes)

by Stephan Eggermont

Esteban wrote: >what is forum? The workshop image for 'Back to the future, (re)learn smalltalkâ. The workshop is targeted at experienced developers and focuses on whatâs different in smalltalk. It has a QCMagritte/Bootstrap based beginning of a Seaside application which the participants have to extend. The workshop exercises are in a glamour browser, as are some code quality visualizations. Stephan

April 24, 2014

Re: [Pharo-dev] [pharo-project/pharo-core] 1953a9: 30829

by Camille Teruel

On 24 avr. 2014, at 14:18, Marcus Denker <marcus.denker(a)inria.fr> wrote: >>>> >>>> This seems to have worked: all image tests are green. >>>> BUT: the Metacello Platformtests fail with a âshould not happenâ error. >>> >>> Did you run the postscript? >>> Smalltalk allClassesDo: [ :c | c superclass addSubclass: c ] >> >> No, but if that would be inconsistent, there is a test that failsâ¦ >> >> But I can do it the next update. >> > > I did one update 30 832 with this. But I guess it will not change anythingâ¦ after that I will revert > to 3.0 829. > My bad I confuses issues... In fact this is not related to this issue but to issue 11596, I never noticed but it has never been integrated!!! By running the script I gave back then, you can see that a lot of classes have still a wrong layout!! That is the scope of the layout of their superclass is not the parent scope of their layout, which give this #shouldNotHappen error Namely: DialogWindowModel class MBAbstractInfoList class MBLabelInfo class MBSpecInfo class MCClassDefinition MCClassDefinition class MCClassTraitDefinition MCClassTraitDefinition class MCFileTreeFileSystemUtils class MCMethodDefinition MCMethodDefinition class MCMockDefinition MCMockDefinition class MCOrganizationDefinition MCOrganizationDefinition class MCScriptDefinition MCScriptDefinition class ProfStef class SpecDebugActionButton class TTLCache TTLCache class TextInputFieldModel class UIThemeVistary class UIThemeWatery class WorldModel class Please run this script we cannot release Pharo with all these corrupted classes!!! > > Marcus

April 24, 2014

Re: [Pharo-dev] Phexample: API Change Proposal (was Phexample: Image Destroying Bug)

by Sean P. DeNigris

Stefan Marr-3 wrote > Now it should be enabled. Looks good, thanks! ----- Cheers, Sean -- View this message in context: http://forum.world.st/Phexample-API-Change-Proposal-was-Phexample-Image-Des… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 24, 2014

Re: [Pharo-dev] [Pharo CI] Linux slave problem solved

by Sean P. DeNigris

Marcus Denker-4 wrote > The problem with the linux slaves is fixedâ¦ things should get normal > again. Thank you Marcus for taking care of all these boring, but crucial, details! ----- Cheers, Sean -- View this message in context: http://forum.world.st/Pharo-CI-Linux-slave-problem-solved-tp4755938p4756226… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

April 24, 2014

Re: [Pharo-dev] Pharo crashes

by Henrik Johansen

On 24 Apr 2014, at 2:21 , Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 24 Apr 2014, at 14:04, Christophe Demarey <Christophe.Demarey(a)inria.fr> wrote: > >> Yes it looks like there is a bug in the slot class builder. >> I also have a job failing since #30830 >> > > Yes, this is already here: > > https://pharo.fogbugz.com/f/cases/13223/Error-Should-not-happen-in-rebase-to > > > Marcus > If I revert (comment out classModification propagate) SlotClassBuilder >> #applyAndUpdateSharedVariableOrSharedPool: classModification ^ self track: classModification during: [ :old :new | installer classDefinitionChangedFrom: old to: new by: classModification. classModification propagate ]. in a 80830 image, loading works fine. â¦ but I guess that change might be the entire point of the patch? Cheers, Henry

April 24, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30832 Home: https://github.com/pharo-project/pharo-core

April 24, 2014