October 2014 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [Vm-dev] Re: Should literals be immutable ?

by Levente Uzonyi

On Mon, 27 Oct 2014, Eliot Miranda wrote: > See my message earlier in the thread.Â Via a per-object isImmutable bit. So you would set the bit for the CompiledMethod and all literals (including sub-arrays, floats, integers, booleans etc)? Does the set immutability bit also mean that the object can't be swapped with #become:? Levente

Oct. 27, 2014

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/40333 Home: https://github.com/pharo-project/pharo-core

Oct. 27, 2014

[pharo-project/pharo-core] 1caecf: 40333

by GitHub

Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: 1caecfd6f3c1999228f90c5106d78cdbcdb0a07e https://github.com/pharo-project/pharo-core/commit/1caecfd6f3c1999228f90c51… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2014-10-27 (Mon, 27 Oct 2014) Changed paths: M Announcements-View.package/AnnouncementSpy.class/instance/building/buildMenu_.st M Keymapping-Settings.package/KMCatcherMorph.class/instance/event handling/showContextMenu.st M Manifest-CriticBrowser.package/CriticBrowser.class/instance/initialization/setActionLogButtom.st M Manifest-CriticBrowser.package/CriticBrowser.class/instance/initialization/setActionResetButtom.st M Manifest-CriticBrowser.package/CriticBrowser.class/instance/protocol/onWindowClosed.st M MonticelloGUI.package/MCCodeTool.class/instance/menus/methodListMenu_.st M MonticelloGUI.package/MCConfigurationBrowser.class/instance/actions/installMenu.st M MonticelloGUI.package/MCConfigurationBrowser.class/instance/actions/loadMenu.st M MonticelloGUI.package/MCConfigurationBrowser.class/instance/actions/updateMenu.st M MonticelloGUI.package/MCSnapshotBrowser.class/instance/menus/categoryListMenu_.st M MonticelloGUI.package/MCSnapshotBrowser.class/instance/menus/classListMenu_.st M MonticelloGUI.package/MCSnapshotBrowser.class/instance/menus/methodListMenu_.st M MonticelloGUI.package/MCSnapshotBrowser.class/instance/menus/protocolListMenu_.st A Morphic-Base.package/MenuMorph.class/class/deprecated/fromArray_.st M Morphic-Base.package/MenuMorph.class/class/example/example.st R Morphic-Base.package/MenuMorph.class/class/instance creation/fromArray_.st A Morphic-Base.package/MenuMorph.class/class/instance creation/fromList_.st A Morphic-Base.package/MenuMorph.class/class/private - utilities/chooseFrom_lines_title_.st A Morphic-Base.package/MenuMorph.class/class/private - utilities/chooseFrom_values_lines_title_.st A Morphic-Base.package/MenuMorph.class/class/private - utilities/confirm_orCancel_.st A Morphic-Base.package/MenuMorph.class/class/private - utilities/confirm_trueChoice_falseChoice_.st R Morphic-Base.package/MenuMorph.class/class/utilities/chooseFrom_lines_title_.st R Morphic-Base.package/MenuMorph.class/class/utilities/chooseFrom_values_lines_title_.st M Morphic-Base.package/MenuMorph.class/class/utilities/confirm_.st R Morphic-Base.package/MenuMorph.class/class/utilities/confirm_orCancel_.st R Morphic-Base.package/MenuMorph.class/class/utilities/confirm_trueChoice_falseChoice_.st R Morphic-Base.package/MenuMorph.class/instance/accessing/addBlankIconsIfNecessary_.st A Morphic-Base.package/MenuMorph.class/instance/construction/addBlankIconsIfNecessary_.st M Morphic-Base.package/MenuMorph.class/instance/construction/addList_.st M Morphic-Base.package/MenuMorph.class/instance/construction/addTranslatedList_.st M Morphic-Base.package/MenuMorph.class/instance/construction/addWithLabel_enablement_action_.st M Morphic-Base.package/MenuMorph.class/instance/construction/add_action_.st M Morphic-Base.package/MenuMorph.class/instance/construction/add_icon_subMenu_.st A Morphic-Base.package/MenuMorph.class/instance/construction/add_selector_.st M Morphic-Base.package/MenuMorph.class/instance/construction/add_selector_argument_.st M Morphic-Base.package/MenuMorph.class/instance/construction/add_subMenu_.st M Morphic-Base.package/MenuMorph.class/instance/construction/add_target_selector_.st M Morphic-Base.package/MenuMorph.class/instance/construction/add_target_selector_argumentList_.st M Morphic-Base.package/MenuMorph.class/instance/construction/add_target_selector_argument_.st M Morphic-Base.package/MenuMorph.class/instance/deprecated/add_target_action_.st M Morphic-Base.package/MenuMorph.class/instance/menu/addCustomMenuItems_hand_.st M Morphic-Base.package/MenuMorph.class/instance/menu/addItem.st R Morphic-Base.package/PluggableMenuItemSpec.class/instance/Morphic-Base-Menus/asMenuItemMorphFrom_isLast_.st R Morphic-Base.package/PluggableMenuItemSpec.class/instance/Morphic-Base-Menus/morphClass.st A Morphic-Base.package/PluggableMenuItemSpec.class/instance/morphic/asMenuItemMorphFrom_isLast_.st A Morphic-Base.package/PluggableMenuItemSpec.class/instance/morphic/morphClass.st R Morphic-Base.package/PluggableMenuSpec.class/instance/Morphic-Base-Menus/asMenuMorph.st R Morphic-Base.package/PluggableMenuSpec.class/instance/Morphic-Base-Menus/buildWith_.st R Morphic-Base.package/PluggableMenuSpec.class/instance/Morphic-Base-Menus/morphClass.st M Morphic-Base.package/PluggableMenuSpec.class/instance/accessing/items.st M Morphic-Base.package/PluggableMenuSpec.class/instance/accessing/label.st M Morphic-Base.package/PluggableMenuSpec.class/instance/construction/addList_.st M Morphic-Base.package/PluggableMenuSpec.class/instance/construction/addSeparator.st A Morphic-Base.package/PluggableMenuSpec.class/instance/construction/add_selector_.st M Morphic-Base.package/PluggableMenuSpec.class/instance/construction/add_selector_argumentList_.st M Morphic-Base.package/PluggableMenuSpec.class/instance/construction/add_target_selector_argumentList_.st M Morphic-Base.package/PluggableMenuSpec.class/instance/construction/newMenuItem.st A Morphic-Base.package/PluggableMenuSpec.class/instance/morphic/asMenuMorph.st A Morphic-Base.package/PluggableMenuSpec.class/instance/morphic/buildWith_.st A Morphic-Base.package/PluggableMenuSpec.class/instance/morphic/morphClass.st M Morphic-Base.package/PolygonMorph.class/instance/menu/addCustomMenuItems_hand_.st M Morphic-Base.package/PolygonMorph.class/instance/menu/addPolyArrowMenuItems_hand_.st M Morphic-Base.package/PolygonMorph.class/instance/menu/addPolyShapingMenuItems_hand_.st M Morphic-Base.package/SelectionMorph.class/instance/halo commands/addCustomMenuItems_hand_.st M Morphic-Base.package/StringMorph.class/instance/menu/addCustomMenuItems_hand_.st M Morphic-Base.package/TextMorph.class/instance/menu/addCustomMenuItems_hand_.st M Morphic-Base.package/TransformMorph.class/instance/menu/addCustomMenuItems_hand_.st M Morphic-Core.package/BorderedMorph.class/instance/menu/addBorderStyleMenuItems_hand_.st M Morphic-Core.package/Morph.class/instance/debug and other/buildDebugMenu_.st M Morphic-Core.package/Morph.class/instance/layout-menu/addLayoutMenuItems_hand_.st M Morphic-Core.package/Morph.class/instance/layout-menu/addTableLayoutMenuItems_hand_.st M Morphic-Core.package/Morph.class/instance/menu/addYellowButtonMenuItemsTo_event_.st M Morphic-Core.package/Morph.class/instance/menus/addExportMenuItems_hand_.st M Morphic-Core.package/Morph.class/instance/menus/addFillStyleMenuItems_hand_.st M Morphic-Core.package/Morph.class/instance/menus/addHaloActionsTo_.st M Morphic-Core.package/Morph.class/instance/menus/addMiscExtrasTo_.st M Morphic-Core.package/Morph.class/instance/menus/addStandardHaloMenuItemsTo_hand_.st M Morphic-Core.package/Morph.class/instance/meta-actions/buildMetaMenu_.st M Morphic-Widgets-Basic.package/PluggableButtonMorph.class/instance/event handling/addStandardHaloMenuItemsTo_hand_.st M Morphic-Widgets-Basic.package/SimpleButtonMorph.class/instance/menu/addCustomMenuItems_hand_.st M Morphic-Widgets-Basic.package/SimpleButtonMorph.class/instance/menu/addLabelItemsTo_hand_.st M Morphic-Widgets-Basic.package/SimpleButtonMorph.class/instance/menu/addTargetingMenuItems_hand_.st M Morphic-Widgets-Windows.package/CollapsedMorph.class/instance/menu/buildWindowMenu.st M Morphic-Widgets-Windows.package/SystemWindow.class/instance/menu actions/addCustomMenuItems_hand_.st M Nautilus.package/AbstractNautilusUI.class/instance/icons behavior/runClassInitializeMethod_.st M Network-Mail.package/MailComposition.class/instance/interface/menuGet_shifted_.st M Polymorph-Tools-Diff.package/extension/MCPatchBrowser/instance/methodListMenu_.st A Polymorph-Widgets.package/PopupChoiceDialogWindow.class/class/instance creation/chooseFrom_lines_title_.st A Polymorph-Widgets.package/PopupChoiceDialogWindow.class/class/instance creation/chooseIn_title_labels_values_lines_.st M Polymorph-Widgets.package/UITheme.class/instance/services/chooseIn_title_labels_values_lines_.st M ProfStef-Core.package/LessonView.class/instance/gui/menu.st M Rubric.package/RubFindReplaceDialogWindow.class/instance/user-interface/buildWindowMenu.st M SUnit-UI.package/TestRunner.class/instance/accessing-categories/categoryMenu_.st M SUnit-UI.package/TestRunner.class/instance/accessing-classes/classMenu_.st M SUnit-UI.package/TestRunner.class/instance/accessing-menu/errorMenu_.st M SUnit-UI.package/TestRunner.class/instance/accessing-menu/failureMenu_.st M SUnit-UI.package/TestRunner.class/instance/accessing-menu/statusMenu_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script333.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40333.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Tools.package/MonticelloRepositoryBrowser.class/instance/menu/workingCopiesMenu_.st M System-FilePackage.package/PseudoClass.class/instance/private/confirmRemovalOf_.st M Text-Edition.package/EditorFindReplaceDialogWindow.class/instance/user-interface/buildWindowMenu.st M Tool-Browser-Old.package/Browser.class/instance/class functions/classListMenu_shifted_.st M Tool-ConfigurationBrowser.package/MetacelloConfigurationBrowserPane.class/instance/menu/configurationListMenu_.st M Tool-FileList.package/FileList.class/instance/volume menu/volumeMenu_.st M Tool-SystemReporter.package/SystemReporter.class/instance/accessing-categories/categoryMenu_.st M Tool-SystemReporter.package/SystemReporter.class/instance/accessing-report/reportMenu_.st M Tool-Workspace.package/Workspace.class/instance/window menu/warnUser.st M Tools.package/SyntaxErrorDebugger.class/instance/menu/listMenu_.st Log Message: ----------- 40333 14331 cleaning more menu https://pharo.fogbugz.com/f/cases/14331 http://files.pharo.org/image/40/40333.zip

Oct. 27, 2014

Re: [Pharo-dev] Can anyone provide me with clear, complete, and detailed instructions for loading PetitParser into Pharo 3.0?

by Richard Sargent

Sean P. DeNigris wrote > If you don't need the UI, just load the 'Core' group and you should be > fine. Thanks for replying, Sean. Unfortunately, I don't know how to process your answer. What actions do I need to do in what window or what expressions do I need to evaluate to achieve this? And likewise, if I do want to load the UI, what do I need to do? Thanks, Richard -- View this message in context: http://forum.world.st/Can-anyone-provide-me-with-clear-complete-and-detaile… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Oct. 27, 2014

Re: [Pharo-dev] Should literals be immutable ?

by Eliot Miranda

On Mon, Oct 27, 2014 at 9:19 AM, Levente Uzonyi <leves(a)elte.hu> wrote: > On Mon, 27 Oct 2014, ClÃ©ment Bera wrote: > > Hey guys, >> I was discussing about methods like that with Marcus: >> >> MyClass>>foo >> #(false) first >> ifFalse: [ >> 'first call since compilation' logCr. >> #(false) at: 1 put: true ] >> ifTrue: [ 'other calls' logCr ] >> >> DoIt: >> 4 timesRepeat: [MyClass new foo ] >> >> Transcript: >> 'first call since compilation' >> 'other calls' >> 'other calls' >> 'other calls' >> >> In the sista image/VM, we are most probably going with Eliot to implement >> a slow path when you edit the literal of a method (deoptimizing the method) >> so we can consider that the literals are immutable in the >> generic case (and if it's not true, execution falls back to a slow path). >> >> But I was thinking, does it worth it to implement the slow path ? >> Couldn't we just put literals as immutable all the time ? >> The methods as the one shown before would not work any more. But does >> someone use it ? >> > > This method was used in Seaside (or some Seaside extension) to cache the > contents of files in methods. > > By the way, how would you ensure immutability? > See my message earlier in the thread. Via a per-object isImmutable bit. > I mean, how would you prevent something like this? > > MyClass >> foo > > ^#('placeHolder') > > And then > > (((MyClass >> #foo) literalAt: 1) at: 1) becomeForward: Object new > > > Levente > > P.S.: why isn't this on the vm-dev list? > > >> ... >> >> >> -- best, Eliot

Oct. 27, 2014

Re: [Pharo-dev] Should literals be immutable ?

by Marcus Denker

> On 27 Oct 2014, at 17:16, Thierry Goubier <thierry.goubier(a)gmail.com> wrote: > > > > 2014-10-27 17:03 GMT+01:00 Marcus Denker <marcus.denker(a)gmail.com <mailto:marcus.denker@gmail.com>>: > > > > > I could imagine cases where, in very tight memory situations or with very very large literals, we could make use of modifying literals. But I'm not sure this is a significant requirement, or that it couldn't be considered if there is a significant (and rich) use case to fund the development of the slow path. > > Pharos does not target classic âresource constraintâ embedded scenarios. > (else we would do many things a lot different) > Is there a critic rule catching that sort of thing? That we could run on Squeaksource / Smalltalkhub? > No, as you can hand a reference to a literal over to someone else who does not even know that it is a literalâ¦ this dreaded âam I going insane, itâs writing right hereâ bug where you change a string somewhere that actually is a string literal of some methodâ¦ > > You mean, as in: > > MyClass>>foo > #(false) first > ifFalse: [ > 'first call since compilation' logCr ] > ifTrue: [ 'other calls' logCr ]. > ^ #(false) > > in a workspace > > 4 timesRepeat: [MyClass new foo at: 1 put: true ] > Or even easierâ¦ someMethod ^âoohhhâ MyClass new someMethod at: 1 put: $N. the execute MyClass new someMethod and wonder where that string comes from. Marcus

Oct. 27, 2014

Re: [Pharo-dev] Should literals be immutable ?

by Levente Uzonyi

On Mon, 27 Oct 2014, ClÃ©ment Bera wrote: > Hey guys, > I was discussing about methods like that with Marcus: > > MyClass>>foo > #(false) firstÂ > ifFalse: [Â > 'first call since compilation' logCr.Â > #(false) at: 1 put: true ] > ifTrue: [ 'other calls' logCr ] > > DoIt: > 4 timesRepeat: [MyClass new foo ] > > Transcript: > 'first call since compilation' > 'other calls' > 'other calls' > 'other calls' > > In the sista image/VM, we are most probably going with Eliot to implement a slow path when you edit the literal of a method (deoptimizing the method) so we can consider that the literals are immutable in the > generic case (and if it's not true, execution falls back to a slow path). > > But I was thinking, does it worth it to implement the slow path ?Â > Couldn't we just put literals as immutable all the time ?Â > The methods as the one shown before would not work any more. But does someone use it ? This method was used in Seaside (or some Seaside extension) to cache the contents of files in methods. By the way, how would you ensure immutability? I mean, how would you prevent something like this? MyClass >> foo ^#('placeHolder') And then (((MyClass >> #foo) literalAt: 1) at: 1) becomeForward: Object new Levente P.S.: why isn't this on the vm-dev list? > > ... > > >

Oct. 27, 2014

Re: [Pharo-dev] Should literals be immutable ?

by Thierry Goubier

2014-10-27 17:03 GMT+01:00 Marcus Denker <marcus.denker(a)gmail.com>: > > > > > I could imagine cases where, in very tight memory situations or with very >> very large literals, we could make use of modifying literals. But I'm not >> sure this is a significant requirement, or that it couldn't be considered >> if there is a significant (and rich) use case to fund the development of >> the slow path. >> >> Pharos does not target classic "resource constraint" embedded scenarios. > (else we would do many things a lot different) > >> Is there a critic rule catching that sort of thing? That we could run on >> Squeaksource / Smalltalkhub? >> > No, as you can hand a reference to a literal over to someone else who does > not even know that it is a literal... this dreaded "am I going insane, it's > writing right here" bug where you change a string somewhere that actually > is a string literal of some method... > You mean, as in: MyClass>>foo #(false) first ifFalse: [ 'first call since compilation' logCr ] ifTrue: [ 'other calls' logCr ]. ^ #(false) in a workspace 4 timesRepeat: [MyClass new foo at: 1 put: true ] Thierry > > Marcus >

Oct. 27, 2014

Re: [Pharo-dev] Should literals be immutable ?

by Eliot Miranda

On Oct 27, 2014, at 8:48 AM, Craig Latta <craig(a)netjam.org> wrote: > > Hoi ClÃ©ment-- > > In keeping with the principle of least surprise (and least time > spent chasing strange bugs at 4am :), I would prefer that literals be > immutable. Sleep no sleep no sleep no sleep and no mad Video machine to eat time, a city scene I can't explain, strange bugs alone at 4am The insane alone at 4a.m, ... > > > thanks, > > -C > > -- > Craig Latta > netjam.org > +31 6 2757 7177 (SMS ok) > + 1 415 287 3547 (no SMS) > >

Oct. 27, 2014

Re: [Pharo-dev] Should literals be immutable ?

by Eliot Miranda

Hi ClÃ©ment, IMO literals should be immutable all the time, and IMO the best way is via a per-object isImmutable bit. We implemented this for VW in 7.0 and it was a positive experience. I've implemented the "create an immutable subclass for each literal class" and it has lots of problems (thing printString or storeString having to produce something like 'an immutable string' asMutableString for a normal string). The per-object bit has other uses too. Object databases such as GemStone can use it to make write-through scheme efficient. The only problem we had was dealing with broken user code that was depending on mutable literals. This is of course a bug, but folks thought we shouldn't just break user code so Alan Knight provided a system setting that write a warning to the transcript and updated the literal instead if raising an error. That's easy to do, if IMO dubious. Fixing the code is as easy as sending copy to the literal in question, the copy being mutable. Now I implemented the per-object bit for the Newspeak interpreter WM so you'll find lots of the necessary work is there waiting to be ported to the Stack and Cog VMs. I've not had the time to implement the JIT support to catch inst var and at:put: writes to immutables. But it shouldn't be too much work. Volunteers? Eliot (phone) On Oct 27, 2014, at 8:22 AM, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > Hey guys, > > I was discussing about methods like that with Marcus: > > MyClass>>foo > #(false) first > ifFalse: [ > 'first call since compilation' logCr. > #(false) at: 1 put: true ] > ifTrue: [ 'other calls' logCr ] > > DoIt: > 4 timesRepeat: [MyClass new foo ] > > Transcript: > 'first call since compilation' > 'other calls' > 'other calls' > 'other calls' > > In the sista image/VM, we are most probably going with Eliot to implement a slow path when you edit the literal of a method (deoptimizing the method) so we can consider that the literals are immutable in the generic case (and if it's not true, execution falls back to a slow path). > > But I was thinking, does it worth it to implement the slow path ? > Couldn't we just put literals as immutable all the time ? > The methods as the one shown before would not work any more. But does someone use it ? > > ... >

Oct. 27, 2014