January 2014 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [Pharo3] Reviewers of fixes needed

by phil＠highoctane.be

Ok boss, on my way. On Fri, Jan 31, 2014 at 10:30 AM, Marcus Denker <marcus.denker(a)inria.fr>wrote: > > On 31 Jan 2014, at 10:26, phil(a)highoctane.be wrote: > > https://pharo.fogbugz.com/default.asp?11674 looks ok for me and I hit the > "resolve" button yesterday. > > Do you need anything else from my side? > > > the resolve button just move the state to one of the resolved states. If > the issue was already in a resolved > state, the only thing it does is to add a tiny meta-data change note from > the same state to the same state, > which nobody will ever recognise as having any meaning. > > THUS: put a note "I checked it and I think it should be integrated" > > Marcus > >

Jan. 31, 2014

Re: [Pharo-dev] Call for action: Help to improve the class comment quality of Pharo 3.0

by Marcus Denker

> > > > Maybe we should add a test to ReleaseTest class that forces us to do it and that stays red until > the situation improved. I advice against this. We tried it in the past and it does not work. Having a green build that goes non-green means action, having a constant yellow build means people do not care at all: after two weeks you will have 20 tests failing. âThe build is not green, and I know whyâ. Marcus

Jan. 31, 2014

Re: [Pharo-dev] [Pharo3] Reviewers of fixes needed

by Marcus Denker

On 31 Jan 2014, at 10:26, phil(a)highoctane.be wrote: > https://pharo.fogbugz.com/default.asp?11674 looks ok for me and I hit the "resolve" button yesterday. > > Do you need anything else from my side? > the resolve button just move the state to one of the resolved states. If the issue was already in a resolved state, the only thing it does is to add a tiny meta-data change note from the same state to the same state, which nobody will ever recognise as having any meaning. THUS: put a note âI checked it and I think it should be integratedâ Marcus

Jan. 31, 2014

Re: [Pharo-dev] [Pharo3] Reviewers of fixes needed

by phil＠highoctane.be

https://pharo.fogbugz.com/default.asp?11674 looks ok for me and I hit the "resolve" button yesterday. Do you need anything else from my side? Phil On Fri, Jan 31, 2014 at 9:06 AM, Marcus Denker <marcus.denker(a)inria.fr>wrote: > Hi, > > As I have integrated some wrong things recently, I would like to only > integrate fixes where at least two other people (then me or the author) > checked that this is a) correct b) not introducing more bugs and c) really > for Pharo3 > (and not Pharo4). > > https://pharo.fogbugz.com/f/filters/45/Review > > Marcus >

Jan. 31, 2014

Call for action: Help to improve the class comment quality of Pharo 3.0

by Torsten Bergmann

There are many undocumented classes left in the system Object allSubclasses select: [:each | each comment includesSubstring: 'xxxxx' ] Exactly 2731 by now in Pharo3.0 Latest update: #30731. Around 400 classes are test classes with a pair class that they test as a test unit and I think these can easily include a comment like "This is a test class for ...". The other ones are left for humans. With the new release we have the chance: - to improve also on this side which would especially help newcomers after grabbing the new release and browsing around - to add class comments before the release date 31.3.2014 since they are safe to integrate SO PLEASE: add class comments for traits, athens-text, compiler, compression, debugger, filesystem, ... Even a short comment makes more sense than no comment! Maybe we should add a test to ReleaseTest class that forces us to do it and that stays red until the situation improved. Maybe also a check to have no uncategorized methods left. Thx T.

Jan. 31, 2014

Re: [Pharo-dev] subscript out of bounds in protocol creation

by Nicolai Hess

2014-01-31 Jordi Delgado <jdelgado(a)lsi.upc.edu>: > Hi, > > I realized that sometimes, when creating new protocols, it appears an > error "subscript out of bounds: 1". I have not been able -yet- > to reproduce it from a clean image, but it happens often (at least > to me). It seems to me that it has something to do with protocol > creation before any method has been written, but I am still investigating. > > I used the latest image downloaded yesterday, and it still happens. > > I browsed fogbuz looking for this error before reporting it, but I could > not > find it. I did not search thorougly, though. > > Just to let you know... > > Bests, and thanks a lot for the work you are doing. It's amazing. > > Jordi > > Hi, yes there are two (or three?) reports for that kind of issue. And maybe there are more than one bug responsible for this issue. At least two bugs, I have found, are described in this report 12469 <https://pharo.fogbugz.com/default.asp?12469> Sometimes an empty protocol is created I didn't provide a solution for this, as I had problems createing a slice, that only incude those changes. Nicolai

Jan. 31, 2014

Re: [Pharo-dev] subscript out of bounds in protocol creation

by ClÃ©ment Bera

I had the same problem. I had to reload my project from a fresh image to solve it. Very hard to reproduce. In addition, after editing a few method you cannot anymore edit the class comment (you need to open another Nautilus to do it). 2014/1/31 Jordi Delgado <jdelgado(a)lsi.upc.edu> > Hi, > > I realized that sometimes, when creating new protocols, it appears an > error "subscript out of bounds: 1". I have not been able -yet- > to reproduce it from a clean image, but it happens often (at least > to me). It seems to me that it has something to do with protocol > creation before any method has been written, but I am still investigating. > > I used the latest image downloaded yesterday, and it still happens. > > I browsed fogbuz looking for this error before reporting it, but I could > not > find it. I did not search thorougly, though. > > Just to let you know... > > Bests, and thanks a lot for the work you are doing. It's amazing. > > Jordi > >

Jan. 31, 2014

[Pharo3] Reviewers of fixes needed

by Marcus Denker

Hi, As I have integrated some wrong things recently, I would like to only integrate fixes where at least two other people (then me or the author) checked that this is a) correct b) not introducing more bugs and c) really for Pharo3 (and not Pharo4). https://pharo.fogbugz.com/f/filters/45/Review Marcus

Jan. 31, 2014

Re: [Pharo-dev] poolDictionaries removal breaks my projects

by Torsten Bergmann

Please make it a setting - so one can see the creation message with poolDictionaries in Nautilus as before in the browser and is able to fill out the template. When using NB one requires them. Thx T.

Jan. 31, 2014

subscript out of bounds in protocol creation

by Jordi Delgado

Hi, I realized that sometimes, when creating new protocols, it appears an error "subscript out of bounds: 1". I have not been able -yet- to reproduce it from a clean image, but it happens often (at least to me). It seems to me that it has something to do with protocol creation before any method has been written, but I am still investigating. I used the latest image downloaded yesterday, and it still happens. I browsed fogbuz looking for this error before reporting it, but I could not find it. I did not search thorougly, though. Just to let you know... Bests, and thanks a lot for the work you are doing. It's amazing. Jordi

Jan. 31, 2014