August 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [Pharo-fuel] Fuel API bug

by Esteban A. Maringolo

2013/8/5 Francisco Garau <francisco.garau(a)gmail.com>: > I'd prefer #when:do: rather than #onAnnouncement:do: +1 Me too. -- Esteban.

Aug. 5, 2013

Re: [Pharo-dev] [Pharo-fuel] Fuel API bug

by Francisco Garau

I'd prefer #when:do: rather than #onAnnouncement:do: - Francisco On 5 Aug 2013, at 18:01, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > On Aug 5, 2013, at 4:18 PM, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > >> false polymorphism with exception handling? > > indeed. > > When I read code and I see on:do: there is a big sign that shows up in my mind: exception. > > In addition when I look inside the senders I get false sense of use. > > This is the case for example with on:do: for announcement which I really do not like. > I think that we will rename on:do: into onAnnouncement:do: > because I did not see one case where suddenly I would like to mix exception with announcement. > > Stef > > > > >> 2013/8/5 Mariano Martinez Peck <marianopeck(a)gmail.com> >> Indeed, I thought the same. >> Stef, could you tell us why implementing on:do: is wrong? >> >> >> On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias(a)gmail.com> wrote: >> Hi >> >> Thanks Stef for fighting with the leak and thanks Max for the fast response. >> >> >> I think was me who added the method #on:do:, and my reasoning was: >> >> - FileStream has #fileNamed: and #fileNamed:do: >> - PositionableStream has #on: >> - I needed the analog to FileStream>>fileNamed:do: in PositionableStream >> >> So, I created #on:do:. It looked consistent. >> >> MartÃn >> >> >> On Sun, Aug 4, 2013 at 5:02 PM, StÃ©phane Ducasse >> <stephane.ducasse(a)inria.fr> wrote: >> > impressive :) >> > Tx guys. >> > We are fighting with memory leaks like mad :) >> > >> > Stef >> > >> > On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske(a)gmail.com> wrote: >> > >> >> Done. >> >> >> >> Name: ConfigurationOfFuel-MaxLeske.207 >> >> Author: MaxLeske >> >> Time: 4 August 2013, 4:49:17.037 pm >> >> UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 >> >> Ancestors: ConfigurationOfFuel-MartinDias.206 >> >> >> >> * created new version 1.9.2 for development >> >> * pointed development to 1.9.2 >> >> * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix) >> >> >> >> >> >> On 04.08.2013, at 16:35, Max Leske <maxleske(a)gmail.com> wrote: >> >> >> >>> Yeah, no problem. I'll get on it right away. >> >>> >> >>> Max >> >>> >> >>> On 04.08.2013, at 16:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: >> >>> >> >>>> Hi guys >> >>>> >> >>>> can you rename this method? >> >>>> >> >>>> on: aCollectionOrStream do: aBlock >> >>>> "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." >> >>>> | aStream | >> >>>> aStream := self on: aCollectionOrStream. >> >>>> [ ^ aBlock value: aStream ] ensure: [ aStream close ] >> >>>> >> >>>> >> >>>> Please do not use on:do: for something that is not about exception (and announcements). >> >>>> >> >>>> It is too confusing and refactor after. >> >>>> >> >>>> Stef >> >>> >> >> >> >> >> >> _______________________________________________ >> >> Pharo-fuel mailing list >> >> Pharo-fuel(a)lists.gforge.inria.fr >> >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >> > >> > >> > _______________________________________________ >> > Pharo-fuel mailing list >> > Pharo-fuel(a)lists.gforge.inria.fr >> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >> >> _______________________________________________ >> Pharo-fuel mailing list >> Pharo-fuel(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com >> >

Aug. 5, 2013

Re: [Pharo-dev] [Pharo-fuel] Fuel API bug

by StÃ©phane Ducasse

On Aug 5, 2013, at 4:18 PM, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > false polymorphism with exception handling? indeed. When I read code and I see on:do: there is a big sign that shows up in my mind: exception. In addition when I look inside the senders I get false sense of use. This is the case for example with on:do: for announcement which I really do not like. I think that we will rename on:do: into onAnnouncement:do: because I did not see one case where suddenly I would like to mix exception with announcement. Stef > 2013/8/5 Mariano Martinez Peck <marianopeck(a)gmail.com> > Indeed, I thought the same. > Stef, could you tell us why implementing on:do: is wrong? > > > On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias(a)gmail.com> wrote: > Hi > > Thanks Stef for fighting with the leak and thanks Max for the fast response. > > > I think was me who added the method #on:do:, and my reasoning was: > > - FileStream has #fileNamed: and #fileNamed:do: > - PositionableStream has #on: > - I needed the analog to FileStream>>fileNamed:do: in PositionableStream > > So, I created #on:do:. It looked consistent. > > MartÃn > > > On Sun, Aug 4, 2013 at 5:02 PM, StÃ©phane Ducasse > <stephane.ducasse(a)inria.fr> wrote: > > impressive :) > > Tx guys. > > We are fighting with memory leaks like mad :) > > > > Stef > > > > On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske(a)gmail.com> wrote: > > > >> Done. > >> > >> Name: ConfigurationOfFuel-MaxLeske.207 > >> Author: MaxLeske > >> Time: 4 August 2013, 4:49:17.037 pm > >> UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 > >> Ancestors: ConfigurationOfFuel-MartinDias.206 > >> > >> * created new version 1.9.2 for development > >> * pointed development to 1.9.2 > >> * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix) > >> > >> > >> On 04.08.2013, at 16:35, Max Leske <maxleske(a)gmail.com> wrote: > >> > >>> Yeah, no problem. I'll get on it right away. > >>> > >>> Max > >>> > >>> On 04.08.2013, at 16:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >>> > >>>> Hi guys > >>>> > >>>> can you rename this method? > >>>> > >>>> on: aCollectionOrStream do: aBlock > >>>> "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." > >>>> | aStream | > >>>> aStream := self on: aCollectionOrStream. > >>>> [ ^ aBlock value: aStream ] ensure: [ aStream close ] > >>>> > >>>> > >>>> Please do not use on:do: for something that is not about exception (and announcements). > >>>> > >>>> It is too confusing and refactor after. > >>>> > >>>> Stef > >>> > >> > >> > >> _______________________________________________ > >> Pharo-fuel mailing list > >> Pharo-fuel(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel > > > > > > _______________________________________________ > > Pharo-fuel mailing list > > Pharo-fuel(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel > > _______________________________________________ > Pharo-fuel mailing list > Pharo-fuel(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel > > > > -- > Mariano > http://marianopeck.wordpress.com >

Aug. 5, 2013

Re: [Pharo-dev] [Pharo-fuel] Fuel API bug

by Igor Stasenko

On 5 August 2013 16:18, Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com> wrote: > false polymorphism with exception handling? > innndeeeed :) > > 2013/8/5 Mariano Martinez Peck <marianopeck(a)gmail.com> >> >> Indeed, I thought the same. >> Stef, could you tell us why implementing on:do: is wrong? >> >> >> On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias(a)gmail.com> wrote: >>> >>> Hi >>> >>> Thanks Stef for fighting with the leak and thanks Max for the fast >>> response. >>> >>> >>> I think was me who added the method #on:do:, and my reasoning was: >>> >>> - FileStream has #fileNamed: and #fileNamed:do: >>> - PositionableStream has #on: >>> - I needed the analog to FileStream>>fileNamed:do: in PositionableStream >>> >>> So, I created #on:do:. It looked consistent. >>> >>> MartÃn >>> >>> >>> On Sun, Aug 4, 2013 at 5:02 PM, StÃ©phane Ducasse >>> <stephane.ducasse(a)inria.fr> wrote: >>> > impressive :) >>> > Tx guys. >>> > We are fighting with memory leaks like mad :) >>> > >>> > Stef >>> > >>> > On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske(a)gmail.com> wrote: >>> > >>> >> Done. >>> >> >>> >> Name: ConfigurationOfFuel-MaxLeske.207 >>> >> Author: MaxLeske >>> >> Time: 4 August 2013, 4:49:17.037 pm >>> >> UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 >>> >> Ancestors: ConfigurationOfFuel-MartinDias.206 >>> >> >>> >> * created new version 1.9.2 for development >>> >> * pointed development to 1.9.2 >>> >> * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime >>> >> fix) >>> >> >>> >> >>> >> On 04.08.2013, at 16:35, Max Leske <maxleske(a)gmail.com> wrote: >>> >> >>> >>> Yeah, no problem. I'll get on it right away. >>> >>> >>> >>> Max >>> >>> >>> >>> On 04.08.2013, at 16:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> >>> >>> wrote: >>> >>> >>> >>>> Hi guys >>> >>>> >>> >>>> can you rename this method? >>> >>>> >>> >>>> on: aCollectionOrStream do: aBlock >>> >>>> "Evaluates a block with a new stream based on the collection or >>> >>>> stream. Answers the result of the block evaluation. Follows the style of >>> >>>> FileStream>>fileNamed:do:." >>> >>>> | aStream | >>> >>>> aStream := self on: aCollectionOrStream. >>> >>>> [ ^ aBlock value: aStream ] ensure: [ aStream close ] >>> >>>> >>> >>>> >>> >>>> Please do not use on:do: for something that is not about exception >>> >>>> (and announcements). >>> >>>> >>> >>>> It is too confusing and refactor after. >>> >>>> >>> >>>> Stef >>> >>> >>> >> >>> >> >>> >> _______________________________________________ >>> >> Pharo-fuel mailing list >>> >> Pharo-fuel(a)lists.gforge.inria.fr >>> >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >>> > >>> > >>> > _______________________________________________ >>> > Pharo-fuel mailing list >>> > Pharo-fuel(a)lists.gforge.inria.fr >>> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >>> >>> _______________________________________________ >>> Pharo-fuel mailing list >>> Pharo-fuel(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >> >> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com > > -- Best regards, Igor Stasenko.

Aug. 5, 2013

Re: [Pharo-dev] [Pharo-fuel] Fuel API bug

by Nicolas Cellier

false polymorphism with exception handling? 2013/8/5 Mariano Martinez Peck <marianopeck(a)gmail.com> > Indeed, I thought the same. > Stef, could you tell us why implementing on:do: is wrong? > > > On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias(a)gmail.com> wrote: > >> Hi >> >> Thanks Stef for fighting with the leak and thanks Max for the fast >> response. >> >> >> I think was me who added the method #on:do:, and my reasoning was: >> >> - FileStream has #fileNamed: and #fileNamed:do: >> - PositionableStream has #on: >> - I needed the analog to FileStream>>fileNamed:do: in PositionableStream >> >> So, I created #on:do:. It looked consistent. >> >> MartÃn >> >> >> On Sun, Aug 4, 2013 at 5:02 PM, StÃ©phane Ducasse >> <stephane.ducasse(a)inria.fr> wrote: >> > impressive :) >> > Tx guys. >> > We are fighting with memory leaks like mad :) >> > >> > Stef >> > >> > On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske(a)gmail.com> wrote: >> > >> >> Done. >> >> >> >> Name: ConfigurationOfFuel-MaxLeske.207 >> >> Author: MaxLeske >> >> Time: 4 August 2013, 4:49:17.037 pm >> >> UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 >> >> Ancestors: ConfigurationOfFuel-MartinDias.206 >> >> >> >> * created new version 1.9.2 for development >> >> * pointed development to 1.9.2 >> >> * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime >> fix) >> >> >> >> >> >> On 04.08.2013, at 16:35, Max Leske <maxleske(a)gmail.com> wrote: >> >> >> >>> Yeah, no problem. I'll get on it right away. >> >>> >> >>> Max >> >>> >> >>> On 04.08.2013, at 16:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> >> wrote: >> >>> >> >>>> Hi guys >> >>>> >> >>>> can you rename this method? >> >>>> >> >>>> on: aCollectionOrStream do: aBlock >> >>>> "Evaluates a block with a new stream based on the collection or >> stream. Answers the result of the block evaluation. Follows the style of >> FileStream>>fileNamed:do:." >> >>>> | aStream | >> >>>> aStream := self on: aCollectionOrStream. >> >>>> [ ^ aBlock value: aStream ] ensure: [ aStream close ] >> >>>> >> >>>> >> >>>> Please do not use on:do: for something that is not about exception >> (and announcements). >> >>>> >> >>>> It is too confusing and refactor after. >> >>>> >> >>>> Stef >> >>> >> >> >> >> >> >> _______________________________________________ >> >> Pharo-fuel mailing list >> >> Pharo-fuel(a)lists.gforge.inria.fr >> >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >> > >> > >> > _______________________________________________ >> > Pharo-fuel mailing list >> > Pharo-fuel(a)lists.gforge.inria.fr >> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >> >> _______________________________________________ >> Pharo-fuel mailing list >> Pharo-fuel(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel >> > > > > -- > Mariano > http://marianopeck.wordpress.com >

Aug. 5, 2013

Re: [Pharo-dev] [Pharo-fuel] Fuel API bug

by Mariano Martinez Peck

Indeed, I thought the same. Stef, could you tell us why implementing on:do: is wrong? On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias(a)gmail.com> wrote: > Hi > > Thanks Stef for fighting with the leak and thanks Max for the fast > response. > > > I think was me who added the method #on:do:, and my reasoning was: > > - FileStream has #fileNamed: and #fileNamed:do: > - PositionableStream has #on: > - I needed the analog to FileStream>>fileNamed:do: in PositionableStream > > So, I created #on:do:. It looked consistent. > > MartÃn > > > On Sun, Aug 4, 2013 at 5:02 PM, StÃ©phane Ducasse > <stephane.ducasse(a)inria.fr> wrote: > > impressive :) > > Tx guys. > > We are fighting with memory leaks like mad :) > > > > Stef > > > > On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske(a)gmail.com> wrote: > > > >> Done. > >> > >> Name: ConfigurationOfFuel-MaxLeske.207 > >> Author: MaxLeske > >> Time: 4 August 2013, 4:49:17.037 pm > >> UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 > >> Ancestors: ConfigurationOfFuel-MartinDias.206 > >> > >> * created new version 1.9.2 for development > >> * pointed development to 1.9.2 > >> * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime > fix) > >> > >> > >> On 04.08.2013, at 16:35, Max Leske <maxleske(a)gmail.com> wrote: > >> > >>> Yeah, no problem. I'll get on it right away. > >>> > >>> Max > >>> > >>> On 04.08.2013, at 16:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > wrote: > >>> > >>>> Hi guys > >>>> > >>>> can you rename this method? > >>>> > >>>> on: aCollectionOrStream do: aBlock > >>>> "Evaluates a block with a new stream based on the collection or > stream. Answers the result of the block evaluation. Follows the style of > FileStream>>fileNamed:do:." > >>>> | aStream | > >>>> aStream := self on: aCollectionOrStream. > >>>> [ ^ aBlock value: aStream ] ensure: [ aStream close ] > >>>> > >>>> > >>>> Please do not use on:do: for something that is not about exception > (and announcements). > >>>> > >>>> It is too confusing and refactor after. > >>>> > >>>> Stef > >>> > >> > >> > >> _______________________________________________ > >> Pharo-fuel mailing list > >> Pharo-fuel(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel > > > > > > _______________________________________________ > > Pharo-fuel mailing list > > Pharo-fuel(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel > > _______________________________________________ > Pharo-fuel mailing list > Pharo-fuel(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel > -- Mariano http://marianopeck.wordpress.com

Aug. 5, 2013

Re: [Pharo-dev] [Pharo-fuel] Fuel API bug

by Martin Dias

Hi Thanks Stef for fighting with the leak and thanks Max for the fast response. I think was me who added the method #on:do:, and my reasoning was: - FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream So, I created #on:do:. It looked consistent. MartÃn On Sun, Aug 4, 2013 at 5:02 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > impressive :) > Tx guys. > We are fighting with memory leaks like mad :) > > Stef > > On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske(a)gmail.com> wrote: > >> Done. >> >> Name: ConfigurationOfFuel-MaxLeske.207 >> Author: MaxLeske >> Time: 4 August 2013, 4:49:17.037 pm >> UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 >> Ancestors: ConfigurationOfFuel-MartinDias.206 >> >> * created new version 1.9.2 for development >> * pointed development to 1.9.2 >> * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix) >> >> >> On 04.08.2013, at 16:35, Max Leske <maxleske(a)gmail.com> wrote: >> >>> Yeah, no problem. I'll get on it right away. >>> >>> Max >>> >>> On 04.08.2013, at 16:10, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: >>> >>>> Hi guys >>>> >>>> can you rename this method? >>>> >>>> on: aCollectionOrStream do: aBlock >>>> "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." >>>> | aStream | >>>> aStream := self on: aCollectionOrStream. >>>> [ ^ aBlock value: aStream ] ensure: [ aStream close ] >>>> >>>> >>>> Please do not use on:do: for something that is not about exception (and announcements). >>>> >>>> It is too confusing and refactor after. >>>> >>>> Stef >>> >> >> >> _______________________________________________ >> Pharo-fuel mailing list >> Pharo-fuel(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel > > > _______________________________________________ > Pharo-fuel mailing list > Pharo-fuel(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel

Aug. 5, 2013

Re: [Pharo-dev] Did canUnderstand: changed?

by Sebastian Tleye

It's a bug i introduced in one of my changes, i am fixing it. 2013/8/4 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > Hi > > why canUnderstand: now handles shouldNotImplement? > > Stef > >

Aug. 5, 2013

Re: [Pharo-dev] about on:do: -> onKey:do:

by Igor Stasenko

On 5 August 2013 10:32, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > Ok, I commited a slice with a different selector name we discussed with Ben > a while ago. #bindKeyCombination:toAction: > > On Mon, Aug 5, 2013 at 9:42 AM, Igor Stasenko <siguctua(a)gmail.com> wrote: >> >> On 4 August 2013 15:50, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: >> > I would use #onKeyCombination:do: to keep coherency with the framework. >> > >> >> why not naming it >> onKeyCombinationInKeyBindingsFramework:do: >> :) > > > Really? > >> >> >> >> >> OnKey: is good because it short. > > > Short is not always better, come on igor! > >> >> And not ambiguous (you can use single >> key(s) > > > yes but also... > >> as well as key combinations, > > > And then why Key is ok? The role the object is playing there is the one of a > key combination. If a key can be used as a key combination it is only > circumstantial. > >> >> but that details). > > > You know better than a lot of people that details matter :). And now you can > solve the detail instantaneously by just making the selector more intention > revealing. I do not see the problem. > Well, it is always a tradeoff between being explicit and too elaborate. Now, of course, you, as designer of key bindings know better, so i won't argue about that. Just thought that onKey:do: is explicit enough to indicate the intent (and in any case, much better than on:do: ). -- Best regards, Igor Stasenko.

Aug. 5, 2013

[update 3.0] #30322

by Esteban Lorenzano

Aug. 5, 2013