August 2013 - Pharo-dev - lists.pharo.org

why can we interrupt the UI thread?

by StÃ©phane Ducasse

Aug. 15, 2013

Re: [Pharo-dev] XML writer in the default image

by Esteban Lorenzano

+1 On Aug 15, 2013, at 9:41 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > On Aug 15, 2013, at 2:15 AM, Camillo Bruni <camillobruni(a)gmail.com> wrote: > >> As reported a while ago (https://pharo.fogbugz.com/default.asp?7412#80347) the TestRunner >> is crashing when test failures accidentally spit out XML sensitive characters: >> >> https://ci.inria.fr/pharo/view/all/job/Pharo-3.0-Regression-Tests/304/VM=vm… >> >> I don't really see a reason to generate XML by concatenating strings, so I wonder >> whether we could include the XMLWriter in the default image? > > Why don't we load HDTestRunner when needed? And HDTestRunner could then use XMLWriter > >> This way I could finally fix the HDTestRunner with very little effort. > > I will finish to pop up my list and start to work on managing the image with Metacello > because we should build it based on subproject > RB > Nautilus > Athens > NativeBoost > AsmJit > Zinc > OPAL > were/are managed with metacello so we could be there :) > > Stef > >

Aug. 15, 2013

Re: [Pharo-dev] XML writer in the default image

by StÃ©phane Ducasse

On Aug 15, 2013, at 2:15 AM, Camillo Bruni <camillobruni(a)gmail.com> wrote: > As reported a while ago (https://pharo.fogbugz.com/default.asp?7412#80347) the TestRunner > is crashing when test failures accidentally spit out XML sensitive characters: > > https://ci.inria.fr/pharo/view/all/job/Pharo-3.0-Regression-Tests/304/VM=vm… > > I don't really see a reason to generate XML by concatenating strings, so I wonder > whether we could include the XMLWriter in the default image? Why don't we load HDTestRunner when needed? And HDTestRunner could then use XMLWriter > This way I could finally fix the HDTestRunner with very little effort. I will finish to pop up my list and start to work on managing the image with Metacello because we should build it based on subproject RB Nautilus Athens NativeBoost AsmJit Zinc OPAL were/are managed with metacello so we could be there :) Stef

Aug. 15, 2013

Re: [Pharo-dev] --no-quit option of eval command handler broken ?

by StÃ©phane Ducasse

Camillo is it what was blocking you with the CI and erwan because yesterday we started to update Ubuntu and other nice libs to be able to check but we did not get an idea about that was the problem. So do you have an expression that does not work? Stef On Aug 15, 2013, at 1:32 AM, Camillo Bruni <camillobruni(a)gmail.com> wrote: > I can confirm. > However, if you save the image in interactive mode it works again. > > On 2013-08-14, at 17:09, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> Hi, >> >> I have the impression that the --no-quit option of the eval command line handler is broken in 3.0 latest. >> >> This used to work >> >> ./pharo Pharo.image --no-quit eval 'ZnServer startDefaultOn: 8080.' >> >> while now, only this works >> >> ./pharo Pharo.image eval 'ZnServer startDefaultOn: 8080. [1 hour asDelay wait] repeat.' >> >> Can anyone confirm this ? Maybe with another example ? >> >> It is a bit hard to debug: nothing happens with --no-quit, no error, no log fileâ¦ >> >> Sven >> >> >> > >

Aug. 15, 2013

Re: [Pharo-dev] Uniformizing Pharo

by StÃ©phane Ducasse

On Aug 14, 2013, at 9:26 PM, Camillo Bruni <camillobruni(a)gmail.com> wrote: > ah looks very nice, indeed much more powerful than my hack. > If you have time, switch to real regular expressions, because things like >> add: (MethodCategorizationRule whenSelectorMatches: 'as*' categorizeIn: #converting); > will easily produce false positives. For instance #assert: will end up in converting, which is not what you want ;) > => /as[A-Z][a-zA-Z]*/ for instance does a much better job Ok thanks for the idea. I will.

Aug. 15, 2013

XML writer in the default image

by Camillo Bruni

As reported a while ago (https://pharo.fogbugz.com/default.asp?7412#80347) the TestRunner is crashing when test failures accidentally spit out XML sensitive characters: https://ci.inria.fr/pharo/view/all/job/Pharo-3.0-Regression-Tests/304/VM=vm… I don't really see a reason to generate XML by concatenating strings, so I wonder whether we could include the XMLWriter in the default image? This way I could finally fix the HDTestRunner with very little effort.

Aug. 15, 2013

Re: [Pharo-dev] --no-quit option of eval command handler broken ?

by Camillo Bruni

I can confirm. However, if you save the image in interactive mode it works again. On 2013-08-14, at 17:09, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > Hi, > > I have the impression that the --no-quit option of the eval command line handler is broken in 3.0 latest. > > This used to work > > ./pharo Pharo.image --no-quit eval 'ZnServer startDefaultOn: 8080.' > > while now, only this works > > ./pharo Pharo.image eval 'ZnServer startDefaultOn: 8080. [1 hour asDelay wait] repeat.' > > Can anyone confirm this ? Maybe with another example ? > > It is a bit hard to debug: nothing happens with --no-quit, no error, no log fileâ¦ > > Sven > > >

Aug. 14, 2013

--no-quit option of eval command handler broken ?

by Sven Van Caekenberghe

Hi, I have the impression that the --no-quit option of the eval command line handler is broken in 3.0 latest. This used to work ./pharo Pharo.image --no-quit eval 'ZnServer startDefaultOn: 8080.' while now, only this works ./pharo Pharo.image eval 'ZnServer startDefaultOn: 8080. [1 hour asDelay wait] repeat.' Can anyone confirm this ? Maybe with another example ? It is a bit hard to debug: nothing happens with --no-quit, no error, no log fileâ¦ Sven

Aug. 14, 2013

Re: [Pharo-dev] Uniformizing Pharo

by Camillo Bruni

ah looks very nice, indeed much more powerful than my hack. If you have time, switch to real regular expressions, because things like > add: (MethodCategorizationRule whenSelectorMatches: 'as*' categorizeIn: #converting); will easily produce false positives. For instance #assert: will end up in converting, which is not what you want ;) => /as[A-Z][a-zA-Z]*/ for instance does a much better job On 2013-08-14, at 15:24, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Ok I checked and I prefer the one I used because you can express nice rules :) > My next step will be to check the tests again, hack/replace the methodClassifier and code with the hacked version for a while > and push everything in the system. Now I will look to see how to make them polymorphic because the classifier is simpler > > Here is the default rules list (I added bench from the other list). > > What is nice is that > - we can express that the superclass should be used in last resort > - I filtered the extensions for now. > > > > defaultCategorizationRules > > "The order is relevant, the categorizer uses the first rule matching - DF" > > ^OrderedCollection new > add: MethodCategorizationRule forAccessors; > > "initialize" > add: (MethodCategorizationRule whenSelectorMatches: 'initialize*' categorizeIn: #initialization); > add: (MethodCategorizationRule whenSelectorMatches: 'init*' categorizeIn: #initialization); > add: (MethodCategorizationRule whenSelectorMatches: 'default*' categorizeIn: #defaults); > > add: (MethodCategorizationRule whenSelectorMatches: 'as*' categorizeIn: #converting); > add: (MethodCategorizationRule whenSelectorMatches: 'hash' categorizeIn: #comparing); > "order is important" > > "testing" > add: (MethodCategorizationRule whenSelectorMatches: 'is*' categorizeIn: #testing); > add: (MethodCategorizationRule whenSelectorMatches: 'has*' categorizeIn: #testing); > > add: (MethodCategorizationRule whenSelectorMatches: '=' categorizeIn: #comparing); > > > add: (MethodCategorizationRule whenSelectorMatches: 'new' categorizeIn: #'instance creation'); > add: (MethodCategorizationRule whenSelectorMatches: 'setting' categorizeIn: #'settings'); > > add: (MethodCategorizationRule whenSelectorMatches: 'printOn:' categorizeIn: #printing); > add: (MethodCategorizationRule whenSelectorMatches: 'storeOn:' categorizeIn: #printing); > > add: (MethodCategorizationRule whenSelectorMatches: '*copy*' categorizeIn: #copying); > > add: (MethodCategorizationRule whenSelectorMatches: 'draw*' categorizeIn: #drawing); > add: (MethodCategorizationRule whenSelectorMatches: 'bench*' categorizeIn: #benchmarking); > add: (MethodCategorizationRule whenSelectorMatches: 'signal*' categorizeIn: #signalling); > add: (MethodCategorizationRule whenSelectorMatches: 'add*' categorizeIn: #adding); > add: (MethodCategorizationRule whenSelectorMatches: 'remove*' categorizeIn: #adding); > > add: (MethodCategorizationRule whenSelectorMatches: 'open*' categorizeIn: #opening); > add: (MethodCategorizationRule whenSelectorMatches: 'update*' categorizeIn: #updating); > add: (MethodCategorizationRule whenSelectorMatches: 'change*' categorizeIn: #updating); > > add: (MethodCategorizationRule whenSelectorMatches: 'accept*' categorizeIn: #'visitor accepting'); > add: (MethodCategorizationRule whenSelectorMatches: 'visit*' categorizeIn: #visiting); > > add: (MethodCategorizationRule whenSelectorMatches: 'menu*' categorizeIn: #menus); > > add: (MethodCategorizationRule whenSelectorMatches: 'value' categorizeIn: #value); > > "test cases" > add: (MethodCategorizationRule > whenSelectorMatches: 'test*' > andClassInheritsFrom: TestCase > categorizeIn: #tests); > > add: (MethodCategorizationRule > whenSelectorMatches: 'setUp' > andClassInheritsFrom: TestCase > categorizeIn: #'setup'); > add: (MethodCategorizationRule > whenSelectorMatches: 'tearDown' > andClassInheritsFrom: TestCase > categorizeIn: #'setup'); > > "baselines, versions..." > add: (MethodCategorizationRule > whenSelectorMatches: 'version*' > andClassMatches: 'ConfigurationOf*' > categorizeIn: #'versions'); > add: (MethodCategorizationRule > whenSelectorMatches: 'baseline*' > andClassMatches: 'ConfigurationOf*' > categorizeIn: #'baselines'); > add: (MethodCategorizationRule > whenSelectorMatches: 'development*' > andClassMatches: 'ConfigurationOf*' > categorizeIn: #'symbolic'); > add: (MethodCategorizationRule > whenSelectorMatches: 'stable*' > andClassMatches: 'ConfigurationOf*' > categorizeIn: #'symbolic'); > > > > add: MethodCategorizationRule usingMostUsedCategoryInSuperClasses; > add: MethodCategorizationRule usingMostUsedCategoryInImage; > yourself > >>> Did you use the method categorizer that is already in the image? >>> >>> => MethodClassifier >>> >>> it implements already a lot of rules, so you should plug in your tool there or remove MethodClassifier and make it work with nautilus. otherwise we have a lot of duplicated functionality. >> >> I was not aware of it I will look at it. >> In fact there was a method categorizer in a nice package with tests and I took this one and adapted it. >> I will check the rules. >> >> Stef >> >> > >

Aug. 14, 2013

Re: [Pharo-dev] Uniformizing Pharo

by StÃ©phane Ducasse

Ok I checked and I prefer the one I used because you can express nice rules :) My next step will be to check the tests again, hack/replace the methodClassifier and code with the hacked version for a while and push everything in the system. Now I will look to see how to make them polymorphic because the classifier is simpler Here is the default rules list (I added bench from the other list). What is nice is that - we can express that the superclass should be used in last resort - I filtered the extensions for now. defaultCategorizationRules "The order is relevant, the categorizer uses the first rule matching - DF" ^OrderedCollection new add: MethodCategorizationRule forAccessors; "initialize" add: (MethodCategorizationRule whenSelectorMatches: 'initialize*' categorizeIn: #initialization); add: (MethodCategorizationRule whenSelectorMatches: 'init*' categorizeIn: #initialization); add: (MethodCategorizationRule whenSelectorMatches: 'default*' categorizeIn: #defaults); add: (MethodCategorizationRule whenSelectorMatches: 'as*' categorizeIn: #converting); add: (MethodCategorizationRule whenSelectorMatches: 'hash' categorizeIn: #comparing); "order is important" "testing" add: (MethodCategorizationRule whenSelectorMatches: 'is*' categorizeIn: #testing); add: (MethodCategorizationRule whenSelectorMatches: 'has*' categorizeIn: #testing); add: (MethodCategorizationRule whenSelectorMatches: '=' categorizeIn: #comparing); add: (MethodCategorizationRule whenSelectorMatches: 'new' categorizeIn: #'instance creation'); add: (MethodCategorizationRule whenSelectorMatches: 'setting' categorizeIn: #'settings'); add: (MethodCategorizationRule whenSelectorMatches: 'printOn:' categorizeIn: #printing); add: (MethodCategorizationRule whenSelectorMatches: 'storeOn:' categorizeIn: #printing); add: (MethodCategorizationRule whenSelectorMatches: '*copy*' categorizeIn: #copying); add: (MethodCategorizationRule whenSelectorMatches: 'draw*' categorizeIn: #drawing); add: (MethodCategorizationRule whenSelectorMatches: 'bench*' categorizeIn: #benchmarking); add: (MethodCategorizationRule whenSelectorMatches: 'signal*' categorizeIn: #signalling); add: (MethodCategorizationRule whenSelectorMatches: 'add*' categorizeIn: #adding); add: (MethodCategorizationRule whenSelectorMatches: 'remove*' categorizeIn: #adding); add: (MethodCategorizationRule whenSelectorMatches: 'open*' categorizeIn: #opening); add: (MethodCategorizationRule whenSelectorMatches: 'update*' categorizeIn: #updating); add: (MethodCategorizationRule whenSelectorMatches: 'change*' categorizeIn: #updating); add: (MethodCategorizationRule whenSelectorMatches: 'accept*' categorizeIn: #'visitor accepting'); add: (MethodCategorizationRule whenSelectorMatches: 'visit*' categorizeIn: #visiting); add: (MethodCategorizationRule whenSelectorMatches: 'menu*' categorizeIn: #menus); add: (MethodCategorizationRule whenSelectorMatches: 'value' categorizeIn: #value); "test cases" add: (MethodCategorizationRule whenSelectorMatches: 'test*' andClassInheritsFrom: TestCase categorizeIn: #tests); add: (MethodCategorizationRule whenSelectorMatches: 'setUp' andClassInheritsFrom: TestCase categorizeIn: #'setup'); add: (MethodCategorizationRule whenSelectorMatches: 'tearDown' andClassInheritsFrom: TestCase categorizeIn: #'setup'); "baselines, versions..." add: (MethodCategorizationRule whenSelectorMatches: 'version*' andClassMatches: 'ConfigurationOf*' categorizeIn: #'versions'); add: (MethodCategorizationRule whenSelectorMatches: 'baseline*' andClassMatches: 'ConfigurationOf*' categorizeIn: #'baselines'); add: (MethodCategorizationRule whenSelectorMatches: 'development*' andClassMatches: 'ConfigurationOf*' categorizeIn: #'symbolic'); add: (MethodCategorizationRule whenSelectorMatches: 'stable*' andClassMatches: 'ConfigurationOf*' categorizeIn: #'symbolic'); add: MethodCategorizationRule usingMostUsedCategoryInSuperClasses; add: MethodCategorizationRule usingMostUsedCategoryInImage; yourself >> Did you use the method categorizer that is already in the image? >> >> => MethodClassifier >> >> it implements already a lot of rules, so you should plug in your tool there or remove MethodClassifier and make it work with nautilus. otherwise we have a lot of duplicated functionality. > > I was not aware of it I will look at it. > In fact there was a method categorizer in a nice package with tests and I took this one and adapted it. > I will check the rules. > > Stef > >

Aug. 14, 2013