July 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] sunit failures vs errors

by StÃ©phane Ducasse

On Jul 10, 2013, at 9:08 AM, Stefan Marr <smalltalk(a)stefan-marr.de> wrote: > Hi Camillo: > > On 10 Jul 2013, at 02:46, Camillo Bruni <camillobruni(a)gmail.com> wrote: > >> Does anybody here distinguish failures and errors for real when doing TDD? > > To make your live a little more difficult, I actually introduced an additional type of failure on top of that: blue for still to be implemented. > > I liked that a lot for prototyping to see all my todos in the test runner in a different pane, and to be able to distinguish between unimplemented stuff, and stuff I just broke again. + 1 > However, to your actual question, I have not noticed that difference in JUnit, so, I guess, I don't really care for the destination between errors and failures. ah I did not know. I always thought it was the same. > > Best regards > Stefan > > -- > Stefan Marr > Software Languages Lab > Vrije Universiteit Brussel > Pleinlaan 2 / B-1050 Brussels / Belgium > http://soft.vub.ac.be/~smarr > Phone: +32 2 629 2974 > Fax: +32 2 629 3525 > >

July 11, 2013

Re: [Pharo-dev] [Pharo-project] RFB in 2.0

by Norbert Hartl

Am 10.07.2013 um 23:05 schrieb Mariano Martinez Peck <marianopeck(a)gmail.com>: > > > > On Wed, Jul 10, 2013 at 6:03 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: >>> >>>> >>>>> Also, I had another problem with RFB and the UIManager. The solution I found was this one: http://samadhiweb.com/blog/2012.11.04.headless.rfb.html >>>>> I don't like it because I need to change Pharo's base source, but I didn't spend time finding a better solution...I guess there is, though. >>>> The first line of code all my images (deployed on server using RFB) see is >>>> >>>> UIManager default: MorphicUIManager new. >>> >>> I was going to do that as well. But it is not clear to me WHERE you write that line of code. Because even if you save the image with that, doesn't the image set its own UI manager when booting? So I guess you need to pass around a script when running the image or something? >>> What about adding RFB at startup list and implement #startUp doing "UIManager default: MorphicUIManager new." ? >> >> Norbert, I still don't understand your answer. What do you mean by "first line of code all my images..." ? >> >> If I save the image with that UIManager then when started again in headless mode it is changed, right? >> >> Thanks, > > Norbert? > I'm using some start scripts that do it for me. It is something like init scripts for linux but for pharo. The first script invokes the line so it is just the first that happens on any image startup. You can doit with a start script as well. I'll release my stuff in a while. Just didn't find time to do it Norbert > >> >>> Best, >>> >>> >>>> With that I don't have problems at all. >>>> >>>> thanks, >>>> >>>> Norbert >>>> >>>>> Best, >>>>> >>>>> >>>>> >>>>> >>>>> On Fri, May 3, 2013 at 2:56 PM, Norbert Hartl <norbert(a)hartl.name> wrote: >>>>>> I've found the problem. There is a FileDirectory access in RFBSession>>#desktopName. Removing it makes RFB work. >>>>>> >>>>>> The current RFB sources are on Lukas' server. What do we do with that stuff? Move to smalltalkhub? If not I can ask Lukas to give me write permission. Just wanted to ask what kind of behaviour is en vogue this days. >>>>>> >>>>>> Norbert >>>>>> >>>>>> Am 03.05.2013 um 19:31 schrieb Norbert Hartl <norbert(a)hartl.name>: >>>>>> >>>>>> > Esteban, >>>>>> > >>>>>> > now I can tell that it isn't working for me either. Socket is open and server is running. But there are immediate disconnects when trying to connect to a pharo2.0 image. >>>>>> > >>>>>> > Did you figure it out? >>>>>> > >>>>>> > Norbert >>>>> >>>>> >>>>> >>>>> -- >>>>> Mariano >>>>> http://marianopeck.wordpress.com >>> >>> >>> >>> -- >>> Mariano >>> http://marianopeck.wordpress.com >> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com > > > > -- > Mariano > http://marianopeck.wordpress.com

July 10, 2013

Re: [Pharo-dev] Is it Glorp trustful enough for the encoding?

by Mariano Martinez Peck

I agree with you guys. So, I fixed something in the GlorpNativePostgresDriver so that it gets the encoding info from Glorp's Login and pass it to the PGConnectionArgs :) Cheers, On Wed, Jul 10, 2013 at 12:16 PM, Esteban A. Maringolo <emaringolo(a)gmail.com > wrote: > 2013/7/10 Sven Van Caekenberghe <sven(a)stfx.eu>: > >> So...where should I do the conversion? At Glorp level or at database > driver level? > > > And IMHO at the lowest possible level. If you have an SQL VARCHAR > column, the driver should convert bytes to a normal Smalltalk String. An OR > mapper is a client of the driver, right ? > > +1 > > Encoding should be a parameter of the Connection/Login details. And > ORM should deal only with strings in whatever encoding Pharo uses for > its strings, ignoring (as much as possible) what happens beneath. > > Regards, > > -- Mariano http://marianopeck.wordpress.com

July 10, 2013

Re: [Pharo-dev] [Pharo-project] RFB in 2.0

by Mariano Martinez Peck

On Wed, Jul 10, 2013 at 6:03 PM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > >> >>> Also, I had another problem with RFB and the UIManager. The solution I >>> found was this one: >>> http://samadhiweb.com/blog/2012.11.04.headless.rfb.html >>> I don't like it because I need to change Pharo's base source, but I >>> didn't spend time finding a better solution...I guess there is, though. >>> >>> The first line of code all my images (deployed on server using RFB) see >>> is >>> >>> UIManager default: MorphicUIManager new. >>> >>> >> I was going to do that as well. But it is not clear to me WHERE you write >> that line of code. Because even if you save the image with that, doesn't >> the image set its own UI manager when booting? So I guess you need to pass >> around a script when running the image or something? >> What about adding RFB at startup list and implement #startUp doing >> "UIManager default: MorphicUIManager new." ? >> >> > Norbert, I still don't understand your answer. What do you mean by "first > line of code all my images..." ? > > If I save the image with that UIManager then when started again in > headless mode it is changed, right? > > Thanks, > > Norbert? > > >> Best, >> >> >> >>> With that I don't have problems at all. >>> >>> thanks, >>> >>> Norbert >>> >>> Best, >>> >>> >>> >>> >>> On Fri, May 3, 2013 at 2:56 PM, Norbert Hartl <norbert(a)hartl.name>wrote: >>> >>>> I've found the problem. There is a FileDirectory access in >>>> RFBSession>>#desktopName. Removing it makes RFB work. >>>> >>>> The current RFB sources are on Lukas' server. What do we do with that >>>> stuff? Move to smalltalkhub? If not I can ask Lukas to give me write >>>> permission. Just wanted to ask what kind of behaviour is en vogue this days. >>>> >>>> Norbert >>>> >>>> Am 03.05.2013 um 19:31 schrieb Norbert Hartl <norbert(a)hartl.name>: >>>> >>>> > Esteban, >>>> > >>>> > now I can tell that it isn't working for me either. Socket is open >>>> and server is running. But there are immediate disconnects when trying to >>>> connect to a pharo2.0 image. >>>> > >>>> > Did you figure it out? >>>> > >>>> > Norbert >>>> >>>> >>>> >>> >>> >>> -- >>> Mariano >>> http://marianopeck.wordpress.com >>> >>> >>> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com >> > > > > -- > Mariano > http://marianopeck.wordpress.com > -- Mariano http://marianopeck.wordpress.com

July 10, 2013

Some updates to GLorp

by Mariano Martinez Peck

Hi guys I did a couple of things related to Glorp. I commited 2 fixes related to the connection pool. Also, for the native postgres driver, I adapted the pool we have for OpenDBXDriver. It's quite ugly because we are duplicating quite a lot of code, but the hierarchy make things complicated here and I don't have more time to improve it (at least not right now). If someone wants to give it a shoot :) You can give it as an exercise to a student hahaha. So...to sum up, some fixes in GlorpOpenDBXDriver and the new connection pool to GlorpDriverPostgreSQL. Cheers, -- Mariano http://marianopeck.wordpress.com

July 10, 2013

Issue in need of review: 11140 #addDeferredUIMessage: is always sent directly to WorldState

by Marcus Denker

Someone who is not me need to look at this: 11140 #addDeferredUIMessage: is always sent directly to WorldState https://pharo.fogbugz.com/f/cases/11140

July 10, 2013

Re: [Pharo-dev] the return of the strange methods

by Jan Vrany

> What you want is a TAssertable>>#should:raise: that: > - takes a one arg block as second argument that is evaluated with the > exception thrown > - fails if no exception is raised > Then please call it #should:raise:suchThat: That's what is in upcoming SUnit 5.0 [1] Also I would avoid using traits in SUnit, this is non-portable. The TestAsserter class was introduced already in SUnit 4.0. Indeed, only if you at all care about having SUnit in sync with other dialects :-) Best, Jan [1]: https://swing.fit.cvut.cz/hg/stx.goodies.sunit/file/fb932a5daa97/TestAssert…

July 10, 2013

Re: [Pharo-dev] the return of the strange methods

by Camille Teruel

On 10 juil. 2013, at 16:45, Igor Stasenko wrote: > On 9 July 2013 22:45, Nicolas Cellier > <nicolas.cellier.aka.nice(a)gmail.com> wrote: >> "should not raise an exceptional event whose description does not include" >> wow, who is crooked enough to use double negation ;) >> > > is it a convenience method for following: > > > [ self dosomething ] on: Error do: [:ex | > self assert: ex message includes:'whatever' ] > ? Not really, because it doesn't fails if no exception is raised. > > as to me this is more readable and intent-revealing than using strange > double-negation.. What you want is a TAssertable>>#should:raise: that: - takes a one arg block as second argument that is evaluated with the exception thrown - fails if no exception is raised > > >> Nicolas >> >> >> 2013/7/9 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> >>> >>> So + 1 :) >>> >>>>>> >>>>>> - shouldnt: aBlock raise: anExceptionalEvent >>>>>> whoseDescriptionDoesNotInclude: subString description: aString >>>>>> - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionIncludes: >>>>>> subString description: aString >>>>>> >>>>>> I honestly cannot wrap my head around these two methods. >>>>> >>>>> They show that the code in the block raises an _informative_ >>>>> exception. So you get a FileNotFound exception... but what was the >>>>> missing file? I don't know! Noone bothered to mention it! >>>> >>>> >>>> no it is #shouldnt: it is the inverse. >>>> the #should:... handler methods are fine, but these specific two methods >>>> are just insane. >>>> I tried to reimplement them without looking at the original definition >>>> and I cannot come up with something that matches the name :) so there is >>>> definitely something wrong with it. >>> >>> >> > > > > -- > Best regards, > Igor Stasenko. >

July 10, 2013

Re: [Pharo-dev] the return of the strange methods

by Jeff Estep

M/I/i On Jul 9, 2013 11:43 AM, "ClÃ©ment Bera" <bera.clement(a)gmail.com> wrote: > They may be useful. Imagine you are too lazy to create a subclass of > Error, but not lazy enough to create a test and copy paste a String. > Then you write in your method: > self error: 'some strange error happened' > And you can test it: > self shouldnt: [ "some strange code" ] raise: Error whoseDescriptionIncludes: > 'some strange error happened' description: 'the strange error did not > happen ! That's strange' > > Seriously, as you saw these methods are used only in their tests. I guess > you can remove them. Open fogz bug ? > > > 2013/7/9 Frank Shearar <frank.shearar(a)gmail.com> > >> On 9 July 2013 16:24, Camillo Bruni <camillobruni(a)gmail.com> wrote: >> > Survey: who uses the following methods? and if yes why? >> > >> > - shouldnt: aBlock raise: anExceptionalEvent >> whoseDescriptionDoesNotInclude: subString description: aString >> > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionIncludes: >> subString description: aString >> > >> > I honestly cannot wrap my head around these two methods. >> >> They show that the code in the block raises an _informative_ >> exception. So you get a FileNotFound exception... but what was the >> missing file? I don't know! Noone bothered to mention it! >> >> frank >> >> >

July 10, 2013

Re: [Pharo-dev] the return of the strange methods

by Jeff Estep

-mgvnf mk. / On Jul 9, 2013 11:49 AM, "Max Leske" <maxleske(a)gmail.com> wrote: > > > On 09.07.2013, at 17:42, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > >> They may be useful. Imagine you are too lazy to create a subclass of Error, but not lazy enough to create a test and copy paste a String. >> Then you write in your method: >> self error: 'some strange error happened' >> And you can test it: >> self shouldnt: [ "some strange code" ] raise: Error whoseDescriptionIncludes: 'some strange error happened' description: 'the strange error did not happen ! That's strange' >> >> Seriously, as you saw these methods are used only in their tests. I guess you can remove them. Open fogz bug ? > > > +1 > >> >> >> 2013/7/9 Frank Shearar <frank.shearar(a)gmail.com> >>> >>> On 9 July 2013 16:24, Camillo Bruni <camillobruni(a)gmail.com> wrote: >>> > Survey: who uses the following methods? and if yes why? >>> > >>> > - shouldnt: aBlock raise: anExceptionalEvent whoseDescriptionDoesNotInclude: subString.- description: aString >>> > - shouldnt: aBlock raise: anExceptionalEvdcdvent whoseDescriptionIncludes: subString description: aString >>> > >>> > I honestly cannot wrap my head around these two methods. >>> >>> They show that the code in the block raises an _informative_ >>> exception. So you get a FileNotFound exception... but what was the >>> missing file? I don't know! Noone bothered to mention it! >>> >>> frank >>> >> >

July 10, 2013