May 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] clean, please

by Sven Van Caekenberghe

Haha, maybe we should switch to swearing in other languages to honour the international character of the community ? But, yes, clean code is paramount ! To come back to a previous discussion: clean code and good design are more important than method comments, class comments are indispensable IMO. On 22 May 2013, at 21:39, Camillo Bruni <camillobruni(a)gmail.com> wrote: > the fucking code of course! > > On 2013-05-22, at 19:53, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: >> The kitchen, the living room ? >> >> On 22 May 2013, at 19:49, Igor Stasenko <siguctua(a)gmail.com> wrote: >> >>> On 22 May 2013 19:41, Paul Davidowitz <pdavidow(a)fastmail.fm> wrote: >>>> Let's keep this clean, please! >>>> >>> >>> keep clean what? >>> >>> -- >>> Best regards, >>> Igor Stasenko. >>> >> >> > >

May 22, 2013

Re: [Pharo-dev] clean, please

by Camillo Bruni

the fucking code of course! On 2013-05-22, at 19:53, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > The kitchen, the living room ? > > On 22 May 2013, at 19:49, Igor Stasenko <siguctua(a)gmail.com> wrote: > >> On 22 May 2013 19:41, Paul Davidowitz <pdavidow(a)fastmail.fm> wrote: >>> Let's keep this clean, please! >>> >> >> keep clean what? >> >> -- >> Best regards, >> Igor Stasenko. >> > >

May 22, 2013

Re: [Pharo-dev] MC Filetree -- missing FiletreeURL ?

by Camillo Bruni

>> Sven >> >> PS: I occasionally read the Squeak mailing and I see the work that you are doing and it is impressive. Your attitude, approach and drive remind me of the many Pharo developers. I would not dream of convincing you, but IMHO you would fit perfectly in the Pharo community, where you would find more interaction and feedback - maybe you would even reconsider using Smalltalk in business. > > Thanks, Sven. I'm really not trying to pick fights over here. And > perhaps today was a bad day to open my mouth at all, given my > crankiness level. > > I would _love_ to be able to use Smalltalk at work. Until it can work > properly with git, and people can use their own text editors (vim, > emacs, sublime), and quite a few other bits and pieces, it's just a > non-starter. that's simply not true, as you can see by all the success stories: http://files.pharo.org/SuccessStories/ > I _like_ Pharo, and I _like_ how it has energy and momentum, and a > much nicer UI than the old Pharo 1.0 UI. I'm honestly quite jealous of > the resources the community wields, not just because of INRIA's and > the Consortium's money, but because there are loads of people actually > around, who are prepared to knuckle down and do the gruntwork needed. > Squeak is now a very small community. I'm rather proud of what we get > done with what little we have. that is sad :(, I really think your contribution would be better off over here. I speak for many at our lab I think, that there is no motivation to prepare stuff for squeak: burnt once, fooled twice :/

May 22, 2013

Re: [Pharo-dev] TxText new version 0.8

by Camillo Bruni

On 2013-05-22, at 21:04, Tudor Girba <tudor(a)tudorgirba.com> wrote: > Hi, > > On May 22, 2013, at 5:33 PM, Igor Stasenko <siguctua(a)gmail.com> wrote: > >> On 22 May 2013 10:38, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: >>> I would use >>> >>> TextModelCore >>> TextModelExtensions >>> >>> TextModelCore-Tests >>> >>> No extra dash in the middle. >> >> nooooo :) >> >> But for tests, i +1, the names are not very good. >> For package: >> >> Package-Name-Tick-Tack >> >> tests should be in: >> >> Package-Name-Tick-Tack-Tests >> >> This convention used everywhere in pharo. > > Please do not do that :). > > If you do that, publishing Package-Name-Tick-Tack will publish the code from Package-Name-Tick-Tack-Tests, too :). Why? Because we have a lovely implicit one-to-many mapping. > > So, the pattern I know of is to put the Tests as a discriminator before the variable part of your code. So, something like: > - BaseName-Core > - BaseName-Tests-Core > > But, the rule I apply more recently for code is to use - only for categories, and camel case for the Monticello packages. Like this we also document what is the unit of publishing, thus when you look into the code browser we also know what is mapped on a Monticello package. I would love to change that rule. I think Tests have the same value as the code itself. The only reason to not load the code is the load time for the configuration. Which is basically is unimportant if you have a CI server preparing images for you. I can only speak for smaller projects, but I really do not sea a reason to not load tests...

May 22, 2013

Re: [Pharo-dev] FileSystem inconsistency

by Camillo Bruni

On 2013-05-22, at 19:53, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi > > I'm doing a pass on the FileSystem chapter (yes you know the documentation that nobody write but everybody > wants to read), I'm updating/adding method comments and I get the following. > > paf does not exist > > (FileSystem disk workingDirectory / 'paf' ) delete. > works without barking > > => may delete should barks to be consistent. > > > > (FileSystem disk workingDirectory / 'paf' ) deleteAll. > barks! > > (FileSystem disk workingDirectory / 'paf' ) deleteAllChildren. > barks! > > (FileSystem disk workingDirectory / 'paf' ) deleteIfAbsent: [ Warning signal: ' File does not exist' ] . > works that's fully correct in my opinion. The error message are less consistent. There are operations that only work on files and some that only work on folders. #deleteAll, #deleteAllChildren are only working on directories (much like `rm -R folder`). #delete works on single instances, much like `rm file` but also on folders

May 22, 2013

Re: [Pharo-dev] FileSystem ensureDeleted

by Camillo Bruni

On 2013-05-22, at 19:39, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > (FileSystem disk workingDirectory / 'fooFolder3') ensureDirectory. > (FileSystem disk workingDirectory / 'fooFolder3') ensureDeleted. > > works > > I get a primitive failure > > (FileSystem disk workingDirectory / 'fooFolder') createDirectory. > (FileSystem disk workingDirectory / 'fooFolder' / 'fooInsidefoo') createDirectory. > (FileSystem disk workingDirectory / 'fooFolder') ensureDeleted. > > because > > ensureDeleted is defined as > > ensureDeleted > self deleteIfAbsent: []. > > and it would be better to define it as > > ensureDeleted > self deleteAll. > > What do you think? no, that is wrong and dangerous. #ensureDeleted just removes a single entity. it is the safe for of #delete. In this case I would add a #ensureDeletedAll

May 22, 2013

Re: [Pharo-dev] fileSystem copyAllTo: ??

by Camillo Bruni

because it is a file? copyAllTo only works on a folder. On 2013-05-22, at 19:36, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > (FileSystem disk workingDirectory / 'fooFolder') ensureDelete. > (FileSystem disk workingDirectory / 'pif' ) ensureFile. > (FileSystem disk workingDirectory / 'fooFolder') ensureDirectory. > (FileSystem disk workingDirectory / 'pif' ) copyAllTo: (FileSystem disk workingDirectory / 'fooFolder'). > > It barks and I do not why > > even with > > (FileSystem disk workingDirectory / 'fooFolder') ensureDelete. > (FileSystem disk workingDirectory / 'pif' ) ensureFile. > (FileSystem disk workingDirectory / 'fooFolder') ensureDirectory. > (FileSystem disk workingDirectory / 'pif' ) copyAllTo: (FileSystem disk workingDirectory / 'fooFolder').

May 22, 2013

Re: [Pharo-dev] could we rename ensureDeleted into ensureDelete?

by Camillo Bruni

On 2013-05-22, at 19:35, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > Because I do not understand why we use paste suddenly? because it is the final state, the file is deleted. it emerged out of a longer discussion with sean, mariano and me I think

May 22, 2013

Re: [Pharo-dev] FileSystem moveTo:

by Camillo Bruni

ah right you change just the item :) On 2013-05-22, at 19:26, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > I imagine that > > (FileSystem disk workingDirectory / 'paf' ) moveTo: (FileSystem disk workingDirectory / 'fooFolder' / 'paf') > > I thought that it was inside somethingâ¦.. > > > On May 22, 2013, at 7:24 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >> How do I move a file inside a folder? >> >> (FileSystem disk workingDirectory / 'paf' ) ensureFile. >> (FileSystem disk workingDirectory / 'fooFolder') ensureDirectory. >> >> (FileSystem disk workingDirectory / 'paf' ) moveTo: (FileSystem disk workingDirectory / 'fooFolder') >> >> this does not work? >> What is the semantics of moveTo: (Yes I'm adding a comment)â¦.. >> >> Stef >> >> >> > >

May 22, 2013

Re: [Pharo-dev] Messy Configurations

by Camillo Bruni

On 2013-05-22, at 19:00, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > > On May 22, 2013, at 5:53 PM, Camillo Bruni <camillobruni(a)gmail.com> wrote: > >> I recently spent some time to revise how to write Metacello Configurations. >> >> Observation: >> ============ >> - many configurations are quite a mess >> - many configurations duplicate code internally >> - many configurations have archived development versions > > I would love to go over the one I maintain and fix them. So give me hints and I will do it. > I want patterns! Patterns are a proof of maturity and optimise the space. >> >> >> For Pharo 3.0 I made a new Configuration template which improves and documents >> these observed points in quite some detail. Simply load a new 3.0 image and >> create a new configuration from the monticello working copy browser. >> >> Solution: >> ========= >> - specify external projects in separate, reusable methods >> - only have ONE development version you regularly update >> - do not use version numbers for the development version >> - only make a version number when you release something stable AKA not #development >> - name the baseline after the first version that introduces it >> >> >> >> What do you think? > > show me one example because there are too many concepts and I'm confused about words when talking > metacellonese. > But yes I do not want all the possible possibilities just the cool and efficient patterns (that a tool should codify > for me). you can check the ConfigurationOfCI and ConfigurationOfAsmJit in http://smalltalkhub.com/mc/Pharo/ci/main or http://smalltalkhub.com/mc/Pharo/AsmJit/main or you come to my office and we look at it together ;) > In my dream (and this is why I'm frustrated that we are burning the time of christophe on travis) > I would love to have a tools to generate and validate configurations for me. yes definitely!

May 22, 2013