March 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] about OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1

by Sven Van Caekenberghe

On 03 Mar 2013, at 10:20, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > Hi sven > > yes I imagine now we should improve in trakcing such changes. > In addition I do not understand why > > XMLOrderedList new: 10 > > breaks the inspectorâ¦. Yes, I once saw that as well, very strange, I guess that is what happens when you start making your own collection classes... > This is why all the important libraries should be covered by a jenkins job and tests. > So that right on the spot we can identify problems. > > Stef > > >> These important changes were made intentionally, so we need to find the rationale of the change. >> Like is the new behavior covered by new tests ? >> >> On 03 Mar 2013, at 09:45, stephane ducasse <stephane.ducasse(a)free.fr> wrote: >> >>> >>> On Mar 3, 2013, at 9:42 AM, stephane ducasse <stephane.ducasse(a)free.fr> wrote: >>> >>>> I could overwrite XMLOrderedList >>>> >>>> replaceFrom: aStartingIndex to: anEndingIndex with: aCollection startingAt: aReplacementStart >>>> >>>> >>>> collection >>>> replaceFrom: aStartingIndex >>>> to: anEndingIndex >>>> with: aCollection >>>> startingAt: aReplacementStart >>>> >>>> to make it grow? But I do not really know the impact on the XML library >>>> >>>>> self makeRoomFor: (anEndingIndex- self capacity). >>>> >>>> any idea? >>> >>> >>> In fact it will not work since makeRoomFor: and others have been removed and I do not have the time to dive in >>> OrderedCollection growing logic. >>> >>>> >>>> Stef >>>> >>>> >>>> >>>> >>>> On Mar 3, 2013, at 9:34 AM, StÃ©phane Ducasse <Stephane.Ducasse(a)inria.fr> wrote: >>>> >>>>> Hi guys >>>>> >>>>> in 1.2.1 >>>>> >>>>> OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 >>>>> gave >>>>> an OrderedCollection(6 7 8 9 10) >>>>> >>>>> >>>>> while in 1.4 and 2.0 >>>>> OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 >>>>> raised an error >>>>> >>>>> Do you have an idea how I can handle that? Because XMLObservableList and XMLOrderedList implements >>>>> replaceFrom: to: with: startingAt: >>>>> >>>>> because there is no self makeRoomFor: (stop - self capacity) invocation. >>>>> >>>>> >>>>> in 1.4>> >>>>> replaceFrom: start to: stop with: replacement startingAt: repStart >>>>> "This destructively replaces elements from start to stop in the receiver >>>>> starting at index, repStart, in the sequenceable collection, >>>>> replacementCollection. Answer the receiver. No range checks are >>>>> performed." >>>>> >>>>> | index repOff | >>>>> repOff := repStart - start. >>>>> index := start - 1. >>>>> [(index := index + 1) <= stop] >>>>> whileTrue: [self at: index put: (replacement at: repOff + index)] >>>>> >>>>> at: anInteger put: anObject >>>>> "Put anObject at element index anInteger. at:put: cannot be used to >>>>> append, front or back, to an ordered collection; it is used by a >>>>> knowledgeable client to replace an element." >>>>> self ensureBoundsFrom: anInteger to: anInteger. >>>>> ^array at: anInteger + firstIndex - 1 put: anObject >>>>> >>>>> >>>>> in 1.2.1 >>>>> >>>>> replaceFrom: start to: stop with: replacement startingAt: repStart >>>>> "An ordered collection is growable, so a call to this can make the collection grow." >>>>> self makeRoomFor: (stop - self capacity). >>>>> array >>>>> replaceFrom: start + firstIndex - 1 >>>>> to: stop + firstIndex - 1 >>>>> with: replacement >>>>> startingAt: repStart. >>>>> lastIndex := lastIndex max: stop + firstIndex - 1. >>>> >>>> >>> >>> >> >> > >

March 3, 2013

Re: [Pharo-project] about OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1

by stephane ducasse

Hi sven yes I imagine now we should improve in trakcing such changes. In addition I do not understand why XMLOrderedList new: 10 breaks the inspectorâ¦. This is why all the important libraries should be covered by a jenkins job and tests. So that right on the spot we can identify problems. Stef > These important changes were made intentionally, so we need to find the rationale of the change. > Like is the new behavior covered by new tests ? > > On 03 Mar 2013, at 09:45, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > >> >> On Mar 3, 2013, at 9:42 AM, stephane ducasse <stephane.ducasse(a)free.fr> wrote: >> >>> I could overwrite XMLOrderedList >>> >>> replaceFrom: aStartingIndex to: anEndingIndex with: aCollection startingAt: aReplacementStart >>> >>> >>> collection >>> replaceFrom: aStartingIndex >>> to: anEndingIndex >>> with: aCollection >>> startingAt: aReplacementStart >>> >>> to make it grow? But I do not really know the impact on the XML library >>> >>>> self makeRoomFor: (anEndingIndex- self capacity). >>> >>> any idea? >> >> >> In fact it will not work since makeRoomFor: and others have been removed and I do not have the time to dive in >> OrderedCollection growing logic. >> >>> >>> Stef >>> >>> >>> >>> >>> On Mar 3, 2013, at 9:34 AM, StÃ©phane Ducasse <Stephane.Ducasse(a)inria.fr> wrote: >>> >>>> Hi guys >>>> >>>> in 1.2.1 >>>> >>>> OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 >>>> gave >>>> an OrderedCollection(6 7 8 9 10) >>>> >>>> >>>> while in 1.4 and 2.0 >>>> OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 >>>> raised an error >>>> >>>> Do you have an idea how I can handle that? Because XMLObservableList and XMLOrderedList implements >>>> replaceFrom: to: with: startingAt: >>>> >>>> because there is no self makeRoomFor: (stop - self capacity) invocation. >>>> >>>> >>>> in 1.4>> >>>> replaceFrom: start to: stop with: replacement startingAt: repStart >>>> "This destructively replaces elements from start to stop in the receiver >>>> starting at index, repStart, in the sequenceable collection, >>>> replacementCollection. Answer the receiver. No range checks are >>>> performed." >>>> >>>> | index repOff | >>>> repOff := repStart - start. >>>> index := start - 1. >>>> [(index := index + 1) <= stop] >>>> whileTrue: [self at: index put: (replacement at: repOff + index)] >>>> >>>> at: anInteger put: anObject >>>> "Put anObject at element index anInteger. at:put: cannot be used to >>>> append, front or back, to an ordered collection; it is used by a >>>> knowledgeable client to replace an element." >>>> self ensureBoundsFrom: anInteger to: anInteger. >>>> ^array at: anInteger + firstIndex - 1 put: anObject >>>> >>>> >>>> in 1.2.1 >>>> >>>> replaceFrom: start to: stop with: replacement startingAt: repStart >>>> "An ordered collection is growable, so a call to this can make the collection grow." >>>> self makeRoomFor: (stop - self capacity). >>>> array >>>> replaceFrom: start + firstIndex - 1 >>>> to: stop + firstIndex - 1 >>>> with: replacement >>>> startingAt: repStart. >>>> lastIndex := lastIndex max: stop + firstIndex - 1. >>> >>> >> >> > >

March 3, 2013

Re: [Pharo-project] About replace:with/copyReplace:with:

by stephane ducasse

this part is missing some methods and rethinking others. replaceAll: with: we never know if this is a collection or all the occurrent of one character. Now replaceAll: col will replace all the col occurrences 'foafobf f' copyReplaceAll: 'fo' with: 'zork' > 'zorkazorkbf f' but this is not what you want. 'lapin' copyReplaceAll: 'a' with: 'zork' 'lzorkpin' Stef > Hello guys, I just encounter these methods and got a bit disappointed > > First there is > > SequenceableCollection>>#replaceAll: oldObject with: newObject > "Replace all occurences of oldObject with newObject" > > On String it something like: > > string := 'lapin'. > string replaceAll: $a with: $b > > so now string is 'lbpin' > > Looking for a non destructive version, I looked at: #copyReplaceAll:with: > > SequenceableCollection>>#copyReplaceAll: oldSubstring with: newSubstring > "Default is not to do token matching. > See also String copyReplaceTokens:with:" > > So here it's not destructive, but > 1) The argument names are wrong (or the method is not defined on the correct class) > 2) why one take an element as argument and the other one a collection of elements ? > > > Am I the only one disturb by this ? > > > Ben >

March 3, 2013

Re: [Pharo-project] Spreadsheet widget

by Ben Coman

stephane ducasse wrote: > Hi Ben > > > >>> Stef >>> >> Where can I find the latest version of SpreadsheetGridMorph ? >> > > it is one smalltalkhub on StephaneDucasse / PetitsBazars > > >> I think this will be a great addition to the Pharo ecosystem. Here is an interesting excerpt from "How Trello is different" (http://www.joelonsoftware.com/items/2012/01/06.html) >> > > it requires some work. > > >> ---- >> "Forgive me if I now divert into telling you a quick story about my time spent on the Microsoft Excel team way back in 1991. (Yes, I know you were not born yet, but I assure you that computers had been invented. Just hop up here on my knee and shut up.) Everybody thought of Excel as a financial modeling application. It was used for creating calculation models with formulas and stuff. You would put in your assumptions and then calculate things like âif interest rates go up by 0.00001% next year, what percentage of Las Vegas homeowners will plunge into bankruptcy?â For example. >> >> Round about 1993 a couple of us went on customer visits to see how people were using Excel. We found a fellow whose entire job consisted of maintaining the ânumber of injuries this weekâ spreadsheet for a large, highly-regulated utility. Once a week, he opened an Excel spreadsheet which listed ten facilities, containing the name of the facilities and the number 0, which indicated that were 0 injuries that week. (They never had injuries). He typed the current date in the top of the spreadsheet, printed a copy, put it in a three-ring binder, and that was pretty much his whole, entire job. It was kind of sad. He took two lunch breaks a day. I would too, if that was my whole job. >> >> Over the next two weeks we visited dozens of Excel customers, and did not see anyone using Excel to actually perform what you would call âcalculations.â Almost all of them were using Excel because it was a convenient way to create a table." >> ---- >> >> This is interesting for me since I find myself in that category, mostly using Excel for cleaning and joining sets of data. My usual workflow is: >> 1. Importing several datasets - usually text files. >> 2. Manually splitting columns using several different separators . >> 3. Using VLOOKUP to match data across datasets. >> 4. Auto-Filtering on non-matching data. Observing where data should match but there are mistakes. >> 5. Manually massaging data using substring cut/paste formulas. Non-matching data usually group into several different patterns. >> 6. Iterate over steps 4 & 5. >> >> I'd love to be doing this using Pharo instead. Later in the year I hope to have time to have a go at this. >> >> cheers -ben >> >> > > > > Thanks Stef. I've just signed up to Smalltalkhub. How do I contribute to the project? The following has been added to the attached mcz. * Pharo 1.4 does not have LayoutFrame>>identity. * Allow external control of spreadsheet using SpreadsheetGridMorph>>cellStringAt:put: & cellStringAt: and added associated test. * Fixed error with SpreadsheetCell>>printOn: missing Integer>>printAsColumnRefOn: and added associated test. * To assist tracing/learning the code, added a few commented halt points. Worked around 'editedCell' instance variable losing its value while in debugger, which probably needs further review. cheers -ben

March 3, 2013

[Pharo-project] About replace:with/copyReplace:with:

by Benjamin

Hello guys, I just encounter these methods and got a bit disappointed First there is SequenceableCollection>>#replaceAll: oldObject with: newObject "Replace all occurences of oldObject with newObject" On String it something like: string := 'lapin'. string replaceAll: $a with: $b so now string is 'lbpin' Looking for a non destructive version, I looked at: #copyReplaceAll:with: SequenceableCollection>>#copyReplaceAll: oldSubstring with: newSubstring "Default is not to do token matching. See also String copyReplaceTokens:with:" So here it's not destructive, but 1) The argument names are wrong (or the method is not defined on the correct class) 2) why one take an element as argument and the other one a collection of elements ? Am I the only one disturb by this ? Ben

March 3, 2013

Re: [Pharo-project] about OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1

by Sven Van Caekenberghe

These important changes were made intentionally, so we need to find the rationale of the change. Like is the new behavior covered by new tests ? On 03 Mar 2013, at 09:45, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > > On Mar 3, 2013, at 9:42 AM, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > >> I could overwrite XMLOrderedList >> >> replaceFrom: aStartingIndex to: anEndingIndex with: aCollection startingAt: aReplacementStart >> >> >> collection >> replaceFrom: aStartingIndex >> to: anEndingIndex >> with: aCollection >> startingAt: aReplacementStart >> >> to make it grow? But I do not really know the impact on the XML library >> >>> self makeRoomFor: (anEndingIndex- self capacity). >> >> any idea? > > > In fact it will not work since makeRoomFor: and others have been removed and I do not have the time to dive in > OrderedCollection growing logic. > >> >> Stef >> >> >> >> >> On Mar 3, 2013, at 9:34 AM, StÃ©phane Ducasse <Stephane.Ducasse(a)inria.fr> wrote: >> >>> Hi guys >>> >>> in 1.2.1 >>> >>> OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 >>> gave >>> an OrderedCollection(6 7 8 9 10) >>> >>> >>> while in 1.4 and 2.0 >>> OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 >>> raised an error >>> >>> Do you have an idea how I can handle that? Because XMLObservableList and XMLOrderedList implements >>> replaceFrom: to: with: startingAt: >>> >>> because there is no self makeRoomFor: (stop - self capacity) invocation. >>> >>> >>> in 1.4>> >>> replaceFrom: start to: stop with: replacement startingAt: repStart >>> "This destructively replaces elements from start to stop in the receiver >>> starting at index, repStart, in the sequenceable collection, >>> replacementCollection. Answer the receiver. No range checks are >>> performed." >>> >>> | index repOff | >>> repOff := repStart - start. >>> index := start - 1. >>> [(index := index + 1) <= stop] >>> whileTrue: [self at: index put: (replacement at: repOff + index)] >>> >>> at: anInteger put: anObject >>> "Put anObject at element index anInteger. at:put: cannot be used to >>> append, front or back, to an ordered collection; it is used by a >>> knowledgeable client to replace an element." >>> self ensureBoundsFrom: anInteger to: anInteger. >>> ^array at: anInteger + firstIndex - 1 put: anObject >>> >>> >>> in 1.2.1 >>> >>> replaceFrom: start to: stop with: replacement startingAt: repStart >>> "An ordered collection is growable, so a call to this can make the collection grow." >>> self makeRoomFor: (stop - self capacity). >>> array >>> replaceFrom: start + firstIndex - 1 >>> to: stop + firstIndex - 1 >>> with: replacement >>> startingAt: repStart. >>> lastIndex := lastIndex max: stop + firstIndex - 1. >> >> > >

March 3, 2013

Re: [Pharo-project] about OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1

by stephane ducasse

On Mar 3, 2013, at 9:42 AM, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > I could overwrite XMLOrderedList > > replaceFrom: aStartingIndex to: anEndingIndex with: aCollection startingAt: aReplacementStart > > > collection > replaceFrom: aStartingIndex > to: anEndingIndex > with: aCollection > startingAt: aReplacementStart > > to make it grow? But I do not really know the impact on the XML library > >> self makeRoomFor: (anEndingIndex- self capacity). > > any idea? In fact it will not work since makeRoomFor: and others have been removed and I do not have the time to dive in OrderedCollection growing logic. > > Stef > > > > > On Mar 3, 2013, at 9:34 AM, StÃ©phane Ducasse <Stephane.Ducasse(a)inria.fr> wrote: > >> Hi guys >> >> in 1.2.1 >> >> OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 >> gave >> an OrderedCollection(6 7 8 9 10) >> >> >> while in 1.4 and 2.0 >> OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 >> raised an error >> >> Do you have an idea how I can handle that? Because XMLObservableList and XMLOrderedList implements >> replaceFrom: to: with: startingAt: >> >> because there is no self makeRoomFor: (stop - self capacity) invocation. >> >> >> in 1.4>> >> replaceFrom: start to: stop with: replacement startingAt: repStart >> "This destructively replaces elements from start to stop in the receiver >> starting at index, repStart, in the sequenceable collection, >> replacementCollection. Answer the receiver. No range checks are >> performed." >> >> | index repOff | >> repOff := repStart - start. >> index := start - 1. >> [(index := index + 1) <= stop] >> whileTrue: [self at: index put: (replacement at: repOff + index)] >> >> at: anInteger put: anObject >> "Put anObject at element index anInteger. at:put: cannot be used to >> append, front or back, to an ordered collection; it is used by a >> knowledgeable client to replace an element." >> self ensureBoundsFrom: anInteger to: anInteger. >> ^array at: anInteger + firstIndex - 1 put: anObject >> >> >> in 1.2.1 >> >> replaceFrom: start to: stop with: replacement startingAt: repStart >> "An ordered collection is growable, so a call to this can make the collection grow." >> self makeRoomFor: (stop - self capacity). >> array >> replaceFrom: start + firstIndex - 1 >> to: stop + firstIndex - 1 >> with: replacement >> startingAt: repStart. >> lastIndex := lastIndex max: stop + firstIndex - 1. > >

March 3, 2013

Re: [Pharo-project] about OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1

by stephane ducasse

I could overwrite XMLOrderedList replaceFrom: aStartingIndex to: anEndingIndex with: aCollection startingAt: aReplacementStart collection replaceFrom: aStartingIndex to: anEndingIndex with: aCollection startingAt: aReplacementStart to make it grow? But I do not really know the impact on the XML library > self makeRoomFor: (anEndingIndex- self capacity). any idea? Stef On Mar 3, 2013, at 9:34 AM, StÃ©phane Ducasse <Stephane.Ducasse(a)inria.fr> wrote: > Hi guys > > in 1.2.1 > > OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 > gave > an OrderedCollection(6 7 8 9 10) > > > while in 1.4 and 2.0 > OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 > raised an error > > Do you have an idea how I can handle that? Because XMLObservableList and XMLOrderedList implements > replaceFrom: to: with: startingAt: > > because there is no self makeRoomFor: (stop - self capacity) invocation. > > > in 1.4>> > replaceFrom: start to: stop with: replacement startingAt: repStart > "This destructively replaces elements from start to stop in the receiver > starting at index, repStart, in the sequenceable collection, > replacementCollection. Answer the receiver. No range checks are > performed." > > | index repOff | > repOff := repStart - start. > index := start - 1. > [(index := index + 1) <= stop] > whileTrue: [self at: index put: (replacement at: repOff + index)] > > at: anInteger put: anObject > "Put anObject at element index anInteger. at:put: cannot be used to > append, front or back, to an ordered collection; it is used by a > knowledgeable client to replace an element." > self ensureBoundsFrom: anInteger to: anInteger. > ^array at: anInteger + firstIndex - 1 put: anObject > > > in 1.2.1 > > replaceFrom: start to: stop with: replacement startingAt: repStart > "An ordered collection is growable, so a call to this can make the collection grow." > self makeRoomFor: (stop - self capacity). > array > replaceFrom: start + firstIndex - 1 > to: stop + firstIndex - 1 > with: replacement > startingAt: repStart. > lastIndex := lastIndex max: stop + firstIndex - 1.

March 3, 2013

[Pharo-project] about OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1

by StÃ©phane Ducasse

Hi guys in 1.2.1 OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 gave an OrderedCollection(6 7 8 9 10) while in 1.4 and 2.0 OrderedCollection new replaceFrom: 1 to: 5 with: #(6 7 8 9 10) startingAt: 1 raised an error Do you have an idea how I can handle that? Because XMLObservableList and XMLOrderedList implements replaceFrom: to: with: startingAt: because there is no self makeRoomFor: (stop - self capacity) invocation. in 1.4>> replaceFrom: start to: stop with: replacement startingAt: repStart "This destructively replaces elements from start to stop in the receiver starting at index, repStart, in the sequenceable collection, replacementCollection. Answer the receiver. No range checks are performed." | index repOff | repOff := repStart - start. index := start - 1. [(index := index + 1) <= stop] whileTrue: [self at: index put: (replacement at: repOff + index)] at: anInteger put: anObject "Put anObject at element index anInteger. at:put: cannot be used to append, front or back, to an ordered collection; it is used by a knowledgeable client to replace an element." self ensureBoundsFrom: anInteger to: anInteger. ^array at: anInteger + firstIndex - 1 put: anObject in 1.2.1 replaceFrom: start to: stop with: replacement startingAt: repStart "An ordered collection is growable, so a call to this can make the collection grow." self makeRoomFor: (stop - self capacity). array replaceFrom: start + firstIndex - 1 to: stop + firstIndex - 1 with: replacement startingAt: repStart. lastIndex := lastIndex max: stop + firstIndex - 1.

March 3, 2013

Re: [Pharo-project] XML-Support red tests

by StÃ©phane Ducasse

Apparently in 1.2.1 the following method works for 1 5 #(1 2 3 4 5) 1 replaceFrom: start to: stop with: replacement startingAt: repStart "An ordered collection is growable, so a call to this can make the collection grow." self makeRoomFor: (stop - self capacity). array replaceFrom: start + firstIndex - 1 to: stop + firstIndex - 1 with: replacement startingAt: repStart. lastIndex := lastIndex max: stop + firstIndex - 1. but not in 1.4, 2.0 where the code is replaceFrom: start to: stop with: replacement startingAt: repStart "This destructively replaces elements from start to stop in the receiver starting at index, repStart, in the sequenceable collection, replacementCollection. Answer the receiver. No range checks are performed." | index repOff | repOff := repStart - start. index := start - 1. [(index := index + 1) <= stop] whileTrue: [self at: index put: (replacement at: repOff + index)] at: anInteger put: anObject "Put anObject at element index anInteger. at:put: cannot be used to append, front or back, to an ordered collection; it is used by a knowledgeable client to replace an element." self ensureBoundsFrom: anInteger to: anInteger. ^array at: anInteger + firstIndex - 1 put: anObject ensureBoundsFrom: fromIndex to: toIndex (fromIndex < 1) ifTrue: [^self errorSubscriptBounds: fromIndex]. (toIndex + firstIndex - 1 > lastIndex) ifTrue: [^self errorSubscriptBounds: toIndex]. On Mar 3, 2013, at 9:10 AM, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > Apparently they were green in in 1.2.1. > This clearly shows why we need automated tools for that. > > Stef > > On Mar 2, 2013, at 10:16 PM, StÃ©phane Ducasse <Stephane.Ducasse(a)inria.fr> wrote: > >> Hi >> >> XML-support has two red tests in Pharo 1.4 and Pharo2.0. >> Does anybody know if they were one day green? >> >> I do not want to put on the CI server something red. >> I will check on 1.3 to see if worked. >> >> Stef >> > >

March 3, 2013