December 2013 - Pharo-dev - lists.pharo.org

[pharo-project/pharo-core] b6872a: 30617

by GitHub

Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: b6872a02e80a33aef212716a623945b5c135687c https://github.com/pharo-project/pharo-core/commit/b6872a02e80a33aef212716a… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2013-12-03 (Tue, 03 Dec 2013) Changed paths: A Komitter.package/KomitCacheRemote.class/README.md A Komitter.package/KomitCacheRemote.class/definition.st A Komitter.package/KomitHttpRemote.class/README.md A Komitter.package/KomitHttpRemote.class/definition.st R Komitter.package/KomitterUI.class/class/icons/historyIconData.st A Komitter.package/KomitterUI.class/class/icons/manageRemotesIcon.st A Komitter.package/KomitterUI.class/class/private-icons/historyIconData.st A Komitter.package/KomitterUI.class/class/private-icons/manageRemotesData.st M Komitter.package/KomitterUI.class/class/specs/defaultSpec.st M Komitter.package/KomitterUI.class/definition.st A Komitter.package/KomitterUI.class/instance/accessing/manageRemotes.st M Komitter.package/KomitterUI.class/instance/initialization/initializeWidgets.st A Komitter.package/KomitterUI.class/instance/private-icons/historyIcon.st A Komitter.package/KomitterUI.class/instance/private-icons/manageRemotesIcon.st A Komitter.package/KomitterUI.class/instance/private/openRemoteManager.st A Komitter.package/RemotesManager.class/README.md A Komitter.package/RemotesManager.class/class/icons/addRemoteIcon.st A Komitter.package/RemotesManager.class/class/icons/removeRemoteIcon.st A Komitter.package/RemotesManager.class/class/private-icons/addRemoteIconData.st A Komitter.package/RemotesManager.class/class/private-icons/removeRemoteIconData.st A Komitter.package/RemotesManager.class/class/specs/defaultSpec.st A Komitter.package/RemotesManager.class/definition.st A Komitter.package/RemotesManager.class/instance/accessing/addRemote.st A Komitter.package/RemotesManager.class/instance/accessing/packages.st A Komitter.package/RemotesManager.class/instance/accessing/remotes.st A Komitter.package/RemotesManager.class/instance/accessing/removeRemote.st A Komitter.package/RemotesManager.class/instance/initialization/buildRoots.st A Komitter.package/RemotesManager.class/instance/initialization/initialize.st A Komitter.package/RemotesManager.class/instance/initialization/initializePresenter.st A Komitter.package/RemotesManager.class/instance/initialization/initializeWidgets.st A Komitter.package/RemotesManager.class/instance/private-icons/addRemoteIcon.st A Komitter.package/RemotesManager.class/instance/private-icons/removeRemoteIcon.st A Komitter.package/RemotesManager.class/instance/private/addRepository.st A Komitter.package/RemotesManager.class/instance/private/change_forRemote_.st A Komitter.package/RemotesManager.class/instance/private/doIfNotSilent_.st A Komitter.package/RemotesManager.class/instance/private/newRepository.st A Komitter.package/RemotesManager.class/instance/private/removeRepository.st A Komitter.package/RemotesManager.class/instance/private/silentWhile_.st A Komitter.package/RemotesManager.class/instance/private/updateRemoteSelectionFrom_.st A Komitter.package/RemotesManager.class/instance/protocol/packages_.st A Komitter.package/RemotesManager.class/instance/protocol/title.st A Komitter.package/extension/MCCacheRepository/instance/isCache.st A Komitter.package/extension/MCCacheRepository/instance/koRemote.st M Komitter.package/extension/MCHttpRepository/instance/koRemote.st A Komitter.package/extension/MCRepository/instance/isCache.st M Morphic-Base.package/HaloMorph.class/instance/geometry/worldBoundsForMorph_.st R Morphic-Base.package/ListItemWrapper.class/instance/as yet unclassified/canBeDragged.st R Morphic-Base.package/ListItemWrapper.class/instance/as yet unclassified/handlesMouseOver_.st R Morphic-Base.package/ListItemWrapper.class/instance/as yet unclassified/hasEquivalentIn_.st R Morphic-Base.package/ListItemWrapper.class/instance/as yet unclassified/wantsDroppedObject_.st A Morphic-Base.package/ListItemWrapper.class/instance/testing/canBeDragged.st A Morphic-Base.package/ListItemWrapper.class/instance/testing/handlesMouseOver_.st A Morphic-Base.package/ListItemWrapper.class/instance/testing/hasEquivalentIn_.st A Morphic-Base.package/ListItemWrapper.class/instance/testing/wantsDroppedObject_.st M Morphic-Base.package/MenuMorph.class/instance/events/updateColor.st M Morphic-Base.package/MenuMorph.class/instance/keyboard control/selectMoreItem_.st M Morphic-Base.package/Paragraph.class/instance/editing/actionAttributesUnder_event_do_.st M Morphic-Base.package/SimpleHierarchicalListMorph.class/instance/search/basicKeyPressed_.st M Morphic-Base.package/SystemWindow.class/instance/menu actions/makeSecondTopmost.st M Morphic-Base.package/SystemWindow.class/instance/menu actions/sendToBack.st M Morphic-Base.package/SystemWindow.class/instance/panes/setUpdatablePanesFrom_.st M Morphic-Base.package/TextMorphForEditView.class/instance/event handling/mouseDown_.st M Morphic-Core.package/HandMorph.class/instance/halo handling/obtainHalo_.st M Morphic-Core.package/WorldState.class/instance/alarms/removeAlarm_for_.st A Morphic-Core.package/WorldState.class/instance/hands/is_overlappingDamagedAreaIn_.st M Morphic-Core.package/WorldState.class/instance/hands/selectHandsToDrawForDamage_.st M Nautilus.package/extension/TBehavior/instance/methodNamed_ifAbsent_.st M Polymorph-Widgets.package/LazyMorphListMorph.class/instance/as yet unclassified/userString.st M Polymorph-Widgets.package/ListDialogWindow.class/instance/button behavior/browseAction.st M Polymorph-Widgets.package/ListDialogWindow.class/instance/morphic protocol/searchAccept_.st M Polymorph-Widgets.package/PopupChoiceDialogWindow.class/instance/as yet unclassified/switchToNextColumn.st M Polymorph-Widgets.package/PopupChoiceDialogWindow.class/instance/as yet unclassified/switchToPreviousColumn.st M Polymorph-Widgets.package/TaskbarMorph.class/instance/as yet unclassified/updateTasks.st M Ring-Core-Kernel.package/extension/TBehavior/instance/methodsInProtocol_.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script272.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30617.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M SmartSuggestions.package/SugsMockContext.class/instance/api-context/selectedMethod.st M Spec-Inspector.package/EyeTreeInspector.class/instance/accessing/tree.st M Tests.package/TraitFileOutTest.class/instance/testing/testFileOutTrait.st M Traits.package/TBehavior.class/instance/accessing method dictionary/sourceCodeAt_.st M Traits.package/TBehavior.class/instance/accessing method dictionary/sourceCodeAt_ifAbsent_.st M Traits.package/TBehavior.class/instance/testing method dictionary/whichSelectorsAccess_.st M Traits.package/TBehavior.class/instance/testing method dictionary/whichSelectorsStoreInto_.st Log Message: ----------- 30617 12321 less senders of #methodDict https://pharo.fogbugz.com/f/cases/12321 12328 TreeInspector DNU https://pharo.fogbugz.com/f/cases/12328 12314 Add a view to link/add new remotes https://pharo.fogbugz.com/f/cases/12314 12325 HaloMorph >> #worldBoundsForMorph: calls deprecated outsetBy: https://pharo.fogbugz.com/f/cases/12325 12312 Cleanup on some Morphic methods https://pharo.fogbugz.com/f/cases/12312 http://files.pharo.org/image/30/30617.zip

Dec. 3, 2013

12259: FileSystem memory reads writesusing a binary stream by default

by Max Leske

Damien, Marcus this change breaks a lot of things in FileSystem-Git. I donât disagree with the idea that reading characters should be default (one could argue about itâ¦) but your change makes it IMPOSSIBLE to read bytes because unprintable characters are discarded! So if my ByteArray is a NULL terminated string, for instance, I can not check for the NULL termination anymore. Cheers, Max

Dec. 3, 2013

Re: [Pharo-dev] Unifying Testing Ideas

by Sean P. DeNigris

Attila Magyar wrote > did you want something like this? > mock a: anyArgument b: exactArgument1 c: exactArgument2 Exactly. Attila Magyar wrote > I rarely use / > does / > , as far as I remember it is not even documented. I don't know the code > behind the test but based on the names it looks like an adapter like > thing. (e.g. a thin wrapper above a 3rd party api with not too much logic > inside). If this is the case, normally I would test it with integration > tests, instead of mocks. Yes it's a wrapper. It should be tested with integration/acceptance tests. But, it wraps callouts to a C dynamic library via NB, so it's hard to test - i.e. crashes the VM, etc. Interactions with it deserve to be tested via unit tests (in general I drop down to unit tests inside a failing integration/acceptance test anyway). Anyway, does: is very important. Stubbing (can & (does: | answers:)) and mocking (should) seemed kind of like a nature-vs-nurture debate for a while, but there is a lot of overlap. Sometimes you need one, sometimes the other, and sometimes both (as shown in my example, although I kept thinking that in practice I'd probably write a test double by hand to be reused in other places). In fact, #does: and #answers: could easily be merged, using double dispatch to pass either a block or a value. Unrelatedly, it would be slightly clearer to rename "anything" to "anyMessage". "anything" makes it seem like it could be passed as an argument, which doesn't work. Or alternately, you could probably rename AnyMessage to Anything and combine its API with that of AnyArgument if they don't clash... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Unifying-Testing-Ideas-tp4726787p4727086.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Dec. 3, 2013

Re: [Pharo-dev] Versionner Impressions

by Sean P. DeNigris

Stephan Eggermont wrote > Didi you compare it to Metaceller in Moose? No I don't know about that one (except that it exists)... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Versionner-Impressions-tp4726902p4727082.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Dec. 3, 2013

Re: [Pharo-dev] explore is broken

by Marcus Denker

On 03 Dec 2013, at 16:37, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 03 Dec 2013, at 16:31, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > >> It works in 30615 but is broken in 30616. >> >> No one knows about it yet I guess because 30616 is from today. >> >> The bug is from the one of the 30616 change. Can someone with a good Spec knowledge have a look at it ? >> > > It seems to work when removing the âcontentsâ send in the displayBlock: block in the method #tree of EyeTreeInspector. > > I will commit a fixâ¦ > https://pharo.fogbugz.com/f/cases/12328/TreeInspector-DNU will be in the next update. Marcus

Dec. 3, 2013

Re: [Pharo-dev] Versionner Impressions

by Sean P. DeNigris

Christophe Demarey wrote > Can you explain me your use case? Sure... I installed Phexample via the Configuration Browser, by switching to MetaRepoFor20. The config loaded Phexample from its home repository, sthub/Phexample/Phexample. When I added it as a dependent project, my choices IIRC were the package cache and MetaRepoFor20. I wanted to use the home repo but the widget only allowed me to choose from those two options. While we're on the subject, repo creation is complicated enough to warrant a nice widget everywhere in Versionner (and maybe port it over to Monticello Browser, whcih is not much better). IMHO, it needs to offer: - likely repos, like was done above e.g. repos associated to the package in question - all repos known to image - create new repo Christophe Demarey wrote > Do you mean for a new project? Yes, maybe the developer has already done > some commits. > I will add that. Yes, FMOD was one package, so I didn't make a config. Then I wrote tests in their own package... Thanks again :) ----- Cheers, Sean -- View this message in context: http://forum.world.st/Versionner-Impressions-tp4726902p4727072.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Dec. 3, 2013

Re: [Pharo-dev] explore is broken

by Marcus Denker

On 03 Dec 2013, at 16:31, ClÃ©ment Bera <bera.clement(a)gmail.com> wrote: > It works in 30615 but is broken in 30616. > > No one knows about it yet I guess because 30616 is from today. > > The bug is from the one of the 30616 change. Can someone with a good Spec knowledge have a look at it ? > It seems to work when removing the âcontentsâ send in the displayBlock: block in the method #tree of EyeTreeInspector. I will commit a fixâ¦ Marcus

Dec. 3, 2013

Re: [Pharo-dev] explore is broken

by ClÃ©ment Bera

It works in 30615 but is broken in 30616. No one knows about it yet I guess because 30616 is from today. The bug is from the one of the 30616 change. Can someone with a good Spec knowledge have a look at it ? 2013/12/3 Oscar Nierstrasz @ gmail <oscar.nierstrasz(a)gmail.com> > > There is something wrong with the EyeTreeInspector in the latest Pharo > image: > > Smalltalk explore > > brings up the debugger. > > Ditto if you inspect and manually select the EyeTreeInspector. > > I could not find any issue in the issue tracker about this. Does anyone > know about it? > > Oscar >

Dec. 3, 2013

explore is broken

by Oscar Nierstrasz ＠ gmail

There is something wrong with the EyeTreeInspector in the latest Pharo image: Smalltalk explore brings up the debugger. Ditto if you inspect and manually select the EyeTreeInspector. I could not find any issue in the issue tracker about this. Does anyone know about it? Oscar

Dec. 3, 2013

Smalltalkhub ci image

by Stephan Eggermont

The smalltalkhub build has been red for quite some time now. If I want to run a hub, should I take the latest build? Stephan

Dec. 3, 2013