November 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Refactoring on more than one method

by Nicolas Cellier

Thanks for sharing positive feedback, and letting us know about new features we may have missed. This is important too. 2013/11/10 Alexandre Bergel <alexandre.bergel(a)me.com> > Hi! > > Just to share my happiness. > > I've just tried in Nautilus: > 1 - select several methods in a class (keep the Cmd key pressed to do so) > 2 - applying the pulling up refactoring > 3 - all the methods I have selected are pulled up, in the superclass > > It works as a charm. Really cool! I have been waiting for this for many > years... > > Cheers, > Alexandre > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > >

Nov. 10, 2013

Re: [Pharo-dev] [Vm-dev] Frequent SegFaults in PharoVM with Pharo 3.0

by Max Leske

On 07.11.2013, at 08:20, Max Leske <maxleske(a)gmail.com> wrote: > On 07.11.2013, at 00:27, vm-dev-request(a)lists.squeakfoundation.org wrote: > >> Date: Wed, 6 Nov 2013 19:23:47 -0200 >> From: Mariano Martinez Peck <marianopeck(a)gmail.com> >> Subject: Re: [Vm-dev] Frequent SegFaults in PharoVM with Pharo 3.0 >> To: Squeak Virtual Machine Development Discussion >> <vm-dev(a)lists.squeakfoundation.org> >> Message-ID: >> <CAA+-=mWDtHGQWSHx-m4u37Kj0UAMx=UG=qUCz+wMvgDT8BaQZQ(a)mail.gmail.com> >> Content-Type: text/plain; charset="windows-1252" >> >> Max, did you try with Eliot VMs besides the pharo ones? > > No, I havenât. I can try (though only on my machine), but if I canât reproduce the SegFault that doesnât mean much unfortunately. It took me 10 to 20 tries with the PharoVM tooâ¦ > > Iâll try anyway and let you know what I find. > > Max I just gave CogVM and NBCog a shot. Unfortunately I canât use the images because theyâve been built with PharoVM and hang after load. At least on the Pharo CI there are no jobs that create Cog / NBCog images. So no luck with different VMs. Max > >> >> Thanks >> >> >> On Wed, Nov 6, 2013 at 6:04 PM, Max Leske <maxleske(a)gmail.com> wrote: >> >>> >>> Hi >>> >>> Weâve been encountering frequent SegFaults when running the Fuel tests on >>> the Pharo CI (https://ci.inria.fr/pharo-contribution/job/Fuel/) Since >>> today Iâve also been able to reproduce the SegFaults on my MacBook Pro (OS >>> X 10.9) too. We have not been able to determine the cause of the SegFault >>> but we can produce SegFaults often, although not reliable (more reliable on >>> the CI). >>> >>> The CI uses the stable VM: >>> http://files.pharo.org/vm/pharo/linux/stable.zip >>> I use a newer version from October on my machine: >>> http://files.pharo.org/vm/pharo/mac/273.zip >>> >>> Iâve attached all the dumps of the crashes I was able to produce on my >>> machine, together with Appleâs crash logs. >>> >>> Iâve been able to deduce the following: >>> - garbage collection seems to be a trigger for the SegFault. When one of >>> the methods FLMethodContextSerialization>>testFuelShouldIgnoreFuel and >>> FLMethodContextSerialization>>testMethodContextWithNilPc contain the line >>> â3 timesRepeat: [Smalltalk garbageCollect]â the SegFault appears nearly >>> always (on CI). When I remove the line the builds run through. >>> - Not all methods with the garbage collect line trigger a SegFault (I >>> could only identify those two) >>> - the garbage collect line itself suffices as a trigger in the mentioned >>> methods. >>> - The number of tests (amount of used memory?) seems to influence the >>> appearence of the SegFault (e.g. loading "DevelopmentGroup" seems to >>> trigger it more often than loading âBenchmarksâ) >>> - the SegFault always appears after the tests with the garbage collect >>> line have been run, never before >>> - the VM canât write the crash.dmp every time >>> >>> Since the SegFaults are so random I cannot give you an image to reproduce >>> the problem. Iâve had the best results using a fresh 3.0 image ( >>> http://files.pharo.org/image/30/30549.zip) and then evaluating the >>> following in a workspace: >>> >>> Gofer it >>> smalltalkhubUser: 'Pharo' project: 'Fuel'; >>> package: 'ConfigurationOfFuel'; >>> load. >>> >>> ((Smalltalk at: #ConfigurationOfFuel) project version: #bleedingEdge) >>> load: 'DevelopmentGroup'. >>> >>> HDTestReport >>> runClasses: (TestCase allSubclasses select: [ :class | class name >>> beginsWith: 'FL']) >>> named: âfoo' >>> >>> If it doesnât work, try using the TestRunner manually. Select the default >>> Fuel tests (alphabetically at F) and the additional Fuel tests (at the >>> bottom of the list) and run them. >>> >>> If anybody has any clue about what could be going on Iâd really appreciate >>> any input. Iâll happily provide more information if I can. >>> >>> Thanks for reading :) >>> Max >>> >>> >>> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com >

Nov. 10, 2013

Re: [Pharo-dev] Morph Events

by kilon alios

Yeah my mistake I should have googled it first. It shown me the chapter you are referring to and Stephane documentation on Morphic. No idea why it did not cross my mind to google it first or why I forgot that PBE has a chapter on this. Thanks for help. On Sun, Nov 10, 2013 at 7:32 PM, Hilaire Fernandes < hilaire.fernandes(a)gmail.com> wrote: > Hello, > > Did you take a look at the Pharo By Example 1 book? > There is a chapter about Morph discussing a bit Mouse event > > Hilaire > > Le 10/11/2013 17:36, kilon alios a Ã©crit : > > I would like to understand how morph events work. I want to able to > > detect when a mouse was clicked inside my morph and also to handle > > keyboard events. Generally I want to be able to handle all events while > > the mouse cursor is above my morph. How I do that ? > > > > for example I have found Morph>>handlesMouseDown: evt > > > > but I am not sure what evt represents here. > > > > Whats the role of HandMorph in all this ? > > > -- > Dr. Geo http://drgeo.eu > > >

Nov. 10, 2013

Re: [Pharo-dev] Morph Events

by Hilaire Fernandes

Hello, Did you take a look at the Pharo By Example 1 book? There is a chapter about Morph discussing a bit Mouse event Hilaire Le 10/11/2013 17:36, kilon alios a Ã©crit : > I would like to understand how morph events work. I want to able to > detect when a mouse was clicked inside my morph and also to handle > keyboard events. Generally I want to be able to handle all events while > the mouse cursor is above my morph. How I do that ? > > for example I have found Morph>>handlesMouseDown: evt > > but I am not sure what evt represents here. > > Whats the role of HandMorph in all this ? -- Dr. Geo http://drgeo.eu

Nov. 10, 2013

Morph Events

by kilon alios

I would like to understand how morph events work. I want to able to detect when a mouse was clicked inside my morph and also to handle keyboard events. Generally I want to be able to handle all events while the mouse cursor is above my morph. How I do that ? for example I have found Morph>>handlesMouseDown: evt but I am not sure what evt represents here. Whats the role of HandMorph in all this ?

Nov. 10, 2013

Re: [Pharo-dev] [Pharo-bugtracker] FogBugz (Case [Issue]2486) File System - Linux VM: Umlaute Ã¤Ã¶Ã etc in in file/directory names: UTF8 unicode problem?

by Camillo Bruni

> That would seem to be a lot of additional work for the monkey, which might not be a problem if the set of Cases is small or CPU resources are high. > > Perhaps the process could be amended so the monkey operates in two stages. > 1. In taking the status from "Fix review needed" to "Fix Reviewed by the Monkey" - the monkey runs once and does not run again. > 2. When a human comes along and changes the status to "Fix to include", the monkey runs again, and also for each image update until integrated. The status would not change from "Fix to include". > > Optionally Step 2 could also... > 2a. In consideration of how several fixes are usually integrated in one image step, the monkey could consecutively load several Fixes on top of the previous image step, to check for incompatibilities between Fixes, and advise the human integrator of a known good order of integration; OR... > 2b. A successful monkey test of "Fix to Include" automatically kicks off a CI run on that Fix. So that you end up with one Fix per image step. Probably this doubles up on the CI test run, but should ensure the CI never goes red; OR... > 2c. A combination of 2a & 2b. The monkey loads several "Fix to Include" Fixes until there is a problem, and copies all the good ones to kick off a CI run. > > So I know that would require some effort, but just food for thought. I'd be interested in helping do this. The noise is some side-effect of the current somewhat limited situation. In the ideal case the monkey would just attach a new tag for each new image version if the validation report did not change. But for that you need to have your own complete service which keeps track of the previous validations. As you can imagine this will take some time and effort ;) For now I think we stick with the current approach which is more noisy but safer. Everybody is of course invited to improve the situation: http://smalltalkhub.com/#!/~Pharo/ci https://ci.inria.fr/pharo-contribution/job/CI/ http://smalltalkhub.com/#!/~PharoExtras/ImageWorker https://ci.inria.fr/pharo-contribution/job/ImageWorker/

Nov. 10, 2013

Refactoring on more than one method

by Alexandre Bergel

Hi! Just to share my happiness. I've just tried in Nautilus: 1 - select several methods in a class (keep the Cmd key pressed to do so) 2 - applying the pulling up refactoring 3 - all the methods I have selected are pulled up, in the superclass It works as a charm. Really cool! I have been waiting for this for many years... Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Nov. 10, 2013

Re: [Pharo-dev] Spec & TableLayout

by btc＠openinworld.com

Nov. 10, 2013

Re: [Pharo-dev] Writing jpeg files to disk

by StÃ©phane Ducasse

On Nov 9, 2013, at 7:52 PM, Usman Bhatti <usman.bhatti(a)gmail.com> wrote: > > > > On Sat, Nov 9, 2013 at 2:40 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi usman > > I'm wondering if the change we did is good. > Too late right now to think. > > So far the change is not integrated so we can still think over it. > > I'm wondering if this is important to know that we are deleting a non existing file. > > Yes why? Usman my question was if my change made sense. May be nobody care that when we are deleting a file it should exist. Else I understand your point. In any case open a bug entry. Stef > it is because now Pharo throws an exception if we do that. Try this in the latest 3.0 image: > Display writeJPEGfileNamed: 'display.jpeg' progressive: true > > I proposed a solution by changing delete to ensureDelete but the change was rejected because it is advised to backup the deleted file before replacing it. However, the other image types are overwritten without any error checking. For example ImageReadWrite: > > putForm: aForm onFileNamed: fileName > "Store the given form on a file of the given name." > | writer | > writer := self on: (FileStream newFileNamed: fileName) binary. > Cursor write showWhile: [ writer nextPutImage: aForm ]. > writer close > > So, we can retain the same policy for PluginBasedJPEGReadWriter. > > usman > > > Stef > > > Hello, > > > > Due to the changes in Pharo 3.0, I cannot write jpeg files on the disk. This happens because when writing a jpeg file, we delete any precedent version of the file to be exported. However, now DiskStore>>delete: throws an exception when the file to be deleted is not present > > > > delete: path > > | pathString encodedPathString | > > > > (self exists: path) > > ifFalse: [ ^ FileDoesNotExist signalWith: path ]. > > > > ... > > > > Hence, we need to fix PluginBasedJPEGReadWriter>>putForm: quality: progressiveJPEG: onFileNamed: to not delete files not present. > > > > To reproduce the problem: > > Display writeJPEGfileNamed: 'display.jpeg' progressive: true > > > > If confirmed, I'll open a bug report and propose a slice because correction is quite simple ;) > > > > > > regards, > > Usman > > >

Nov. 10, 2013

DateAndTime vs TimeStamp

by Sven Van Caekenberghe

Related to https://pharo.fogbugz.com/f/cases/2919/should-remove-TimeStamp Independent from the actual name (TimeStamp/Timestamp is shorter), it is confusing to have the two. TimeStamp inherits from DataAndTime and adds only the following: (1) its #printOn: is different (2) its class side #readFrom: matches this (3) its nanoseconds get set to zero on creation (4) it has some additional API ([plus|minus][Days|Seconds]:) (5) it has some alias methods (date, time) TimeStamp seems to be primarily used to deal with method timestamps. [A] Now, (1) and (2) for its primary usage [A] could easily be moved to DateAndTime. (3) is questionable and could be solved by #rounded, if really needed. (4) is plain silly (5) is dangerous, the originals are better So instead of moving API from TimeStamp to its superclass DataAndTime, I would remove it ;-) Comments ? Sven PS: Zinc did use TimeStamp in some places, but replacing all occurrences by DateAndTime had no effect, they are equivalent.

Nov. 10, 2013