October 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Bisect with Pharo Launcher / Git

by Bruni camillo

This is exactly the reason I started exporting everything to git and archiving all the images in an accessible way :-P. it would be definitely nice to have this more automated. On Oct 22, 2013 11:50 AM, <btc(a)openinworld.com> wrote: > I am probably not working on it anytime soon, but btw I logged the idea > last week of enhancing Pharo Launcher with some kind of support for bisect > operations. > https://pharo.fogbugz.com/**default.asp?11927<https://pharo.fogbugz.com/default.asp?11927> > . > > cheers -ben > > Goubier Thierry wrote: > >> Hi all, >> >> I want to thank the combination of Pharo Launcher and the pharo-core >> github repo for earching a specific bug in Pharo 3, linked to >> https://pharo.fogbugz.com/f/**cases/11949/<https://pharo.fogbugz.com/f/cases/11949/>: >> >> I noticed that the bug was introduced between 30450 and 30490. With the >> Pharo launcher, I then went through a ad-hoc bisecting (loading the right >> image version / launching it / testing) : >> >> Start point is 30450 No bug, 30490 bug. >> >> 30470 No bug >> 30480 No >> 30485 Bug >> 30483 No >> 30484 Bug >> >> Then I tried to view the changes in Morphic for the bug out of the >> Monticello tools... Didn't work :( It's hard to guess which versions have >> changed and when in relation to the image version number. >> >> So I went to github/pharo-core and I searched for the relevant commit: >> >> https://github.com/pharo-**project/pharo-core/commit/** >> 5034553d07f342a5a0e512757a04e6**afec677d96<https://github.com/pharo-project/pharo-core/commit/5034553d07f342a5a0e51275…> >> >> And a file that could be relevant: >> >> https://github.com/pharo-**project/pharo-core/commit/** >> 5034553d07f342a5a0e512757a04e6**afec677d96#diff-** >> 8582177f7215f3cef75a8ce52f5ef0**12<https://github.com/pharo-project/pharo-core/commit/5034553d07f342a5a0e51275…> >> >> And there I could see things in relation with MorpTreeMorph... Bug solved >> shortly thereafter. Damn Rectangle stuff :( >> >> Thanks again >> > > >

Oct. 22, 2013

Re: [Pharo-dev] The new fogbugz mails look nice :)

by Benjamin

that would be cool ;) Ben On Oct 22, 2013, at 3:10 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > One would almost start fixing things, just to see them ;-) > > On 22 Oct 2013, at 15:08, Benjamin <benjamin.vanryseghem.pharo(a)gmail.com> wrote: > >> Just to say :P >> >> Ben >> > >

Oct. 22, 2013

Re: [Pharo-dev] The new fogbugz mails look nice :)

by Sven Van Caekenberghe

One would almost start fixing things, just to see them ;-) On 22 Oct 2013, at 15:08, Benjamin <benjamin.vanryseghem.pharo(a)gmail.com> wrote: > Just to say :P > > Ben >

Oct. 22, 2013

The new fogbugz mails look nice :)

by Benjamin

Just to say :P Ben

Oct. 22, 2013

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30514 Home: https://github.com/pharo-project/pharo-core

Oct. 22, 2013

[pharo-project/pharo-core] 25056e: 30514

by GitHub

Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: 25056e11c4758d0413fb73aa0febf2465002bea4 https://github.com/pharo-project/pharo-core/commit/25056e11c4758d0413fb73aa… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2013-10-22 (Tue, 22 Oct 2013) Changed paths: A AST-Core.package/RBMessageNode.class/instance/accessing/debugHighlightStart.st A AST-Core.package/RBMessageNode.class/instance/accessing/debugHighlightStop.st A AST-Core.package/RBProgramNode.class/instance/accessing/debugHighlightRange.st A AST-Core.package/RBProgramNode.class/instance/accessing/debugHighlightStart.st A AST-Core.package/RBProgramNode.class/instance/accessing/debugHighlightStop.st A AST-Core.package/RBReturnNode.class/instance/converting/asSequenceNode.st A AST-Core.package/RBSequenceNode.class/instance/converting/asSequenceNode.st A AST-Core.package/RBValueNode.class/instance/converting/asSequenceNode.st A Deprecated30.package/extension/CompiledMethod/instance/parserClass.st A Deprecated30.package/extension/TBehavior/instance/parserClass.st A Deprecated30.package/extension/UndefinedObject/instance/parserClass.st M GroupManagerUI.package/GroupCreatorTreeModel.class/instance/t - accessing/selection.st M Morphic-Base.package/MorphTreeAnnounce.class/definition.st A Morphic-Base.package/MorphTreeChangeRequest.class/README.md A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/chunkSize_.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/collapseAll.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/collapseNodePath_.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/deselectAll.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/enabled.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/expandAll.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/expandAllFromNode_.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/expandItemPath_.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/expandNodePath_.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/expandRoots.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/pageSize_.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/selectAll.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/selectItems_.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/updateList.st A Morphic-Base.package/MorphTreeChangeRequest.class/class/instance creation/updateSelectionFromModel.st A Morphic-Base.package/MorphTreeChangeRequest.class/definition.st A Morphic-Base.package/MorphTreeChangeRequest.class/instance/accessing/action_.st A Morphic-Base.package/MorphTreeChangeRequest.class/instance/accessing/arguments.st A Morphic-Base.package/MorphTreeChangeRequest.class/instance/accessing/arguments_.st A Morphic-Base.package/MorphTreeChangeRequest.class/instance/accessing/change_.st R Morphic-Base.package/MorphTreeModel.class/instance/accessing/collapseAll.st A Morphic-Base.package/MorphTreeModel.class/instance/accessing/defaultChunkSize.st A Morphic-Base.package/MorphTreeModel.class/instance/accessing/defaultPageSize.st M Morphic-Base.package/MorphTreeModel.class/instance/accessing/enabled_.st R Morphic-Base.package/MorphTreeModel.class/instance/accessing/expandAll.st R Morphic-Base.package/MorphTreeModel.class/instance/accessing/expandAllFromNode_.st R Morphic-Base.package/MorphTreeModel.class/instance/accessing/selectItems_.st R Morphic-Base.package/MorphTreeModel.class/instance/accessing/selection_.st M Morphic-Base.package/MorphTreeModel.class/instance/announcing/onSelectionChangeSend_to_.st A Morphic-Base.package/MorphTreeModel.class/instance/announcing/requestView_.st A Morphic-Base.package/MorphTreeModel.class/instance/expanding-collapsing/collapseAll.st A Morphic-Base.package/MorphTreeModel.class/instance/expanding-collapsing/collapseNodePath_.st A Morphic-Base.package/MorphTreeModel.class/instance/expanding-collapsing/expandAll.st A Morphic-Base.package/MorphTreeModel.class/instance/expanding-collapsing/expandAllFromNode_.st A Morphic-Base.package/MorphTreeModel.class/instance/expanding-collapsing/expandItemPath_.st A Morphic-Base.package/MorphTreeModel.class/instance/expanding-collapsing/expandNodePath_.st A Morphic-Base.package/MorphTreeModel.class/instance/expanding-collapsing/expandRoots.st M Morphic-Base.package/MorphTreeModel.class/instance/selecting/deselectAll.st M Morphic-Base.package/MorphTreeModel.class/instance/selecting/selectAll.st A Morphic-Base.package/MorphTreeModel.class/instance/selecting/selectItems_.st M Morphic-Base.package/MorphTreeModel.class/instance/selecting/selectionChanged.st A Morphic-Base.package/MorphTreeModel.class/instance/selecting/selection_.st R Morphic-Base.package/MorphTreeModel.class/instance/t - accessing/defaultChunkSize.st R Morphic-Base.package/MorphTreeModel.class/instance/t - accessing/defaultPageSize.st A Morphic-Base.package/MorphTreeModel.class/instance/updating/updateList.st A Morphic-Base.package/MorphTreeMorph.class/instance/accessing/model_.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/changeListRequest_.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/changeRequest_.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/changeSelectionRequest_.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/collapseRequest_.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/nodeCollapseRequest_.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/nodeExpandRequest_.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/registerRequestHandlers.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/selectItemsRequest_.st A Morphic-Base.package/MorphTreeMorph.class/instance/announce requests/selectItems_.st A Morphic-Base.package/MorphTreeMorph.class/instance/as yet unclassified/setSelectedMorph_.st A Morphic-Base.package/MorphTreeMorph.class/instance/expanding-collapsing/collapseNodePath_.st M Morphic-Base.package/MorphTreeMorph.class/instance/expanding-collapsing/expandAll.st M Morphic-Base.package/MorphTreeMorph.class/instance/expanding-collapsing/expandAllFromNode_.st A Morphic-Base.package/MorphTreeMorph.class/instance/expanding-collapsing/expandItemPath_.st A Morphic-Base.package/MorphTreeMorph.class/instance/expanding-collapsing/expandNodePath_.st A Morphic-Base.package/MorphTreeMorph.class/instance/updating/updateSelectionFromModel.st M Morphic-Base.package/MorphTreeMorph.class/instance/updating/update_.st A Morphic-Base.package/MorphTreeNodeMorph.class/instance/expanding-collapsing/collapseNodePath_.st A Morphic-Base.package/MorphTreeNodeMorph.class/instance/expanding-collapsing/expandItemPath_.st A Morphic-Base.package/MorphTreeNodeMorph.class/instance/expanding-collapsing/openNodePath_.st M Morphic-Base.package/MorphTreeSelectionChanged.class/definition.st M Morphic-Base.package/PaginatedMorphTreeModel.class/class/examples/testExample.st M Morphic-Base.package/PaginatedMorphTreeModel.class/instance/accessing/chunkSize_.st M Morphic-Base.package/PaginatedMorphTreeModel.class/instance/accessing/pageSize_.st A Morphic-Base.package/PaginatedMorphTreeMorph.class/instance/expanding-collapsing/expandItemPath_.st R Morphic-Base.package/PaginatedMorphTreeMorph.class/instance/updating/update_.st M Morphic-Examples.package/ClassTreeExample.class/instance/user interface/treeMorph.st M Morphic-Examples.package/SimplestClassListExample.class/instance/as yet unclassified/rootItemsTest.st M Morphic-Examples.package/SimplestPaginatedClassListExample.class/instance/accessing/rootItems.st R MorphicTests.package/PaginatedMorphTreeMorphTests.class/instance/tests/testChunkPager.st M MorphicTests.package/PaginatedMorphTreeMorphTests.class/instance/tests/testPager.st M NautilusCommon.package/NautilusPluginManagerTree.class/instance/t - accessing/update.st R OpalCompiler-Core.package/extension/CompiledMethod/instance/parserClass.st R OpalCompiler-Core.package/extension/RBMessageNode/instance/debugHighlightStart.st R OpalCompiler-Core.package/extension/RBMessageNode/instance/debugHighlightStop.st R OpalCompiler-Core.package/extension/RBProgramNode/instance/debugHighlightRange.st R OpalCompiler-Core.package/extension/RBProgramNode/instance/debugHighlightStart.st R OpalCompiler-Core.package/extension/RBProgramNode/instance/debugHighlightStop.st R OpalCompiler-Core.package/extension/RBReturnNode/instance/asSequenceNode.st R OpalCompiler-Core.package/extension/RBSequenceNode/instance/asSequenceNode.st R OpalCompiler-Core.package/extension/RBValueNode/instance/asSequenceNode.st R OpalCompiler-Core.package/extension/TBehavior/instance/parserClass.st R OpalCompiler-Core.package/extension/UndefinedObject/instance/parserClass.st M RecentSubmissions.package/MessageListBrowser.class/instance/display/updateTree.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script169.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30514.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-MorphicAdapters.package/MorphicTreeAdapter.class/instance/spec protocol/expandAll.st M System-Settings.package/SettingBrowser.class/instance/updating/closePathFrom_.st M System-Settings.package/SettingBrowser.class/instance/updating/openPathFrom_.st M System-Settings.package/SettingBrowser.class/instance/updating/updateList.st R Tools.package/FinderUI.class/instance/buttons behavior/updateList.st M Tools.package/TimeProfiler.class/instance/UI specific/reportOtherProcesses_.st M Tools.package/TimeProfiler.class/instance/UI specific/showLeavesOnly_.st M Tools.package/TimeProfiler.class/instance/accessing/threshold_.st M Tools.package/TimeProfiler.class/instance/actions/blockCode_notifying_.st M Tools.package/TimeProfiler.class/instance/public opening/openPathFrom_.st Log Message: ----------- 30514 11969 Move some methods from Opal to AST https://pharo.fogbugz.com/f/cases/11969 11954 MorphTreeMorph selection cleanup https://pharo.fogbugz.com/f/cases/11954 http://files.pharo.org/image/30/30514.zip

Oct. 22, 2013

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30513 Home: https://github.com/pharo-project/pharo-core

Oct. 22, 2013

[pharo-project/pharo-core] a6d9c1: 30513

by GitHub

Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: a6d9c1e621abd742e679f61050e6b0dba0303884 https://github.com/pharo-project/pharo-core/commit/a6d9c1e621abd742e679f610… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2013-10-22 (Tue, 22 Oct 2013) Changed paths: R Nautilus.package/extension/Behavior/instance/realClass.st R Nautilus.package/extension/TraitBehavior/instance/realClass.st R RPackage-Tests.package/RPackageSetTest.class/README.md R RPackage-Tests.package/RPackageSetTest.class/definition.st R RPackage-Tests.package/RPackageSetTest.class/instance/private/comparePackageSet_withPackageInfo_.st R RPackage-Tests.package/RPackageSetTest.class/instance/private/equalElementsBetween_and_.st R RPackage-Tests.package/RPackageSetTest.class/instance/tests/testPolymorphicWithPackageInfo.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script168.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30513.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 30513 11965 Remove RPackageSetTest https://pharo.fogbugz.com/f/cases/11965 11966 failing tests testLocalMethodsOfTheClassShouldNotBeRepeatedInItsTraits and testBehaviorRespectsPolymorphismWithTraitBehavior https://pharo.fogbugz.com/f/cases/11966 11967 failing test: testUnknownProcesses https://pharo.fogbugz.com/f/cases/11967 http://files.pharo.org/image/30/30513.zip

Oct. 22, 2013

Re: [Pharo-dev] Use #shouldnt:raise: only with specific errors, or evaluate the given expression directly

by Igor Stasenko

On 22 October 2013 10:02, Camillo Bruni <camillobruni(a)gmail.com> wrote: > On 2013-10-22, at 09:46, Johan Brichau <johan(a)inceptive.be> wrote: > > In Seaside, there are a couple of tests that now fail because of this > change. > > > > Although I agree it's good practice to use specific error classes in > such assertions, the tests that are failing in Seaside use the Error class > because they are written to be cross-platform. Different subclasses of > Error will be thrown on different platforms. Moreover, the use of the > assertion specifically documents that this test is testing for any errors > being thrown. Removing the assertion means we need to write it down in > comments, which is less explicit imho. > > That's not true, that is the default behavior that you test for not Errors. > I mean every code that is run must work and testing that it does not raise > and Error is duplicated efforts. +1 'shouldn't raise' is bogus and as you said, it is default expectation for any code you run that it doesn't throws any errors. (that's why exceptions called so and that's why error is exception). i can understand why i would want to use 'should raise' to check that my code throws appropriate error when i using wrong data etc.. but not this one. > As I said, checking for any other error makes > somehow sense, but not for Error itself. Because that basically means that > you > ignore what the test does since you are not specific at all. The test > framework > takes already care of that part, if you have an error the test fails. I > think > that is the goal. I do not understand why you would have to explain this > to the > user of the tests, since for him the result does not change. Yes it is red > instead of yellow, but does that matter? I mean you just transformed at > will an > error into an assertion failure, to me this sounds very bogus. Just > because you > transform the error to an assertion, you did not anticipated anything, > since you > cannot be sure at all where the error happened, since you do not test for > an > explicit error. On the other hand if you call a method that is very small > to check > if it really works, you know which errors are signaled and you test > explicitly > for those. > > I think I can come up with a tree transformation rule to go from > #shouldnt:raise:Error > to a refactored version that even includes a comment. > > > I'm not in favour of enforcing best practices this way. It just yields > more workarounds in the end. > > I also do not understand the problem with debugging the test. If the > test fails, you step through it and will discover the cause. > > But if you just use the expression directly, the debugger pops up in the > place where > the error was signaled. Not somewhere in deep in the assertion framework. > Furthermore > if you run the test under jenkins you will get no reasonable feedback (yes > this should > be changed as well). Just try to debug the following statement in a test: > > self shouldnt: [ 0/0 ] raise: Error > > vs. > 0/0. > > > Of course we can change it back at some point, but I haven't heard a solid > reason in favor of shouldnt:raise:Error. > > > Johan > > > > On 22 Oct 2013, at 00:26, Camillo Bruni <camillobruni(a)gmail.com> wrote: > > > >> > >> On 2013-10-22, at 00:20, Alexandre Bergel <alexandre.bergel(a)me.com> > wrote: > >> > >>> Instead of using shouldnt:raise:, you can simply remove the assertion, > as in: > >>> > >>> -=-=-=-=-=-=-=-=-= > >>> testNoErrorWhenDrawing > >>> self shouldnt: [ view raw drawOn: tracingCanvas ] raise: Error > >>> -=-=-=-=-=-=-=-=-= > >>> > >>> || > >>> V > >>> > >>> -=-=-=-=-=-=-=-=-= > >>> testNoErrorWhenDrawing > >>> view raw drawOn: tracingCanvas > >>> -=-=-=-=-=-=-=-=-= > >>> > >>> With the second version of the test, the test may be listed as an > error in case of an exception, whereas the first version it can only be > listed as a failure. > >> > >> Right, but that doesn't make any difference IMO, using `shouldnt: [...] > raise: Error` to not have errors > >> does not make much sense. It makes a little bit more sense when using a > specific Error, and it > >> makes sense when testing for Notifications, which would go otherwise > unnoticed. > >> > >> Which is the reason that `#shouldnt:raise:` no longer accepts `Error` > as an argument, but still lets > >> you use anything else. > >> > >>> I read your post and I kind of agree. > >>> I will fix my tests then. > >> > >> nice :) > > > > > > -- Best regards, Igor Stasenko.

Oct. 22, 2013

Re: [Pharo-dev] Standard Fonts Specs

by Igor Stasenko

i can be mistaken, but FreeTypeFontProvider current updateFromSystem. most probably wipes out all registered fonts and installs only ones it finds on file system, ignoring embedded ones. On 22 October 2013 10:58, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > I don't understand why, but StandardFonts class>>#setFontsFromSpec: does > not seem to work with the new fonts using a spec generated by StandardFonts > class>>#getCurrentFontsSpec, while the following code does work for me: > > "From Pavel" > > SourceCodeProRegular new install. > OpenSansRegular new install. > FreeTypeFontProvider current updateFromSystem. > > "Set some specific fonts and sizes" > > #( > #(#defaultFont: 'Open Sans' 12) > #(#listFont: 'Open Sans' 12) > #(#menuFont: 'Open Sans' 12) > #(#windowTitleFont: 'Open Sans' 12) > #(#balloonFont: 'Open Sans' 10) > #(#codeFont: 'Source Code Pro' 11) > #(#buttonFont: 'Open Sans' 12) > #(#haloFont: 'Open Sans' 10)) do: [ :spec | > | font | > font := LogicalFont familyName: spec second pointSize: > spec third. > StandardFonts perform: spec first with: font ] > > I like the window title font bold, but I didn't manage that ;-) > Anyway, this might be useful, I seem to remember Esteban had some trouble > there as well. > > Sven > > > -- Best regards, Igor Stasenko.

Oct. 22, 2013