October 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Unwind error during termination

by Igor Stasenko

On 25 October 2013 01:28, Nicolas Cellier < nicolas.cellier.aka.nice(a)gmail.com> wrote: > The author of the test is Andreas Raab, but I'm not sure who found it > (excavating mailing list is hard work) > > and this test is missing in pharo, so thanks anyways :) i can't imagine what can't go wrong is such basic stuff is broken. so we should fix it first, and then see if on:fork: needs some extra handling. > 2013/10/25 Igor Stasenko <siguctua(a)gmail.com> > >> >> >> >> On 25 October 2013 00:26, Nicolas Cellier < >> nicolas.cellier.aka.nice(a)gmail.com> wrote: >> >>> Hard to debug this kind of code :( >>> This is reproducible on Squeak wiht on:do:, so on:fork: bizareness >>> apart, this is another flaw in exception handling, along with wrong handler >>> for nested exception (testHandlerFromAction below), unless it's an avatar. >>> >>> Still, I do not see how you get the errorSubscriptBound:... >>> In Squeak that would mean that you sent #handleSignal: to a not >>> isHandlerContext ContextPart... >>> I never saw this, but if Eliot says so... >>> >>> >>> >>> ExceptionTests>>testHandlerFromAction >>> "A test ensuring that nested exceptions work as expected." >>> >>> | result | >>> result := [ >>> [ >>> [self error: 'trigger error'] on: ZeroDivide do: [ :ex | >>> 'inner' ] >>> ] on: Error do: [ :ex | 3 / 0 ] >>> ] on: ZeroDivide do: [ :ex | 'outer' ]. >>> self assert: 'outer' equals: result description: 'Incorrect handler'. >>> >>> good find :) >> >> https://pharo.fogbugz.com/f/cases/11996/Wrong-exception-handler-problem >> >> >>> >>> >>> 2013/10/24 Igor Stasenko <siguctua(a)gmail.com> >>> >>>> >>>> ok, it seems i found how to reproduce the situation with following: >>>> >>>> [ [ 1/0 ] ensure: [ nil foo ] ] on: Error fork: [ :ex | 1halt ] >>>> >>>> you will get halt, and if you close the debugger , it will throw unwind >>>> error. >>>> (while instead it should throw DNU) >>>> >>>> >>>> -- >>>> Best regards, >>>> Igor Stasenko. >>>> >>> >>> >> >> >> -- >> Best regards, >> Igor Stasenko. >> > > -- Best regards, Igor Stasenko.

Oct. 24, 2013

Re: [Pharo-dev] Unwind error during termination

by Nicolas Cellier

The author of the test is Andreas Raab, but I'm not sure who found it (excavating mailing list is hard work) 2013/10/25 Igor Stasenko <siguctua(a)gmail.com> > > > > On 25 October 2013 00:26, Nicolas Cellier < > nicolas.cellier.aka.nice(a)gmail.com> wrote: > >> Hard to debug this kind of code :( >> This is reproducible on Squeak wiht on:do:, so on:fork: bizareness apart, >> this is another flaw in exception handling, along with wrong handler for >> nested exception (testHandlerFromAction below), unless it's an avatar. >> >> Still, I do not see how you get the errorSubscriptBound:... >> In Squeak that would mean that you sent #handleSignal: to a not >> isHandlerContext ContextPart... >> I never saw this, but if Eliot says so... >> >> >> >> ExceptionTests>>testHandlerFromAction >> "A test ensuring that nested exceptions work as expected." >> >> | result | >> result := [ >> [ >> [self error: 'trigger error'] on: ZeroDivide do: [ :ex | >> 'inner' ] >> ] on: Error do: [ :ex | 3 / 0 ] >> ] on: ZeroDivide do: [ :ex | 'outer' ]. >> self assert: 'outer' equals: result description: 'Incorrect handler'. >> >> good find :) > > https://pharo.fogbugz.com/f/cases/11996/Wrong-exception-handler-problem > > >> >> >> 2013/10/24 Igor Stasenko <siguctua(a)gmail.com> >> >>> >>> ok, it seems i found how to reproduce the situation with following: >>> >>> [ [ 1/0 ] ensure: [ nil foo ] ] on: Error fork: [ :ex | 1halt ] >>> >>> you will get halt, and if you close the debugger , it will throw unwind >>> error. >>> (while instead it should throw DNU) >>> >>> >>> -- >>> Best regards, >>> Igor Stasenko. >>> >> >> > > > -- > Best regards, > Igor Stasenko. >

Oct. 24, 2013

Re: [Pharo-dev] Unwind error during termination

by Igor Stasenko

On 25 October 2013 00:26, Nicolas Cellier < nicolas.cellier.aka.nice(a)gmail.com> wrote: > Hard to debug this kind of code :( > This is reproducible on Squeak wiht on:do:, so on:fork: bizareness apart, > this is another flaw in exception handling, along with wrong handler for > nested exception (testHandlerFromAction below), unless it's an avatar. > > Still, I do not see how you get the errorSubscriptBound:... > In Squeak that would mean that you sent #handleSignal: to a not > isHandlerContext ContextPart... > I never saw this, but if Eliot says so... > > > > ExceptionTests>>testHandlerFromAction > "A test ensuring that nested exceptions work as expected." > > | result | > result := [ > [ > [self error: 'trigger error'] on: ZeroDivide do: [ :ex | > 'inner' ] > ] on: Error do: [ :ex | 3 / 0 ] > ] on: ZeroDivide do: [ :ex | 'outer' ]. > self assert: 'outer' equals: result description: 'Incorrect handler'. > > good find :) https://pharo.fogbugz.com/f/cases/11996/Wrong-exception-handler-problem > > > 2013/10/24 Igor Stasenko <siguctua(a)gmail.com> > >> >> ok, it seems i found how to reproduce the situation with following: >> >> [ [ 1/0 ] ensure: [ nil foo ] ] on: Error fork: [ :ex | 1halt ] >> >> you will get halt, and if you close the debugger , it will throw unwind >> error. >> (while instead it should throw DNU) >> >> >> -- >> Best regards, >> Igor Stasenko. >> > > -- Best regards, Igor Stasenko.

Oct. 24, 2013

API docs?

by projectVALIS

Hi all, I'm wondering if there are online API docs like there are for Java (here's a link <http://docs.oracle.com/javase/7/docs/api/> for all you non-Java types). I've already got a copy of 'Pharo by Example' and 'A Guide to Work with Squeak Morph Classes', but neither are what I'm looking for. Also, the 'swiki' doesn't have a comprehensive list. An up-to-date reference of the morphs and classes available in a stock Pharo image would be immensely helpful. Does one exist? -- View this message in context: http://forum.world.st/API-docs-tp4716945.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Oct. 24, 2013

Re: [Pharo-dev] Unwind error during termination

by Nicolas Cellier

Hard to debug this kind of code :( This is reproducible on Squeak wiht on:do:, so on:fork: bizareness apart, this is another flaw in exception handling, along with wrong handler for nested exception (testHandlerFromAction below), unless it's an avatar. Still, I do not see how you get the errorSubscriptBound:... In Squeak that would mean that you sent #handleSignal: to a not isHandlerContext ContextPart... I never saw this, but if Eliot says so... ExceptionTests>>testHandlerFromAction "A test ensuring that nested exceptions work as expected." | result | result := [ [ [self error: 'trigger error'] on: ZeroDivide do: [ :ex | 'inner' ] ] on: Error do: [ :ex | 3 / 0 ] ] on: ZeroDivide do: [ :ex | 'outer' ]. self assert: 'outer' equals: result description: 'Incorrect handler'. 2013/10/24 Igor Stasenko <siguctua(a)gmail.com> > > ok, it seems i found how to reproduce the situation with following: > > [ [ 1/0 ] ensure: [ nil foo ] ] on: Error fork: [ :ex | 1halt ] > > you will get halt, and if you close the debugger , it will throw unwind > error. > (while instead it should throw DNU) > > > -- > Best regards, > Igor Stasenko. >

Oct. 24, 2013

Re: [Pharo-dev] UpdatingMenuMorph

by Camille Teruel

On 24 oct. 2013, at 22:07, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > What happened to it and why? I'm porting TWM to 3.0 and didn't find any > mention of removal on the dev or issue mailing list... Thanks. It was removed in 30507. The decision to remove it has been made during the august sprint. I just remember that I did the job. Does someone remember why? > > ----- > Cheers, > Sean > -- > View this message in context: http://forum.world.st/UpdatingMenuMorph-tp4716928.html > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >

Oct. 24, 2013

Re: [Pharo-dev] Unwind error during termination

by Igor Stasenko

ok, it seems i found how to reproduce the situation with following: [ [ 1/0 ] ensure: [ nil foo ] ] on: Error fork: [ :ex | 1halt ] you will get halt, and if you close the debugger , it will throw unwind error. (while instead it should throw DNU) -- Best regards, Igor Stasenko.

Oct. 24, 2013

Re: [Pharo-dev] Unwind error during termination

by Igor Stasenko

the stack looks quite strange.. but if you open the debugger on that unwind error and see the #resume: context, evaluating: self isDead yields to true. it is a mystery however, how #resume: end up on the stack, when you just closing the debugger window and terminating the process. it seems like there's a bug somewhere which injects #resume: message send on stack. On 24 October 2013 22:17, Igor Stasenko <siguctua(a)gmail.com> wrote: > I doubt that the reason is some bug in VM, > i suspecting much simpler explanation: > > if you look at the bottom of stack, it starts from on:fork: > it tries to deliver announcement.. and everything goes well until it gets > an exception: > > PharoLauncher class(Object)>>doesNotUnderstand: #quitOnLaunch > > the on:fork: then spawns new process forking this part of stack with > exception. > then right after (i think because you press resume), it tries to resume > that exception. > The problem is that the context which it tries to resume belonging to > different process. > The exception is from foreign process, and it simply cannot be resumed, > and cannot be unwounded etc because stack is cut by on:fork:. > > So, to solve the problem is to see why it tries to resume that exception > (or maybe you tried to resume it manually?) > > In short, the wrong is a following: > > [ 1/0 ] on: Error fork: [ :ex | ex resume ] > > > (strangely enough this code does not raising any errors, perhaps because > the signaler context > is no longer on stack, and so modifying its state , by running > Context>>return: > does not causing stack corruption. > While in cases, where context is still on parent process stack, it may > wreak havoc. > > > > > On 24 October 2013 21:43, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > >> >> >> >> On Thu, Oct 24, 2013 at 11:25 AM, ClÃ©ment Bera <bera.clement(a)gmail.com>wrote: >> >>> OK I'll wait for another use case or until it happened to me. Like a >>> usecase from a fresh image. >>> >>> It's just it may be due to the new inspector, new debugger or new >>> compiler. Just wondering. >>> >> >> It's definitely not due to the new code. I see it occasionally in Squeak >> images without Opal. >> >> >>> >>> >>> 2013/10/24 Eliot Miranda <eliot.miranda(a)gmail.com> >>> >>>> >>>> >>>> >>>> On Thu, Oct 24, 2013 at 12:10 AM, ClÃ©ment Bera <bera.clement(a)gmail.com>wrote: >>>> >>>>> Ok I have the error too. >>>>> >>>>> Strangely enough, the error is triggered because the third >>>>> BlockClosure>>#on:do: context has 2 temporaries instead of 3. >>>>> >>>>> Igor / Esteban do you have a clue ? Why a context would have less >>>>> temporaries than expected ? Problem from context creation out of the stack ? >>>>> >>>> >>>> No. It'll be popping too much off the stack. See e.g. >>>> ContextPart>>jump. >>>> >>>> >>>>> >>>>> I will try to find some time to look at this problem. Though it is not >>>>> an easy one it will take some time to be fixed. >>>>> >>>>> >>>>> 2013/10/24 <btc(a)openinworld.com> >>>>> >>>>> ** >>>>>> ClÃ©ment Bera wrote: >>>>>> >>>>>> Hello, >>>>>> >>>>>> I'm interested. >>>>>> >>>>>> Please send me the image in private mail not to overload the mailing list >>>>>> with large attachment. >>>>>> Alternatively, give me a place where I can download it. >>>>>> >>>>>> >>>>>> http://files.openinworld.com/Pharo/PharoLauncher-Unwind-Error.zip >>>>>> >>>>>> The steps to reproduce are: open the image, execute 1halt, close debugger ? >>>>>> >>>>>> >>>>>> There are three debuggers already open. Just close them. The third >>>>>> close generates the error. >>>>>> A confounding factor may be your running this on a different VM. >>>>>> This is mine... >>>>>> >>>>>> http://files.openinworld.com/Pharo/PharoLauncher-Unwind-Error-VM.zip >>>>>> >>>>>> Win32 built on Mar 13 2013 18:49:42 Compiler: 4.6.2 >>>>>> VMMaker versionString git://gitorious.org/cogvm/blessed.git Commit: >>>>>> 412abef33cbed05cf1d75329e451d71c0c6aa5a7 Date: 2013-03-13 17:48:50 +0100 >>>>>> By: Esteban Lorenzano <estebanlm(a)gmail.com> <estebanlm(a)gmail.com>Jenkins build #14535 >>>>>> NBCoInterpreter NativeBoost-CogPlugin-EstebanLorenzano.18 uuid: >>>>>> a53445f9-c0c0-4015-97a3-be7db8d9ed6b Mar 13 2013 >>>>>> NBCogit NativeBoost-CogPlugin-EstebanLorenzano.18 uuid: >>>>>> a53445f9-c0c0-4015-97a3-be7db8d9ed6b Mar 13 2013 >>>>>> >>>>>> The error still occurs if I try the image on the latest VM, but then >>>>>> again the effect may already be in effect. >>>>>> >>>>>> btw, Its not directly causing me pain since I can continue in the >>>>>> image, but still thanks for checking it out for general improvements. >>>>>> >>>>>> cheers -ben >>>>>> >>>>>> Best, >>>>>> >>>>>> >>>>>> >>>>>> 2013/10/22 <btc(a)openinworld.com> <btc(a)openinworld.com> >>>>>> >>>>>> ** >>>>>> For a while now, every now and then when closing a debugger I have been >>>>>> getting an "Unwind error during termination" >>>>>> >>>>>> >>>>>> >>>>>> I happened to have saved the image moments before it just occurred again. >>>>>> From opening that save error can be reliably triggered in three clicks. >>>>>> I can provide this image if anyone is interested in it. >>>>>> >>>>>> cheers -ben >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> best, >>>> Eliot >>>> >>> >>> >> >> >> -- >> best, >> Eliot >> > > > > -- > Best regards, > Igor Stasenko. > -- Best regards, Igor Stasenko.

Oct. 24, 2013

Re: [Pharo-dev] Unwind error during termination

by Igor Stasenko

I doubt that the reason is some bug in VM, i suspecting much simpler explanation: if you look at the bottom of stack, it starts from on:fork: it tries to deliver announcement.. and everything goes well until it gets an exception: PharoLauncher class(Object)>>doesNotUnderstand: #quitOnLaunch the on:fork: then spawns new process forking this part of stack with exception. then right after (i think because you press resume), it tries to resume that exception. The problem is that the context which it tries to resume belonging to different process. The exception is from foreign process, and it simply cannot be resumed, and cannot be unwounded etc because stack is cut by on:fork:. So, to solve the problem is to see why it tries to resume that exception (or maybe you tried to resume it manually?) In short, the wrong is a following: [ 1/0 ] on: Error fork: [ :ex | ex resume ] (strangely enough this code does not raising any errors, perhaps because the signaler context is no longer on stack, and so modifying its state , by running Context>>return: does not causing stack corruption. While in cases, where context is still on parent process stack, it may wreak havoc. On 24 October 2013 21:43, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > > > On Thu, Oct 24, 2013 at 11:25 AM, ClÃ©ment Bera <bera.clement(a)gmail.com>wrote: > >> OK I'll wait for another use case or until it happened to me. Like a >> usecase from a fresh image. >> >> It's just it may be due to the new inspector, new debugger or new >> compiler. Just wondering. >> > > It's definitely not due to the new code. I see it occasionally in Squeak > images without Opal. > > >> >> >> 2013/10/24 Eliot Miranda <eliot.miranda(a)gmail.com> >> >>> >>> >>> >>> On Thu, Oct 24, 2013 at 12:10 AM, ClÃ©ment Bera <bera.clement(a)gmail.com>wrote: >>> >>>> Ok I have the error too. >>>> >>>> Strangely enough, the error is triggered because the third >>>> BlockClosure>>#on:do: context has 2 temporaries instead of 3. >>>> >>>> Igor / Esteban do you have a clue ? Why a context would have less >>>> temporaries than expected ? Problem from context creation out of the stack ? >>>> >>> >>> No. It'll be popping too much off the stack. See e.g. >>> ContextPart>>jump. >>> >>> >>>> >>>> I will try to find some time to look at this problem. Though it is not >>>> an easy one it will take some time to be fixed. >>>> >>>> >>>> 2013/10/24 <btc(a)openinworld.com> >>>> >>>> ** >>>>> ClÃ©ment Bera wrote: >>>>> >>>>> Hello, >>>>> >>>>> I'm interested. >>>>> >>>>> Please send me the image in private mail not to overload the mailing list >>>>> with large attachment. >>>>> Alternatively, give me a place where I can download it. >>>>> >>>>> >>>>> http://files.openinworld.com/Pharo/PharoLauncher-Unwind-Error.zip >>>>> >>>>> The steps to reproduce are: open the image, execute 1halt, close debugger ? >>>>> >>>>> >>>>> There are three debuggers already open. Just close them. The third >>>>> close generates the error. >>>>> A confounding factor may be your running this on a different VM. This >>>>> is mine... >>>>> >>>>> http://files.openinworld.com/Pharo/PharoLauncher-Unwind-Error-VM.zip >>>>> >>>>> Win32 built on Mar 13 2013 18:49:42 Compiler: 4.6.2 >>>>> VMMaker versionString git://gitorious.org/cogvm/blessed.git Commit: >>>>> 412abef33cbed05cf1d75329e451d71c0c6aa5a7 Date: 2013-03-13 17:48:50 +0100 >>>>> By: Esteban Lorenzano <estebanlm(a)gmail.com> <estebanlm(a)gmail.com>Jenkins build #14535 >>>>> NBCoInterpreter NativeBoost-CogPlugin-EstebanLorenzano.18 uuid: >>>>> a53445f9-c0c0-4015-97a3-be7db8d9ed6b Mar 13 2013 >>>>> NBCogit NativeBoost-CogPlugin-EstebanLorenzano.18 uuid: >>>>> a53445f9-c0c0-4015-97a3-be7db8d9ed6b Mar 13 2013 >>>>> >>>>> The error still occurs if I try the image on the latest VM, but then >>>>> again the effect may already be in effect. >>>>> >>>>> btw, Its not directly causing me pain since I can continue in the >>>>> image, but still thanks for checking it out for general improvements. >>>>> >>>>> cheers -ben >>>>> >>>>> Best, >>>>> >>>>> >>>>> >>>>> 2013/10/22 <btc(a)openinworld.com> <btc(a)openinworld.com> >>>>> >>>>> ** >>>>> For a while now, every now and then when closing a debugger I have been >>>>> getting an "Unwind error during termination" >>>>> >>>>> >>>>> >>>>> I happened to have saved the image moments before it just occurred again. >>>>> From opening that save error can be reliably triggered in three clicks. >>>>> I can provide this image if anyone is interested in it. >>>>> >>>>> cheers -ben >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>> >>> >>> -- >>> best, >>> Eliot >>> >> >> > > > -- > best, > Eliot > -- Best regards, Igor Stasenko.

Oct. 24, 2013

UpdatingMenuMorph

by Sean P. DeNigris

What happened to it and why? I'm porting TWM to 3.0 and didn't find any mention of removal on the dev or issue mailing list... Thanks. ----- Cheers, Sean -- View this message in context: http://forum.world.st/UpdatingMenuMorph-tp4716928.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Oct. 24, 2013