October 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] [PROVENANCE INTERNET] Re: Please contributors fill up this form...

by Olivier Auverlot

PharoContributor new name: 'Olivier Auverlot'; id: 'olivierauverlot'; email: 'olivier.auverlot(a)gmail.com'; description: 'Artefact,PROXimity'; yourself

Oct. 10, 2013

Re: [Pharo-dev] Start with a trivial improvement!

by kilon

This is something I was contemplating lately for my project Ephestos. The problem I see with your approach is that it takes a long time to see those changes integrated into Pharo cause AFAIK there are not many people to check out those "fixes" approve them and then integrate them. Now multiple that by 1000. Yeah right ! So I decided to follow the external library route. My initial concern about my project was that I want a better Morphic. Now the sensible start would be to do what you suggested, start small , fix morphic problems here and there, tiny clean ups to the code etc. But I realised that if someone pings me back months later about a fix he does not like and I am way forward in the development process that could seriously mess with my code and even make it hard to change the fix. So it was a great news indeed that morphic is entirely (or almost entirely ?) written in smalltalk. I am back at studying opengl since I want to make an opengl implementation of moprhic , but also I would also like to get rid of things I dont like about morphic. Making it into an external lib also makes sure I dont brake people's code but also I am tied into things I dont like and need the approval of the community to fix. So yes I agree that what you say sounds ideal in theory, but its not ideal in practice. -- View this message in context: http://forum.world.st/Start-with-a-trivial-improvement-tp4713648p4713655.ht… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Oct. 10, 2013

Re: [Pharo-dev] [Pharo-users] Start with a trivial improvement!

by Marcus Denker

On Oct 10, 2013, at 1:43 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote: > Thank you, Marcus! > > Could you post this on the Pharo blog? > Good idea, yes, I will do that. Marcus

Oct. 10, 2013

Re: [Pharo-dev] [Pharo-users] Start with a trivial improvement!

by Tudor Girba

Thank you, Marcus! Could you post this on the Pharo blog? Doru On Thu, Oct 10, 2013 at 1:36 PM, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > +100 > > On 10 Oct 2013, at 13:21, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > > One nice way to get in the mood of doing (and at the same time testing > the system) is to start > > with trivial improvements. > > > > This is especially nice as a "starter" when you never contributed any > change to Pharo. > > > > And by trivial I mean *really* mean trivial: > > -> a typo in a comment > > -> remove a temp not accessed > > -> clean out some trivial dead code > > -> do a simplistic refactoring of a bad smell, even inside a > single method > > -> document something > > -> structure bad stuff better so it is easier to replace later > > > > Taken in itself, single changes like these have no influence, but: > > > > -> they get you in a mood of doing. > > -> they make you feel that Pharo is "owned" by you. > > -> take 1000 of those trivialities and they *do* make a difference. > > -> next time something bothers you, you will have the context of > "I can just fix it". > > > > The critic tools is one way of finding these places, another is to just > note down every time > > you see a triviality and later go through that list. The bug tracker can > be source, too. > > > > > > <wtfm.jpg> > > > > Marcus > > > -- www.tudorgirba.com "Every thing has its own flow"

Oct. 10, 2013

Re: [Pharo-dev] [Pharo-users] Start with a trivial improvement!

by Sven Van Caekenberghe

+100 On 10 Oct 2013, at 13:21, Marcus Denker <marcus.denker(a)inria.fr> wrote: > One nice way to get in the mood of doing (and at the same time testing the system) is to start > with trivial improvements. > > This is especially nice as a "starter" when you never contributed any change to Pharo. > > And by trivial I mean *really* mean trivial: > -> a typo in a comment > -> remove a temp not accessed > -> clean out some trivial dead code > -> do a simplistic refactoring of a bad smell, even inside a single method > -> document something > -> structure bad stuff better so it is easier to replace later > > Taken in itself, single changes like these have no influence, but: > > -> they get you in a mood of doing. > -> they make you feel that Pharo is "owned" by you. > -> take 1000 of those trivialities and they *do* make a difference. > -> next time something bothers you, you will have the context of "I can just fix it". > > The critic tools is one way of finding these places, another is to just note down every time > you see a triviality and later go through that list. The bug tracker can be source, too. > > > <wtfm.jpg> > > Marcus

Oct. 10, 2013

Start with a trivial improvement!

by Marcus Denker

One nice way to get in the mood of doing (and at the same time testing the system) is to start with trivial improvements. This is especially nice as a "starter" when you never contributed any change to Pharo. And by trivial I mean *really* mean trivial: -> a typo in a comment -> remove a temp not accessed -> clean out some trivial dead code -> do a simplistic refactoring of a bad smell, even inside a single method -> document something -> structure bad stuff better so it is easier to replace later Taken in itself, single changes like these have no influence, but: -> they get you in a mood of doing. -> they make you feel that Pharo is "owned" by you. -> take 1000 of those trivialities and they *do* make a difference. -> next time something bothers you, you will have the context of "I can just fix it". The critic tools is one way of finding these places, another is to just note down every time you see a triviality and later go through that list. The bug tracker can be source, too. Marcus

Oct. 10, 2013

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30468 Home: https://github.com/pharo-project/pharo-core

Oct. 10, 2013

[pharo-project/pharo-core] 37e993: 30468

by GitHub

Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: 37e993116ec8882e0a9fd775488cd4938f2666be https://github.com/pharo-project/pharo-core/commit/37e993116ec8882e0a9fd775… Author: Jenkins Build Server <board(a)pharo-project.org> Date: 2013-10-10 (Thu, 10 Oct 2013) Changed paths: A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script123.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30468.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st A Spec-MorphicAdapters.package/AbstractMorphicAdapter.class/instance/testing/isMorphicAdapter.st A Spec-MorphicAdapters.package/extension/AbstractAdapter/instance/isMorphicAdapter.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/beginsWith_fromList_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/ensureMorphicAdapter.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/ensureMorphicAdapterDo_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/heightToDisplayInList_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/heightToDisplayInTree_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/listRenderOn_atRow_bounds_color_backgroundColor_from_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/treeRenderOn_bounds_color_font_from_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/widthToDisplayInList_.st A Spec-MorphicAdapters.package/extension/ComposableModel/instance/widthToDisplayInTree_.st Log Message: ----------- 30468 11786 CheckBoxModel>>doesNotUnderstand: #widthToDisplayInList: https://pharo.fogbugz.com/f/cases/11786 http://files.pharo.org/image/30/30468.zip

Oct. 10, 2013

Re: [Pharo-dev] [PROVENANCE INTERNET] Re: Please contributors fill up this form...

by Benjamin

PharoContributor new name: 'Benjamin Van Ryseghem'; id: 'BenjaminVanRyseghem'; email: 'benjamin.vanryseghem.pharo(a)gmail.com'; website: 'benjamin.vanryseghem.com'; description: 'Pharo core. Morphic maintainer. Spec author. Nautilus author. Responsible of quite some UIs'; image: 'http://www.gravatar.com/avatar/7367a4e9e6a838db7cd1b0ecdc234934.png'; yourself Ben On Oct 10, 2013, at 10:39 AM, Guillermo Polito <guillermopolito(a)gmail.com> wrote: > PharoContributor new > name: 'Guille Polito'; > id: 'guillep'; > email: 'guillermopolito(a)gmail.com'; > website: 'playingwithobjects.wordpress.com'; > description: 'Pharo core. Pharo bootstrap, DBXTalk, Keymappings, have traveled a bit to Mars, ocassional VMer. The wizard of Oz.'; > image: 'http://www.gravatar.com/avatar/e50b0970fbf94e7086ad065995e55b59.png'; > yourself

Oct. 10, 2013

Re: [Pharo-dev] CheckBoxModel DNU widthToDisplayInList

by Camillo Bruni

duplicate of https://pharo.fogbugz.com/f/cases/11786/CheckBoxModel-doesNotUnderstand-wid… On 2013-10-10, at 10:27, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi guys > > When I want to extract a method I get CheckBoxModel DNU widthToDisplayInList in 30467 > > heightToDisplayInList: is also missing > > https://pharo.fogbugz.com/f/cases/11838/CheckBoxModel-DNU-widthToDisplayInL… > > > > hUnadjustedScrollRange > "Ok, this is a bit messed up. We need to return the width of the widest item in the list. If we grab every item in the list, it defeats the purpose of LazyListMorph. If we don't, then we don't know the size. > > This is a compromise -- find the widest of the first 30 items, then double it, This width will be updated as new items are installed, so it will always be correct for the visible items. If you know a better way, please chime in." > > | itemsToCheck item index | > "Check for a cached value" > maxWidth ifNotNil:[^maxWidth]. > > listItems isEmpty ifTrue: [^0]. "don't set maxWidth if empty do will be recomputed when there are some items" > "Compute from scratch" > itemsToCheck := 30 min: (listItems size). > maxWidth := 0. > > "Check the first few items to get a representative sample of the rest of the list." > index := 1. > [index < itemsToCheck] whileTrue: > [ item := self getListItem: index. "Be careful not to actually install this item" > maxWidth := maxWidth max: (item widthToDisplayInList: self). > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > index:= index + 1. > ]. > > "Add some initial fudge if we didn't check all the items." > (itemsToCheck < listItems size) ifTrue:[maxWidth := maxWidth*2]. > > ^maxWidth > >

Oct. 10, 2013