October 2013 - Pharo-dev - lists.pharo.org

Fix Review Needed - Slice query - was Re: bug: [4993] Typing cmd+L cancel all typing and we can't undo it [Terminated]

by btc＠openinworld.com

As I reviewed the Slice <Changes> related to Case 4993, I notice the relevant part was only a single method, but also included were several more unrelated modifications with zero-sum refactorings. eg, from... position: aPoint super position: aPoint. self viewBox ifNotNil: [self viewBox: (aPoint extent: self viewBox extent)]. to... position: aPoint super position: aPoint. self viewBox ifNotNil: [:viewBox | self viewBox: (aPoint extent: viewBox extent)]. which itself is cool, but my first thought was that these shouldn't have been included in the Case 4993 Slice, but in a separate Slice for a different Case that dealt just with those refactorings. But thinking further in general the image I use for testing could have moved on from the image used to generate that Slice. So maybe its not not such a problem anyhow? Also, if the zero-sum refactoring modifications were put in their own separate Slice, then probably the specific modifications related to the Case would build upon that, so ultimately you end up with the same situation. So in short my question is, how much do you typically separate out Case-specific modifications from incidental zero-sum refactoring made along the way. cheers -ben --------Original Message----------- btc(a)openinworld.com wrote: > kilon wrote: >> This is my first pharo bug fix so be gentle :D >> >> https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-w… >> >> <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-w…> >> >> As I explain in the link and in my commit log , I have added a confirm >> dialog so the user in case he accidentally pressed CMD+L will click >> no and >> his changes will not be lost. I have verified the bug fix with the >> latest >> pharo build. >> >> >> -- >> View this message in context: >> http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-… >> >> Sent from the Pharo Smalltalk Developers mailing list archive at >> Nabble.com. >> >> >> > It looks fine. Simple enough even for me to understand ;). So I've > changed the status to 'Resolved - fix to include.' Actually my first, > so just checking this is the correct next step in the workflow ? > > >

Oct. 13, 2013

Pharo is on HN, push it up :-)

by phil＠highoctane.be

Noticed Pharo mentioned on the home https://news.ycombinator.com Give it some points to move it up. Phil

Oct. 13, 2013

Re: [Pharo-dev] bug: [4993] Typing cmd+L cancel all typing and we can't undo it [Terminated]

by Marcus Denker

On Oct 13, 2013, at 4:10 PM, btc(a)openinworld.com wrote: > kilon wrote: >> This is my first pharo bug fix so be gentle :D >> >> https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-w… >> <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-w…> >> As I explain in the link and in my commit log , I have added a confirm >> dialog so the user in case he accidentally pressed CMD+L will click no and >> his changes will not be lost. I have verified the bug fix with the latest >> pharo build. >> >> >> -- >> View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-… >> Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. >> >> >> > It looks fine. Simple enough even for me to understand ;). So I've changed the status to 'Resolved - fix to include.' Actually my first, so just checking this is the correct next step in the workflow ? > Normally the first step is "fix review needed". Then someone else needs to check if this is ok (not any small mistake, problem really solved), "fix to include" should be the state when it is guaranteed that is can be included without check and thinking. Marcus

Oct. 13, 2013

Re: [Pharo-dev] bug: [4993] Typing cmd+L cancel all typing and we can't undo it [Terminated]

by btc＠openinworld.com

kilon wrote: > This is my first pharo bug fix so be gentle :D > > https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-w… > <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-w…> > > As I explain in the link and in my commit log , I have added a confirm > dialog so the user in case he accidentally pressed CMD+L will click no and > his changes will not be lost. I have verified the bug fix with the latest > pharo build. > > > > -- > View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-… > Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com. > > > It looks fine. Simple enough even for me to understand ;). So I've changed the status to 'Resolved - fix to include.' Actually my first, so just checking this is the correct next step in the workflow ?

Oct. 13, 2013

Re: [Pharo-dev] Bug : [3556] Find and replace dialog behavior

by kilon

Ctrl+f only scrolls it down for me. Cant reproduce this "bug" still. I still see no Find and replace dialog. btc wrote > <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 > Transitional//EN"> > > > > > > > kilon wrote: > > forgot to add the link to it > > https://pharo.fogbugz.com/f/cases/3536/Find-and-replace-dialog-behavior > <https://pharo.fogbugz.com/f/cases/3536/Find-and-replace-dialog-behavior> > > > kilon wrote > > > I cannot reproduce this bug. I cant find a "find and replace popup". > Is > this bug still relevant ? > > > > > > > I > think it means... within System Browser with a method shown in the code > pane, and the cursor in that pane, hit <Ctrl-F> to bring up the > Find-and-Replace dialog. > This > seems to be the original thread > http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/2010-December/03… > Where > Alain said: "It was supposed to be a feature [..] for the find & > replace window to always stay on top. A setting can be easily > introduced to allow/forbid this. But, it should not take the keyboard > focus. > And > original reporter Mariano says "No, this is exactly the case. Don't > worry. It is fine to be that way. It was just rare for me and wanted to > be sure it was not a bug. Perfect for me. No, no need a settting, don't > worry ;)  thanks for offering!" > Just > tested #30472 exhibits the behaviour specified by Alain, so I think > this should be closed as invalid. > > So > one more bug down. And good work kilon :) - its important flush out the > old ones. > > cheer > -ben -- View this message in context: http://forum.world.st/Bug-3556-Find-and-replace-dialog-behavior-tp4714147p4… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Oct. 13, 2013

Re: [Pharo-dev] Bug : [3556] Find and replace dialog behavior

by btc＠openinworld.com

Oct. 13, 2013

bug: [4993] Typing cmd+L cancel all typing and we can't undo it [Terminated]

by kilon

This is my first pharo bug fix so be gentle :D https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-w… <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-w…> As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build. -- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Oct. 13, 2013

Re: [Pharo-dev] Bug : [3556] Find and replace dialog behavior

by kilon

forgot to add the link to it https://pharo.fogbugz.com/f/cases/3536/Find-and-replace-dialog-behavior <https://pharo.fogbugz.com/f/cases/3536/Find-and-replace-dialog-behavior> kilon wrote > I cannot reproduce this bug. I cant find a "find and replace popup". Is > this bug still relevant ? -- View this message in context: http://forum.world.st/Bug-3556-Find-and-replace-dialog-behavior-tp4714147p4… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Oct. 13, 2013

Bug : [3556] Find and replace dialog behavior

by kilon

I cannot reproduce this bug. I cant find a "find and replace popup". Is this bug still relevant ? -- View this message in context: http://forum.world.st/Bug-3556-Find-and-replace-dialog-behavior-tp4714147.h… Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.

Oct. 13, 2013

[pharo-project/pharo-core]

by GitHub

Branch: refs/tags/30477 Home: https://github.com/pharo-project/pharo-core

Oct. 13, 2013