January 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] SmallLint journey: another rule :)

by StÃ©phane Ducasse

Jan's experience on it :) !RBTempsReadBeforeWrittenRule class methodsFor:'accessing'! tagsBasic "Return an array of tags (symbols) of given rule. Any rule may arbitrary number of tags. Tag values are not predefined/fixed. See class documentation for list of common tags" ^#( #broken ) On Jan 22, 2013, at 4:16 PM, StÃ©phane Ducasse wrote: > Hi > > I'm trying the Temporaries read before written and I have the impression that I found a bug in the > RBReadBeforeWrittenTester class > because it flags connections (but connections is not a temp but an instance variable). > > Did anybody experience the same? > > Stef > > listenLoop > "Private! This loop is run in a separate process. It will establish up to maxQueueLength connections on the given port." > "Details: When out of sockets or queue is full, retry more frequently, since a socket may become available, space may open in the queue, or a previously queued connection may be aborted by the client, making it available for a fresh connection." > "Note: If the machine is disconnected from the network while the server is running, the currently waiting socket will go from 'isWaitingForConnection' to 'unconnected', and attempts to create new sockets will fail. When this happens, delete the broken socket and keep trying to create a socket in case the network connection is re-established. Connecting and disconnecting was tested under PPP on Mac system 8.1. It is not if this will work on other platforms. > > Fixed to not accept the connection if the queue is full (gvc)." > > > | newConnection | > > socket := Socket newTCP. > "We'll accept four simultanous connections at the same time" > socket listenOn: portNumber backlogSize: 4. > "If the listener is not valid then the we cannot use the > BSD style accept() mechanism." > socket isValid ifFalse: [^self oldStyleListenLoop]. > [true] whileTrue: [ > socket isValid ifFalse: [ > "socket has stopped listening for some reason" > socket destroy. > (Delay forMilliseconds: 10) wait. > ^self listenLoop ]. > [newConnection := socket waitForAcceptFor: 10] > on: ConnectionTimedOut > do: [:ex | newConnection := nil]. > (newConnection notNil and: [newConnection isConnected]) > ifTrue: [(accessSema critical: [connections size < maxQueueLength]) > ^^^^^^^^^^ > > > > ifFalse: [newConnection close. newConnection := nil]] > ifFalse: [newConnection := nil]. > (newConnection notNil and: [newConnection isConnected]) ifTrue: [ > accessSema critical: [connections addLast: newConnection]. > newConnection := nil. > self changed]. > self pruneStaleConnections].

Jan. 22, 2013

Re: [Pharo-project] [Ann] New version of Mocketry

by Denis Kudriashov

2013/1/22 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > ConfigurationOfMocketry > Tests > This is already exists many years (thank's Laurent Laffont for configuration) > SmallLint rules applied. > Never use it. I will try.

Jan. 22, 2013

Re: [Pharo-project] Object>>#name

by StÃ©phane Ducasse

hi gary we will address it. :) Stef On Jan 22, 2013, at 3:31 PM, Gary Chambers wrote: > Indeed, is a common accessor for domain/business objects. > Have got use to having to re-implement each time myself but quicker to not have to. > > Regards, Gary > > ----- Original Message ----- From: "Sven Van Caekenberghe" <sven(a)stfx.eu> > To: <Pharo-project(a)lists.gforge.inria.fr> > Sent: Monday, January 21, 2013 6:43 PM > Subject: [Pharo-project] Object>>#name > > > Hi, > > Many people have hit the fact that Object implements #name, which then seems to conflict with some other class where one would really like to use name as an instance variable and thus accessor. > > Turns out that it seems that Object>>#name is actually not used (anymore). > > I just put a halt in it and tried a couple of tools and everything seems to work just fine. > > The comment talks about Inspector use, but there is #defaultLabelForInspector for that. > > It is a small thing, but it confuses everybody for no good reason, > > Any comments ? > > Sven > > PS: it was also in the testing procotol ;-) > > -- > Sven Van Caekenberghe > http://stfx.eu > Smalltalk is the Red Pill > > >

Jan. 22, 2013

[Pharo-project] SmallLint journey: another rule :)

by StÃ©phane Ducasse

Hi I'm trying the Temporaries read before written and I have the impression that I found a bug in the RBReadBeforeWrittenTester class because it flags connections (but connections is not a temp but an instance variable). Did anybody experience the same? Stef listenLoop "Private! This loop is run in a separate process. It will establish up to maxQueueLength connections on the given port." "Details: When out of sockets or queue is full, retry more frequently, since a socket may become available, space may open in the queue, or a previously queued connection may be aborted by the client, making it available for a fresh connection." "Note: If the machine is disconnected from the network while the server is running, the currently waiting socket will go from 'isWaitingForConnection' to 'unconnected', and attempts to create new sockets will fail. When this happens, delete the broken socket and keep trying to create a socket in case the network connection is re-established. Connecting and disconnecting was tested under PPP on Mac system 8.1. It is not if this will work on other platforms. Fixed to not accept the connection if the queue is full (gvc)." | newConnection | socket := Socket newTCP. "We'll accept four simultanous connections at the same time" socket listenOn: portNumber backlogSize: 4. "If the listener is not valid then the we cannot use the BSD style accept() mechanism." socket isValid ifFalse: [^self oldStyleListenLoop]. [true] whileTrue: [ socket isValid ifFalse: [ "socket has stopped listening for some reason" socket destroy. (Delay forMilliseconds: 10) wait. ^self listenLoop ]. [newConnection := socket waitForAcceptFor: 10] on: ConnectionTimedOut do: [:ex | newConnection := nil]. (newConnection notNil and: [newConnection isConnected]) ifTrue: [(accessSema critical: [connections size < maxQueueLength]) ^^^^^^^^^^ ifFalse: [newConnection close. newConnection := nil]] ifFalse: [newConnection := nil]. (newConnection notNil and: [newConnection isConnected]) ifTrue: [ accessSema critical: [connections addLast: newConnection]. newConnection := nil. self changed]. self pruneStaleConnections].

Jan. 22, 2013

Re: [Pharo-project] Must OSPlatform class>>osVersion be deprecated?

by Marcus Denker

On Jan 22, 2013, at 5:27 PM, H. Hirzel <hannes.hirzel(a)gmail.com> wrote: > Dave > > I wonder why you can't check for > > Smalltalk at: #OSPlatform > > and if that exists go for > OSPlatform osVersion > We deprecated thatâ¦ but I can un-deprecate. > Neither Squeak nor Cuis do have an OSPlatform class. > > Then you go for > Smalltalk os version > This works in Pharo 2.0â¦ > Am I missing something here? > > --Hannes > > On 1/21/13, David T. Lewis <lewis(a)mail.msen.com> wrote: >> Why is OSPlatform class>>osVersion deprecated but OSPlatform >> class>>platformName >> is not? >> >> My suggestion would be to comment #osVersion as being a synonym for >> #version, >> but do not deprecate it. That would enable use of "Smalltalk os version", >> and >> it would also support "OSPlatform osVersion", both of which make logical >> sense. >> It would also maintain support for external packages that rely on >> #osVersion >> to figure out platform differences. >> >> The reason that I am asking is that I am trying to find a way to make >> OSProcess class>>osVersion work on Pharo 2.0, Pharo1.x, and the various >> versions of Squeak and Cuis. I quite honestly cannot figure out any way to >> add Pharo 2.0 without breaking one more more of the other supported images. >> If OSPlatform class>>osVersion did not raise a deprecation warning, then >> I could make it work. >> >> Thanks, >> Dave >> >> >> >

Jan. 22, 2013

Re: [Pharo-project] Closing unresolved issues

by Marcus Denker

On Jan 22, 2013, at 5:17 PM, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > For example... > Issue 5656: Large fonts make tools slow > http://code.google.com/p/pharo/issues/detail?id=5656 > > This issue has not been resolved, but the issue was closed, leading to this > experience... > - I just upgraded a project to 2.0 > - I notice that the UI is very slow - a simple Spec dialog window with a few > text fields and buttons takes ~4 seconds to open > - I check the issue tracker because I remember I reported the bug already, > but I don't find it in the open issues > - I waste time because I think it must be something else > - I finally expand my search through the issues and find my report was > closed as invalid > > I'm not saying that this is wrong, just that I don't understand and want to > share another perspective and come to the best solution... What benefit are > we getting from closing these that is significant enough to justify this > kind of experience (I'm sure I'm not the only one). > Yes, I was too fast closing this reportâ¦ I will open it again. Marcus

Jan. 22, 2013

Re: [Pharo-project] SmallLint applied on Pharo: Continued

by Jan Vrany

On 22/01/13 18:22, StÃ©phane Ducasse wrote: > Hi > > I'm running the rule RBSubclassResponsibilityNotDefinedRule that > > Checks that all subclassResponsibility methods are defined in all leaf classes. > > Now the results display the sender of ^ subclassResponsibility but I have to manually find the > problems. I would be better to report the violations. Of course this is not that simple: returning a class and missing method. > > But this would be much better. Jan did you do that in your version? Good point. Yes, since now we do that :-) Jan > > Stef >

Jan. 22, 2013

Re: [Pharo-project] Fonts in Pharo By Example

by Gary Chambers

Have got used to using FreeType so always look up fonts via LogicalFont class methods these days... headingFont "Answer the font for headings." ^LogicalFont familyName: 'Arial' pointSize: 20 Regards, Gary ----- Original Message ----- From: "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> To: <Pharo-project(a)lists.gforge.inria.fr> Sent: Tuesday, January 22, 2013 5:26 PM Subject: Re: [Pharo-project] Fonts in Pharo By Example On Jan 21, 2013, at 11:57 AM, Sean P. DeNigris wrote: > It would be great to have a section in PBE2 about fonts. I find them very > confusing - TrueType, FreeType, Logical, etc. Understanding how they're > handled in Pharo requires background knowledge, and an overview and a few > specific examples could really do some good. If somebody explain it It would be great. I always wanted to read something on fonts but unfortunately I feel a bit alone on the writing side This is why I love the attitude of sven to produce doc. Stef > > Cheers, > Sean > > > > -- > View this message in context: > http://forum.world.st/Fonts-in-Pharo-By-Example-tp4664406.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. >

Jan. 22, 2013

Re: [Pharo-project] Object>>#name

by Gary Chambers

Indeed, is a common accessor for domain/business objects. Have got use to having to re-implement each time myself but quicker to not have to. Regards, Gary ----- Original Message ----- From: "Sven Van Caekenberghe" <sven(a)stfx.eu> To: <Pharo-project(a)lists.gforge.inria.fr> Sent: Monday, January 21, 2013 6:43 PM Subject: [Pharo-project] Object>>#name Hi, Many people have hit the fact that Object implements #name, which then seems to conflict with some other class where one would really like to use name as an instance variable and thus accessor. Turns out that it seems that Object>>#name is actually not used (anymore). I just put a halt in it and tried a couple of tools and everything seems to work just fine. The comment talks about Inspector use, but there is #defaultLabelForInspector for that. It is a small thing, but it confuses everybody for no good reason, Any comments ? Sven PS: it was also in the testing procotol ;-) -- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill

Jan. 22, 2013

[Pharo-project] SmallLint applied on Pharo: Continued

by StÃ©phane Ducasse

Hi I'm running the rule RBSubclassResponsibilityNotDefinedRule that Checks that all subclassResponsibility methods are defined in all leaf classes. Now the results display the sender of ^ subclassResponsibility but I have to manually find the problems. I would be better to report the violations. Of course this is not that simple: returning a class and missing method. But this would be much better. Jan did you do that in your version? Stef

Jan. 22, 2013