January 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] OrderedIdentityDictionary in a more general package

by Esteban Lorenzano

... and we need Spec as a project under team Pharo, in sthub :) On Jan 31, 2013, at 8:28 AM, "Torsten Bergmann" <astares(a)gmx.de> wrote: > Stef wrote: >> good idea. >> Do you know the test coverage of the class? >> Because it would be nice to run hapao on it and write some tests if there are none. > > Actually there are no tests - at least not in the Pharo image. > Maybe Benjamin can comment if there are some tests in the Spec universe for it. > > I opened an issue: http://code.google.com/p/pharo/issues/detail?id=7374 > > @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a > more general "Collection-Ordered" category/package for Pharo? > I dont want to interfere with current Spec development and > have no rights to commit to http://ss3.gemstone.com/ss/Spec > > BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont > know about the dependencies - but for Kernel we have only one package (and one > for the tests). > > Thx > T. > > >

Jan. 31, 2013

Re: [Pharo-project] help needed

by Goubier Thierry

Le 31/01/2013 02:30, StÃ©phane Ducasse a Ã©crit : > Morbid fascination > It is late so I may completely off but > how many isKindOf: are executed in this method? > >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #openPath]]]) > > when [aSymbol second == #openPath] is not openPath > then we go to the next (not mentioning duplicated code inside the method ---- I will vomit) > and we restart to execute isKindOf: > > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #expandAllFromNode:]]]) > > Am'I right? > It looks so terrible. It is. As a user of MorphTreeMorph, this stuff is hard to use (and doesn't work very well). self history pauseDuring: [ self changed: #(#rootNodes #openItemPath) , nPath reverse ]. :( It's also very well documented, of course. Thierry > Stef > > > >> update: aSymbol >> aSymbol == #selection ifTrue: [^ self listManager updateSelectionFromModel]. >> ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == #selectItems and: [aSymbol second isCollection]]]) >> ifTrue: [^ self selectedItems: aSymbol second]. >> aSymbol == self nodeListSelector ifTrue: [^ self updateList]. >> aSymbol == #selectAll ifTrue: [^ self listManager selectAll]. >> aSymbol == #deselectAll ifTrue: [^ self listManager deselectAll]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #openPath]]]) "allow directed path opening where multiple trees exist" >> ifTrue: >> [^(self allNodeMorphs at: 1 ifAbsent: [^self]) >> openPath: (aSymbol allButFirst: 2)]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #openItemPath]]]) "allow directed path opening where multiple trees exist" >> ifTrue: >> [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) >> openItemPath: (aSymbol allButFirst: 2)]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #expandAllFromNode:]]]) >> ifTrue: >> [^ self expandAllFromNode: aSymbol third]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #closeItemPath]]]) "allow directed path closing where multiple trees exist" >> ifTrue: >> [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) >> closeItemPath: (aSymbol allButFirst: 2)]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) >> ifTrue: >> [^(self allNodeMorphs at: 1 ifAbsent: [^self]) >> openPath: aSymbol allButFirst]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector and: [ >> aSymbol second == #expandRoots]]]) >> ifTrue: >> [^self expandRoots]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector]]) >> ifTrue: [aSymbol second = #expandAll ifTrue: [^ self expandAll]. >> aSymbol second = #collapseAll ifTrue: [^ self collapseAll]] > > > -- Thierry Goubier CEA list Laboratoire des Fondations des SystÃ¨mes Temps RÃ©el EmbarquÃ©s 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95

Jan. 31, 2013

[Pharo-project] OrderedIdentityDictionary in a more general package

by Torsten Bergmann

Stef wrote: >good idea. >Do you know the test coverage of the class? >Because it would be nice to run hapao on it and write some tests if there are none. Actually there are no tests - at least not in the Pharo image. Maybe Benjamin can comment if there are some tests in the Spec universe for it. I opened an issue: http://code.google.com/p/pharo/issues/detail?id=7374 @Benjamin: can you move "OrderedIdentityDictionary" it out of Spec up to a more general "Collection-Ordered" category/package for Pharo? I dont want to interfere with current Spec development and have no rights to commit to http://ss3.gemstone.com/ss/Spec BTW: Is it really necessary to have an mzc per "Collection-***" category? Dont know about the dependencies - but for Kernel we have only one package (and one for the tests). Thx T.

Jan. 31, 2013

Re: [Pharo-project] I hate 'as yet unclassified'

by Ben Coman

Camillo Bruni wrote: > I was just waiting for the google issue tracker to come back to life... > > https://code.google.com/p/pharo/issues/detail?id=7373 > > => Slice in Inbox > > the major problem I have now, is that wrong categorizations might easily > spread :P, the sepll-fleu and the space - vi rus, are very common... > > Can the auto-categorization mark such methods as "auto-categorized" ? So that later if it doesn't seem quite right, a human can make a better judgment rather than assuming someone else had already made such a judgment for some-good-reason. In reality perhaps such re-categorization wouldn't happen a lot, but "being at least able to" make such judgment increases confidence in the system, which can be subtly undermined by automated tools (and anyway I hate throwing away information that is easily available at the time). This wouldn't need any tool support straight away, but at least the data is captured for later use.

Jan. 31, 2013

Re: [Pharo-project] I hate 'as yet unclassified'

by Sean P. DeNigris

Stephan Eggermont wrote > By author > > gvc 1307 > GaryChambers 195 > 186 > AlainPlantec 123 > CamilloBruni 89 > stephaneducasse 78 > SeanDeNigris 72 Sweet, I moved up in the rankings :) I'm so proud... -- View this message in context: http://forum.world.st/I-hate-as-yet-unclassified-tp4666245p4666748.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Jan. 31, 2013

Re: [Pharo-project] help needed

by StÃ©phane Ducasse

Morbid fascination It is late so I may completely off but how many isKindOf: are executed in this method? > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #openPath]]]) when [aSymbol second == #openPath] is not openPath then we go to the next (not mentioning duplicated code inside the method ---- I will vomit) and we restart to execute isKindOf: ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ aSymbol second == #expandAllFromNode:]]]) Am'I right? It looks so terrible. Stef > update: aSymbol > aSymbol == #selection ifTrue: [^ self listManager updateSelectionFromModel]. > ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == #selectItems and: [aSymbol second isCollection]]]) > ifTrue: [^ self selectedItems: aSymbol second]. > aSymbol == self nodeListSelector ifTrue: [^ self updateList]. > aSymbol == #selectAll ifTrue: [^ self listManager selectAll]. > aSymbol == #deselectAll ifTrue: [^ self listManager deselectAll]. > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #openPath]]]) "allow directed path opening where multiple trees exist" > ifTrue: > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > openPath: (aSymbol allButFirst: 2)]. > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #openItemPath]]]) "allow directed path opening where multiple trees exist" > ifTrue: > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > openItemPath: (aSymbol allButFirst: 2)]. > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #expandAllFromNode:]]]) > ifTrue: > [^ self expandAllFromNode: aSymbol third]. > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #closeItemPath]]]) "allow directed path closing where multiple trees exist" > ifTrue: > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > closeItemPath: (aSymbol allButFirst: 2)]. > ((aSymbol isKindOf: Array) > and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) > ifTrue: > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > openPath: aSymbol allButFirst]. > ((aSymbol isKindOf: Array) > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector and: [ > aSymbol second == #expandRoots]]]) > ifTrue: > [^self expandRoots]. > ((aSymbol isKindOf: Array) > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector]]) > ifTrue: [aSymbol second = #expandAll ifTrue: [^ self expandAll]. > aSymbol second = #collapseAll ifTrue: [^ self collapseAll]]

Jan. 31, 2013

Re: [Pharo-project] I hate 'as yet unclassified'

by Chris Cunningham

On Wed, Jan 30, 2013 at 12:53 PM, Chris Muller <asqueaker(a)gmail.com> wrote: > On Wed, Jan 30, 2013 at 2:40 PM, Camillo Bruni <camillobruni(a)gmail.com> > wrote: > > I just wrote a simple classifier which is going to be used in Nautilus. > > Basically it is an extensions of the existing code. > > > [snip] > > 3. know protocols of super implementors > > I admit that is a good one. > I think this is execllent. I'd appreciate is a lot. > > > 4. gather all implementors in the system and choose the most used > protocol. > > Not so much this one. If you limited the scope (say to siblings - subclasses of it's superclass of the same level, ignoring Object as a superclass), I think this would also be excellent. Usually when I'm creating a set of related classes, I'll wind up making the categories (or protocols) similar - any help here is indeed help. -Chris

Jan. 31, 2013

Re: [Pharo-project] help needed

by Peter Hugosson-Miller

On 31 jan 2013, at 01:04, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Arghhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh > What a terrible methodâ¦â¦. so ugly. > There is something fundamentally wrong. +1000 -- Cheers, Peter > This is why we should rewrite MorphTreeMorph. > > Stef > > > > On Jan 30, 2013, at 4:13 PM, Usman Bhatti wrote: > >> I am trying to look into this issue in Glamour related to morphs: >> >> http://code.google.com/p/pharo/issues/detail?id=7345 >> >> The problem is that, in Glamour, one can choose to display first few items instead of the all and then the user can choose to display more. When the selection is set to the items not shown, there is a DNU in PaginatedMorphTreeMorph. Digging this problem, I have encountered this piece of code for which I would require the help of someone knowing Morph. Is someone knowledgable about this piece of code? Here you can find an image with the script to explore the problem: https://dl.dropbox.com/u/11804892/glamour-treemorphs.zip >> >> >> MorphTreeMorph >> update: >> >> >> update: aSymbol >> aSymbol == #selection ifTrue: [^ self listManager updateSelectionFromModel]. >> ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == #selectItems and: [aSymbol second isCollection]]]) >> ifTrue: [^ self selectedItems: aSymbol second]. >> aSymbol == self nodeListSelector ifTrue: [^ self updateList]. >> aSymbol == #selectAll ifTrue: [^ self listManager selectAll]. >> aSymbol == #deselectAll ifTrue: [^ self listManager deselectAll]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #openPath]]]) "allow directed path opening where multiple trees exist" >> ifTrue: >> [^(self allNodeMorphs at: 1 ifAbsent: [^self]) >> openPath: (aSymbol allButFirst: 2)]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #openItemPath]]]) "allow directed path opening where multiple trees exist" >> ifTrue: >> [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) >> openItemPath: (aSymbol allButFirst: 2)]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #expandAllFromNode:]]]) >> ifTrue: >> [^ self expandAllFromNode: aSymbol third]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ >> aSymbol second == #closeItemPath]]]) "allow directed path closing where multiple trees exist" >> ifTrue: >> [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) >> closeItemPath: (aSymbol allButFirst: 2)]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) >> ifTrue: >> [^(self allNodeMorphs at: 1 ifAbsent: [^self]) >> openPath: aSymbol allButFirst]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector and: [ >> aSymbol second == #expandRoots]]]) >> ifTrue: >> [^self expandRoots]. >> ((aSymbol isKindOf: Array) >> and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector]]) >> ifTrue: [aSymbol second = #expandAll ifTrue: [^ self expandAll]. >> aSymbol second = #collapseAll ifTrue: [^ self collapseAll]] > >

Jan. 31, 2013

[Pharo-project] pharo code twitter cards

by Camillo Bruni

I just learned about twitter cards [1], might actually be fun to create a small pharo doc-page where you can refer to pharo methods from tweets :P [1] https://dev.twitter.com/docs/cards

Jan. 31, 2013

Re: [Pharo-project] help needed

by StÃ©phane Ducasse

Arghhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh What a terrible methodâ¦â¦. so ugly. There is something fundamentally wrong. This is why we should rewrite MorphTreeMorph. Stef On Jan 30, 2013, at 4:13 PM, Usman Bhatti wrote: > I am trying to look into this issue in Glamour related to morphs: > > http://code.google.com/p/pharo/issues/detail?id=7345 > > The problem is that, in Glamour, one can choose to display first few items instead of the all and then the user can choose to display more. When the selection is set to the items not shown, there is a DNU in PaginatedMorphTreeMorph. Digging this problem, I have encountered this piece of code for which I would require the help of someone knowing Morph. Is someone knowledgable about this piece of code? Here you can find an image with the script to explore the problem: https://dl.dropbox.com/u/11804892/glamour-treemorphs.zip > > > MorphTreeMorph >> update: > > > update: aSymbol > aSymbol == #selection ifTrue: [^ self listManager updateSelectionFromModel]. > ((aSymbol isKindOf: Array) and: [aSymbol size > 1 and: [aSymbol first == #selectItems and: [aSymbol second isCollection]]]) > ifTrue: [^ self selectedItems: aSymbol second]. > aSymbol == self nodeListSelector ifTrue: [^ self updateList]. > aSymbol == #selectAll ifTrue: [^ self listManager selectAll]. > aSymbol == #deselectAll ifTrue: [^ self listManager deselectAll]. > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #openPath]]]) "allow directed path opening where multiple trees exist" > ifTrue: > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > openPath: (aSymbol allButFirst: 2)]. > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #openItemPath]]]) "allow directed path opening where multiple trees exist" > ifTrue: > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > openItemPath: (aSymbol allButFirst: 2)]. > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #expandAllFromNode:]]]) > ifTrue: > [^ self expandAllFromNode: aSymbol third]. > ((aSymbol isKindOf: Array) > and: [aSymbol size > 1 and: [aSymbol first == self nodeListSelector and: [ > aSymbol second == #closeItemPath]]]) "allow directed path closing where multiple trees exist" > ifTrue: > [^ (self allNodeMorphs at: 1 ifAbsent: [^self]) > closeItemPath: (aSymbol allButFirst: 2)]. > ((aSymbol isKindOf: Array) > and: [aSymbol notEmpty and: [aSymbol first == #openPath]]) > ifTrue: > [^(self allNodeMorphs at: 1 ifAbsent: [^self]) > openPath: aSymbol allButFirst]. > ((aSymbol isKindOf: Array) > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector and: [ > aSymbol second == #expandRoots]]]) > ifTrue: > [^self expandRoots]. > ((aSymbol isKindOf: Array) > and: [aSymbol size = 2 and: [aSymbol first = self nodeListSelector]]) > ifTrue: [aSymbol second = #expandAll ifTrue: [^ self expandAll]. > aSymbol second = #collapseAll ifTrue: [^ self collapseAll]]

Jan. 31, 2013