September 2012 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Camillo Bruni

On 2012-09-09, at 15:25, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > On Sun, Sep 9, 2012 at 3:20 PM, Camillo Bruni <camillobruni(a)gmail.com>wrote: > >> >> On 2012-09-09, at 15:16, Mariano Martinez Peck <marianopeck(a)gmail.com> >> wrote: >> >>> allFileNames >>> cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ]. >>> ^ allFileNames ifNil: [ >>> allFileNames := self loadAllFileNames] >>> >>> >>> If you put a halt in the first if, you will see it stops... >>> because cacheFileNames is nil. In 1.4 you have: >>> >>> allFileNamesOrCache >>> ^ allFileNames ifNil: [self allFileNames] >>> >>> so it kind of always cached... so maybe this is a difference that affects >>> the results? >> >> >> humm you might be right |(. so metacello should explicitely tell to cache >> stuff in 2.0 then >> >> >> > > I would do > > MCFileBasedRepository >> initialize > cacheFileNames := true > > or something like test. But first, we should be sure this was really one of > the causes of the slowdown you'll break the whole download optimizations if you enable these caches there, since it will never find the newly downloaded files again :P I think there is a method, something like cacheAllFileNamesDuring: or so...

Sept. 9, 2012

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Mariano Martinez Peck

Send me the doIt to install your confs and I will try to try it. On Sun, Sep 9, 2012 at 3:25 PM, Mariano Martinez Peck <marianopeck(a)gmail.com > wrote: > > > On Sun, Sep 9, 2012 at 3:20 PM, Camillo Bruni <camillobruni(a)gmail.com>wrote: > >> >> On 2012-09-09, at 15:16, Mariano Martinez Peck <marianopeck(a)gmail.com> >> wrote: >> >> > allFileNames >> > cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ]. >> > ^ allFileNames ifNil: [ >> > allFileNames := self loadAllFileNames] >> > >> > >> > If you put a halt in the first if, you will see it stops... >> > because cacheFileNames is nil. In 1.4 you have: >> > >> > allFileNamesOrCache >> > ^ allFileNames ifNil: [self allFileNames] >> > >> > so it kind of always cached... so maybe this is a difference that >> affects >> > the results? >> >> >> humm you might be right |(. so metacello should explicitely tell to cache >> stuff in 2.0 then >> >> >> > > I would do > > MCFileBasedRepository >> initialize > cacheFileNames := true > > or something like test. But first, we should be sure this was really one > of the causes of the slowdown > > > > -- > Mariano > http://marianopeck.wordpress.com > > -- Mariano http://marianopeck.wordpress.com

Sept. 9, 2012

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Mariano Martinez Peck

On Sun, Sep 9, 2012 at 3:20 PM, Camillo Bruni <camillobruni(a)gmail.com>wrote: > > On 2012-09-09, at 15:16, Mariano Martinez Peck <marianopeck(a)gmail.com> > wrote: > > > allFileNames > > cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ]. > > ^ allFileNames ifNil: [ > > allFileNames := self loadAllFileNames] > > > > > > If you put a halt in the first if, you will see it stops... > > because cacheFileNames is nil. In 1.4 you have: > > > > allFileNamesOrCache > > ^ allFileNames ifNil: [self allFileNames] > > > > so it kind of always cached... so maybe this is a difference that affects > > the results? > > > humm you might be right |(. so metacello should explicitely tell to cache > stuff in 2.0 then > > > I would do MCFileBasedRepository >> initialize cacheFileNames := true or something like test. But first, we should be sure this was really one of the causes of the slowdown -- Mariano http://marianopeck.wordpress.com

Sept. 9, 2012

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Camillo Bruni

On 2012-09-09, at 15:16, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > allFileNames > cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ]. > ^ allFileNames ifNil: [ > allFileNames := self loadAllFileNames] > > > If you put a halt in the first if, you will see it stops... > because cacheFileNames is nil. In 1.4 you have: > > allFileNamesOrCache > ^ allFileNames ifNil: [self allFileNames] > > so it kind of always cached... so maybe this is a difference that affects > the results? humm you might be right |(. so metacello should explicitely tell to cache stuff in 2.0 then

Sept. 9, 2012

[Pharo-project] pharo-2.0-tests Â» win - Build # 338 - Still Failing!

by jenkins-pharo.ci.inria.fr＠jenkins-server.lille.inria.fr

Sept. 9, 2012

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Mariano Martinez Peck

allFileNames cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ]. ^ allFileNames ifNil: [ allFileNames := self loadAllFileNames] If you put a halt in the first if, you will see it stops... because cacheFileNames is nil. In 1.4 you have: allFileNamesOrCache ^ allFileNames ifNil: [self allFileNames] so it kind of always cached... so maybe this is a difference that affects the results? On Sun, Sep 9, 2012 at 3:14 PM, Camillo Bruni <camillobruni(a)gmail.com>wrote: > > On 2012-09-09, at 15:12, Mariano Martinez Peck <marianopeck(a)gmail.com> > wrote: > > > I think instVar cacheFileNames is never initialized and hence, it follows > > > > cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ]. > > where is that? > > > On Sun, Sep 9, 2012 at 2:35 PM, Camillo Bruni <camillobruni(a)gmail.com > >wrote: > > > >> > >> On 2012-09-09, at 14:24, Mariano Martinez Peck <marianopeck(a)gmail.com> > >> wrote: > >> > >>> I guess you tried both with an empty package-cache, right? > >> > >> yes, not much of a diff... > > > -- Mariano http://marianopeck.wordpress.com

Sept. 9, 2012

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Camillo Bruni

On 2012-09-09, at 15:12, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > I think instVar cacheFileNames is never initialized and hence, it follows > > cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ]. where is that? > On Sun, Sep 9, 2012 at 2:35 PM, Camillo Bruni <camillobruni(a)gmail.com>wrote: > >> >> On 2012-09-09, at 14:24, Mariano Martinez Peck <marianopeck(a)gmail.com> >> wrote: >> >>> I guess you tried both with an empty package-cache, right? >> >> yes, not much of a diff...

Sept. 9, 2012

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Mariano Martinez Peck

I think instVar cacheFileNames is never initialized and hence, it follows cacheFileNames == true ifFalse: [ ^ self loadAllFileNames ]. On Sun, Sep 9, 2012 at 2:35 PM, Camillo Bruni <camillobruni(a)gmail.com>wrote: > > On 2012-09-09, at 14:24, Mariano Martinez Peck <marianopeck(a)gmail.com> > wrote: > > > I guess you tried both with an empty package-cache, right? > > yes, not much of a diff... > > -- Mariano http://marianopeck.wordpress.com

Sept. 9, 2012

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Camillo Bruni

On 2012-09-09, at 14:24, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > I guess you tried both with an empty package-cache, right? yes, not much of a diff...

Sept. 9, 2012

Re: [Pharo-project] Configuration loading 1.4 vs 2.0

by Camillo Bruni

On 2012-09-09, at 14:14, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > I think it has to do with the change in #readableFileNames Indeed it metacello does this big mistake of gathering all the local gofer-references first. But that would mean on an empty package-cache it should load the same way, but even then it's still considerably slower in 2.0 There's also an additional overhead by the announcement system for recategorizing methods..

Sept. 9, 2012