June 2012 - Pharo-dev - lists.pharo.org

[Pharo-project] Jenkins Pharo 2.0 build failing

by Sean P. DeNigris

>From the console output (https://ci.lille.inria.fr/pharo/view/Pharo%202.0/job/Pharo-2.0/153/console) it looks like maybe primitiveDirectoryEntry is returning nil... -- View this message in context: http://forum.world.st/Jenkins-Pharo-2-0-build-failing-tp4635571.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

June 19, 2012

[Pharo-project] Issue 6076: Pharo 2.0 Jenkins build trigger not working

by Sean P. DeNigris

Maybe I didn't cc the person responsible... Probably an easy fix. I've been triggering the builds manually for the last few days. http://code.google.com/p/pharo/issues/detail?id=6076 -- View this message in context: http://forum.world.st/Issue-6076-Pharo-2-0-Jenkins-build-trigger-not-workin… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

June 19, 2012

Re: [Pharo-project] flatten method is kind of broken

by Tudor Girba

I did not open the issue. Please go ahead :) Doru On 18 Jun 2012, at 20:59, Fabrizio Perin wrote: > Sorry, > back from long weekend offline. I can port the moose extensions to the core indeed. > Doru did you open the issue already? > > Cheers, > Fabrizio > > > 2012/6/16 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > doru > > can you open a bug entry and provide necessary information? > Package and tests? > > Stef > > On Jun 16, 2012, at 8:07 AM, Tudor Girba wrote: > > > Indeed. It would be great to integrate CollectionExtensions into Pharo. > > > > For example, we have: > > #(#(1) #(2 3) #(#(4) 5) ) deepFlatten > > ==> #(1 2 3 4 5) > > > > Cheers, > > Doru > > > > On 15 Jun 2012, at 21:04, StÃ©phane Ducasse wrote: > > > >> fabrizio we should really include some of the moose extensions to pharo. > >> Could you take the lead on that? > >> > >> Did you try gather:? > >> > >> Stef > >> > >> On Jun 15, 2012, at 10:05 AM, Fabrizio Perin wrote: > >> > >>> Hi, > >>> I need to flatten a collection which does not contain other collections necessarily. The method flatten doesn't really work: > >>> > >>> #(#(1 2) #(3 4)) flatten -> #(1 2 3 4) OK > >>> > >>> #(#(1) #(2 3) #(#(4) 5) ) flatten -> #(1 2 3 #(4) 5) I would have expected something like #(1 2 3 4 5) > >>> > >>> #(1 2 3) flatten -> error > >>> #(#(1) 2 3) flatten -> error > >>> > >>> Is this the meant behavior for flatten? Any other method I could use instead? > >>> > >>> Thanks, > >>> Fabrizio > >> > >> > > > > -- > > www.tudorgirba.com > > > > "We are all great at making mistakes." > > > > > > > > > > > > > > > > > > > -- www.tudorgirba.com "What we can governs what we wish."

June 19, 2012

Re: [Pharo-project] compiled method inherits from Collection?

by Igor Stasenko

On 19 June 2012 14:33, Henrik Sperre Johansen <henrik.s.johansen(a)veloxit.no> wrote: > On 19.06.2012 11:46, Fernando Olivero wrote: >> >> Thanks for the info, its a shame we cant easily change the vm. >> >> Oh well, i should first ask for isCompiledMethod before isCollection >> now... >> >> Fernando > > > Why? > I mean, each CompiledMethod IS a collection of bytes, even though those > bytes hold a special meaning. > What do you do when you encounter normal ByteArrays? > i think CM inherit from Collection is abuse, and makes little sense: (Object>>#yourself) do: collect: select: add: remove: detect: so, only to reuse #at:/#at:put: ? but it could live with basicAt:/basicAt:put: just well. > Cheers, > Henry -- Best regards, Igor Stasenko.

June 19, 2012

[Pharo-project] Issue 6069: Test guard for 20132

by Sean P. DeNigris

This is an easy slice to review (SLICE-Issue-6069-Test-guard-for-20132-SeanDeNigris.1). Mostly one-liner changes, all with newly passing tests... http://code.google.com/p/pharo/issues/detail?id=6069 Sean -- View this message in context: http://forum.world.st/Issue-6069-Test-guard-for-20132-tp4635559.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

June 19, 2012

Re: [Pharo-project] who can have a look at Issue 5913: Remove Squeak epoch

by Sean P. DeNigris

I wrote some tests to show the broken behavior. I'm attaching them to the issue and http://forum.world.st/file/n4635557/DateAndTimeTest-test_-_epoch.st to Nabble . Comments inline below... Eliot Miranda-2 wrote > >> We recently agreed that the Squeak epoch was well-defined, i.e. the >> start of the 20th century in GMT. This is clear if you read the >> SMalltalk-80 V2 sources. The reason advanced for changing to Unix was >> that the Squeak epoch is not well-defined. That argument is incorrect. > My understanding of what we found was that ST-80 referenced GMT, but Squeak was cloudy (IMO wrong) from the beginning [1]. However, the actual constant SqueakEpoch is actually a number of julian days, so that *could* stay unchanged if we decide that way. [1] http://forum.world.st/Re-Pharo-project-Epoch-returns-local-offset-tp4630581… Eliot Miranda-2 wrote > >> Further, the Squeak epoch is embedded in the VMs, in their answering both >> seconds and microseconds from the epoch. So there's work involved in >> getting rid of it. > This test indicates to me that the VM is using the same (wrong) logic as the image: testSqueakEpochClock | secondsFromClock secondsSinceEpochUTC | self useTimeZone: 'EDT' during: [ secondsFromClock := Time primSecondsClock. secondsSinceEpochUTC := (DateAndTime now - '1901-01-01T00:00:00+00:00' asDateAndTime) asSeconds. "Fails because the clock returns the number of seconds since 1901-01-01T00:00:00+(localOffset)" self deny: secondsFromClock = (secondsSinceEpochUTC + DateAndTime localOffset asSeconds). self assert: secondsFromClock equals: secondsSinceEpochUTC ]. StÃ©phane Ducasse wrote > > Now Sean what was your problem? Because may be we can also improve > Squeak-epoch. > Any time a DateAndTime is converted to seconds, the result is "the number of seconds since 1901-01-01T00:00:00+(localOffset)", which is indeterminate. For example (see #testSqueakEpochAcrossTimeZones): 1. aDateAndTime asSeconds. 2. quit the image 3. move to a different time zone (or set localTimeZone: to a different tz) 4. open the image again 5. restore the DateAndTime e.g. #fromSeconds: It is a different DateAndTime!! I'm clear (but please review the tests) that whatever epoch we choose: - the implementation *around* it must be fixed - the VM should be changed - any existing integers representing DateAndTime's will be invalid I think the only reason we've gotten this far without anyone noticing is that they are converted to/from integers in the same incorrect way in both directions, so unless you transport live instances into a different time zone, you would never notice. The only question that I see we've come down to is: - keep the Squeak epoch, because it is elegant (turn of the century...) or - use the Unix epoch, because it is well-known and documented This is honestly much less important than the givens above, so this is what I'll do... I'm going to create a new issue and to fix the image-side issues I mentioned, and we can have fun debating this last question, which seems to come down to style, ad infinitum ;-) Sean -- View this message in context: http://forum.world.st/who-can-have-a-look-at-Issue-5913-Remove-Squeak-epoch… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

June 19, 2012

[Pharo-project] [update 2.0] #20142

by StÃ©phane Ducasse

20142 ----- - Issue 6084: [BUG]: File Browser cannot load mcz files. Thanks Sean DeNigris http://code.google.com/p/pharo/issues/detail?id=6084 - Issue 6088: primitive:numArgs:numTemps:stackSize:literals:bytecodes:trailer: should use #needsFrameSize:. Thanks Marcus Denker. http://code.google.com/p/pharo/issues/detail?id=6088 - Issue 6087: make doPerformOldLargeFrame to decompile with the temps Thanks Marcus Denker. http://code.google.com/p/pharo/issues/detail?id=6087 - Issue 6083: Mouse down events are being processed twice. Thanks Sean DeNigris. http://code.google.com/p/pharo/issues/detail?id=6083

June 19, 2012

[Pharo-project] [update 2.0] #20141

by StÃ©phane Ducasse

20141 ----- - Issue 4734: file out of packages raises an exception with Nautilus. Thanks Sean DeNigris, Guillermo and others :) http://code.google.com/p/pharo/issues/detail?id=4734 - Issue 6054: Error when reading zip files with Squeak date/time format. Thanks Sean DeNigris. http://code.google.com/p/pharo/issues/detail?id=6054

June 19, 2012

Re: [Pharo-project] The Magic of FileSystem

by StÃ©phane Ducasse

:) I want the same with OPAL :) Stef > This... > localFileName: aString > | dir entry parent fileNameWithoutTrailingSlash | > super localFileName: aString. > parent := FileDirectory default. > > self flag: 'directoryExists: fails if trailing slash. Replace this whole > mess with FS'. > fileNameWithoutTrailingSlash := fileName last = $/ ifTrue: [ fileName > allButLast ] ifFalse: [ fileName ]. > (parent directoryExists: fileNameWithoutTrailingSlash) ifTrue: [ > dir := FileDirectory on: (parent fullNameFor: fileName). > entry := dir directoryEntry. > self modifiedAt: (DateAndTime fromSeconds: entry modificationTime) ]. > fileName last = $/ ifFalse: [ fileName := fileName, '/' ]. > (which I *think* had an undiscovered bug, invisible due to the complexity) > > vs. This... > localFileName: aString > > | file | > super localFileName: aString. > file := aString asFileReference. > file exists ifFalse: [ ^ self ]. > self modifiedAt: file entry modificationTime. > > Ahhhh... > > Cheers, > Sean > > -- > View this message in context: http://forum.world.st/The-Magic-of-FileSystem-tp4635471.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. >

June 19, 2012

Re: [Pharo-project] Integer>>asDateFromZip

by StÃ©phane Ducasse

ok I will have a look at it later this evening. Thanks. Thanks. Thanks. > I tagged issue 6054 as FixToInclude. > > Sven Van Caekenberghe wrote >>> >>> Is there some quick patch that I could do to get passed this, as it is >>> blocking the loading of code, which is rather fundamental. >>> >> >> I didn't realize this hadn't been integrated... >> http://code.google.com/p/pharo/issues/detail?id=6054 >> >> -- >> View this message in context: http://forum.world.st/Integer-asDateFromZip-tp4635452p4635460.html >> Sent from the Pharo Smalltalk mailing list archive at Nabble.com. >> > >

June 19, 2012