September 2011 - Pharo-dev - lists.pharo.org

[Pharo-project] scaled decimal question

by StÃ©phane Ducasse

Why (0.1 asScaledDecimal: 2) + (0.2 asScaledDecimal: 2) = (0.3 asScaledDecimal: 2) returns false while 0.1s2 + 0.2s2 = 0.3s2 returns true ?

Sept. 17, 2011

[Pharo-project] [update 1.4] #14147

by StÃ©phane Ducasse

14147 ----- Issue 4816: Really cleaning messageSet and subclasses. http://code.google.com/p/pharo/issues/detail?id=4816 Now we can remove MessageSet and subclasses.... Should do another pass to verify it. Stef

Sept. 17, 2011

[Pharo-project] bug report

by HwaJong Oh

'Here is a float "%e" and an integer "%d".' printf: #(0.000000000001 42). evalutes to 'Here is a float "1.0" and an integer "42".' I think 'Here is a float "1.0e-12" and an integer "42".' is the right answer. -- View this message in context: http://forum.world.st/printing-Scientific-notation-of-float-tp3778559p38200… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Sept. 17, 2011

Re: [Pharo-project] ChangeSet element has nil protocol

by StÃ©phane Ducasse

Veronica I did the following: - compute and store the category since the changeRecord does not have it. - turn the RGMethodDefinition asActive so that the FlatBrowser can display the source of the method To see that in action: changeSorter open browse changeset (b) Stef changedMessageList "Used by a message set browser to access the list view information." | messageList | messageList := OrderedCollection new. changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | classNameInFull := clAssoc key asString. classNameInParts := classNameInFull findTokens: ' '. (clAssoc value allChangeTypes includes: #comment) ifTrue: [messageList add: (RGCommentDefinition new parentName: clAssoc key asSymbol)]. clAssoc value methodChangeTypes associationsDo: [:mAssoc | (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: [messageList add: ((RGMethodDefinition named: mAssoc key) protocol: (self protocolFor: mAssoc key definedIn: classNameInParts first asSymbol isMeta: (classNameInParts size > 1)); parentName: clAssoc key asSymbol; isMetaSide: (classNameInParts size > 1)) asActive ]]]. ^ messageList asArray sort On Sep 17, 2011, at 12:04 PM, StÃ©phane Ducasse wrote: > Hi veronica > > Apparently in the ChangeSet the RG method definition have nil protocols. > Do you have one idea where it could come from. > I imagine when created but I should look for it. > > Ben I'm removing the latest reference to ChangedMessageSet and it was used by the > ChangeSorter. So I'm making sure that flat list is robust when protocol returns nil. > > Stef > >

Sept. 17, 2011

Re: [Pharo-project] ChangeSet element has nil protocol

by StÃ©phane Ducasse

In fact not :( The SourcedMethodReference category is nil.... so I will look for the place which access (and from where the category). Stef On Sep 17, 2011, at 12:19 PM, StÃ©phane Ducasse wrote: > I guess I found it > > changedMessageList > "Used by a message set browser to access the list view information." > > | messageList | > messageList := OrderedCollection new. > changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | > classNameInFull := clAssoc key asString. > classNameInParts := classNameInFull findTokens: ' '. > > (clAssoc value allChangeTypes includes: #comment) ifTrue: > [messageList add: > (SourcedMethodReference new > setClassSymbol: classNameInParts first asSymbol > classIsMeta: false > methodSymbol: #Comment > stringVersion: classNameInFull, ' Comment')]. > > clAssoc value methodChangeTypes associationsDo: [:mAssoc | > (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: > [self halt. > > messageList add: > (SourcedMethodReference new > setClassSymbol: classNameInParts first asSymbol > classIsMeta: classNameInParts size > 1 > methodSymbol: mAssoc key > stringVersion: classNameInFull, ' ' , mAssoc key)]]]. > > ^^^^^^^^^^^^^ > ^ messageList asArray sort > > > versus > > changedMessageList > "Used by a message set browser to access the list view information." > > | messageList | > messageList := OrderedCollection new. > changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | > classNameInFull := clAssoc key asString. > classNameInParts := classNameInFull findTokens: ' '. > > (clAssoc value allChangeTypes includes: #comment) ifTrue: > [messageList add: > (RGCommentDefinition new > parentName: clAssoc key asSymbol)]. > > clAssoc value methodChangeTypes associationsDo: [:mAssoc | > (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: > [self halt. > messageList add: > ((RGMethodDefinition named: mAssoc key) > parentName: clAssoc key asSymbol; > isMetaSide: (classNameInParts size > 1))]]]. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > ^ messageList asArray sort > > > > >

Sept. 17, 2011

Re: [Pharo-project] ChangeSet element has nil protocol

by StÃ©phane Ducasse

I guess I found it changedMessageList "Used by a message set browser to access the list view information." | messageList | messageList := OrderedCollection new. changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | classNameInFull := clAssoc key asString. classNameInParts := classNameInFull findTokens: ' '. (clAssoc value allChangeTypes includes: #comment) ifTrue: [messageList add: (SourcedMethodReference new setClassSymbol: classNameInParts first asSymbol classIsMeta: false methodSymbol: #Comment stringVersion: classNameInFull, ' Comment')]. clAssoc value methodChangeTypes associationsDo: [:mAssoc | (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: [self halt. messageList add: (SourcedMethodReference new setClassSymbol: classNameInParts first asSymbol classIsMeta: classNameInParts size > 1 methodSymbol: mAssoc key stringVersion: classNameInFull, ' ' , mAssoc key)]]]. ^^^^^^^^^^^^^ ^ messageList asArray sort versus changedMessageList "Used by a message set browser to access the list view information." | messageList | messageList := OrderedCollection new. changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | classNameInFull := clAssoc key asString. classNameInParts := classNameInFull findTokens: ' '. (clAssoc value allChangeTypes includes: #comment) ifTrue: [messageList add: (RGCommentDefinition new parentName: clAssoc key asSymbol)]. clAssoc value methodChangeTypes associationsDo: [:mAssoc | (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: [self halt. messageList add: ((RGMethodDefinition named: mAssoc key) parentName: clAssoc key asSymbol; isMetaSide: (classNameInParts size > 1))]]]. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^ messageList asArray sort

Sept. 17, 2011

[Pharo-project] ChangeSet element has nil protocol

by StÃ©phane Ducasse

Hi veronica Apparently in the ChangeSet the RG method definition have nil protocols. Do you have one idea where it could come from. I imagine when created but I should look for it. Ben I'm removing the latest reference to ChangedMessageSet and it was used by the ChangeSorter. So I'm making sure that flat list is robust when protocol returns nil. Stef

Sept. 17, 2011

[Pharo-project] in finder *Set* + regexp -> Error

by StÃ©phane Ducasse

Hi ben may be you should trap errors like that. in fact the correct form is .*Set.* and it works. Stef

Sept. 17, 2011

Re: [Pharo-project] [squeak-dev] Re: Issue 4538 and CompiledMethod equality

by Mariano Martinez Peck

> Or maybe after reading: >> >> literal1 := self literalAt: numLits. >> literal2 := method literalAt: numLits. >> ^ (literal1 == literal2) or: [literal1 key isNil == literal2 key >> isNil and: [literal1 value == literal2 value]]. >> >> I we are sure that the last literal is always an Association >> > > If it's not then one is playing fast and loose with the system. But if the > method doesn't contain a super send then as far as the VM is concerned it > doesn't need an association, and that might be the case with, for example, > shared inst var accessors in Newspeak. So instead of assuming its an > association write it something like > > ^literal1 class == literal2 class > and: [literal1 isVariableBinding > ifTrue: [literal1 key = literal2 key and: [literal1 value = > literal2 value]] > ifFalse: [literal1 = literal2]] > > >> Thanks. Issue and slice in http://code.google.com/p/pharo/issues/detail?id=4814 > Nicolas >> >> >> On Fri, Sep 16, 2011 at 8:12 PM, StÃ©phane Ducasse >> >> <stephane.ducasse(a)inria.fr> wrote: >> >>> >> >>> Mariano >> >>> >> >>> So should we intgerate a fix? >> >>> >> >>> Stef >> >>> >> >>> On Sep 15, 2011, at 11:27 PM, Mariano Martinez Peck wrote: >> >>> >> >>> > >> >>> > >> >>> > >> >>> > BUT, it doesn't mean that Association is always used for globals. >> >>> > CompiledMethod equality is failing because of the last literal, the >> one that >> >>> > maps class name (symbol) and point to the real class. So...when I >> >>> > materialize, both CMs have non-identical associations for the last >> literal, >> >>> > but equal. >> >>> > >> >>> > As Henrik says the last literals are ideally #== to each other. >> >>> > However, no Squeak dialect makes any attempt to keep the class0side >> >>> > associations equal. Look at a class-side method and you'll see it's >> last >> >>> > literal is nil->SomeClass class. Now since this association doesn't >> exist >> >>> > in Smalltalk (unlike last literals on the instance side) the >> compiler merely >> >>> > creates distinct ones for each class-side method. >> >>> > >> >>> > >> >>> > Thanks Eliot for that point. In fact, I have just checked and you >> are >> >>> > right. The tests that are failing for me is those where class side >> methods >> >>> > are involded. In this case, the last literal of the original CM and >> the >> >>> > materialized, gives false in #literalEqual: hence, originalCM = >> >>> > materializedCM is false :( >> >>> > >> >>> > >> >>> > >> >>> > Personally I don't think one can defend the position where method >> >>> > equality is different for instance-side or class-side methods so >> there must >> >>> > be some solutions: >> >>> > >> >>> > 1. special case comparison of the last literal (the methodClass >> >>> > literal), comparing keys and insisting that the keys be #== and the >> values >> >>> > be #== (can't just define it as keys #== since all similar >> class-side >> >>> > methods will be equal irrespective of their actual class). >> >>> > >> >>> > >> >>> > This one seems the easier and fixes my problem :) >> >>> > >> >>> > sameLiteralsAs: method >> >>> > "Compare my literals to those of method. This is needed to >> compare >> >>> > compiled methods." >> >>> > >> >>> > | numLits literal1 literal2 | >> >>> > (numLits := self numLiterals) ~= method numLiterals >> >>> > ifTrue: [ ^ false ]. >> >>> > "The last literal requires special checking instead of using >> >>> > #literalEqual:" >> >>> > 1 to: numLits - 1 do: [ :index | >> >>> > literal1 := self literalAt: index. >> >>> > literal2 := method literalAt: index. >> >>> > (literal1 == literal2 or: [ literal1 literalEqual: literal2 >> ]) >> >>> > ifFalse: [ >> >>> > (index = 1 and: [ #(117 120) includes: self >> primitive ]) >> >>> > ifTrue: [ >> >>> > literal1 isArray >> >>> > ifTrue: [ >> >>> > (literal2 isArray and: [ literal1 >> >>> > allButLast = literal2 allButLast ]) >> >>> > ifFalse: [ self halt. ^ false ] >> ] >> >>> > ifFalse: [ >> >>> > "ExternalLibraryFunction" >> >>> > (literal1 analogousCodeTo: literal2) >> >>> > ifFalse: [ self halt. ^ false ] >> ] ] >> >>> > ifFalse: [ >> >>> > index = (numLits - 1) >> >>> > ifTrue: [ >> >>> > "properties" >> >>> > (self properties analogousCodeTo: >> method >> >>> > properties) >> >>> > ifFalse: [ self halt. ^ false ] >> ] >> >>> > ifFalse: [ self halt. ^ false ] ] ] ]. >> >>> > literal1 := self literalAt: numLits. >> >>> > literal2 := method literalAt: numLits. >> >>> > ^ ((literal1 key == literal2 key) and: [literal1 value == >> literal2 >> >>> > value]). >> >>> > >> >>> > >> >>> > >> >>> > 2. special case comparison of the last literal (the methodClass >> >>> > literal), insisting only that the class of the literal be the same >> if it >> >>> > isVariableBinding. >> >>> > >> >>> > 3. make the compile unique class-side methodClass literals. i.e. if >> a >> >>> > class already has a class-side method then the compiler or method >> dictionary >> >>> > insertion code must find that existing association and reuse it >> >>> > >> >>> > Other ideas? >> >>> > >> >>> > >From my point of view, that literal, the last one does not need to >> be >> >>> > identical to assume 2 CMs are equal. They just need to be equal. >> >>> > >> >>> > >> >>> > -- >> >>> > Mariano >> >>> > http://marianopeck.wordpress.com >> >>> > >> >>> > >> >>> > >> >>> > >> >>> > -- >> >>> > best, >> >>> > Eliot >> >>> > >> >>> > >> >>> > >> >>> > >> >>> > >> >>> > >> >>> > >> >>> > -- >> >>> > Mariano >> >>> > http://marianopeck.wordpress.com >> >>> > >> >>> >> >>> >> >> >> >> >> >> >> >> -- >> >> Mariano >> >> http://marianopeck.wordpress.com >> >> >> >> >> > >> >> > > > -- > best, > Eliot > > > > > -- Mariano http://marianopeck.wordpress.com

Sept. 17, 2011

[Pharo-project] We will deprecate ProtocolBrowser

by StÃ©phane Ducasse

Hi guys I'm sorry but ProtocolBrowser is the last user of MessageSet so we will deprecate it. We cannot continue to have old code that hamper making the system really better. Stef setClassAndSelectorIn: csBlock "Decode strings of the form <selectorName> (<className> [class])" | i classAndSelString selString sel | sel := self selection ifNil: [^ csBlock value: nil value: nil]. (sel isKindOf: RGMethodDefinition) ifTrue: [ ^ csBlock value: sel realClass value: sel selector ]. "MethodReference should be remove" ((sel isKindOf: MethodReference) or: [sel isKindOf: SourcedMethodReference]) ifTrue: [ sel setClassAndSelectorIn: csBlock ] ifFalse: [ selString := sel asString. i := selString indexOf: $(. "Rearrange to <className> [class] <selectorName> , and use MessageSet" classAndSelString := (selString copyFrom: i + 1 to: selString size - 1) , ' ' , (selString copyFrom: 1 to: i - 1) withoutTrailingBlanks. Smalltalk tools messageSet parse: classAndSelString toClassAndSelector: csBlock. ]. parse: methodRef toClassAndSelector: csBlock "Decode strings of the form <className> [class] <selectorName>." | tuple cl | self flag: #mref. "compatibility with pre-MethodReference lists" methodRef ifNil: [ ^ csBlock value: nil value: nil ]. (methodRef isKindOf: RGMethodDefinition) ifTrue: [ ^ csBlock value: methodRef realClass value: methodRef selector ]. (methodRef isKindOf: SourceReference) ifTrue: [ ^ methodRef setClassAndSelectorIn: csBlock ]. methodRef isEmpty ifTrue: [ ^ csBlock value: nil value: nil ]. tuple := methodRef asString findTokens: ' .'. cl := Smalltalk globals at: tuple first asSymbol ifAbsent: [ ^ csBlock value: nil value: nil ]. (tuple size = 2 or: [ tuple size > 2 and: [ (tuple at: 2) ~= 'class' ] ]) ifTrue: [ ^ csBlock value: cl value: (tuple at: 2) asSymbol ] ifFalse: [ ^ csBlock value: cl class value: (tuple at: 3) asSymbol ]

Sept. 17, 2011