September 2011 - Pharo-dev - lists.pharo.org

[Pharo-project] [update 1.4] #14151

by StÃ©phane Ducasse

14151 ----- - Issue 4819: Fix MessageList>>#example. Thanks benjamin van ryseghem. http://code.google.com/p/pharo/issues/detail?id=4819 - Issue 4817: New Widget: Ticking list and widget.Thanks benjamin van ryseghem. http://code.google.com/p/pharo/issues/detail?id=4817 - Issue 4818: Fix for AbstractTool. Thanks benjamin van ryseghem. http://code.google.com/p/pharo/issues/detail?id=4818 - Issue 4821: Fixing changedMessageList to adapt to MessageList use (vs MessageSet R.I.P.). Thanks Veronica Uquillas-Gomez. http://code.google.com/p/pharo/issues/detail?id=4821 Stef

Sept. 17, 2011

[Pharo-project] [update 1.4] #14151

by StÃ©phane Ducasse

14151 ----- - Issue 4819: Fix MessageList>>#example. Thanks benjamin van ryseghem. http://code.google.com/p/pharo/issues/detail?id=4819 - Issue 4817: New Widget: Ticking list and widget.Thanks benjamin van ryseghem. http://code.google.com/p/pharo/issues/detail?id=4817 - Issue 4818: Fix for AbstractTool. Thanks benjamin van ryseghem. http://code.google.com/p/pharo/issues/detail?id=4818 - Issue 4821: Fixing changedMessageList to adapt to MessageList use (vs MessageSet R.I.P.). Thanks Veronica Uquillas-Gomez. http://code.google.com/p/pharo/issues/detail?id=4821 Stef

Sept. 17, 2011

Re: [Pharo-project] ChangeSet element has nil protocol

by StÃ©phane Ducasse

On Sep 17, 2011, at 6:13 PM, Veronica Isabel Uquillas Gomez wrote: > Stef, > > On 17 Sep 2011, at 13:41, StÃ©phane Ducasse wrote: > >> Veronica >> >> I did the following: >> - compute and store the category since the changeRecord does not have it. > > storing the category is not needed since you set the ring method asActive Indeed I got it after. Because the passive bnehavior was not showing the code. I will integrate that. > >> - turn the RGMethodDefinition asActive so that the FlatBrowser can display the source of the method > > It will always get it from the compiled method. > >> >> To see that in action: >> changeSorter open >> browse changeset (b) > > This part is tricky, I was clicking on the contextual menu of the changeSorter on "Browse Change Set (B)" and you get a different browser where no protocol is displayed. > I assume this should open the FlatBrowser, right? to me it looks like older behavior > > > I cleaned a bit the code (specially those ugly local variables): > > changedMessageList > "Used by a message set browser to access the list view information." > > | messageList | > messageList := OrderedCollection new. > changeRecords associationsDo: [:clAssoc | | className classIsMeta | > className := clAssoc key asSymbol. > classIsMeta := (className findTokens: ' ') size > 1. > > (clAssoc value allChangeTypes includes: #comment) ifTrue: > [messageList add: > (RGCommentDefinition new > parentName: className) ]. > > clAssoc value methodChangeTypes associationsDo: [:mAssoc | > (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: > [messageList add: > ((RGMethodDefinition named: mAssoc key) > parentName: className; > isMetaSide: classIsMeta) asActive ]]]. > ^ messageList asArray sort > > > ** the method for getting the protocol could be removed > ** found something missing for comments (they should also behavior like methods). Will do that tomorrow!! > > > Veronica > >> >> Stef >> >> >> changedMessageList >> "Used by a message set browser to access the list view information." >> >> | messageList | >> messageList := OrderedCollection new. >> changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | >> classNameInFull := clAssoc key asString. >> classNameInParts := classNameInFull findTokens: ' '. >> >> (clAssoc value allChangeTypes includes: #comment) ifTrue: >> [messageList add: >> (RGCommentDefinition new >> parentName: clAssoc key asSymbol)]. >> >> clAssoc value methodChangeTypes associationsDo: [:mAssoc | >> (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: >> [messageList add: >> ((RGMethodDefinition named: mAssoc key) >> protocol: (self protocolFor: mAssoc key definedIn: classNameInParts first asSymbol isMeta: (classNameInParts size > 1)); >> parentName: clAssoc key asSymbol; >> isMetaSide: (classNameInParts size > 1)) asActive >> >> ]]]. >> ^ messageList asArray sort >> >> >> >> >> On Sep 17, 2011, at 12:04 PM, StÃ©phane Ducasse wrote: >> >>> Hi veronica >>> >>> Apparently in the ChangeSet the RG method definition have nil protocols. >>> Do you have one idea where it could come from. >>> I imagine when created but I should look for it. >>> >>> Ben I'm removing the latest reference to ChangedMessageSet and it was used by the >>> ChangeSorter. So I'm making sure that flat list is robust when protocol returns nil. >>> >>> Stef >>> >>> >> >> > >

Sept. 17, 2011

[Pharo-project] [update 1.4] #14150

by StÃ©phane Ducasse

14150 ----- - Issue 4820: Cleaning MessageSet hierarchy http://code.google.com/p/pharo/issues/detail?id=4820 removed timeProfilerBrowser, RecentMessageSet, ChangedMessageSet and clean the rest Please test because it may happen that some browser gets some problems but I could not exercise all the paths. Stef

Sept. 17, 2011

Re: [Pharo-project] Class>>asRingDescription

by Veronica Isabel Uquillas Gomez

Fernando, I am almost done with this.. I already implemented some utilities to get ring classes including methods/superclasses/subclasses. Will write some tests and publish tomorrow. Veronica On 15 Sep 2011, at 21:22, Fernando Olivero wrote: > Veronica, i've started to adopt Ring in Gaucho. Very nice work, > excellent tests also! > > A question, why does the following is true? > > Collection asRingDefinition methods isEmpty = true > > If you look at the following method, they should be added here > right?, on the ring definition creation. > > Class>>asRingDefinition > > | ring | > ring := (RGFactory current createClassNamed: self name) > category: self category; > superclassName: self superclass name; > traitCompositionSource: self traitCompositionString; > addInstanceVariables: self instVarNames; > addClassVariables: self classVarNames; > addPoolDictionaries: self poolDictionaryNames; > comment: self organization classComment; > stamp: self organization commentStamp; > definitionSource: self definition; > withMetaclass. > ring theMetaClass > traitCompositionSource: self theMetaClass traitCompositionString; > definitionSource: self theMetaClass definition; > addInstanceVariables: self theMetaClass instVarNames. > ^ring > > > I'm using the latest Pharo1.4 from Jenkins. > > Fernando >

Sept. 17, 2011

Re: [Pharo-project] ChangeSet element has nil protocol

by Veronica Isabel Uquillas Gomez

Stef, On 17 Sep 2011, at 13:41, StÃ©phane Ducasse wrote: > Veronica > > I did the following: > - compute and store the category since the changeRecord does not have it. storing the category is not needed since you set the ring method asActive > - turn the RGMethodDefinition asActive so that the FlatBrowser can display the source of the method It will always get it from the compiled method. > > To see that in action: > changeSorter open > browse changeset (b) This part is tricky, I was clicking on the contextual menu of the changeSorter on "Browse Change Set (B)" and you get a different browser where no protocol is displayed. I assume this should open the FlatBrowser, right? to me it looks like older behavior I cleaned a bit the code (specially those ugly local variables): changedMessageList "Used by a message set browser to access the list view information." | messageList | messageList := OrderedCollection new. changeRecords associationsDo: [:clAssoc | | className classIsMeta | className := clAssoc key asSymbol. classIsMeta := (className findTokens: ' ') size > 1. (clAssoc value allChangeTypes includes: #comment) ifTrue: [messageList add: (RGCommentDefinition new parentName: className) ]. clAssoc value methodChangeTypes associationsDo: [:mAssoc | (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: [messageList add: ((RGMethodDefinition named: mAssoc key) parentName: className; isMetaSide: classIsMeta) asActive ]]]. ^ messageList asArray sort ** the method for getting the protocol could be removed ** found something missing for comments (they should also behavior like methods). Will do that tomorrow!! Veronica > > Stef > > > changedMessageList > "Used by a message set browser to access the list view information." > > | messageList | > messageList := OrderedCollection new. > changeRecords associationsDo: [:clAssoc | | classNameInParts classNameInFull | > classNameInFull := clAssoc key asString. > classNameInParts := classNameInFull findTokens: ' '. > > (clAssoc value allChangeTypes includes: #comment) ifTrue: > [messageList add: > (RGCommentDefinition new > parentName: clAssoc key asSymbol)]. > > clAssoc value methodChangeTypes associationsDo: [:mAssoc | > (#(remove addedThenRemoved) includes: mAssoc value) ifFalse: > [messageList add: > ((RGMethodDefinition named: mAssoc key) > protocol: (self protocolFor: mAssoc key definedIn: classNameInParts first asSymbol isMeta: (classNameInParts size > 1)); > parentName: clAssoc key asSymbol; > isMetaSide: (classNameInParts size > 1)) asActive > > ]]]. > ^ messageList asArray sort > > > > > On Sep 17, 2011, at 12:04 PM, StÃ©phane Ducasse wrote: > >> Hi veronica >> >> Apparently in the ChangeSet the RG method definition have nil protocols. >> Do you have one idea where it could come from. >> I imagine when created but I should look for it. >> >> Ben I'm removing the latest reference to ChangedMessageSet and it was used by the >> ChangeSorter. So I'm making sure that flat list is robust when protocol returns nil. >> >> Stef >> >> > >

Sept. 17, 2011

[Pharo-project] [update 1.4] #14149

by StÃ©phane Ducasse

14149 ----- - Post clean of MessageSet deprecation. - Issue 4811: Restraint the modal of ClassSearch. Thanks Benjmain van Ryseghem. http://code.google.com/p/pharo/issues/detail?id=4811 Stef (more to come :)).

Sept. 17, 2011

Re: [Pharo-project] [squeak-dev] Re: Issue 4538 and CompiledMethod equality

by Mariano Martinez Peck

I wanted to write a test (before Stef asked) but I don't know how to clearly copy a CompiledMethod. First I tried CompiledMethodTest >> testEqualityClassSideMethod | method1 method2 | method1 := self class class >> #returnPlusOne:. method2 := method1 veryDeepCopy. self deny: (method1 literalAt: method1 numLiterals) == (method2 literalAt: method2 numLiterals). self assert: method1 = method2. And it doesn't work, the last literal of both CM point are #==. Then I tried: testEqualityClassSideMethod | method1 method2 originalAssociation | method1 := self class class >> #returnPlusOne:. method2 := method1 veryDeepCopy. originalAssociation := method2 literalAt: method2 numLiterals. method2 literalAt: method2 numLiterals put: (Association key: originalAssociation key value: originalAssociation value). method1 literalAt: method1 numLiterals put: (Association key: originalAssociation key value: originalAssociation value). self deny: (method1 literalAt: method1 numLiterals) == (method2 literalAt: method2 numLiterals). self assert: method1 = method2. Again, same problem. So...I don't know how can I copy a CM completly, that means, even use different objects for the last literals. Any ideas? Thanks! On Sat, Sep 17, 2011 at 11:30 AM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > > Or maybe after reading: >>> >>> literal1 := self literalAt: numLits. >>> literal2 := method literalAt: numLits. >>> ^ (literal1 == literal2) or: [literal1 key isNil == literal2 key >>> isNil and: [literal1 value == literal2 value]]. >>> >>> I we are sure that the last literal is always an Association >>> >> >> If it's not then one is playing fast and loose with the system. But if >> the method doesn't contain a super send then as far as the VM is concerned >> it doesn't need an association, and that might be the case with, for >> example, shared inst var accessors in Newspeak. So instead of assuming its >> an association write it something like >> >> ^literal1 class == literal2 class >> and: [literal1 isVariableBinding >> ifTrue: [literal1 key = literal2 key and: [literal1 value >> = literal2 value]] >> ifFalse: [literal1 = literal2]] >> >> >>> > Thanks. Issue and slice in > http://code.google.com/p/pharo/issues/detail?id=4814 > > > > >> Nicolas >>> >>> >> On Fri, Sep 16, 2011 at 8:12 PM, StÃ©phane Ducasse >>> >> <stephane.ducasse(a)inria.fr> wrote: >>> >>> >>> >>> Mariano >>> >>> >>> >>> So should we intgerate a fix? >>> >>> >>> >>> Stef >>> >>> >>> >>> On Sep 15, 2011, at 11:27 PM, Mariano Martinez Peck wrote: >>> >>> >>> >>> > >>> >>> > >>> >>> > >>> >>> > BUT, it doesn't mean that Association is always used for globals. >>> >>> > CompiledMethod equality is failing because of the last literal, the >>> one that >>> >>> > maps class name (symbol) and point to the real class. So...when I >>> >>> > materialize, both CMs have non-identical associations for the last >>> literal, >>> >>> > but equal. >>> >>> > >>> >>> > As Henrik says the last literals are ideally #== to each other. >>> >>> > However, no Squeak dialect makes any attempt to keep the >>> class0side >>> >>> > associations equal. Look at a class-side method and you'll see it's >>> last >>> >>> > literal is nil->SomeClass class. Now since this association >>> doesn't exist >>> >>> > in Smalltalk (unlike last literals on the instance side) the >>> compiler merely >>> >>> > creates distinct ones for each class-side method. >>> >>> > >>> >>> > >>> >>> > Thanks Eliot for that point. In fact, I have just checked and you >>> are >>> >>> > right. The tests that are failing for me is those where class side >>> methods >>> >>> > are involded. In this case, the last literal of the original CM and >>> the >>> >>> > materialized, gives false in #literalEqual: hence, originalCM = >>> >>> > materializedCM is false :( >>> >>> > >>> >>> > >>> >>> > >>> >>> > Personally I don't think one can defend the position where method >>> >>> > equality is different for instance-side or class-side methods so >>> there must >>> >>> > be some solutions: >>> >>> > >>> >>> > 1. special case comparison of the last literal (the methodClass >>> >>> > literal), comparing keys and insisting that the keys be #== and the >>> values >>> >>> > be #== (can't just define it as keys #== since all similar >>> class-side >>> >>> > methods will be equal irrespective of their actual class). >>> >>> > >>> >>> > >>> >>> > This one seems the easier and fixes my problem :) >>> >>> > >>> >>> > sameLiteralsAs: method >>> >>> > "Compare my literals to those of method. This is needed to >>> compare >>> >>> > compiled methods." >>> >>> > >>> >>> > | numLits literal1 literal2 | >>> >>> > (numLits := self numLiterals) ~= method numLiterals >>> >>> > ifTrue: [ ^ false ]. >>> >>> > "The last literal requires special checking instead of using >>> >>> > #literalEqual:" >>> >>> > 1 to: numLits - 1 do: [ :index | >>> >>> > literal1 := self literalAt: index. >>> >>> > literal2 := method literalAt: index. >>> >>> > (literal1 == literal2 or: [ literal1 literalEqual: literal2 >>> ]) >>> >>> > ifFalse: [ >>> >>> > (index = 1 and: [ #(117 120) includes: self >>> primitive ]) >>> >>> > ifTrue: [ >>> >>> > literal1 isArray >>> >>> > ifTrue: [ >>> >>> > (literal2 isArray and: [ literal1 >>> >>> > allButLast = literal2 allButLast ]) >>> >>> > ifFalse: [ self halt. ^ false ] >>> ] >>> >>> > ifFalse: [ >>> >>> > "ExternalLibraryFunction" >>> >>> > (literal1 analogousCodeTo: >>> literal2) >>> >>> > ifFalse: [ self halt. ^ false ] >>> ] ] >>> >>> > ifFalse: [ >>> >>> > index = (numLits - 1) >>> >>> > ifTrue: [ >>> >>> > "properties" >>> >>> > (self properties analogousCodeTo: >>> method >>> >>> > properties) >>> >>> > ifFalse: [ self halt. ^ false ] >>> ] >>> >>> > ifFalse: [ self halt. ^ false ] ] ] ]. >>> >>> > literal1 := self literalAt: numLits. >>> >>> > literal2 := method literalAt: numLits. >>> >>> > ^ ((literal1 key == literal2 key) and: [literal1 value == >>> literal2 >>> >>> > value]). >>> >>> > >>> >>> > >>> >>> > >>> >>> > 2. special case comparison of the last literal (the methodClass >>> >>> > literal), insisting only that the class of the literal be the same >>> if it >>> >>> > isVariableBinding. >>> >>> > >>> >>> > 3. make the compile unique class-side methodClass literals. i.e. >>> if a >>> >>> > class already has a class-side method then the compiler or method >>> dictionary >>> >>> > insertion code must find that existing association and reuse it >>> >>> > >>> >>> > Other ideas? >>> >>> > >>> >>> > >From my point of view, that literal, the last one does not need to >>> be >>> >>> > identical to assume 2 CMs are equal. They just need to be equal. >>> >>> > >>> >>> > >>> >>> > -- >>> >>> > Mariano >>> >>> > http://marianopeck.wordpress.com >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > -- >>> >>> > best, >>> >>> > Eliot >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > >>> >>> > -- >>> >>> > Mariano >>> >>> > http://marianopeck.wordpress.com >>> >>> > >>> >>> >>> >>> >>> >> >>> >> >>> >> >>> >> -- >>> >> Mariano >>> >> http://marianopeck.wordpress.com >>> >> >>> >> >>> > >>> >>> >> >> >> -- >> best, >> Eliot >> >> >> >> >> > > > -- > Mariano > http://marianopeck.wordpress.com > > -- Mariano http://marianopeck.wordpress.com

Sept. 17, 2011

[Pharo-project] [update 1.4] #14148

by StÃ©phane Ducasse

14148 ----- - Issue 4814: CompiledMethod equality broken for class side methods. Thanks guys! http://code.google.com/p/pharo/issues/detail?id=4814 - Issue 4718: Deprecate old deprecation messages http://code.google.com/p/pharo/issues/detail?id=4718 Thanks Sean De Nigris Stef

Sept. 17, 2011

Re: [Pharo-project] scaled decimal question

by Peter Hugosson-Miller

Probably because Floats are not exact, so the result of #asScaledDecimal: when sent to a Float, differs from what the compiler produces when it parses 0.1s2. -- Cheers, Peter. On 17 sep 2011, at 15:01, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > Why > (0.1 asScaledDecimal: 2) + (0.2 asScaledDecimal: 2) = (0.3 asScaledDecimal: 2) > returns false > > while > > 0.1s2 + 0.2s2 = 0.3s2 > returns true > > ?

Sept. 17, 2011