September 2011 - Pharo-dev - lists.pharo.org

[Pharo-project] [update 1.4] #14153

by Marcus Denker

14153 ----- Issue 2986: DemoModeshould not change Fonts only sizes http://code.google.com/p/pharo/issues/detail?id=2986 -- Marcus Denker -- http://marcusdenker.de

Sept. 18, 2011

Re: [Pharo-project] scaled decimal question

by Frank Shearar

On 17 September 2011 14:06, Peter Hugosson-Miller <oldmanlink(a)gmail.com> wrote: > Probably because Floats are not exact, so the result of #asScaledDecimal: when sent to a Float, differs from what the compiler produces when it parses 0.1s2. Indeed. In particular, the Floats turn themselves into "exact representations" (Float >> #asTrueFraction) - Fractions whose bit patterns duplicate the float representation. That means that the resulting ScaledDecimals (0.1s2 + 0.2s2 and 0.3s2) have differing fraction instvars. frank > -- > Cheers, > Peter. > > On 17 sep 2011, at 15:01, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > >> >> Why >> (0.1 asScaledDecimal: 2) + (0.2 asScaledDecimal: 2) = (0.3 asScaledDecimal: 2) >> returns false >> >> while >> >> 0.1s2 + 0.2s2 = 0.3s2 >> returns true >> >> ? > >

Sept. 18, 2011

[Pharo-project] [update 1.4] #14152

by StÃ©phane Ducasse

14152 ----- - Issue 4824: New tests for CompiledMethod equality. Thanks Mariano Martinez-Peck. http://code.google.com/p/pharo/issues/detail?id=4824 - Issue 4822: Improving TickList. Thanks Benjamin van Ryseghem. http://code.google.com/p/pharo/issues/detail?id=4822 - Issue 4823: Make MCSliceMaker use TickList. Thanks Benjamin van Ryseghem. http://code.google.com/p/pharo/issues/detail?id=4823 Stef

Sept. 18, 2011

Re: [Pharo-project] New CogDroid alpha: with intent filter.

by StÃ©phane Ducasse

thanks dimitry this is cool I would like to buy a tablet for our team to try pharo on it. What do you suggest? Stef On Sep 18, 2011, at 6:54 AM, Dimitry Golubovsky wrote: > I have uploaded a new alpha of CogDroid: > > http://squeakvm-tablet.googlecode.com/files/CogDroid-alpha-20110918.apk > > Intent filtering has been added to the application. Also application > icon and Java package name (org.golubovsky.cogstack) have been > updated. > > Intents in Android are messages that an application may pass around to > invoke other applications that subscribe to filtering intents with > some properties. > > That is, another application may broadcast an Intent (via > startActivity()) with scheme "file", content-type > "application/x-squeak-image", and path to the image as data. CogDroid > will start right with the image given (provided that it exists) > without scanning the sdcard storage for available image files. > > Sample Java code for this: > > public void launchImage(String imgpath) { > Intent cog = new Intent(); > cog.setAction(Intent.ACTION_VIEW); > Uri uri = new Uri.Builder().scheme("file").path(imgpath).build(); > cog.setDataAndType(uri, "application/x-squeak-image"); > try { > startActivity(cog); > } catch (Exception e) { > // process the exception: it is raised if no > recipients were found for this intent, e. g. CogDroid is not > installed. > } > } > > Relevant section in CogDroid's AndroidManifest.xml: > > <intent-filter> > <action android:name="android.intent.action.VIEW" /> > <category android:name="android.intent.category.DEFAULT" /> > <data android:scheme="file" > android:mimeType="application/x-squeak-image" /> > </intent-filter> > > I also created a simple launcher for two images (the application when > installed shows an icon for each image). Unfortunately image paths are > hardcoded (but just for illustration this should be OK), and a single > Activity subclass is required for each image file. > > See under https://gitorious.org/~golubovsky/cogvm/dmg-blessed/trees/master/platforms/… > > Thanks. > > > -- > Dimitry Golubovsky > > Anywhere on the Web >

Sept. 18, 2011

[Pharo-project] New CogDroid alpha: with intent filter.

by Dimitry Golubovsky

I have uploaded a new alpha of CogDroid: http://squeakvm-tablet.googlecode.com/files/CogDroid-alpha-20110918.apk Intent filtering has been added to the application. Also application icon and Java package name (org.golubovsky.cogstack) have been updated. Intents in Android are messages that an application may pass around to invoke other applications that subscribe to filtering intents with some properties. That is, another application may broadcast an Intent (via startActivity()) with scheme "file", content-type "application/x-squeak-image", and path to the image as data. CogDroid will start right with the image given (provided that it exists) without scanning the sdcard storage for available image files. Sample Java code for this: public void launchImage(String imgpath) { Intent cog = new Intent(); cog.setAction(Intent.ACTION_VIEW); Uri uri = new Uri.Builder().scheme("file").path(imgpath).build(); cog.setDataAndType(uri, "application/x-squeak-image"); try { startActivity(cog); } catch (Exception e) { // process the exception: it is raised if no recipients were found for this intent, e. g. CogDroid is not installed. } } Relevant section in CogDroid's AndroidManifest.xml: <intent-filter> <action android:name="android.intent.action.VIEW" /> <category android:name="android.intent.category.DEFAULT" /> <data android:scheme="file" android:mimeType="application/x-squeak-image" /> </intent-filter> I also created a simple launcher for two images (the application when installed shows an icon for each image). Unfortunately image paths are hardcoded (but just for illustration this should be OK), and a single Activity subclass is required for each image file. See under https://gitorious.org/~golubovsky/cogvm/dmg-blessed/trees/master/platforms/… Thanks. -- Dimitry Golubovsky Anywhere on the Web

Sept. 18, 2011

Re: [Pharo-project] [squeak-dev] Re: Issue 4538 and CompiledMethod equality

by Mariano Martinez Peck

On Sat, Sep 17, 2011 at 9:00 PM, Eliot Miranda <eliot.miranda(a)gmail.com>wrote: > > > On Sat, Sep 17, 2011 at 8:39 AM, Mariano Martinez Peck < > marianopeck(a)gmail.com> wrote: > >> I wanted to write a test (before Stef asked) but I don't know how to >> clearly copy a CompiledMethod. First I tried >> >> CompiledMethodTest >> testEqualityClassSideMethod >> | method1 method2 | >> method1 := self class class >> #returnPlusOne:. >> method2 := method1 veryDeepCopy. >> self deny: (method1 literalAt: method1 numLiterals) == (method2 >> literalAt: method2 numLiterals). >> self assert: method1 = method2. >> >> And it doesn't work, the last literal of both CM point are #==. >> >> Then I tried: >> >> testEqualityClassSideMethod >> | method1 method2 originalAssociation | >> method1 := self class class >> #returnPlusOne:. >> method2 := method1 veryDeepCopy. >> originalAssociation := method2 literalAt: method2 numLiterals. >> method2 literalAt: method2 numLiterals put: (Association key: >> originalAssociation key value: originalAssociation value). >> method1 literalAt: method1 numLiterals put: (Association key: >> originalAssociation key value: originalAssociation value). >> self deny: (method1 literalAt: method1 numLiterals) == (method2 >> literalAt: method2 numLiterals). >> self assert: method1 = method2. >> >> Again, same problem. >> >> So...I don't know how can I copy a CM completly, that means, even use >> different objects for the last literals. Any ideas? >> > > Compile them from source using the same and different source. Generate > source with subtle differences etc. e.g. use > Behavior>compile:classified:notifying:trailer:ifFail: which answers a > compiled method. > Thanks Eliot for the point :) Two new test: #testEqualityInstanceSideMethod and #testEqualityClassSideMethod. testEqualityClassSideMethod should be failing before http://code.google.com/p/pharo/issues/detail?id=4814 and green after it. > > > >> Thanks! >> >> >> On Sat, Sep 17, 2011 at 11:30 AM, Mariano Martinez Peck < >> marianopeck(a)gmail.com> wrote: >> >>> >>> Or maybe after reading: >>>>> >>>>> literal1 := self literalAt: numLits. >>>>> literal2 := method literalAt: numLits. >>>>> ^ (literal1 == literal2) or: [literal1 key isNil == literal2 key >>>>> isNil and: [literal1 value == literal2 value]]. >>>>> >>>>> I we are sure that the last literal is always an Association >>>>> >>>> >>>> If it's not then one is playing fast and loose with the system. But if >>>> the method doesn't contain a super send then as far as the VM is concerned >>>> it doesn't need an association, and that might be the case with, for >>>> example, shared inst var accessors in Newspeak. So instead of assuming its >>>> an association write it something like >>>> >>>> ^literal1 class == literal2 class >>>> and: [literal1 isVariableBinding >>>> ifTrue: [literal1 key = literal2 key and: [literal1 >>>> value = literal2 value]] >>>> ifFalse: [literal1 = literal2]] >>>> >>>> >>>>> >>> Thanks. Issue and slice in >>> http://code.google.com/p/pharo/issues/detail?id=4814 >>> >>> >>> >>> >>>> Nicolas >>>>> >>>>> >> On Fri, Sep 16, 2011 at 8:12 PM, StÃ©phane Ducasse >>>>> >> <stephane.ducasse(a)inria.fr> wrote: >>>>> >>> >>>>> >>> Mariano >>>>> >>> >>>>> >>> So should we intgerate a fix? >>>>> >>> >>>>> >>> Stef >>>>> >>> >>>>> >>> On Sep 15, 2011, at 11:27 PM, Mariano Martinez Peck wrote: >>>>> >>> >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > BUT, it doesn't mean that Association is always used for globals. >>>>> >>> > CompiledMethod equality is failing because of the last literal, >>>>> the one that >>>>> >>> > maps class name (symbol) and point to the real class. So...when I >>>>> >>> > materialize, both CMs have non-identical associations for the >>>>> last literal, >>>>> >>> > but equal. >>>>> >>> > >>>>> >>> > As Henrik says the last literals are ideally #== to each other. >>>>> >>> > However, no Squeak dialect makes any attempt to keep the >>>>> class0side >>>>> >>> > associations equal. Look at a class-side method and you'll see >>>>> it's last >>>>> >>> > literal is nil->SomeClass class. Now since this association >>>>> doesn't exist >>>>> >>> > in Smalltalk (unlike last literals on the instance side) the >>>>> compiler merely >>>>> >>> > creates distinct ones for each class-side method. >>>>> >>> > >>>>> >>> > >>>>> >>> > Thanks Eliot for that point. In fact, I have just checked and you >>>>> are >>>>> >>> > right. The tests that are failing for me is those where class >>>>> side methods >>>>> >>> > are involded. In this case, the last literal of the original CM >>>>> and the >>>>> >>> > materialized, gives false in #literalEqual: hence, originalCM >>>>> = >>>>> >>> > materializedCM is false :( >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > Personally I don't think one can defend the position where method >>>>> >>> > equality is different for instance-side or class-side methods so >>>>> there must >>>>> >>> > be some solutions: >>>>> >>> > >>>>> >>> > 1. special case comparison of the last literal (the methodClass >>>>> >>> > literal), comparing keys and insisting that the keys be #== and >>>>> the values >>>>> >>> > be #== (can't just define it as keys #== since all similar >>>>> class-side >>>>> >>> > methods will be equal irrespective of their actual class). >>>>> >>> > >>>>> >>> > >>>>> >>> > This one seems the easier and fixes my problem :) >>>>> >>> > >>>>> >>> > sameLiteralsAs: method >>>>> >>> > "Compare my literals to those of method. This is needed to >>>>> compare >>>>> >>> > compiled methods." >>>>> >>> > >>>>> >>> > | numLits literal1 literal2 | >>>>> >>> > (numLits := self numLiterals) ~= method numLiterals >>>>> >>> > ifTrue: [ ^ false ]. >>>>> >>> > "The last literal requires special checking instead of using >>>>> >>> > #literalEqual:" >>>>> >>> > 1 to: numLits - 1 do: [ :index | >>>>> >>> > literal1 := self literalAt: index. >>>>> >>> > literal2 := method literalAt: index. >>>>> >>> > (literal1 == literal2 or: [ literal1 literalEqual: >>>>> literal2 ]) >>>>> >>> > ifFalse: [ >>>>> >>> > (index = 1 and: [ #(117 120) includes: self >>>>> primitive ]) >>>>> >>> > ifTrue: [ >>>>> >>> > literal1 isArray >>>>> >>> > ifTrue: [ >>>>> >>> > (literal2 isArray and: [ literal1 >>>>> >>> > allButLast = literal2 allButLast ]) >>>>> >>> > ifFalse: [ self halt. ^ false >>>>> ] ] >>>>> >>> > ifFalse: [ >>>>> >>> > "ExternalLibraryFunction" >>>>> >>> > (literal1 analogousCodeTo: >>>>> literal2) >>>>> >>> > ifFalse: [ self halt. ^ false >>>>> ] ] ] >>>>> >>> > ifFalse: [ >>>>> >>> > index = (numLits - 1) >>>>> >>> > ifTrue: [ >>>>> >>> > "properties" >>>>> >>> > (self properties analogousCodeTo: >>>>> method >>>>> >>> > properties) >>>>> >>> > ifFalse: [ self halt. ^ false >>>>> ] ] >>>>> >>> > ifFalse: [ self halt. ^ false ] ] ] >>>>> ]. >>>>> >>> > literal1 := self literalAt: numLits. >>>>> >>> > literal2 := method literalAt: numLits. >>>>> >>> > ^ ((literal1 key == literal2 key) and: [literal1 value == >>>>> literal2 >>>>> >>> > value]). >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > 2. special case comparison of the last literal (the methodClass >>>>> >>> > literal), insisting only that the class of the literal be the >>>>> same if it >>>>> >>> > isVariableBinding. >>>>> >>> > >>>>> >>> > 3. make the compile unique class-side methodClass literals. i.e. >>>>> if a >>>>> >>> > class already has a class-side method then the compiler or method >>>>> dictionary >>>>> >>> > insertion code must find that existing association and reuse it >>>>> >>> > >>>>> >>> > Other ideas? >>>>> >>> > >>>>> >>> > >From my point of view, that literal, the last one does not need >>>>> to be >>>>> >>> > identical to assume 2 CMs are equal. They just need to be equal. >>>>> >>> > >>>>> >>> > >>>>> >>> > -- >>>>> >>> > Mariano >>>>> >>> > http://marianopeck.wordpress.com >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > -- >>>>> >>> > best, >>>>> >>> > Eliot >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > >>>>> >>> > -- >>>>> >>> > Mariano >>>>> >>> > http://marianopeck.wordpress.com >>>>> >>> > >>>>> >>> >>>>> >>> >>>>> >> >>>>> >> >>>>> >> >>>>> >> -- >>>>> >> Mariano >>>>> >> http://marianopeck.wordpress.com >>>>> >> >>>>> >> >>>>> > >>>>> >>>>> >>>> >>>> >>>> -- >>>> best, >>>> Eliot >>>> >>>> >>>> >>>> >>>> >>> >>> >>> -- >>> Mariano >>> http://marianopeck.wordpress.com >>> >>> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com >> >> > > > -- > best, > Eliot > > -- Mariano http://marianopeck.wordpress.com

Sept. 17, 2011

Re: [Pharo-project] MethodDictionary fast #rehash

by Mariano Martinez Peck

On Sat, Sep 17, 2011 at 10:26 PM, Nicolas Cellier < nicolas.cellier.aka.nice(a)gmail.com> wrote: > 2011/9/17 Mariano Martinez Peck <marianopeck(a)gmail.com>: > > Hi guys. I was checking MethodDictionary >> rehash and this is terribly > slow > > because of the #become. Then I saw #rehashWithoutBecome but it answers a > > different instance. I need a #rehash that does the rehash in the real > object > > and answers self. So...I need the regular #rehash but I want to avoid the > > #become. Is that possible somehow? > > > > This is the current implementation: > > > > rehashWithoutBecome > > > > | newInstance | > > newInstance := self species new: self basicSize - 1. "Make sure it > has > > the same capacity" > > 1 to: self basicSize do: [ :index | > > (self basicAt: index) ifNotNil: [ :key | > > newInstance at: key put: (array at: index) ] ]. > > ^newInstance > > > > I am terrible bad with Collection and friends, but cannot we do soemthing > > like this: > > > > rehashWithoutBecome > > > > | newInstance | > > newInstance := self species new: self basicSize - 1. "Make sure it > has > > the same capacity" > > > > 1 to: self basicSize do: [ :index | > > (self basicAt: index) ifNotNil: [ :key | > > newInstance at: key put: (array at: index) ] ]. > > > > 1 to: newInstance basicSize do: [ :index | > > (newInstance basicAt: index) ifNotNil: [ :key | > > self at: key put: (newInstance array at: index) ] ]. > > > > ^ self > > > > I guess you should at least also copy the nil entries... > Maybe something like > > 1 to: newInstance basicSize do: [ :index | > self basicAt: index put: (newInstance basicAt: index). > array at: index put: (newInstance array at: index)]. > > Good point. So....I was not that mistaken ;) I have just replaced CompiledMethod >> hash with this new method and at least all the tests in MethodDictionaryTest are green. Do you think this implementation is correct or there can be problems? because it is really MUCH faster than the original one. Thanks in advance > > > > > Thanks for any help. > > > > > > -- > > Mariano > > http://marianopeck.wordpress.com > > > > > > -- Mariano http://marianopeck.wordpress.com

Sept. 17, 2011

Re: [Pharo-project] MethodDictionary fast #rehash

by Nicolas Cellier

2011/9/17 Mariano Martinez Peck <marianopeck(a)gmail.com>: > Hi guys. I was checking MethodDictionary >> rehash and this is terribly slow > because of the #become. Then I saw #rehashWithoutBecomeÂ but it answers a > different instance. I need a #rehash that does the rehash in the real object > and answers self. So...I need the regular #rehash but I want to avoid the > #become. Is that possible somehow? > > This is the current implementation: > > rehashWithoutBecome > > Â Â Â | newInstance | > Â Â Â newInstance := self species new: self basicSize - 1. "Make sure it has > the same capacity" > Â Â Â 1 to: self basicSize do: [ :index | > Â Â Â Â Â Â (self basicAt: index) ifNotNil: [ :key | > Â Â Â Â Â Â Â Â Â newInstance at: key put: (array at: index) ] ]. > Â Â Â ^newInstance > > I am terrible bad with Collection and friends, but cannot we do soemthing > like this: > > rehashWithoutBecome > > Â Â Â | newInstance | > Â Â Â newInstance := self species new: self basicSize - 1. "Make sure it has > the same capacity" > > Â Â Â 1 to: self basicSize do: [ :index | > Â Â Â Â Â Â (self basicAt: index) ifNotNil: [ :key | > Â Â Â Â Â Â Â Â Â newInstance at: key put: (array at: index) ] ]. > > Â Â Â 1 to: newInstance basicSize do: [ :index | > Â Â Â Â Â Â (newInstance basicAt: index) ifNotNil: [ :key | > Â Â Â Â Â Â Â Â Â self at: key put: (newInstance array at: index) ] ]. > > Â Â Â ^ self > I guess you should at least also copy the nil entries... Maybe something like 1 to: newInstance basicSize do: [ :index | self basicAt: index put: (newInstance basicAt: index). array at: index put: (newInstance array at: index)]. > > Thanks for any help. > > > -- > Mariano > http://marianopeck.wordpress.com > >

Sept. 17, 2011

[Pharo-project] MethodDictionary fast #rehash

by Mariano Martinez Peck

Hi guys. I was checking MethodDictionary >> rehash and this is terribly slow because of the #become. Then I saw #rehashWithoutBecome but it answers a different instance. I need a #rehash that does the rehash in the real object and answers self. So...I need the regular #rehash but I want to avoid the #become. Is that possible somehow? This is the current implementation: rehashWithoutBecome | newInstance | newInstance := self species new: self basicSize - 1. "Make sure it has the same capacity" 1 to: self basicSize do: [ :index | (self basicAt: index) ifNotNil: [ :key | newInstance at: key put: (array at: index) ] ]. ^newInstance I am terrible bad with Collection and friends, but cannot we do soemthing like this: rehashWithoutBecome | newInstance | newInstance := self species new: self basicSize - 1. "Make sure it has the same capacity" 1 to: self basicSize do: [ :index | (self basicAt: index) ifNotNil: [ :key | newInstance at: key put: (array at: index) ] ]. 1 to: newInstance basicSize do: [ :index | (newInstance basicAt: index) ifNotNil: [ :key | self at: key put: (newInstance array at: index) ] ]. ^ self Thanks for any help. -- Mariano http://marianopeck.wordpress.com

Sept. 17, 2011

Re: [Pharo-project] [squeak-dev] Re: Issue 4538 and CompiledMethod equality

by Eliot Miranda

On Sat, Sep 17, 2011 at 8:39 AM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > I wanted to write a test (before Stef asked) but I don't know how to > clearly copy a CompiledMethod. First I tried > > CompiledMethodTest >> testEqualityClassSideMethod > | method1 method2 | > method1 := self class class >> #returnPlusOne:. > method2 := method1 veryDeepCopy. > self deny: (method1 literalAt: method1 numLiterals) == (method2 > literalAt: method2 numLiterals). > self assert: method1 = method2. > > And it doesn't work, the last literal of both CM point are #==. > > Then I tried: > > testEqualityClassSideMethod > | method1 method2 originalAssociation | > method1 := self class class >> #returnPlusOne:. > method2 := method1 veryDeepCopy. > originalAssociation := method2 literalAt: method2 numLiterals. > method2 literalAt: method2 numLiterals put: (Association key: > originalAssociation key value: originalAssociation value). > method1 literalAt: method1 numLiterals put: (Association key: > originalAssociation key value: originalAssociation value). > self deny: (method1 literalAt: method1 numLiterals) == (method2 > literalAt: method2 numLiterals). > self assert: method1 = method2. > > Again, same problem. > > So...I don't know how can I copy a CM completly, that means, even use > different objects for the last literals. Any ideas? > Compile them from source using the same and different source. Generate source with subtle differences etc. e.g. use Behavior>compile:classified:notifying:trailer:ifFail: which answers a compiled method. > Thanks! > > > On Sat, Sep 17, 2011 at 11:30 AM, Mariano Martinez Peck < > marianopeck(a)gmail.com> wrote: > >> >> Or maybe after reading: >>>> >>>> literal1 := self literalAt: numLits. >>>> literal2 := method literalAt: numLits. >>>> ^ (literal1 == literal2) or: [literal1 key isNil == literal2 key >>>> isNil and: [literal1 value == literal2 value]]. >>>> >>>> I we are sure that the last literal is always an Association >>>> >>> >>> If it's not then one is playing fast and loose with the system. But if >>> the method doesn't contain a super send then as far as the VM is concerned >>> it doesn't need an association, and that might be the case with, for >>> example, shared inst var accessors in Newspeak. So instead of assuming its >>> an association write it something like >>> >>> ^literal1 class == literal2 class >>> and: [literal1 isVariableBinding >>> ifTrue: [literal1 key = literal2 key and: [literal1 value >>> = literal2 value]] >>> ifFalse: [literal1 = literal2]] >>> >>> >>>> >> Thanks. Issue and slice in >> http://code.google.com/p/pharo/issues/detail?id=4814 >> >> >> >> >>> Nicolas >>>> >>>> >> On Fri, Sep 16, 2011 at 8:12 PM, StÃ©phane Ducasse >>>> >> <stephane.ducasse(a)inria.fr> wrote: >>>> >>> >>>> >>> Mariano >>>> >>> >>>> >>> So should we intgerate a fix? >>>> >>> >>>> >>> Stef >>>> >>> >>>> >>> On Sep 15, 2011, at 11:27 PM, Mariano Martinez Peck wrote: >>>> >>> >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > BUT, it doesn't mean that Association is always used for globals. >>>> >>> > CompiledMethod equality is failing because of the last literal, >>>> the one that >>>> >>> > maps class name (symbol) and point to the real class. So...when I >>>> >>> > materialize, both CMs have non-identical associations for the last >>>> literal, >>>> >>> > but equal. >>>> >>> > >>>> >>> > As Henrik says the last literals are ideally #== to each other. >>>> >>> > However, no Squeak dialect makes any attempt to keep the >>>> class0side >>>> >>> > associations equal. Look at a class-side method and you'll see >>>> it's last >>>> >>> > literal is nil->SomeClass class. Now since this association >>>> doesn't exist >>>> >>> > in Smalltalk (unlike last literals on the instance side) the >>>> compiler merely >>>> >>> > creates distinct ones for each class-side method. >>>> >>> > >>>> >>> > >>>> >>> > Thanks Eliot for that point. In fact, I have just checked and you >>>> are >>>> >>> > right. The tests that are failing for me is those where class side >>>> methods >>>> >>> > are involded. In this case, the last literal of the original CM >>>> and the >>>> >>> > materialized, gives false in #literalEqual: hence, originalCM = >>>> >>> > materializedCM is false :( >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > Personally I don't think one can defend the position where method >>>> >>> > equality is different for instance-side or class-side methods so >>>> there must >>>> >>> > be some solutions: >>>> >>> > >>>> >>> > 1. special case comparison of the last literal (the methodClass >>>> >>> > literal), comparing keys and insisting that the keys be #== and >>>> the values >>>> >>> > be #== (can't just define it as keys #== since all similar >>>> class-side >>>> >>> > methods will be equal irrespective of their actual class). >>>> >>> > >>>> >>> > >>>> >>> > This one seems the easier and fixes my problem :) >>>> >>> > >>>> >>> > sameLiteralsAs: method >>>> >>> > "Compare my literals to those of method. This is needed to >>>> compare >>>> >>> > compiled methods." >>>> >>> > >>>> >>> > | numLits literal1 literal2 | >>>> >>> > (numLits := self numLiterals) ~= method numLiterals >>>> >>> > ifTrue: [ ^ false ]. >>>> >>> > "The last literal requires special checking instead of using >>>> >>> > #literalEqual:" >>>> >>> > 1 to: numLits - 1 do: [ :index | >>>> >>> > literal1 := self literalAt: index. >>>> >>> > literal2 := method literalAt: index. >>>> >>> > (literal1 == literal2 or: [ literal1 literalEqual: >>>> literal2 ]) >>>> >>> > ifFalse: [ >>>> >>> > (index = 1 and: [ #(117 120) includes: self >>>> primitive ]) >>>> >>> > ifTrue: [ >>>> >>> > literal1 isArray >>>> >>> > ifTrue: [ >>>> >>> > (literal2 isArray and: [ literal1 >>>> >>> > allButLast = literal2 allButLast ]) >>>> >>> > ifFalse: [ self halt. ^ false >>>> ] ] >>>> >>> > ifFalse: [ >>>> >>> > "ExternalLibraryFunction" >>>> >>> > (literal1 analogousCodeTo: >>>> literal2) >>>> >>> > ifFalse: [ self halt. ^ false >>>> ] ] ] >>>> >>> > ifFalse: [ >>>> >>> > index = (numLits - 1) >>>> >>> > ifTrue: [ >>>> >>> > "properties" >>>> >>> > (self properties analogousCodeTo: >>>> method >>>> >>> > properties) >>>> >>> > ifFalse: [ self halt. ^ false >>>> ] ] >>>> >>> > ifFalse: [ self halt. ^ false ] ] ] ]. >>>> >>> > literal1 := self literalAt: numLits. >>>> >>> > literal2 := method literalAt: numLits. >>>> >>> > ^ ((literal1 key == literal2 key) and: [literal1 value == >>>> literal2 >>>> >>> > value]). >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > 2. special case comparison of the last literal (the methodClass >>>> >>> > literal), insisting only that the class of the literal be the same >>>> if it >>>> >>> > isVariableBinding. >>>> >>> > >>>> >>> > 3. make the compile unique class-side methodClass literals. i.e. >>>> if a >>>> >>> > class already has a class-side method then the compiler or method >>>> dictionary >>>> >>> > insertion code must find that existing association and reuse it >>>> >>> > >>>> >>> > Other ideas? >>>> >>> > >>>> >>> > >From my point of view, that literal, the last one does not need >>>> to be >>>> >>> > identical to assume 2 CMs are equal. They just need to be equal. >>>> >>> > >>>> >>> > >>>> >>> > -- >>>> >>> > Mariano >>>> >>> > http://marianopeck.wordpress.com >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > -- >>>> >>> > best, >>>> >>> > Eliot >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > >>>> >>> > -- >>>> >>> > Mariano >>>> >>> > http://marianopeck.wordpress.com >>>> >>> > >>>> >>> >>>> >>> >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> Mariano >>>> >> http://marianopeck.wordpress.com >>>> >> >>>> >> >>>> > >>>> >>>> >>> >>> >>> -- >>> best, >>> Eliot >>> >>> >>> >>> >>> >> >> >> -- >> Mariano >> http://marianopeck.wordpress.com >> >> > > > -- > Mariano > http://marianopeck.wordpress.com > > -- best, Eliot

Sept. 17, 2011