September 2011 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] about Shout default to shout any text?

by Alain Plantec

On 04/09/2011 22:26, StÃ©phane Ducasse wrote: > Alain > > it means that we should define shoutAboutToStyle: to certain places like inspector pane. > Isn't? > :) > arrggh, I've tried and it exhibits a problem. see the end of the answer. yes, you can do it with a shoutAboutToStyle: something like: Inspector>>shoutAboutToStyle: aPluggableTextMorph ^ (aPluggableTextMorph getTextSelector = #contents) not because an inspector is made of two text views. The one for the contents should not be styled. Only the one for coding should. But this solution is not so good because the model is making an asumptions about the view. It considers that the argument responds to #getTextSelector and that #contents can be the value of the result. Another solution should be to directly set the text editors as not styled when the view is built. Regarding Inspector view, it is built by MorphicUIManager>>openInspector: asMorphOn: withLabel: Normally, sending #styled: to a PluggableTextMorph with true as argument set it as styled. I prefer this solution because of the separation of concern between the model and its view(s). But now that the default is "not styled", this solution is broken. Maybe we should re-introduce a 'styled' inst var and revise the #okToStyle implementation. I open an issue. Alain

Sept. 4, 2011

[Pharo-project] [update 1.4] #14119

by StÃ©phane Ducasse

14119 ----- - Issue 4760: Shout default to shout only if shoutAboutToStyle is defined. Thanks Alain Plantec. http://code.google.com/p/pharo/issues/detail?id=4760 - Issue 4756: More cleaning of ImageSegment. Thanks Mariano Martinez-Peck. http://code.google.com/p/pharo/issues/detail?id=4756 - Issue 4697: OrderedCollectionInspector>>fieldList bug in debugger. Thanks Mike Roberts. http://code.google.com/p/pharo/issues/detail?id=4697 Stef

Sept. 4, 2011

Re: [Pharo-project] Zinc crashing image at start up

by Sven Van Caekenberghe

On 04 Sep 2011, at 21:33, Lukas Renggli wrote: >> Just looking at the code, I can't think of an explanation (since it worked before). The last diff is pretty small, all in one class. >> >> Could it be VM related ? Can I download the exact same VM that you are using, but that would be a linux one I guess ? Maybe I should set up a build process in my virtual Ubuntu but that will take some time. > > I am using an old Cog VM from Eliot's site > http://www.mirandabanda.org/files/Cog/VM/VM.r2370/. I haven't updated > it for months. > >> I took the seaside-zinc image but that was the previous one so that didn't help. >> >> I want to help but where should I start ? Any suggestions ? > > I don't know. Sorry. > > Lukas OK, thanks for the extra info. I'll see what I can do tomorrow, after thinking about this a bit. If I can't reproduce this, I can't debug it. Sven

Sept. 4, 2011

Re: [Pharo-project] about Shout default to shout any text?

by StÃ©phane Ducasse

Alain it means that we should define shoutAboutToStyle: to certain places like inspector pane. Isn't? :) On Sep 4, 2011, at 8:20 PM, Alain Plantec wrote: > Hi all, > just coming back ... > > yes > if "not styled" is the default then #okToStyle should > return false if #shoutAboutToStyle is not implemented by the model: > > > (model respondsTo: #shoutAboutToStyle:) > > ifFalse: [^true]. > > should be: > > (model respondsTo: #shoutAboutToStyle:) > > ifFalse: [^false]. > > Cheers > Alain > > > > > On 04/09/2011 14:25, StÃ©phane Ducasse wrote: >>>> >>>> >>>> The inspector is shouted because the "not to shout" was the default behavior >>>> of Shout, but now, >>>> okToStyle >>>> self shoutEnabled >>>> ifFalse: [^ false]. >>>> (model respondsTo: #shoutAboutToStyle:) >>>> ifFalse: [^true]. >>>> ^model shoutAboutToStyle: self >>>> the bold part make the default behavior "to shout". >>>> So maybe this value should be changed. But let's wait for Alain explanation >>> >>> No, #shoutEnabled returning true makes it enabled. >> >> I do not get it >> >> >> okToStyle >> self shoutEnabled >> ifFalse: [^ false]. >> (model respondsTo: #shoutAboutToStyle:) >> ifFalse: [^true]. >> ^model shoutAboutToStyle: self >> >> shoutEnabled >> ^ self class shoutEnabled >> >> shoutEnabled >> ^ (Smalltalk globals includesKey: #SHPreferences) >> and: [(Smalltalk globals at: #SHPreferences) enabled] >> >> so when shout is loaded self shoutEnabled = true >> >> self shoutEnabled >> ifFalse: [^ false]. >> >> So okToStyle will return true when the method shoutAboutToStyle: is not defined >> >> (model respondsTo: #shoutAboutToStyle:) >> ifFalse: [^true]. >> >> and this is this default that I'm talking about. >> Because if we would return false then only places that specifically define shoutAboutToStyle would be styled. >> >> No? >> >> >> Stef >> > >

Sept. 4, 2011

Re: [Pharo-project] about Shout default to shout any text?

by StÃ©phane Ducasse

On Sep 4, 2011, at 8:20 PM, Alain Plantec wrote: > Hi all, > just coming back ... > > yes > if "not styled" is the default then #okToStyle should > return false if #shoutAboutToStyle is not implemented by the model: > > > (model respondsTo: #shoutAboutToStyle:) > > ifFalse: [^true]. > > should be: > > (model respondsTo: #shoutAboutToStyle:) > > ifFalse: [^false]. Ok this is what I was thinking :) Tx alain. > Cheers > Alain > > > > > On 04/09/2011 14:25, StÃ©phane Ducasse wrote: >>>> >>>> >>>> The inspector is shouted because the "not to shout" was the default behavior >>>> of Shout, but now, >>>> okToStyle >>>> self shoutEnabled >>>> ifFalse: [^ false]. >>>> (model respondsTo: #shoutAboutToStyle:) >>>> ifFalse: [^true]. >>>> ^model shoutAboutToStyle: self >>>> the bold part make the default behavior "to shout". >>>> So maybe this value should be changed. But let's wait for Alain explanation >>> >>> No, #shoutEnabled returning true makes it enabled. >> >> I do not get it >> >> >> okToStyle >> self shoutEnabled >> ifFalse: [^ false]. >> (model respondsTo: #shoutAboutToStyle:) >> ifFalse: [^true]. >> ^model shoutAboutToStyle: self >> >> shoutEnabled >> ^ self class shoutEnabled >> >> shoutEnabled >> ^ (Smalltalk globals includesKey: #SHPreferences) >> and: [(Smalltalk globals at: #SHPreferences) enabled] >> >> so when shout is loaded self shoutEnabled = true >> >> self shoutEnabled >> ifFalse: [^ false]. >> >> So okToStyle will return true when the method shoutAboutToStyle: is not defined >> >> (model respondsTo: #shoutAboutToStyle:) >> ifFalse: [^true]. >> >> and this is this default that I'm talking about. >> Because if we would return false then only places that specifically define shoutAboutToStyle would be styled. >> >> No? >> >> >> Stef >> > >

Sept. 4, 2011

Re: [Pharo-project] Glamour configuration doesn't load in Pharo 1.3

by Tudor Girba

Hi, On 4 Sep 2011, at 20:59, Alain Plantec wrote: > On 04/09/2011 11:13, Lukas Renggli wrote: >>> Strange indeed. The thing is that in my image, these methods are not extensions. So, I cannot see why they would not load. >>> >>> In any case, Glamour was always loaded in the Dev image. >> >> Ok, I do not use the "official" dev image, but then again it worked up >> until a few days ago. Something must have changed in some of the >> dependent packages. >> >> Lukas >> > Hi lukas, > You are using the first slice I pushed in the tracker for testing. > Now, these bad dependencies should be removed because all #shoutAboutToStyle: are in the Shout package (*Shout-Styling meth. cat.). The problem was that some classes, like LessonView, are not in the Core. As such, if the LessonView>>shoutAboutToStyle: is packaged in Shout, it means you cannot load Shout in the Core anymore without loading these other classes. I do not have time to check right now, but we would not want to have it like that. Cheers, Doru > Cheers > Alain > -- www.tudorgirba.com "If you interrupt the barber while he is cutting your hair, you will end up with a messy haircut."

Sept. 4, 2011

Re: [Pharo-project] Zinc crashing image at start up

by Lukas Renggli

> Just looking at the code, I can't think of an explanation (since it worked before). The last diff is pretty small, all in one class. > > Could it be VM related ? Can I download the exact same VM that you are using, but that would be a linux one I guess ? Maybe I should set up a build process in my virtual Ubuntu but that will take some time. I am using an old Cog VM from Eliot's site http://www.mirandabanda.org/files/Cog/VM/VM.r2370/. I haven't updated it for months. > I took the seaside-zinc image but that was the previous one so that didn't help. > > I want to help but where should I start ? Any suggestions ? I don't know. Sorry. Lukas -- Lukas Renggli www.lukas-renggli.ch

Sept. 4, 2011

Re: [Pharo-project] Zinc crashing image at start up

by Sven Van Caekenberghe

On 04 Sep 2011, at 20:27, Lukas Renggli wrote: >> Strange indeed. I just downloaded the lastest base seaside3 image from http://jenkins.lukas-renggli.ch and executed the builder/scripts/seaside3-zinc.st code manually and the server started and worked as expected. > > The strange thing is that it happened in both builds, Seaside 3.0 and 3.1. Yeah, I saw that too, kind of rules out chance, too bad. >> The PrimitiveFailed seems to be in (server) Socket>>#waitForAcceptFor: but nothing was changed in the code calling that, or in surrounding error handlers. >> >> I am correct to assume that the crash is while starting the server ? Or is it later during the save image ? > > Yes, the stack trace is while starting the server. Just looking at the code, I can't think of an explanation (since it worked before). The last diff is pretty small, all in one class. Could it be VM related ? Can I download the exact same VM that you are using, but that would be a linux one I guess ? Maybe I should set up a build process in my virtual Ubuntu but that will take some time. I took the seaside-zinc image but that was the previous one so that didn't help. I want to help but where should I start ? Any suggestions ? Sven

Sept. 4, 2011

Re: [Pharo-project] Glamour configuration doesn't load in Pharo 1.3

by Alain Plantec

On 04/09/2011 11:13, Lukas Renggli wrote: >> Strange indeed. The thing is that in my image, these methods are not extensions. So, I cannot see why they would not load. >> >> In any case, Glamour was always loaded in the Dev image. > > Ok, I do not use the "official" dev image, but then again it worked up > until a few days ago. Something must have changed in some of the > dependent packages. > > Lukas > Hi lukas, You are using the first slice I pushed in the tracker for testing. Now, these bad dependencies should be removed because all #shoutAboutToStyle: are in the Shout package (*Shout-Styling meth. cat.). Cheers Alain

Sept. 4, 2011

Re: [Pharo-project] Zinc crashing image at start up

by Lukas Renggli

> Strange indeed. I just downloaded the lastest base seaside3 image from http://jenkins.lukas-renggli.ch and executed the builder/scripts/seaside3-zinc.st code manually and the server started and worked as expected. The strange thing is that it happened in both builds, Seaside 3.0 and 3.1. > The PrimitiveFailed seems to be in (server) Socket>>#waitForAcceptFor: but nothing was changed in the code calling that, or in surrounding error handlers. > > I am correct to assume that the crash is while starting the server ? Or is it later during the save image ? Yes, the stack trace is while starting the server. Lukas -- Lukas Renggli www.lukas-renggli.ch

Sept. 4, 2011