July 2011 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Stubbing class-side methods

by Igor Stasenko

On 18 July 2011 18:52, Sean P. DeNigris <sean(a)clipperadams.com> wrote: > > Carlo wrote: >> >> Personally when I come across cases like this I either break the (usually >> public) method into a public and internal method, the internal method >> contains the date so we can test the edge cases. >> > > The thing I don't like about this is that I often load a package I've never > used before and go to the tests, which I believe should be examples of how > to use the class, yet I find tests that are not from the POV of a user and > give me less direction than I'd like. With this method, the > sin-to-make-it-testable is on display in the action step of the test instead > of hidden away in the setup as it could be with a stub. > > > Carlo wrote: >> >> Another option which you've probably decided against is to delegate to >> your current class or a Registry to ask for the class with which to use >> for date related tasks, a kind of factory in a way. >> > Yes, this is the best way I can think of, but it feels like a hack. > > > Carlo wrote: >> >> I personally feel Pharo is moving into a more pluggable direction with the >> work on the environment (Smalltalk environment) where we can provide our >> own environment for a particular context >> > That would be awesome! > This looks like a relevant: http://code.google.com/p/pharo/issues/detail?id=4485 > Thanks. > Sean > > -- > View this message in context: http://forum.world.st/Stubbing-class-side-methods-tp3674065p3675843.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > > -- Best regards, Igor Stasenko AKA sig.

July 18, 2011

Re: [Pharo-project] Stubbing class-side methods

by Sean P. DeNigris

Carlo wrote: > > Personally when I come across cases like this I either break the (usually > public) method into a public and internal method, the internal method > contains the date so we can test the edge cases. > The thing I don't like about this is that I often load a package I've never used before and go to the tests, which I believe should be examples of how to use the class, yet I find tests that are not from the POV of a user and give me less direction than I'd like. With this method, the sin-to-make-it-testable is on display in the action step of the test instead of hidden away in the setup as it could be with a stub. Carlo wrote: > > Another option which you've probably decided against is to delegate to > your current class or a Registry to ask for the class with which to use > for date related tasks, a kind of factory in a way. > Yes, this is the best way I can think of, but it feels like a hack. Carlo wrote: > > I personally feel Pharo is moving into a more pluggable direction with the > work on the environment (Smalltalk environment) where we can provide our > own environment for a particular context > That would be awesome! Thanks. Sean -- View this message in context: http://forum.world.st/Stubbing-class-side-methods-tp3674065p3675843.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

July 18, 2011

Re: [Pharo-project] Stubbing class-side methods

by Sean P. DeNigris

Michael Roberts-2 wrote: > > is MyClass a domain class > Yes -- View this message in context: http://forum.world.st/Stubbing-class-side-methods-tp3674065p3675827.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

July 18, 2011

Re: [Pharo-project] about privShrinking

by StÃ©phane Ducasse

On Jul 18, 2011, at 6:36 PM, Pavel Krivanek wrote: > ok, > > let me know if you will remove or add some package because it requires > manual modification of scripts. > > What is the current right way to create new Transcript object? :-) no idea :) > > -- Pavel > > > On Mon, Jul 18, 2011 at 4:34 PM, StÃ©phane Ducasse > <stephane.ducasse(a)inria.fr> wrote: >> Hi pavel >> >> I removed the ref to RecentMessageSet since we will remove it. >> And I noticed that there was a reference to TranscriptModel, so may be we should remove it since I'm not sure that we will keep it. Or may be this is a good >> idea of have a model :) >> >> Smalltalk globals at: #Transcript put: TranscriptModel new. >> >> Stef >> >

July 18, 2011

Re: [Pharo-project] about privShrinking

by Pavel Krivanek

ok, let me know if you will remove or add some package because it requires manual modification of scripts. What is the current right way to create new Transcript object? :-) -- Pavel On Mon, Jul 18, 2011 at 4:34 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Hi pavel > > I removed the ref to RecentMessageSet since we will remove it. > And I noticed that there was a reference to TranscriptModel, so may be we should remove it since I'm not sure that we will keep it. Or may be this is a good > idea of have a model :) > > Â Â Â Â Smalltalk globals at: #Transcript put: TranscriptModel new. > > Stef >

July 18, 2011

Re: [Pharo-project] Stubbing class-side methods

by Dennis Schetinin

Let's get rid of classes? :) 2011/7/18 Carlo <snoobabk(a)yahoo.ie> > Personally when I come across cases like this I either break the (usually > public) method into a public and internal method, the internal method > contains the date so we can test the edge cases. > > E.g. MyClass>> doSomethingWorthTesting > ... > basicDoSomethingWorthTestingAt: DateAndTime now. > ... > > My test then uses the internal method for testing where I can pass in > different dates. > > > Another option which you've probably decided against is to delegate to your > current class or a Registry to ask for the class with which to use for date > related tasks, a kind of factory in a way. > MyClass>>>> doSomethingWorthTesting > ... > now := self class dateClass now. > ... > > > I personally feel Pharo is moving into a more pluggable direction with the > work on the environment (Smalltalk environment) where we can provide our own > environment for a particular context, something similar to Newspeaks nested > classes and imports using the usingPlatform: construct. > E.g. > class MyClassModule usingPlatform: platform = ( > private DateAndTime = platform time DateAndTime. > private Error = platform exceptions Error. > ) > > Hmm maybe we can do a lightweight version using DynamicBindling library > myEnvironmentBinding bindDuring: [ > ...your testcase... > ] > > Cheers > Carlo > > On 17 Jul 2011, at 11:45 PM, Sean P. DeNigris wrote: > > I keep coming up against this situation over and over in testing. > > MyClass>>doSomethingWorthTesting > ... > now := DateAndTime now. > ... > > I want to control DateAndTime class>>now to make this test determinate and > simulate interesting edge cases, but can't figure out a good way. In Ruby, > I > could easily stub it because it's not a live system (or use dependency > injection), but here I don't want to mess with the real DateAndTime class > in > case something goes wrong and leaves my system dirty. > > I really hate using dependency injection for this kind of thing (especially > without Ruby's default parameter values). I've been creating MyClass>>now > and stubbing that. Am I being paranoid, should I just hijack the real class > and fix it when I'm done? What's the best way to do this? > > Thanks. > Sean > > -- > View this message in context: > http://forum.world.st/Stubbing-class-side-methods-tp3674065p3674065.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. > > > > -- Dennis Schetinin

July 18, 2011

[Pharo-project] [update 1.3] #13287

by StÃ©phane Ducasse

13287 ----- - Issue 4528: Exception on:fork: enhancement. Thanks Igor Stasenko and Lukas Renggli for the idea. - Issue 4529: Announcement delivery breaks if last subscriber is curtailed. Thanks Henrik Johanssen.

July 18, 2011

Re: [Pharo-project] fun bug: fileouting method with a $!, produces $!!

by StÃ©phane Ducasse

> Why do you say so ? > I can fileOut, then fileIn without a problem. > To me, this is not a bug. This is a feature. > Source ! are doubled so as not to be confused with chunk separators, it's an escaping sequence like doubles quotes in String > > 'here''s another example which is not a bug' this is not because people were not using a decent syntax to fileout and that after they hacked the system that this is not a bug. If you save a method and once it is saved you cannot load it back then what is the point to save it. Seriously this is not the same than with double quote. Else it means that you cannot/should not use $! in Smalltalk method. And I read most of the spec and books on smalltalk and nobody ever mentioned that. Here this is just that this is doing the wrong behavior. Imagine that we save the code using the coral syntax then what we would not use [] anymore in method? Stef > > Nicolas > > 2011/7/18 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > Yes I know. > To me, saving a method should make sure that we can reload it and this is not the case. > So to me this is a bug. > > try to fileout > > getPreambleFrom: aFileStream at: position > | writeStream | > writeStream := String new writeStream. > position to: 0 by: -1 do: [ :p | > | c | > aFileStream position: p. > c := aFileStream basicNext. > c == $! > ifTrue: [^ writeStream contents reversed] > ifFalse: [writeStream nextPut: c]] > > > :) > > I do not see why the system should not save it correctly even if !! is used as a chunk separator. > > Stef > > > On Jul 18, 2011, at 4:55 PM, Lukas Renggli wrote: > > > !! Is the escaping of a single ! (like '' is the escaping of ' in a > > string), because the ! Is used to separate junks. > > > > Lukas > > > > On Monday, 18 July 2011, stephane ducasse <stephane.ducasse(a)free.fr> wrote: > >> Hi > >> > >> with veronica we found a fun bug. > >> If you have a method with a $! and you file it out. you get $!! in the fileouted file. > >> > >> http://code.google.com/p/pharo/issues/detail?id=4531 > >> > >> Stef > >> > > > > -- > > Lukas Renggli > > www.lukas-renggli.ch > > > > >

July 18, 2011

Re: [Pharo-project] New 1.4 image on inria forge.

by StÃ©phane Ducasse

no apparently this is an inria problem. only one guy there and we should check how we can get access to kick the machine... Stef On Jul 18, 2011, at 6:06 PM, Pavel Krivanek wrote: > Hi Stef, > > is there some progress with inaccessible build server? Or are we > waiting on Marcus? > > > Cheers, > -- Pavel > > On Mon, Jul 18, 2011 at 6:01 PM, StÃ©phane Ducasse > <stephane.ducasse(a)inria.fr> wrote: >> https://gforge.inria.fr/frs/download.php/28785/Pharo-1.4-14048.zip >> >> Stef >> >> >

July 18, 2011

Re: [Pharo-project] fun bug: fileouting method with a $!, produces $!!

by Nicolas Cellier

Why do you say so ? I can fileOut, then fileIn without a problem. To me, this is not a bug. This is a feature. Source ! are doubled so as not to be confused with chunk separators, it's an escaping sequence like doubles quotes in String 'here''s another example which is not a bug' Nicolas 2011/7/18 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> > Yes I know. > To me, saving a method should make sure that we can reload it and this is > not the case. > So to me this is a bug. > > try to fileout > > getPreambleFrom: aFileStream at: position > | writeStream | > writeStream := String new writeStream. > position to: 0 by: -1 do: [ :p | > | c | > aFileStream position: p. > c := aFileStream basicNext. > c == $! > ifTrue: [^ writeStream contents reversed] > ifFalse: [writeStream nextPut: c]] > > > :) > > I do not see why the system should not save it correctly even if !! is used > as a chunk separator. > > Stef > > > On Jul 18, 2011, at 4:55 PM, Lukas Renggli wrote: > > > !! Is the escaping of a single ! (like '' is the escaping of ' in a > > string), because the ! Is used to separate junks. > > > > Lukas > > > > On Monday, 18 July 2011, stephane ducasse <stephane.ducasse(a)free.fr> > wrote: > >> Hi > >> > >> with veronica we found a fun bug. > >> If you have a method with a $! and you file it out. you get $!! in the > fileouted file. > >> > >> http://code.google.com/p/pharo/issues/detail?id=4531 > >> > >> Stef > >> > > > > -- > > Lukas Renggli > > www.lukas-renggli.ch > > > > >

July 18, 2011