April 2011 - Pharo-dev - lists.pharo.org

[Pharo-project] [update 1.3] #13154

by Igor Stasenko

13154 ----- - added collections-atomic -- Best regards, Igor Stasenko AKA sig.

April 15, 2011

[Pharo-project] Making OB / RB / OCompletion / Shout to work on Pharo 1.3

by Mariano Martinez Peck

Hi folks. I spent a couple of hours here in the sprint trying to make all those projects to work on Pharo 1.3. I've updated all configurations. All tests are green, and I can browse code, and some refactors. However, I did a couple of changes that I have NO IDEA. I commit them but I would like someone to review them. Important changes: from: OBCodeBrowser >> subscribe "We want to be notified first about changes of the definition, so that we can replace it with a custom one." | actions | super subscribe. actions := announcer subscriptions at: OBDefinitionChanged ifAbsent: [ ActionSequence new ]. announcer subscriptions at: OBDefinitionChanged put: (actions copyWithFirst: (MessageSend receiver: self selector: #definitionChanged:)) to: OBCodeBrowser >> subscribe "We want to be notified first about changes of the definition, so that we can replace it with a custom one." | actions | super subscribe. announcer on: OBDefinitionChanged send: #definitionChanged: to: self. And from: OBTextMorphWithShout >> editorClass "Answer the class used to create the receiver's editor" ^OBTextMorphEditorWithShout to: OBTextMorphWithShout >> editorClass "Answer the class used to create the receiver's editor" ^SmalltalkEditor Thanks -- Mariano http://marianopeck.wordpress.com

April 15, 2011

Re: [Pharo-project] Issue 3871 in pharo: [Failing Test] 1.3 ReduceTest.testReduceCollection3Arguments

by pharo＠googlecode.com

Comment #1 on issue 3871 by thomas.h...(a)gmail.com: [Failing Test] 1.3 ReduceTest.testReduceCollection3Arguments http://code.google.com/p/pharo/issues/detail?id=3871 Name: Collections-Abstract-ThomasHolzer.130 Author: ThomasHolzer Time: 15 April 2011, 2:55:10 pm UUID: 2d36eaff-6047-0142-b9e1-802b35007254 Ancestors: Collections-Abstract-StephaneDucasse.129 Fix for issue 3871. Problem was caused by an incorrect implementation of reduce: on Collection. This implementation only worked for blocks with 2 arguments. Issue was fixed by converting the collection to a sequenceable collection and reusing the reduce functionalitz of that one.

April 15, 2011

[Pharo-project] Does someone knows that happened to OBTextMorphEditorWithShout ?

by Mariano Martinez Peck

which one should we use? and where is OBTextMorphEditor ? it is not present in latests commites. what should OBTextMorphWithShout >> editorClass answer? Thanks -- Mariano http://marianopeck.wordpress.com

April 15, 2011

[Pharo-project] Issue 4028 in pharo: Possible infinite loop in ImageSegment >> #uniqueFileNameFor:

by pharo＠googlecode.com

Status: Accepted Owner: ryd...(a)gmail.com Labels: Milestone-1.3 New issue 4028 by ryd...(a)gmail.com: Possible infinite loop in ImageSegment >> #uniqueFileNameFor: http://code.google.com/p/pharo/issues/detail?id=4028 I guess noone's ever needed more than 99 versions of a segment... ImageSegment >> uniqueFileNameFor: segName "Choose a unique file name for the segment with this name." | segDir fileName listOfFiles | segDir := self segmentDirectory. listOfFiles := segDir fileNames. BiggestFileNumber ifNil: [BiggestFileNumber := 1]. BiggestFileNumber > 99 ifTrue: [BiggestFileNumber := 1]. "wrap" [fileName := segName, BiggestFileNumber printString, '.seg'. (listOfFiles includes: fileName)] whileTrue: [ BiggestFileNumber := BiggestFileNumber + 1]. "force a unique file name" ^ fileName

April 15, 2011

[Pharo-project] Issue 4027 in pharo: Adding all dirty packages as required to a slice adds the slice, adds...

by pharo＠googlecode.com

Status: Accepted Owner: step...(a)stack.nl New issue 4027 by step...(a)stack.nl: Adding all dirty packages as required to a slice adds the slice, adds... http://code.google.com/p/pharo/issues/detail?id=4027 Make some changes. Open monticello browser Add a slice Select the dirty package right-click on the slice select: add all dirty packages as required never-ending recursion 1.3 13152 OS-X

April 15, 2011

Re: [Pharo-project] Issue 3981 in pharo: #<= on SourcedMethodReference is very slow

by pharo＠googlecode.com

Updates: Status: FixProposed Comment #6 on issue 3981 by johanbri...(a)me.com: #<= on SourcedMethodReference is very slow http://code.google.com/p/pharo/issues/detail?id=3981 Yes, I prefer that one too. I will leave the rest of the method using the ifTrue:ifFalse, just to keep it in sync with the overridden method code. For now, this stupid bug is fixed! thanks!

April 15, 2011

Re: [Pharo-project] Issue 3341 in pharo: use #= for integer comparison instead of #==

by pharo＠googlecode.com

Comment #11 on issue 3341 by step...(a)stack.nl: use #= for integer comparison instead of #== http://code.google.com/p/pharo/issues/detail?id=3341 also Symbol>>isBinary

April 15, 2011

Re: [Pharo-project] Issue 3488 in pharo: Find and replace dialog behavior

by pharo＠googlecode.com

Updates: Labels: -Milestone-1.3 Comment #3 on issue 3488 by marcus.d...(a)gmail.com: Find and replace dialog behavior http://code.google.com/p/pharo/issues/detail?id=3488 (No comment was entered for this change.)

April 15, 2011

Re: [Pharo-project] Issue 3214 in pharo: better Stack implementation

by pharo＠googlecode.com

Updates: Labels: -Milestone-1.3 Comment #4 on issue 3214 by marcus.d...(a)gmail.com: better Stack implementation http://code.google.com/p/pharo/issues/detail?id=3214 (No comment was entered for this change.)

April 15, 2011