April 2011 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] HelpBrowser takes too much time to open

by Mariano Martinez Peck

in fact cannot the cache be class side? beucase now each time you do HelpBrowser open, you compute again the cache....but I am not sure if they should change amont different opened browsers cheers mariano On Sat, Apr 30, 2011 at 5:07 PM, Alexandre Bergel <alexandre.bergel(a)me.com>wrote: > Yes, but this depends what is the expected behavior of the browser. I like > the Agile approach that says you're done when all the tests are green :-) > > Alexandre > > > On 30 Apr 2011, at 10:02, Mariano Martinez Peck wrote: > > > Yes, but I have no idea. Another thing is that now HelpBrowser should > implement something like: > > > > HelpBrowser >> cleanUp > > self resetChache > > > > >> resetCache > > helpTopicCache := nil > > > > So that the class is automatically cleaned in #cleanUpForRelease and > friends... right now since Smalltalk cleanUp sends to all classes which > understand such method, just implemented that should be enough. > > > > Cheers > > > > Mariano > > > > > > On Sat, Apr 30, 2011 at 4:58 PM, Alexandre Bergel < > alexandre.bergel(a)me.com> wrote: > > You're right Mariano. However, I do not know if the help browser gets > updated if you have a browser opened and add a new help in the system. In > any case, this is a requirement that is not formalized by the unit tests. > > > > I think that ideally, the reset cache should be done when receiving an > event of a class creation that is a help. > > > > Alexandre > > > > > > On 30 Apr 2011, at 09:29, Mariano Martinez Peck wrote: > > > > > Cool! Thanks Alexandre. Now...the problem with the cache is always the > same...when to invalidate them. > > > In this case, when do I need to set helpTopicCache to nil. I guess that > if you create a help, then it is "automatically" detected when you open the > browser. > > > Now, you have to explicitly flush the cache, haven't you? So...is > there some documentation of HelpSystem that should be updated to reflect > that ? > > > > > > Thanks > > > > > > On Sat, Apr 30, 2011 at 3:15 AM, Alexandre Bergel < > alexandre.bergel(a)me.com> wrote: > > > > MessageTally time: [HelpBrowser open] between 2 seconds in Cog and > with a regular VM between 6 and 8.... > > > > is there an easy way to improve it ? > > > > > > > > Alexandre, do you want another place where to put a cache like > Metacello's currentVersion? ;) > > > > > > :-) > > > Sure. Easy. > > > > > > SystemHelp>>allSystemHelpPragmas takes time. When you open a browser, > the method HelpBrowser>>open is called once and > SystemHelp>>allSystemHelpPragmas twice. Easy to suspect that a cache is > missing. > > > > > > So, if you define > > > -=-=-=-=-=-=-=-=-= > > > HelpBrowser>>helpTopic > > > ^ helpTopicCache ifNil: [ helpTopicCache := rootTopic > asHelpTopic ] > > > -=-=-=-=-=-=-=-=-= > > > > > > and adapt HelpBrowser>>refresh you win 50% of execution time. > > > > > > Here is it: > > > > > > > > > http://code.google.com/p/pharo/issues/detail?id=4126 > > > > > > Before this fix, I have: > > > [HelpBrowser open] timeToRun > > > => 6099 > > > > > > After the fix I have: > > > [HelpBrowser open] timeToRun > > > => 3094 > > > > > > Naturally, tests are kept green. > > > > > > Cheers, > > > Alexandre > > > > > > -- > > > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > > > Alexandre Bergel http://www.bergel.eu > > > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Mariano > > > http://marianopeck.wordpress.com > > > > > > > -- > > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > > Alexandre Bergel http://www.bergel.eu > > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > > > > > > > > > > > > > > -- > > Mariano > > http://marianopeck.wordpress.com > > > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > -- Mariano http://marianopeck.wordpress.com

April 30, 2011

[Pharo-project] I am the only one who finds #assert:equals: oppostite to expected?

by Mariano Martinez Peck

Hi guys. I always code my tests something like this: testBlah | universalAnswer | universalAnswer := 30. universalAnswer := universalAnswer + 11. self assert: universalAnswer equals: 42. In this case, 42 is the "expected" and "universalAnswer" is the "actual" value. I feel weird writing like this: self assert: 42 equals: universalAnswer. I don't know why...but I do..the same as when doing should: [] raise: Error. In that case you put the "actual" first and the "expected" at the end... ok....the "problem" is that assert:equals: is in fact: asserts: expected equals: actual instead of asserts: actual equals: expected So, with my test I would receive a description in the debugger that says "'Expected 41 but was 42.'" which is completely the opposite. Of course, if I write my tests in the way I don't like, that is: self assert: 42 equals: universalAnswer. then i got the correct message "'Expected 42 but was 41.'" I don't pretend pharo change this because I guess it is standard, and blah blah blah. But senders of #assert:equals: should both, some written as mine (so the message is incorrect for them) and some correct. In addition, I think it is a problem of the selector name. If we could make it clearer, the won't be necessary to confuse "actual" with "expected". Cheers -- Mariano http://marianopeck.wordpress.com

April 30, 2011

Re: [Pharo-project] HelpBrowser takes too much time to open

by Mariano Martinez Peck

Yes, but I have no idea. Another thing is that now HelpBrowser should implement something like: HelpBrowser >> cleanUp self resetChache >> resetCache helpTopicCache := nil So that the class is automatically cleaned in #cleanUpForRelease and friends... right now since Smalltalk cleanUp sends to all classes which understand such method, just implemented that should be enough. Cheers Mariano On Sat, Apr 30, 2011 at 4:58 PM, Alexandre Bergel <alexandre.bergel(a)me.com>wrote: > You're right Mariano. However, I do not know if the help browser gets > updated if you have a browser opened and add a new help in the system. In > any case, this is a requirement that is not formalized by the unit tests. > > I think that ideally, the reset cache should be done when receiving an > event of a class creation that is a help. > > Alexandre > > > On 30 Apr 2011, at 09:29, Mariano Martinez Peck wrote: > > > Cool! Thanks Alexandre. Now...the problem with the cache is always the > same...when to invalidate them. > > In this case, when do I need to set helpTopicCache to nil. I guess that > if you create a help, then it is "automatically" detected when you open the > browser. > > Now, you have to explicitly flush the cache, haven't you? So...is there > some documentation of HelpSystem that should be updated to reflect that ? > > > > Thanks > > > > On Sat, Apr 30, 2011 at 3:15 AM, Alexandre Bergel < > alexandre.bergel(a)me.com> wrote: > > > MessageTally time: [HelpBrowser open] between 2 seconds in Cog and > with a regular VM between 6 and 8.... > > > is there an easy way to improve it ? > > > > > > Alexandre, do you want another place where to put a cache like > Metacello's currentVersion? ;) > > > > :-) > > Sure. Easy. > > > > SystemHelp>>allSystemHelpPragmas takes time. When you open a browser, the > method HelpBrowser>>open is called once and SystemHelp>>allSystemHelpPragmas > twice. Easy to suspect that a cache is missing. > > > > So, if you define > > -=-=-=-=-=-=-=-=-= > > HelpBrowser>>helpTopic > > ^ helpTopicCache ifNil: [ helpTopicCache := rootTopic asHelpTopic > ] > > -=-=-=-=-=-=-=-=-= > > > > and adapt HelpBrowser>>refresh you win 50% of execution time. > > > > Here is it: > > > > > > http://code.google.com/p/pharo/issues/detail?id=4126 > > > > Before this fix, I have: > > [HelpBrowser open] timeToRun > > => 6099 > > > > After the fix I have: > > [HelpBrowser open] timeToRun > > => 3094 > > > > Naturally, tests are kept green. > > > > Cheers, > > Alexandre > > > > -- > > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > > Alexandre Bergel http://www.bergel.eu > > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > > > > > > > > > > > > > > -- > > Mariano > > http://marianopeck.wordpress.com > > > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > -- Mariano http://marianopeck.wordpress.com

April 30, 2011

Re: [Pharo-project] [Pharo-users] Tutorial on Announcements

by Mariano Martinez Peck

Cool! It seems we have too much information about announcements hehhehe 1) http://dougedmunds.com/pmwiki.php?n=Pharo.AnnouncementsTutorial 2) The Help System chapter -> just take your image, world menu -> Help -> Help Browser -> "Announcements framework" 3) Pharo collabortive book chapter: http://book.pharo-project.org/book/announcements/ So....I've just created a last chapter in: http://book.pharo-project.org/book/announcements/windowannouncements/Announ… where I link to the rest of the resources, and I have updated the "Links" page of the Help System chapter. Name: Announcements-Help-MarianoMartinezPeck.3 Author: MarianoMartinezPeck Time: 30 April 2011, 3:51:06 pm UUID: 01d0f9a7-11e4-41b3-9539-e386111efb6d Ancestors: Announcements-Help-StephaneDucasse.2 Fix to issue 4128, update links of Announcements help Cheers Mariano On Sat, Apr 30, 2011 at 9:05 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr > wrote: > thanks doug > I will read that because we are looking for ideas for a chapter on > announcements for PBE2 :) > > Stef > On Apr 30, 2011, at 3:58 AM, DougEdmunds wrote: > > > http://dougedmunds.com/pmwiki.php?n=Pharo.AnnouncementsTutorial > > > > What you can get out of this tutorial and sample code > > > > How to use Announcements > > Ideas on building a GUI > > Associating buttons with actions > > Pulling text out of a text field morph. > > Convert text to numbers using exception handling > > How to create and exit an endless loop > > Setting process priority > > > > -- > > View this message in context: > http://forum.world.st/Tutorial-on-Announcements-tp3485041p3485041.html > > Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com. > > > > > -- Mariano http://marianopeck.wordpress.com

April 30, 2011

Re: [Pharo-project] HelpBrowser takes too much time to open

by Mariano Martinez Peck

On Sat, Apr 30, 2011 at 2:14 AM, Torsten Bergmann <astares(a)gmx.de> wrote: > This is because the help book "Pharo" includes an API > reference for the WHOLE system (starting from ProtoObject > all subclasses down) and converts all class comments > in the system into help text. Accessing sources is slow... > > Thanks Torsten for the explanation. > Just run > > MessageTally spyOn: [SystemReference asHelpTopic] > > If nobody uses this full API reference then we can eliminate > the class "PharoAPIHelp" and it should be much faster > (from 3705 down to 1006 in my image). > > No, I like that, it would be cool to keep it. What I am wondering (I have no idea how HelpBrowser is implemented) is if you cannot do a lazy loading for PharoHelp instead of the whole image. For example, when you start you have ProtoObject, then 6 subclasess, and then.... so...what about loading the subclasses only when requested ? in this case, why expanding with the arrow. > Other books like the ones on announcements and on regular > expression also contain an API reference ... but only > with classes for these packages. > Ok, I understand. -- Mariano http://marianopeck.wordpress.com

April 30, 2011

Re: [Pharo-project] HelpBrowser takes too much time to open

by Mariano Martinez Peck

Cool! Thanks Alexandre. Now...the problem with the cache is always the same...when to invalidate them. In this case, when do I need to set helpTopicCache to nil. I guess that if you create a help, then it is "automatically" detected when you open the browser. Now, you have to explicitly flush the cache, haven't you? So...is there some documentation of HelpSystem that should be updated to reflect that ? Thanks On Sat, Apr 30, 2011 at 3:15 AM, Alexandre Bergel <alexandre.bergel(a)me.com>wrote: > > MessageTally time: [HelpBrowser open] between 2 seconds in Cog and with > a regular VM between 6 and 8.... > > is there an easy way to improve it ? > > > > Alexandre, do you want another place where to put a cache like > Metacello's currentVersion? ;) > > :-) > Sure. Easy. > > SystemHelp>>allSystemHelpPragmas takes time. When you open a browser, the > method HelpBrowser>>open is called once and SystemHelp>>allSystemHelpPragmas > twice. Easy to suspect that a cache is missing. > > So, if you define > -=-=-=-=-=-=-=-=-= > HelpBrowser>>helpTopic > ^ helpTopicCache ifNil: [ helpTopicCache := rootTopic asHelpTopic ] > -=-=-=-=-=-=-=-=-= > > and adapt HelpBrowser>>refresh you win 50% of execution time. > > Here is it: > > > http://code.google.com/p/pharo/issues/detail?id=4126 > > Before this fix, I have: > [HelpBrowser open] timeToRun > => 6099 > > After the fix I have: > [HelpBrowser open] timeToRun > => 3094 > > Naturally, tests are kept green. > > Cheers, > Alexandre > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > -- Mariano http://marianopeck.wordpress.com

April 30, 2011

Re: [Pharo-project] Don't you think "Windows" menu item should be with the rest?

by Mariano Martinez Peck

On Sat, Apr 30, 2011 at 9:08 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr > wrote: > Mariano > let it like it is. > we did it because windows is not the same as the other one and got in our > way.... > so either we remove windows or we let it like that. the three others are > nicely grouped. > Ok...that's why I asked instead of directly open an issue. I wanted to know if it was intentional or not. I am not sure if I would like to remove them. Maybe we can remove some options. There are 2 that I use quite frequently: "Close all debuggers" and "Delete unchanged windows" (which in fact the name is bad for me) > Stef > On Apr 30, 2011, at 12:40 AM, Mariano Martinez Peck wrote: > > > Right now, there is a special section for "Windows", but I think it is > easier if it is together with Help, System, Tools, etc. > > I attach a screenshot. > > > > In addition, it changed the order in compare with Pharo 1.2 where it was: > > > > Tools > > Windows > > System > > Help > > > > What do you tink ? > > > > -- > > Mariano > > http://marianopeck.wordpress.com > > > > <Pharo 1.2.png><Pharo 1.3.png> > > > -- Mariano http://marianopeck.wordpress.com

April 30, 2011

Re: [Pharo-project] Don't you think "Windows" menu item should be with the rest?

by StÃ©phane Ducasse

+1 On Apr 30, 2011, at 10:40 AM, Tudor Girba wrote: > I vote for removing. The only thing that is remotely useful is "close all debuggers", but that would work better under the System menu together with "enable halt inspect once". > > Cheers, > Doru > > > On 30 Apr 2011, at 09:08, StÃ©phane Ducasse wrote: > >> Mariano >> let it like it is. >> we did it because windows is not the same as the other one and got in our way.... >> so either we remove windows or we let it like that. the three others are nicely grouped. >> Stef >> On Apr 30, 2011, at 12:40 AM, Mariano Martinez Peck wrote: >> >>> Right now, there is a special section for "Windows", but I think it is easier if it is together with Help, System, Tools, etc. >>> I attach a screenshot. >>> >>> In addition, it changed the order in compare with Pharo 1.2 where it was: >>> >>> Tools >>> Windows >>> System >>> Help >>> >>> What do you tink ? >>> >>> -- >>> Mariano >>> http://marianopeck.wordpress.com >>> >>> <Pharo 1.2.png><Pharo 1.3.png> >> >> > > -- > www.tudorgirba.com > > "Beauty is where we see it." > > > >

April 30, 2011

[Pharo-project] [update 1.3] #13177

by Marcus Denker

13177 ----- Issue 4127: little bit faster traitNames, allTraitsDo:, allClassesDo:, allClassesAndTraitsDo: Issue 4126: Speeding up HelpBrowser by 50% Issue 4115: Deprecate IdentityGlyphMap and HostFont Issue 4098: Fileout - choose another name cancel crashs -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

April 30, 2011

Re: [Pharo-project] Don't you think "Windows" menu item should be with the rest?

by Tudor Girba

I vote for removing. The only thing that is remotely useful is "close all debuggers", but that would work better under the System menu together with "enable halt inspect once". Cheers, Doru On 30 Apr 2011, at 09:08, StÃ©phane Ducasse wrote: > Mariano > let it like it is. > we did it because windows is not the same as the other one and got in our way.... > so either we remove windows or we let it like that. the three others are nicely grouped. > Stef > On Apr 30, 2011, at 12:40 AM, Mariano Martinez Peck wrote: > >> Right now, there is a special section for "Windows", but I think it is easier if it is together with Help, System, Tools, etc. >> I attach a screenshot. >> >> In addition, it changed the order in compare with Pharo 1.2 where it was: >> >> Tools >> Windows >> System >> Help >> >> What do you tink ? >> >> -- >> Mariano >> http://marianopeck.wordpress.com >> >> <Pharo 1.2.png><Pharo 1.3.png> > > -- www.tudorgirba.com "Beauty is where we see it."

April 30, 2011