February 2011 - Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3665 in pharo: asStringOrText should invoke asString

by pharo＠googlecode.com

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3665 by stephane...(a)gmail.com: asStringOrText should invoke asString http://code.google.com/p/pharo/issues/detail?id=3665 to be discussed #asStringOrText should return the receiver #asString, not printString. This is the correct behavior to be able to render first-class objects in PluggableListMorphs without quotes around them. =============== Diff against Kernel-ul.540 =============== Item was changed: ----- Method: Object>>asStringOrText (in category 'converting') ----- asStringOrText "Answer a string that represents the receiver." + ^ self asString! - - ^ self printString !

Feb. 6, 2011

Re: [Pharo-project] Issue 3663 in pharo: XMLWriter and MultiByteFileStream

by pharo＠googlecode.com

Comment #3 on issue 3663 by stephane...(a)gmail.com: XMLWriter and MultiByteFileStream http://code.google.com/p/pharo/issues/detail?id=3663 ----- Method: MultiByteFileStreamTest>>testNextPutAllStartingAt (in category 'testing') ----- testNextPutAllStartingAt | result | fileName := 'foonextputallstartingat.txt'. MultiByteFileStream forceNewFileNamed: fileName do: [ :file | + { 'abcde' asWideString. 'abcde' } do: [ :string | + file + next: 1 putAll: string startingAt: 5; + next: 3 putAll: string startingAt: 2; + next: 1 putAll: string startingAt: 1 ] ]. - file - next: 1 putAll: 'abcde' startingAt: 5; - next: 3 putAll: 'abcde' startingAt: 2; - next: 1 putAll: 'abcde' startingAt: 1 ]. result := StandardFileStream readOnlyFileNamed: fileName do: [ :file | file binary; contents ]. + self assert: #[101 98 99 100 97 101 98 99 100 97] equals: result - self assert: #[101 98 99 100 97] equals: result

Feb. 6, 2011

Re: [Pharo-project] Issue 3663 in pharo: XMLWriter and MultiByteFileStream

by pharo＠googlecode.com

Comment #2 on issue 3663 by stephane...(a)gmail.com: XMLWriter and MultiByteFileStream http://code.google.com/p/pharo/issues/detail?id=3663 should take as a version to compare with 135

Feb. 6, 2011

Re: [Pharo-project] Issue 3663 in pharo: XMLWriter and MultiByteFileStream

by pharo＠googlecode.com

Comment #1 on issue 3663 by stephane...(a)gmail.com: XMLWriter and MultiByteFileStream http://code.google.com/p/pharo/issues/detail?id=3663 Name: Multilingual-ul.135 Author: ul Time: 31 January 2011, 2:40:43.278 am UUID: 8cec33f7-5ea5-1c45-974d-a335275f1192 Ancestors: Multilingual-ul.134 Fixed an indexing mistake. =============== Diff against Multilingual-ul.133 =============== Item was added: + ----- Method: MultiByteBinaryOrTextStream>>basicNext:putAll:startingAt: (in category 'private basic') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^super next: anInteger putAll: aCollection startingAt: startIndex! Item was added: + ----- Method: MultiByteBinaryOrTextStream>>next:putAll:startingAt: (in category 'public') ----- + next: anInteger putAll: aCollection startingAt: startIndex + + (self isBinary or: [ aCollection class == ByteArray ]) ifTrue: [ + ^super next: anInteger putAll: aCollection startingAt: startIndex ]. + ^self converter next: anInteger putAll: aCollection startingAt: startIndex toStream: self + ! Item was added: + ----- Method: MultiByteFileStream>>basicNext:putAll:startingAt: (in category 'private basic') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^super next: anInteger putAll: aCollection startingAt: startIndex! Item was added: + ----- Method: MultiByteFileStream>>next:putAll:startingAt: (in category 'public') ----- + next: anInteger putAll: aCollection startingAt: startIndex + + (self isBinary or: [ aCollection class == ByteArray ]) ifTrue: [ + ^super next: anInteger putAll: aCollection startingAt: startIndex ]. + ^converter next: anInteger putAll: aCollection startingAt: startIndex toStream: self! Item was changed: ----- Method: MultiByteFileStream>>nextPutAll: (in category 'public') ----- nextPutAll: aCollection (self isBinary or: [aCollection class == ByteArray]) ifTrue: [ ^ super nextPutAll: aCollection. ]. + ^converter nextPutAll: aCollection toStream: self! - converter nextPutAll: aCollection toStream: self. - ^aCollection! Item was added: + ----- Method: TextConverter>>next:putAll:startingAt:toStream: (in category 'conversion') ----- + next: anInteger putAll: aString startingAt: startIndex toStream: aStream + "Handle fast conversion if ByteString" + + | lastIndex nextIndex | + aString class == ByteString ifFalse: [ + startIndex to: startIndex + anInteger - 1 do: [ :index | + self nextPut: (aString at: index) toStream: aStream ]. + ^aString ]. + aStream isBinary ifTrue: [ + aStream basicNext: anInteger putAll: aString startingAt: startIndex. + ^aString ]. + lastIndex := startIndex. + [ (nextIndex := ByteString + findFirstInString: aString + inSet: latin1Map + startingAt: lastIndex) = 0 or: [ nextIndex > anInteger ] ] whileFalse: [ + aStream + basicNext: nextIndex - lastIndex putAll: aString startingAt: lastIndex; + basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex) + 1). + lastIndex := nextIndex + 1 ]. + aStream basicNext: anInteger - lastIndex + startIndex putAll: aString startingAt: lastIndex. + ^aString! Item was changed: ----- Method: TextConverter>>nextPutAll:toStream: (in category 'conversion') ----- nextPutAll: aString toStream: aStream "Handle fast conversion if ByteString" + ^self next: aString size putAll: aString startingAt: 1 toStream: aStream! - | lastIndex nextIndex | - aString class == ByteString ifFalse: [ - aString do: [:char | self nextPut: char toStream: aStream]. - ^self]. - - aStream isBinary ifTrue: [ - aStream basicNextPutAll: aString. - ^self]. - lastIndex := 1. - [nextIndex := ByteString findFirstInString: aString inSet: latin1Map startingAt: lastIndex. - nextIndex = 0] whileFalse: - [aStream next: nextIndex-lastIndex putAll: aString startingAt: lastIndex. - aStream basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex)+1). - lastIndex := nextIndex + 1]. - aStream next: aString size-lastIndex+1 putAll: aString startingAt: lastIndex. - ^self - !

Feb. 6, 2011

[Pharo-project] Issue 3663 in pharo: XMLWriter and MultiByteFileStream

by pharo＠googlecode.com

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3663 by stephane...(a)gmail.com: XMLWriter and MultiByteFileStream http://code.google.com/p/pharo/issues/detail?id=3663 Name: Collections-ul.422 Author: ul Time: 31 January 2011, 2:02:00.387 am UUID: 89c6854c-b6d1-1646-a22b-bbc47ce7522f Ancestors: Collections-ul.421 Introduced Stream >> #basicNext:putAll:startingAt: which will be used by MultiByteFileStream to fix http://bugs.squeak.org/view.php?id=7603 . =============== Diff against Collections-ul.421 =============== Item was added: + ----- Method: Stream>>basicNext:putAll:startingAt: (in category 'accessing') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^self next: anInteger putAll: aCollection startingAt: startIndex + ! A fix for http://bugs.squeak.org/view.php?id=7603 . Requires Collections-ul.422. Added TextConverter >> #next:putAll:startingAt:toStream: which is used by MultiByteFileStream and MultiByteBinaryOrTextStream to properly implement #next:putAll:startingAt:. =============== Diff against Multilingual-ul.133 =============== Item was added: + ----- Method: MultiByteBinaryOrTextStream>>basicNext:putAll:startingAt: (in category 'private basic') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^super next: anInteger putAll: aCollection startingAt: startIndex! Item was added: + ----- Method: MultiByteBinaryOrTextStream>>next:putAll:startingAt: (in category 'public') ----- + next: anInteger putAll: aCollection startingAt: startIndex + + (self isBinary or: [ aCollection class == ByteArray ]) ifTrue: [ + ^super next: anInteger putAll: aCollection startingAt: startIndex ]. + ^self converter next: anInteger putAll: aCollection startingAt: startIndex toStream: self + ! Item was added: + ----- Method: MultiByteFileStream>>basicNext:putAll:startingAt: (in category 'private basic') ----- + basicNext: anInteger putAll: aCollection startingAt: startIndex + + ^super next: anInteger putAll: aCollection startingAt: startIndex! Item was added: + ----- Method: MultiByteFileStream>>next:putAll:startingAt: (in category 'public') ----- + next: anInteger putAll: aCollection startingAt: startIndex + + (self isBinary or: [ aCollection class == ByteArray ]) ifTrue: [ + ^super next: anInteger putAll: aCollection startingAt: startIndex ]. + ^converter next: anInteger putAll: aCollection startingAt: startIndex toStream: self! Item was changed: ----- Method: MultiByteFileStream>>nextPutAll: (in category 'public') ----- nextPutAll: aCollection (self isBinary or: [aCollection class == ByteArray]) ifTrue: [ ^ super nextPutAll: aCollection. ]. + ^converter nextPutAll: aCollection toStream: self! - converter nextPutAll: aCollection toStream: self. - ^aCollection! Item was added: + ----- Method: TextConverter>>next:putAll:startingAt:toStream: (in category 'conversion') ----- + next: anInteger putAll: aString startingAt: startIndex toStream: aStream + "Handle fast conversion if ByteString" + + | lastIndex nextIndex | + aString class == ByteString ifFalse: [ + startIndex to: startIndex + anInteger - 1 do: [ :index | + self nextPut: (aString at: index) toStream: aStream ]. + ^aString ]. + aStream isBinary ifTrue: [ + aStream basicNext: anInteger putAll: aString startingAt: startIndex. + ^aString ]. + lastIndex := startIndex. + [ (nextIndex := ByteString + findFirstInString: aString + inSet: latin1Map + startingAt: lastIndex) = 0 or: [ nextIndex > anInteger ] ] whileFalse: [ + aStream + basicNext: nextIndex - lastIndex putAll: aString startingAt: lastIndex; + basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex) + 1). + lastIndex := nextIndex + 1 ]. + aStream basicNext: anInteger - lastIndex + 1 putAll: aString startingAt: lastIndex. + ^aString! Item was changed: ----- Method: TextConverter>>nextPutAll:toStream: (in category 'conversion') ----- nextPutAll: aString toStream: aStream "Handle fast conversion if ByteString" + ^self next: aString size putAll: aString startingAt: 1 toStream: aStream! - | lastIndex nextIndex | - aString class == ByteString ifFalse: [ - aString do: [:char | self nextPut: char toStream: aStream]. - ^self]. - - aStream isBinary ifTrue: [ - aStream basicNextPutAll: aString. - ^self]. - lastIndex := 1. - [nextIndex := ByteString findFirstInString: aString inSet: latin1Map startingAt: lastIndex. - nextIndex = 0] whileFalse: - [aStream next: nextIndex-lastIndex putAll: aString startingAt: lastIndex. - aStream basicNextPutAll: (latin1Encodings at: (aString byteAt: nextIndex)+1). - lastIndex := nextIndex + 1]. - aStream next: aString size-lastIndex+1 putAll: aString startingAt: lastIndex. - ^self - !

Feb. 6, 2011

Re: [Pharo-project] Issue 3658 in pharo: Dictionaries corrupt when loaded from image segment

by pharo＠googlecode.com

Updates: Labels: Milestone-1.1.2 Milestone-1.2 Milestone-1.3 Comment #2 on issue 3658 by adrian.l...(a)gmail.com: Dictionaries corrupt when loaded from image segment http://code.google.com/p/pharo/issues/detail?id=3658 Yes. Its critical in each version for all uses of image segment. So I added tags for these three versions. If the patch can make into 1.2 and 1.1.2 that would be good.

Feb. 6, 2011

[Pharo-project] Issue 3662 in pharo: build of 1.3 Full fails on Hudson

by pharo＠googlecode.com

Status: Accepted Owner: marcus.d...(a)gmail.com Labels: Milestone-1.3 New issue 3662 by marcus.d...(a)gmail.com: build of 1.3 Full fails on Hudson http://code.google.com/p/pharo/issues/detail?id=3662 Related to OCompletion: An attempt to use interactive tools detected, while in non-interactive mode 6 February 2011 10:16:11 am VM: unix - i686 - linux - Squeak3.10.2 of '5 June 2008' [latest update: #7179] Image: Pharo1.3a [Latest update: #13038] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir /builds/workspace/Pharo 1.3/Pharo-1.3 Trusted Dir /builds/workspace/Pharo 1.3/Pharo-1.3/secure Untrusted Dir /builds/workspace/Pharo 1.3/Pharo-1.3/My Squeak NonInteractiveUIManager>>nonInteractive Receiver: a NonInteractiveUIManager Arguments and temporary variables: Receiver's instance variables: uiManager: a MorphicUIManager doNotQuitOnRestart: false NonInteractiveUIManager>>request:initialAnswer: Receiver: a NonInteractiveUIManager Arguments and temporary variables: queryString: ' Thanks for installing OCompletion!

Feb. 6, 2011

Re: [Pharo-project] Issue 3515 in pharo: Failing Test: RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod

by pharo＠googlecode.com

Comment #1 on issue 3515 by marcus.d...(a)gmail.com: Failing Test: RBInlineMethodFromComponentTest.testInlineEmptyComponentMethod http://code.google.com/p/pharo/issues/detail?id=3515 Error Message implementorToInline Stacktrace Refactoring class(Object)>>error: [:ref :imps | self error: #implementorToInline] in Refactoring class>>initializeRefactoringOptions InlineMethodFromComponentRefactoring(Refactoring)>>requestImplementorToInline: InlineMethodFromComponentRefactoring>>inlineClass InlineMethodFromComponentRefactoring>>isOverridden [self findSelectedMessage. self isOverridden ifTrue: [self refactoringWarning: ('<1p>>><2s> is overriden. Do you want to inline it anyway?' expandMacrosWith: self inlineClass with: self inlineSelector)]. self parseInlineMethod. self isPrimitive ifTrue: [self refactoringError: 'Cannot inline primitives']. self checkSuperMessages. self rewriteInlinedTree. (sourceMessage parent isReturn or: [self hasMultipleReturns not]) ifFalse: [self refactoringError: 'Cannot inline method since it contains multiple returns that cannot be rewritten']. true] in InlineMethodFromComponentRefactoring(InlineMethodRefactoring)>>preconditions RBCondition>>check RBConjunctiveCondition>>check InlineMethodFromComponentRefactoring(Refactoring)>>checkPreconditions InlineMethodFromComponentRefactoring(Refactoring)>>primitiveExecute RBInlineMethodFromComponentTest(RBRefactoringBrowserTest)>>executeRefactoring: [refactoring := InlineMethodFromComponentRefactoring inline: (self convertInterval: (35 to: 91) for: (RBRefactoryTestDataApp sourceCodeAt: #inlineComponent)) inMethod: #inlineComponent forClass: RBRefactoryTestDataApp. self setupInlineExpressionFor: refactoring toReturn: false. self executeRefactoring: refactoring] in RBInlineMethodFromComponentTest>>testInlineEmptyComponentMethod BlockClosure>>on:do: RBInlineMethodFromComponentTest(RBRefactoringBrowserTest)>>proceedThroughWarning: RBInlineMethodFromComponentTest>>testInlineEmptyComponentMethod RBInlineMethodFromComponentTest(TestCase)>>performTest

Feb. 6, 2011

Re: [Pharo-project] Issue 3652 in pharo: [Failing Test] MocketryTests.Actions.MockActionAcceptanceTests.testWillProcessBlocking

by pharo＠googlecode.com

Comment #3 on issue 3652 by marcus.d...(a)gmail.com: [Failing Test] MocketryTests.Actions.MockActionAcceptanceTests.testWillProcessBlocking http://code.google.com/p/pharo/issues/detail?id=3652 No, it sometimes fails, sometimes not. Similar to Issue 3581

Feb. 6, 2011

[Pharo-project] Issue 3661 in pharo: fixed the calculation of base in PNGReadWriter>>copyPixelsGray: (floor vs ceil)

by pharo＠googlecode.com

Status: FixedWaitingToBePharoed Owner: stephane...(a)gmail.com Labels: Milestone-1.3 Type-Squeak New issue 3661 by stephane...(a)gmail.com: fixed the calculation of base in PNGReadWriter>>copyPixelsGray: (floor vs ceil) http://code.google.com/p/pharo/issues/detail?id=3661 Name: Graphics-ul.177 Author: ul Time: 5 February 2011, 4:53:19.27 am UUID: dfac9cf3-85a4-3c4b-9256-1c8214f36fe6 Ancestors: Graphics-nice.176 - fixed the calculation of base in PNGReadWriter>>copyPixelsGray: (floor vs ceil) =============== Diff against Graphics-nice.176 =============== Item was changed: ----- Method: PNGReadWriter>>copyPixelsGray: (in category 'pixel copies') ----- copyPixelsGray: y "Handle non-interlaced grayscale color mode (colorType = 0)" | base bits bytesLeft word | bitsPerChannel = 16 ifTrue: [ "Warning: This is extremely slow. Besides we are downsampling to 8 bits!!" | blitter | blitter := BitBlt current bitPokerToForm: form. 0 to: width - 1 do: [ :x | blitter pixelAt: x @ y put: 255 - (thisScanline at: x * 2 + 1) ]. ^self ]. "Just copy the bits" "This Smalltalk version might be easier to understand than the others below." + base := y * (form width * bitsPerChannel + 31 // 32) + 1. - base := y * form width * bitsPerChannel // 32 + 1. bits := form bits. 0 to: thisScanline size // 4 - 1 do: [ :i | | ii | ii := i * 4. "This somewhat weird mixture of (#* and #+) with (#bitShift: and #bitOr:) is to make use of faster arithmetic bytecodes, but not of slow largeintegers." word := (((thisScanline at: ii + 1) * 256 + (thisScanline at: ii + 2) * 256 + (thisScanline at: ii + 3)) bitShift: 8) bitOr: (thisScanline at: ii + 4). bits at: base + i put: word ]. (bytesLeft := thisScanline size bitAnd: 3) = 0 ifFalse: [ word := 0. thisScanline size - bytesLeft + 1 to: thisScanline size do: [ :ii | word := word * 256 + (thisScanline at: ii) ]. word := word bitShift: 8 * (4 - bytesLeft). bits at: base + (thisScanline size // 4) put: word ]. "This interesting technique (By Andreas Raab) is faster for very large images, but might be slower for small ones" "^self copyPixelsGrayWeirdBitBltHack: y ". "It uses the following method: PNGReadWriter >> copyPixelsGrayWeirdBitBltHack: y ""Handle non-interlaced black and white color mode (colorType = 0) By Andreas Raab"" | source dest cmap | source := Form extent: 1 @ (thisScanline size // 4) depth: 32 bits: thisScanline. dest := Form extent: 1 @ (form bits size) depth: 32 bits: form bits. cmap := Smalltalk isLittleEndian ifTrue:[ColorMap shifts: #(-24 -8 8 24) masks: #(16rFF000000 16r00FF0000 16r0000FF00 16r000000FF)]. (BitBlt toForm: dest) sourceForm: source; destX: 0 destY: (y * form width*bitsPerChannel//32) width: 1 height: (form width+31*bitsPerChannel//32); colorMap: cmap; combinationRule: 3; copyBits." "This interesting technique (By Yoshiki Ohshima) is faster for very large images, but might be slower for small ones" "form bits copyFromByteArray2: thisScanline to: y * (form width* bitsPerChannel // 32)". "It uses the following method: BitMap >> copyFromByteArray2: byteArray to: i ""This method should work with either byte orderings"" | myHack byteHack | myHack := Form new hackBits: self. byteHack := Form new hackBits: byteArray. Smalltalk isLittleEndian ifTrue: [byteHack swapEndianness]. byteHack displayOn: myHack at: 0@i"!

Feb. 6, 2011