December 2011 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] How to resurrect an unrepsonsive image?

by Levente Uzonyi

On Sat, 10 Dec 2011, Mariano Martinez Peck wrote: > On Sat, Dec 10, 2011 at 12:09 AM, Levente Uzonyi <leves(a)elte.hu> wrote: > >> On Fri, 9 Dec 2011, Schwab,Wilhelm K wrote: >> >> Ok, but I have never failed to be impressed by how much trouble even >>> green threads can cause. Meaning no disrespect, if I had a repeatable >>> failure scenario, I would make the switch to a mutex just in case. If for >>> no other reason, Semaphore>>critical: makes assumptions about what is and >>> is not interruptible. I don't have to so much as play dumb here (it comes >>> naturally at the vm level), but I can't help wondering about the validity >>> of the assumptions, the correctness of the code, and all the more so given >>> our move to Cog. >>> >> >> Is there a reason *not* to use Mutex in such situations? We have multiple >> users telling us there is a problem. >> >> Mutex is broken, so you better not use it. :) >> >> > Why? where? what should I use instead? It's semaphore can get more than one signal somehow. Details here: http://bugs.squeak.org/view.php?id=6830 . I have no answer for your third question. :) Levente > > >> >> Levente >> >> >> >> ______________________________**__________ >> From: pharo-project-bounces(a)lists.**gforge.inria.fr<pharo-project-bounces(a)lists.gforge.inria.fr>[ >> pharo-project-bounces(a)lists.**gforge.inria.fr<pharo-project-bounces(a)lists.gforge.inria.fr>] >> on behalf of Henrik Sperre Johansen [henrik.s.johansen(a)veloxit.no] >> Sent: Friday, December 09, 2011 1:33 PM >> To: Pharo-project(a)lists.gforge.**inria.fr<Pharo-project(a)lists.gforge.inria.fr> >> Subject: Re: [Pharo-project] How to resurrect an unrepsonsive image? >> >> On 09.12.2011 16:59, Schwab,Wilhelm K wrote: >> >>> I would be very curious about what happens if you replace the >>> socket-related mutual exclusion semaphores with mutexes. >>> >> For the semaphore in question here, there is no recursion going on in >> any of the critical sections. >> So the answer to that would be absolutely nothing. >> >> Cheers, >> Henry >> >>> >>> >> > > > -- > Mariano > http://marianopeck.wordpress.com >

Dec. 10, 2011

Re: [Pharo-project] GZipWriteStream crashing my VM when serializing ?

by John McIntosh

Mmm I recall a problem from long ago where the buffer passed into the zip call was not big enough to store the results. If you pass in a small chunk of data, why the buffer to hold the results and the decode data is bigger than the buffer going in. So the two sizes, input and output are? On Fri, Dec 2, 2011 at 4:41 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: > Hi guys. We are doing some experiments with Fuel and GZip streams... Now I > have a beatiful test like this: > > testMethodContextThisContext > > Â Â Â | materializedContext context | > Â Â Â context := thisContext copy. > Â Â Â materializedContext := self resultOfSerializeAndMaterialize: context. > > and it crashes like crazy. From the VM crash stack, I can see: > > > Smalltalk stack dump: > 0xbff66ba4 M GZipWriteStream(DeflateStream)>deflateBlock 447551436: a(n) > GZipWriteStream > 0xbff66bc8 M GZipWriteStream(DeflateStream)>nextPutAll: 447551436: a(n) > GZipWriteStream > 0xbff66be4 M GZipWriteStream(DeflateStream)>next:putAll:startingAt: > 447551436: a(n) GZipWriteStream > 0xbff66c08 M FLBufferedWriteStream>flushBuffer 448048664: a(n) > FLBufferedWriteStream > 0xbff66c20 M FLBufferedWriteStream>nextBytesPutAll: 448048664: a(n) > FLBufferedWriteStream > 0xbff66c40 M FLBufferedWriteStream>nextStringPut: 448048664: a(n) > FLBufferedWriteStream > 0xbff66c5c M FLByteStringCluster>serialize:on: 448054196: a(n) > FLByteStringCluster > 0xbff66c7c M FLByteStringCluster(FLPrimitiveCluster)>serializeInstance:with: > 448054196: a(n) FLByteStringCluster > 0xbff66ca0 M [] in > FLByteStringCluster(FLIteratingCluster)>serializeInstances: 448054196: a(n) > FLByteStringCluster > 0xbff66cc8 M IdentitySet(Set)>do: 451711680: a(n) IdentitySet > 0xbff66ce4 M FLByteStringCluster(FLIteratingCluster)>serializeInstances: > 448054196: a(n) FLByteStringCluster > 0xbff66d00 M > FLByteStringCluster(FLIteratingCluster)>serializeInstancesStepWith: > 448054196: a(n) FLByteStringCluster > 0xbff66d1c M FLSerialization>clusterInstancesStepOf: 448053428: a(n) > FLSerialization > 0xbff66d38 M [] in FLSerialization>instancesStep 448053428: a(n) > FLSerialization > 0xbff66d58 M OrderedCollection>do: 449989736: a(n) OrderedCollection > 0xbff66d74 M FLSerialization>instancesStep 448053428: a(n) FLSerialization > 0xbff66d8c M FLSerialization>run 448053428: a(n) FLSerialization > 0xbff66db0 I [] in FLSerializer>defaultSerialization 447550464: a(n) > FLSerializer > 0xbff66dd8 M [] in FLSerializer>serialize:on: 447550464: a(n) FLSerializer > 0xbff66df8 M BlockClosure>ensure: 448052884: a(n) BlockClosure > 0xbff66e18 M FLSerializer>serialize:on: 447550464: a(n) FLSerializer > 0xbff66e3c M [] in > FLMethodContextSerializationTest(FLSerializationTest)>serialize: 447235380: > a(n) FLMethodContextSerializationTest > 0xbff66e60 M [] in GZipWriteStream class(PositionableStream class)>on:do: > 419845144: a(n) GZipWriteStream class > 0xbff66e80 M BlockClosure>ensure: 448048616: a(n) BlockClosure > 0xbff66ea0 M GZipWriteStream class(PositionableStream class)>on:do: > 419845144: a(n) GZipWriteStream class > 0xbff66ec4 M [] in FLGZipStrategy>writeStreamDo: 447550896: a(n) > FLGZipStrategy > 0xbff66ee0 M FLByteArrayStreamStrategy>writeStreamDo: 447550884: a(n) > FLByteArrayStreamStrategy > 0xbff66efc M FLGZipStrategy>writeStreamDo: 447550896: a(n) FLGZipStrategy > 0xbff66f18 M > FLMethodContextSerializationTest(FLSerializationTest)>serialize: 447235380: > a(n) FLMethodContextSerializationTest > 0xbff66f34 M > FLMethodContextSerializationTest(FLSerializationTest)>resultOfSerializeAndMaterialize: > 447235380: a(n) FLMethodContextSerializationTest > 0xbff66f58 M FLMethodContextSerializationTest>testMethodContextThisContext > 447235380: a(n) FLMethodContextSerializationTest > > > any idea of where I should start to look at? > > Thanks > > > -- > Mariano > http://marianopeck.wordpress.com > -- =========================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd.Â http://www.smalltalkconsulting.com ===========================================================================

Dec. 10, 2011

Re: [Pharo-project] [Pharo-users] [COTDC] 94 - AnnouncementSet

by Sean P. DeNigris

Igor Stasenko wrote > > which is pretty useless IMO. > The collaborative book says: If you want to register the same action for multiple events, simply create an AnnouncementSet using a comma: > > Parent>>initialize > super initialize. > self session announcer on: AddChild, RemoveChild do: [:it | self > changeChild: it child] -- View this message in context: http://forum.world.st/Re-Pharo-users-COTDC-94-AnnouncementSet-tp4178427p417… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Dec. 10, 2011

Re: [Pharo-project] Command Line AWS S3 Upload/Download Tool using Pharo Smalltalk

by Mariano Martinez Peck

Looks awesome. Thanks for sharing and congrats. On Fri, Dec 9, 2011 at 4:58 PM, Sven Van Caekenberghe <sven(a)beta9.be> wrote: > Command Line AWS S3 Upload/Download Tool using Pharo Smalltalk > > This is a little story about a tool that I needed and that I finally > implemented in Pharo Smalltalk. I think it is quite nice and elegant and > might be useful to others too. Also, I think it is important to share > little hacks like this to show that what you can do is almost unlimited (as > many others have shown in all kinds of projects). > > This is a bit long, so if you're not interested, please ignore. > > Amazon S3 is a web service interface to store and retrieve any data from > anywhere that is highly scalable, reliable, secure, fast, inexpensive. [ > http://aws.amazon.com/s3/ ] [ http://en.wikipedia.org/wiki/Amazon_S3 ] > > I needed a client to interface with S3 from Linux to store and retrieve > archives and backups up to 100s of Mb large. Although I had already written > a client for this web service in Pharo some time ago, I thought it would > not be good enough for these amounts of data. Furthermore, it had no > command line interface. So I Googled and found s3cmd. This installed easily > and quickly in Ubuntu. Uploading/downloading some small test files went OK. > However, uploading large files gave all kinds of strange errors, even > though I was doing this from EC2 directly on the Amazon network. I don't > know Python so I was not capable of debugging the tool. > > But I do know Smalltalk and had the basic code already. [ Zinc-AWS in > http://www.squeaksource.com/ZincHTTPComponents ] > > What was missing was a solution to do streaming uploads and downloads so > that these huge files would not be taken into memory all at once and a > command line interface. Turns out both were quite easy and elegant to > implement. > > I added the following methods to ZnAWSS3Client: > > downloadFile: filename fromBucket: bucket > "Do a streaming download of the key filename from bucket, > creating it as a file with that name in the current directory." > > | streaming response | > streaming := self httpClient streaming. > self httpClient streaming: true. > response := self at: bucket -> filename. > self httpClient streaming: streaming. > response isSuccess ifFalse: [ ^ ZnHttpUnsuccessful signal ]. > FileStream > fileNamed: filename > do: [ :stream | response entity writeOn: stream ]. > ^ response > > The #streaming option of the underlying ZnClient is toggled on for this > request and reset later to its previous value after the request. The #at: > does the actual request, returning a ZnStreamingEntity that is then written > to a file. When a streaming entity writes itself to another stream it will > actually do a streaming copy (one buffer at a time in a loop) for an > efficient download. > > uploadFile: filename withMd5: md5 inBucket: bucket > "Do a streaming upload of the file filename to bucket. > When md5 is notNil, use it to validate the ETag of the response." > > | entry size mimeType fileStream entity response | > entry := FileDirectory root directoryEntryFor: filename. > size := entry fileSize. > mimeType := ZnMimeType forFilenameExtension: (FileDirectory > extensionFor: filename). > fileStream := FileDirectory root readOnlyFileNamed: filename. > mimeType isBinary ifTrue: [ fileStream binary ]. > (entity := ZnStreamingEntity type: mimeType length: size) > stream: fileStream. > self at: bucket -> entry name put: entity. > (md5 notNil and: [ (md5 sameAs: self eTag) not ]) > ifTrue: [ self error: 'Uploaded ETag does not equal > supplied MD5' ]. > ^ self httpClient response > > Here the streaming entity is created based on an existing file, the mime > type coming from the extension. Then, #at:put: is used to do the upload. > Again, when the streaming entity writes itself to the socket stream it will > actually do a streaming copy (one buffer at a time in a loop), for an > efficient upload. > > Amazon S3 delivers MD5 hashes (ETags) that can be used to check the > integrity of uploads/downloads. ZnAWSS3Client uses these when its > #checkIntegrity option is true using MD5>>#hashMessage:, though not using > the streaming option of HashFunction. Since it would be a lot of work to > make that possible, I opted for externally supplied MD5 hashes using > Linux's md5sum utility. > > Next, I took a clean Pharo 1.3 image and the standard Pharo built CogVM > and loaded the following to create a server image: > > Gofer new > squeaksource: 'XMLSupport'; > package: 'ConfigurationOfXMLSupport'; > load. > (Smalltalk at: #ConfigurationOfXMLSupport) perform: #loadDefault. > > Gofer new > squeaksource: 'ZincHTTPComponents'; > package: 'Zinc-HTTP'; > package: 'Zinc-AWS'; > load. > > Gofer new > squeaksource: 'ADayAtTheBeach'; > package: 'NonInteractiveTranscript'; > load. > > The glue code for each tool consists of a Linux shell script and a > Smalltalk startup script. This is a tool for personal use, error handling > could be a bit better regarding wrong invocations. > > #!/bin/bash > echo S3 Download $* > script_home=$(dirname $0) > script_home=$(cd $script_home && pwd) > image=$script_home/pharo-t3.image > script=$script_home/s3-download.st > bucket=$1 > file=$2 > vm=$script_home/bin/CogVM > options="-vm-display-null -vm-sound-null" > echo $vm $options $image $script $bucket $file > $vm $options $image $script $bucket $file > > NonInteractiveTranscript stdout install. > [ > > | args bucket filename | > args := Smalltalk commandLine arguments. > bucket := args first. > filename := args second. > > (ZnAWSS3Client new) > accessKeyId: 'AAAAXXYYZZ5HGQZ77EQ'; > secretAccessKey: 'AAAA+D9n7gabcdefghSfevY/mH6KWsvMAcsjzzzz'; > checkIntegrity: false; > downloadFile: filename fromBucket: bucket; > close. > > Transcript show: 'OK'; cr; endEntry. > > ] on: Error do: [ :exception | > > Smalltalk logError: exception description inContext: exception > signalerContext. > Transcript show: 'FAILED'; cr; endEntry. > > ]. > SmalltalkImage current quitPrimitive. > > #!/bin/bash > echo S3 Upload $* > script_home=$(dirname $0) > script_home=$(cd $script_home && pwd) > image=$script_home/pharo-t3.image > script=$script_home/s3-upload.st > bucket=$1 > file=$2 > file_dir=$(dirname $file) > file_name=$(basename $file) > file=$(cd $file_dir && pwd)/$file_name > vm=$script_home/bin/CogVM > options="-vm-display-null -vm-sound-null" > compute_md5="md5sum $file" > md5=`$compute_md5` > echo $vm $options $image $script $bucket $file $md5 > $vm $options $image $script $bucket $file $md5 > > NonInteractiveTranscript stdout install. > [ > > | args bucket filename md5 | > args := Smalltalk commandLine arguments. > bucket := args first. > filename := args second. > md5 := args third. > > (ZnAWSS3Client new) > accessKeyId: 'AAAAXXYYZZ5HGQZ77EQ'; > secretAccessKey: 'AAAA+D9n7gabcdefghSfevY/mH6KWsvMAcsjzzzz'; > checkIntegrity: false; > uploadFile: filename withMd5: md5 inBucket: bucket; > close. > > Transcript show: 'OK'; cr; endEntry. > > ] on: Error do: [ :exception | > > Smalltalk logError: exception description inContext: exception > signalerContext. > Transcript show: 'FAILED'; cr; endEntry. > > ] > SmalltalkImage current quitPrimitive. > > Both tools are very similar: the shell scripts uses the VM to start the > right image after massaging some of the arguments. > The Smalltalk script retrieves arguments, instanciates and invokes the > tool to do its job. NonInteractiveTranscript is used with the #stdout > option to write OK or FAILED. In the case of failure a PharoDebug.log is > written. #quitPrimitive is used for a fast exit (not marking the changes > file). Since then I learned from Igor that #quitPrimitive accepts an exit > value so it would be possible to do away with the OK/FAILED writing to > stdout and just rely on the exit value for an even better integration with > *nix. > > Uploading/downloading files of 100s of Mb went flawless and was more than > fast enough (network IO bound anyway). Repeatably starting/stopping a VM > with a 20Mb image is totally acceptable and fast as well. > > A big thanks to everybody who is working on all the little details all the > time to make things like this possible ! > > Sven > > > -- Mariano http://marianopeck.wordpress.com

Dec. 10, 2011

Re: [Pharo-project] [ANN] Magma 1.3

by Mariano Martinez Peck

On Thu, Dec 8, 2011 at 11:08 PM, Chris Muller <ma.chris.m(a)gmail.com> wrote: > I am very pleased to announce the immediate availability of Magma 1.3. > The following detail the major improvements to 1.3 over 1.2: > > Serializer Upgrade > ==== > BlockClosures (Contexts and CompiledMethods too, of course), can now > be stored in the database, even with references to inst-vars, self, > temps or globals. > Excellent. I will take a look. Proxy Transparency > ==== > A new extension to the WriteBarrier should now alleviate the need to > send #yourself to primitive arguments! Primitives which require > arguments are now overridden in the anonymous subclass so that the > arguments will automatically be ensured to be fully-reified for the > super call. > > I would like to take a look to this. In which primitives you need to send #yourself for example? This is because otherwise the VM will fail / crash because it expects the parameters of a primitive to be of a certain type rather than a proxy ? Which are those subclases you mention that override the primitive methods? Thanks and congrats for the release. -- Mariano http://marianopeck.wordpress.com

Dec. 9, 2011

Re: [Pharo-project] How to resurrect an unrepsonsive image?

by Mariano Martinez Peck

On Sat, Dec 10, 2011 at 12:09 AM, Levente Uzonyi <leves(a)elte.hu> wrote: > On Fri, 9 Dec 2011, Schwab,Wilhelm K wrote: > > Ok, but I have never failed to be impressed by how much trouble even >> green threads can cause. Meaning no disrespect, if I had a repeatable >> failure scenario, I would make the switch to a mutex just in case. If for >> no other reason, Semaphore>>critical: makes assumptions about what is and >> is not interruptible. I don't have to so much as play dumb here (it comes >> naturally at the vm level), but I can't help wondering about the validity >> of the assumptions, the correctness of the code, and all the more so given >> our move to Cog. >> > > Is there a reason *not* to use Mutex in such situations? We have multiple > users telling us there is a problem. > > Mutex is broken, so you better not use it. :) > > Why? where? what should I use instead? > > Levente > > > > ______________________________**__________ > From: pharo-project-bounces(a)lists.**gforge.inria.fr<pharo-project-bounces(a)lists.gforge.inria.fr>[ > pharo-project-bounces(a)lists.**gforge.inria.fr<pharo-project-bounces(a)lists.gforge.inria.fr>] > on behalf of Henrik Sperre Johansen [henrik.s.johansen(a)veloxit.no] > Sent: Friday, December 09, 2011 1:33 PM > To: Pharo-project(a)lists.gforge.**inria.fr<Pharo-project(a)lists.gforge.inria.fr> > Subject: Re: [Pharo-project] How to resurrect an unrepsonsive image? > > On 09.12.2011 16:59, Schwab,Wilhelm K wrote: > >> I would be very curious about what happens if you replace the >> socket-related mutual exclusion semaphores with mutexes. >> > For the semaphore in question here, there is no recursion going on in > any of the critical sections. > So the answer to that would be absolutely nothing. > > Cheers, > Henry > >> >> > -- Mariano http://marianopeck.wordpress.com

Dec. 9, 2011

Re: [Pharo-project] [Pharo-users] [COTDC] 94 - AnnouncementSet

by Igor Stasenko

which is pretty useless IMO. there is no any performance benefit for using groups over single ones. On 9 December 2011 23:54, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > I'm a group of announcements. I can be used to register action to a group of announcement instead of enumerating them one by one. > > > On Dec 9, 2011, at 10:46 PM, sean(a)clipperadams.com wrote: > >> 93 classes done >> 802 classes remaining >> Continuing in Announcements... >> >> Today: Â AnnouncementSet >> >> >> Comment Of The Day Contest - One Day One Comment >> Rules: >> #1: Each day a not commented class is elected. Each day the best comment will be integrated with name of the author(s). >> #2: If you cannot comment it, deprecate it. >> Results: http://code.google.com/p/pharo/wiki/CommentOfTheDayContest >> >> p.s. this message was sent from a pharo image. Did you know you could easily do that?! >> > > -- Best regards, Igor Stasenko.

Dec. 9, 2011

Re: [Pharo-project] How to resurrect an unrepsonsive image?

by Levente Uzonyi

On Fri, 9 Dec 2011, Schwab,Wilhelm K wrote: > Ok, but I have never failed to be impressed by how much trouble even green threads can cause. Meaning no disrespect, if I had a repeatable failure scenario, I would make the switch to a mutex just in case. If for no other reason, Semaphore>>critical: makes assumptions about what is and is not interruptible. I don't have to so much as play dumb here (it comes naturally at the vm level), but I can't help wondering about the validity of the assumptions, the correctness of the code, and all the more so given our move to Cog. Is there a reason *not* to use Mutex in such situations? We have multiple users telling us there is a problem. Mutex is broken, so you better not use it. :) Levente ________________________________________ From: pharo-project-bounces(a)lists.gforge.inria.fr [pharo-project-bounces(a)lists.gforge.inria.fr] on behalf of Henrik Sperre Johansen [henrik.s.johansen(a)veloxit.no] Sent: Friday, December 09, 2011 1:33 PM To: Pharo-project(a)lists.gforge.inria.fr Subject: Re: [Pharo-project] How to resurrect an unrepsonsive image? On 09.12.2011 16:59, Schwab,Wilhelm K wrote: > I would be very curious about what happens if you replace the socket-related mutual exclusion semaphores with mutexes. For the semaphore in question here, there is no recursion going on in any of the critical sections. So the answer to that would be absolutely nothing. Cheers, Henry >

Dec. 9, 2011

Re: [Pharo-project] [squeak-dev] Re: Prune stack serialization

by Mariano Martinez Peck

Hi guys. When we implemented this possibility of pruning the closures when they were clean, one of our crazy tests started to fail. It is not that the test is very important, but I am interested in trying to understand why it fails. The test (simplied) is: | aSortedCollection materialized | instanceVariableForTesting := false. aSortedCollection := SortedCollection sortBlock: [:a :b | instanceVariableForTesting ifTrue: [ a <= b ] ifFalse: [ a >= b ] ]. materialized := self resultOfSerializeAndMaterialize: aSortedCollection. materialized addAll: #(2 3 1). aSortedCollection addAll: #(2 3 1). Well, the thing is that the materialized SortedCollection, it is sortBLock, the closure is quite crazy and the 'instanceVariableForTesting' doesn't have the boolean but instead a #Processor WTF?? So then the #addAll: fails with a MustBeBoolean. Do you think there is something I should check for this closure? I think it may have to be related with the instanceVariable... Just for the record, what we are doing is something like: serializeReferencesOf: aBlockClosure with: aSerialization 1 to: aBlockClosure basicSize do: [ :index | aSerialization encodeReferenceTo: (aBlockClosure basicAt: index) ]. aBlockClosure isClean ifTrue: [ aSerialization stream nextPut: 1. aSerialization encodeReferenceTo: aBlockClosure method. aSerialization encodeReferenceTo: aBlockClosure receiver. ] ifFalse: [ aSerialization stream nextPut: 0. aSerialization encodeReferenceTo: aBlockClosure outerContext. ]. aSerialization encodeReferenceTo: aBlockClosure startpc. aSerialization encodeReferenceTo: aBlockClosure numArgs. ----- materializeReferencesOf: aBlockClosure with: aMaterialization | methodOrContext method context | 1 to: aBlockClosure basicSize do: [ :index | aBlockClosure basicAt: index put: (aMaterialization nextEncodedReference). ]. (aMaterialization stream next = 1) ifTrue: [ " it was a clean BlockClosure, otherwise it should have been 0" method := aMaterialization nextEncodedReference. aBlockClosure outerContext: (MethodContext sender: nil receiver: aMaterialization nextEncodedReference method: method arguments: #() ) startpc: aMaterialization nextEncodedReference numArgs: aMaterialization nextEncodedReference. ] ifFalse: [ context := aMaterialization nextEncodedReference. aBlockClosure outerContext: context startpc: aMaterialization nextEncodedReference numArgs: aMaterialization nextEncodedReference]. ----- Thanks in advance! On Sun, Dec 4, 2011 at 8:33 PM, Mariano Martinez Peck <marianopeck(a)gmail.com > wrote: > Thanks Juan. With the latest version of Eliot, the following are failing: > > > self deny: [ | outerBlockTemp | [ outerBlockTemp printString ] isClean ] > value. > self deny: [ | outerBlockTemp | [ outerBlockTemp :=7 ] isClean ] value. > self deny: [ tempVar + 1 ] isClean. > self deny: [ tempVar := 1 ] isClean. > self deny: [ ClassVar + 1 ] isClean. > self deny: [ ClassVar := 1 ] isClean. > > Thanks > > > On Sat, Dec 3, 2011 at 3:01 AM, Juan Vuletich <juan(a)jvuletich.org> wrote: > >> Eliot Miranda wrote: >> >> >>> >>> On Fri, Dec 2, 20Tha11 at 4:01 PM, Juan Vuletich <juan(a)jvuletich.org<mailto: >>> juan(a)jvuletich.org>> wrote: >>> >>> Eliot Miranda wrote: >>> >>> Hi Juan, >>> >>> ... >>> >>> >>> >>> I can say that it does indeed work. But I'd be really >>> grateful if >>> Eliot took a good look at that code! >>> >>> >>> There is a much better way, using >>> InstructionStream>>**interpreetNextInstructionFor: which >>> abstracts away from the bytecode encoding and allows one to >>> simply use messages. e.g. look at >>> >>> and (SortedCollection sortBlock: [:a :b| a compare: b >>> caseSensitive: false]) sortBlock abstractBytecodes evaluates to >>> >>> an OrderedCollection(#**pushTemporaryVariable: >>> #pushTemporaryVariable: #pushConstant: #send:super:numArgs:) >>> >>> So a check for clean blocks would check for a block's >>> abstractBytecodes not including some particular set of banned >>> messages (which I *think* is pushReceiver >>> pushReceiverVariable: popIntoReceiverVariable: >>> storeIntoReceiverVariable: methodReturnConstant: >>> methodReturnReceiver methodReturnTop). >>> >>> e.g. >>> >>> isClean >>> ^(self abstractBytecodes intersection: #(pushReceiver >>> pushReceiverVariable: popIntoReceiverVariable: >>> storeIntoReceiverVariable: methodReturnConstant: >>> methodReturnReceiver methodReturnTop)) isEmpty >>> >>> >>> Cheers, >>> Juan Vuletich >>> >>> >>> >>> >>> -- best, >>> Eliot >>> >>> >>> Thanks Eliot. However, it looks to me that this needs more tweaking. >>> >>> <blush>Damn right :) I've done zero testing. It was just an >>> example</blush> >>> >>> For instance, your method answers true for >>> [ xx size ] isClean >>> and >>> [ ^ nil ] isClean >>> while mine answers false for both. Maybe we could serialize non >>> local returns using the Compiler (although we won't be able to >>> return anywhere), but external variable acess is a problem. >>> >>> Will keep playing with this for a while... >>> >>> >>> Can you (can I??) write some tests? What's xx in the above? Ah! [^nil] >>> isn't clean in my code since it should be pc <= end, not pc < end!! Try >>> the attached... >>> >> >> This is a start: >> >> testIsClean >> " >> ClosureTests new testIsClean >> " >> | tempVar | >> tempVar := 1. >> self assert: [ 3 + 4 ] isClean. >> self assert: [ :a | a * 2 ] isClean. >> self assert: [ Smalltalk size ] isClean. >> self assert: [ :blockArg | blockArg printString ] isClean. >> self assert: [ | blockTemp | blockTemp printString ] isClean. >> self assert: [ | blockTemp | blockTemp :=7 ] isClean. >> self deny: [ | outerBlockTemp | [ outerBlockTemp printString ] isClean >> ] value. >> self deny: [ | outerBlockTemp | [ outerBlockTemp :=7 ] isClean ] value. >> self deny: [ tempVar + 1 ] isClean. >> self deny: [ tempVar := 1 ] isClean. >> self deny: [ ivar + 1 ] isClean. >> self deny: [ ivar := 1 ] isClean. >> self deny: [ ^ true ] isClean. >> self deny: [ self printString ] isClean. >> self deny: [ ^ self ] isClean. >> self deny: [ ClassVar + 1 ] isClean. >> self deny: [ ClassVar := 1 ] isClean. >> >> This test passes with my implementation. >> >> >> >>> >>> Cheers, >>> Juan Vuletich >>> >>> >>> >>> >>> -- >>> best, >>> Eliot >>> >>> >> Cheers, >> Juan Vuletich >> >> > > > -- > Mariano > http://marianopeck.wordpress.com > > -- Mariano http://marianopeck.wordpress.com

Dec. 9, 2011

Re: [Pharo-project] SMTPClient uses local address

by Sean P. DeNigris

Issue 5078: SMTPClient (wrongly) uses local address http://code.google.com/p/pharo/issues/detail?id=5078 I have no idea how to fix it. I cheated in my image with "(PipeableOSProcess waitForCommand: 'curl whatismyip.org') output" to get it to work temporarily. -- View this message in context: http://forum.world.st/SMTPClient-uses-local-address-tp4178445p4178467.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Dec. 9, 2011