December 2011 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Startup Preferences

by Benjamin

On Dec 16, 2011, at 8:16 PM, Sean P. DeNigris wrote: > > Benjamin Van Ryseghem-2 wrote >> >> You are right. It doesn't add a lot, except maybe that you can set an >> action do be performed only once per image and not at every launch. >> >> But may be you can do it also with Metacello :) >> > > If I understand correctly, Metacello would. My primary motivation here is to > make sure we squeeze all the juice out of our current tools before adding > more. I've been working a lot with Morphic, and I see how hard it is to > remove bloat once it's been incorporated into the image. I always go back to > two items of the manifesto: > * Beauty to learn from > * Clean, lean and fast > > It is imperative that we add as little as possible, especially where a > context shift is required. > > Sean Metacello can code, for sure. The point is that StartupPreferences is not a mechanism to load code, it's a mechanism to load code at startup and to have a chain a possible location to find scripts. So if you want to load a metacello gofer a load time, you will have to create a class to launch it. Moreover, you can't ensure some action are set only once and some each time. I am not for pushing new useless stuff in the system, but I am pretty sure that such a mechanism is really needed ( I can't imagine liveing without it now ^^) Ben > > > -- > View this message in context: http://forum.world.st/Startup-Preferences-tp4129591p4205896.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. >

Dec. 16, 2011

[Pharo-project] Anyone want more timezones in the base image?

by Paul DeBruicker

Hi - Because of how Internet Explorer reports javascript dates back to Seaside (as detected by Brian Murphy-Dye when using the FullCalendar jQuery plugin) I added the ability to determine the timezone based on the abbreviation IE reports. I used the list here: https://en.wikipedia.org/wiki/Time_zone_abbreviations to create an expanded version of TimeZone class>>#timeZones which encompasses those shown in the list on wikipedia. And added some convenience methods. Its not as useful or sophisticated as David Lewis's TimeZone database or Chronos, but its more than what's in the image now. If someone wants it I can make an issue and package my changes up for review. Right now I'm just including them as extensions to the JQWidgetBox-JQFullCalendar-Core package. Thanks for whatever guidance you care to provide. Paul DeBruicker

Dec. 16, 2011

Re: [Pharo-project] Help with #cleanUpForRelease is broken: MessageNotUnderstood: ByteSymbol>>run:with:in:

by Mariano Martinez Peck

Well.....the maximum I got after a couple of hours is to be able to reproduce it executing TWO times (because the first one works) the following: "code that geenrates the bug" HashedCollection compactAll. Smalltalk removeEmptyMessageCategories. "Code to test the bug" Smalltalk allClassesAndTraitsDo: [ :class | [ :each | each removeEmptyCategories; sortCategories ] value: class organization; value: class class organization ]. If I do only HashedCollection compactAll or only Smalltalk removeEmptyMessageCategories., there is no problem, I can execute the rest without problems. If I do both (no matter which order), then the error happens. Moreover, I tried: (HashedCollection allSubclasses reject: [:each | each = MethodDictionary ]) do: #compactAllInstances. and that does work (no errors). So...somehow, the compact of the MethodDictionary is affecting something...what it is weird is that it only fails if the other code is executed... Anyway, any hint is appreciated. Thanks On Fri, Dec 16, 2011 at 8:24 PM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > Hi guys. Somethine is very strange. I cannot do ScriptLoader new > cleanUpForRelease because I get an error saying MessageNotUnderstood: > ByteSymbol>>run:with:in: > So....all the info is here: > http://code.google.com/p/pharo/issues/detail?id=5005 > I checked and it is not related to methodDictionary rehash..... so, do you > have in mind what can we be doing in cleanUpForRelease which causes tu put > symbols in the value of the association of a MethodDictionary rather than a > CompiledMethod ??? > > Thanks! > > -- > Mariano > http://marianopeck.wordpress.com > > -- Mariano http://marianopeck.wordpress.com

Dec. 16, 2011

Re: [Pharo-project] Class rename on materialization

by Mariano Martinez Peck

so guys??? Should we only renames Classes/Traits/ClassPools/Methods or we directly rename all ocurrences of a symbol ? On Thu, Dec 15, 2011 at 6:32 AM, Martin Dias <tinchodias(a)gmail.com> wrote: > Hi. We have recently discussed in a couple of threads about > serialization & class renames. I want to ask you for the following > case, because I'm not sure what should be the expected result. > > Suppose we serialize: > > Array > with: OldClass new > with: OldClass > with: #OldClass. > > Then, we specify to the materializer that OldClass has been renamed to > NewClass. > > Now, should we expect that > > result > first -------> a NewClass > second --> NewClass > third ------> #NewClass > > or... > > result > third ------> #OldClass > > ? > > In other words, should a class rename affect to every symbol in the graph? > > > Thanks, > MartÃn > > -- Mariano http://marianopeck.wordpress.com

Dec. 16, 2011

Re: [Pharo-project] [Vm-dev] New primitive??? [WAS] Re: IdentitySet but using #hash rather than #identityHash ?

by Eliot Miranda

On Fri, Dec 16, 2011 at 11:55 AM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > > > "Preallocate objects, so we won't count gc time." >> n := 1000000. >> objects := Array new: n streamContents: [ :stream | >> n timesRepeat: [ stream nextPut: Object new ] ]. >> >> >> set := IdentitySet new: n. >> Smalltalk garbageCollect. >> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "4949" >> >> set := LargeIdentitySet new. >> Smalltalk garbageCollect. >> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "331" >> >> set := (PluggableSet new: n) >> hashBlock: [ :object | object identityHash * 4096 + object class >> identityHash * 64 ]; "Change this to #basicIdentityHash in Pharo" >> equalBlock: [ :a :b | a == b ]; >> yourself. >> Smalltalk garbageCollect. >> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "5511" >> >> >> I also have a LargeIdentityDictionary, which is relatively fast, but not >> as fast as LargeIdentitySet, because (for some unknown reason) we don't >> have a primitive that could support it. If we had a primitive like >> primitive 132 which would return the index of the element if found or 0 if >> not, then we could have a really fast LargeIdentityDictionary. >> >> > Eliot do you think we could provide such a primitive? > Levente, what's the specification? > > Thanks > > > >> >> Levente >> >> >>> Cheers, >>> Henry >>> >>> >>> >> > > > -- > Mariano > http://marianopeck.wordpress.com > > > -- best, Eliot

Dec. 16, 2011

[Pharo-project] New primitive??? [WAS] Re: IdentitySet but using #hash rather than #identityHash ?

by Mariano Martinez Peck

> "Preallocate objects, so we won't count gc time." > n := 1000000. > objects := Array new: n streamContents: [ :stream | > n timesRepeat: [ stream nextPut: Object new ] ]. > > > set := IdentitySet new: n. > Smalltalk garbageCollect. > [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "4949" > > set := LargeIdentitySet new. > Smalltalk garbageCollect. > [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "331" > > set := (PluggableSet new: n) > hashBlock: [ :object | object identityHash * 4096 + object class > identityHash * 64 ]; "Change this to #basicIdentityHash in Pharo" > equalBlock: [ :a :b | a == b ]; > yourself. > Smalltalk garbageCollect. > [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "5511" > > > I also have a LargeIdentityDictionary, which is relatively fast, but not > as fast as LargeIdentitySet, because (for some unknown reason) we don't > have a primitive that could support it. If we had a primitive like > primitive 132 which would return the index of the element if found or 0 if > not, then we could have a really fast LargeIdentityDictionary. > > Eliot do you think we could provide such a primitive? Thanks > > Levente > > >> Cheers, >> Henry >> >> >> > -- Mariano http://marianopeck.wordpress.com

Dec. 16, 2011

Re: [Pharo-project] IdentitySet but using #hash rather than #identityHash ?

by Mariano Martinez Peck

On Fri, Dec 16, 2011 at 3:28 PM, Levente Uzonyi <leves(a)elte.hu> wrote: > On Fri, 16 Dec 2011, Henrik Sperre Johansen wrote: > > On 16.12.2011 03:26, Levente Uzonyi wrote: >> >>> >>> How about my numbers? :) >>> >>> "Preallocate objects, so we won't count gc time." >>> n := 1000000. >>> objects := Array new: n streamContents: [ :stream | >>> n timesRepeat: [ stream nextPut: Object new ] ]. >>> >>> set := IdentitySet new: n. >>> Smalltalk garbageCollect. >>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "4949" >>> >>> set := LargeIdentitySet new. >>> Smalltalk garbageCollect. >>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "331" >>> >>> set := (PluggableSet new: n) >>> hashBlock: [ :object | object identityHash * 4096 + object class >>> identityHash * 64 ]; "Change this to #basicIdentityHash in Pharo" >>> equalBlock: [ :a :b | a == b ]; >>> yourself. >>> Smalltalk garbageCollect. >>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "5511" >>> >>> >>> I also have a LargeIdentityDictionary, which is relatively fast, but not >>> as fast as LargeIdentitySet, because (for some unknown reason) we don't >>> have a primitive that could support it. If we had a primitive like >>> primitive 132 which would return the index of the element if found or 0 if >>> not, then we could have a really fast LargeIdentityDictionary. >>> >>> >>> Levente >>> >> Hehe yes, if writing a version fully exploiting the limited range, that's >> probably the approach I would go for as well. >> (IAssuming it's the version at http://leves.web.elte.hu/** >> squeak/LargeIdentitySet.st<http://leves.web.elte.hu/squeak/LargeIdentitySet.st> >> ) >> >> Mariano commented in the version at http://www.squeaksource.com/** >> FuelExperiments <http://www.squeaksource.com/FuelExperiments> that it's >> slow for them, which I guess is due to not adopting #identityHash calls to >> #basicIdentityHash calls for Pharo: >> ((0 to: 4095) collect: [:each | each << 22 \\ 4096 ]) asSet size -> 1 >> So it basically uses 1 bucket instead of 4096... Whoops. :) >> >> Uploaded a new version to the MC repository which is adapted for Pharo, >> on the same machine my numbers were taken from, it does the same test as I >> used above in 871 ms. (181 with preallocation). >> > > Cool. One more thing: in Squeak the method using primitive 132 directly > was renamed to #instVarsInclude:, so now #pointsTo: works as expected. If > this was also added to Pharo, then the #pointsTo: sends should be changed > to #instVarsInclude:, otherwise Array can be reported as included even if > it wasn't added. > In Pharo we have: pointsTo: anObject "This method returns true if self contains a pointer to anObject, and returns false otherwise" <primitive: 132> So I guess it is correct to let it like this. > I'll upload my LargeIdentityDictionary implementation to the same place > this evening, since it's still 2-3 factor faster than other solutionts and > there seem to be demand for it. > > I am lost. thought I read something saying you couldn't do that for Dictionaries because you needed a primitive? Sorry...long day, maybe I am just crazy ;) Anyway, I would appreaciate and take a look to LargeIdentityDictionary if you do it. BTW, I guess both are MIT ? Thanks Levente > > Levente > > >> Cheers, >> Henry >> >> >> > -- Mariano http://marianopeck.wordpress.com

Dec. 16, 2011

Re: [Pharo-project] IdentitySet but using #hash rather than #identityHash ?

by Mariano Martinez Peck

Levente, one more question: is there a case (small sets?) where LargeIdentitySet is not recommended? my question is, should I ONLY use it for places where I know I can have large sets or should it also work for small sets as well? from my tests it seems to work well also with small ones...but just wondering. Thanks On Fri, Dec 16, 2011 at 8:43 PM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > Wow...... > > Henrik: thank you so much for teaching me :) Indeed, I didn't notice that > in that case I use using a LargePositiveInteger, and indeed I had removed > the basicSize since I also noticed it wouldn't make much sense. Second, > thanks a LOT for finding Levente's LargeIdentitySet in Fuel repo with our > small adaptation (#addIfNotPresent: anObject ifPresentDo: aBlock). Thanks > for fixing it and commiting a new version. > > All I can say is that I am impressed by the numbers it is really much > faster. > I still don't understand why I send this email with a subject say > IdentitySet because what I really need is a fast/large IdentityDictionary > :( Anyway, there's a place where we can use this LargeIdentitySet in Fuel > I think). > > So Levente, you say this is not possible to adapt this for dictionary? > can we contact Eliot to provide such a primitive? > > thanks > > > On Fri, Dec 16, 2011 at 3:28 PM, Levente Uzonyi <leves(a)elte.hu> wrote: > >> On Fri, 16 Dec 2011, Henrik Sperre Johansen wrote: >> >> On 16.12.2011 03:26, Levente Uzonyi wrote: >>> >>>> >>>> How about my numbers? :) >>>> >>>> "Preallocate objects, so we won't count gc time." >>>> n := 1000000. >>>> objects := Array new: n streamContents: [ :stream | >>>> n timesRepeat: [ stream nextPut: Object new ] ]. >>>> >>>> set := IdentitySet new: n. >>>> Smalltalk garbageCollect. >>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "4949" >>>> >>>> set := LargeIdentitySet new. >>>> Smalltalk garbageCollect. >>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "331" >>>> >>>> set := (PluggableSet new: n) >>>> hashBlock: [ :object | object identityHash * 4096 + object class >>>> identityHash * 64 ]; "Change this to #basicIdentityHash in Pharo" >>>> equalBlock: [ :a :b | a == b ]; >>>> yourself. >>>> Smalltalk garbageCollect. >>>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "5511" >>>> >>>> >>>> I also have a LargeIdentityDictionary, which is relatively fast, but >>>> not as fast as LargeIdentitySet, because (for some unknown reason) we don't >>>> have a primitive that could support it. If we had a primitive like >>>> primitive 132 which would return the index of the element if found or 0 if >>>> not, then we could have a really fast LargeIdentityDictionary. >>>> >>>> >>>> Levente >>>> >>> Hehe yes, if writing a version fully exploiting the limited range, >>> that's probably the approach I would go for as well. >>> (IAssuming it's the version at http://leves.web.elte.hu/** >>> squeak/LargeIdentitySet.st<http://leves.web.elte.hu/squeak/LargeIdentitySet.st> >>> ) >>> >>> Mariano commented in the version at http://www.squeaksource.com/** >>> FuelExperiments <http://www.squeaksource.com/FuelExperiments> that it's >>> slow for them, which I guess is due to not adopting #identityHash calls to >>> #basicIdentityHash calls for Pharo: >>> ((0 to: 4095) collect: [:each | each << 22 \\ 4096 ]) asSet size -> 1 >>> So it basically uses 1 bucket instead of 4096... Whoops. :) >>> >>> Uploaded a new version to the MC repository which is adapted for Pharo, >>> on the same machine my numbers were taken from, it does the same test as I >>> used above in 871 ms. (181 with preallocation). >>> >> >> Cool. One more thing: in Squeak the method using primitive 132 directly >> was renamed to #instVarsInclude:, so now #pointsTo: works as expected. If >> this was also added to Pharo, then the #pointsTo: sends should be changed >> to #instVarsInclude:, otherwise Array can be reported as included even if >> it wasn't added. >> I'll upload my LargeIdentityDictionary implementation to the same place >> this evening, since it's still 2-3 factor faster than other solutionts and >> there seem to be demand for it. >> >> >> Levente >> >> >>> Cheers, >>> Henry >>> >>> >>> >> > > > -- > Mariano > http://marianopeck.wordpress.com > > -- Mariano http://marianopeck.wordpress.com

Dec. 16, 2011

Re: [Pharo-project] IdentitySet but using #hash rather than #identityHash ?

by Mariano Martinez Peck

Wow...... Henrik: thank you so much for teaching me :) Indeed, I didn't notice that in that case I use using a LargePositiveInteger, and indeed I had removed the basicSize since I also noticed it wouldn't make much sense. Second, thanks a LOT for finding Levente's LargeIdentitySet in Fuel repo with our small adaptation (#addIfNotPresent: anObject ifPresentDo: aBlock). Thanks for fixing it and commiting a new version. All I can say is that I am impressed by the numbers it is really much faster. I still don't understand why I send this email with a subject say IdentitySet because what I really need is a fast/large IdentityDictionary :( Anyway, there's a place where we can use this LargeIdentitySet in Fuel I think). So Levente, you say this is not possible to adapt this for dictionary? can we contact Eliot to provide such a primitive? thanks On Fri, Dec 16, 2011 at 3:28 PM, Levente Uzonyi <leves(a)elte.hu> wrote: > On Fri, 16 Dec 2011, Henrik Sperre Johansen wrote: > > On 16.12.2011 03:26, Levente Uzonyi wrote: >> >>> >>> How about my numbers? :) >>> >>> "Preallocate objects, so we won't count gc time." >>> n := 1000000. >>> objects := Array new: n streamContents: [ :stream | >>> n timesRepeat: [ stream nextPut: Object new ] ]. >>> >>> set := IdentitySet new: n. >>> Smalltalk garbageCollect. >>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "4949" >>> >>> set := LargeIdentitySet new. >>> Smalltalk garbageCollect. >>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "331" >>> >>> set := (PluggableSet new: n) >>> hashBlock: [ :object | object identityHash * 4096 + object class >>> identityHash * 64 ]; "Change this to #basicIdentityHash in Pharo" >>> equalBlock: [ :a :b | a == b ]; >>> yourself. >>> Smalltalk garbageCollect. >>> [1 to: n do: [ :i | set add: (objects at: i) ] ] timeToRun. "5511" >>> >>> >>> I also have a LargeIdentityDictionary, which is relatively fast, but not >>> as fast as LargeIdentitySet, because (for some unknown reason) we don't >>> have a primitive that could support it. If we had a primitive like >>> primitive 132 which would return the index of the element if found or 0 if >>> not, then we could have a really fast LargeIdentityDictionary. >>> >>> >>> Levente >>> >> Hehe yes, if writing a version fully exploiting the limited range, that's >> probably the approach I would go for as well. >> (IAssuming it's the version at http://leves.web.elte.hu/** >> squeak/LargeIdentitySet.st<http://leves.web.elte.hu/squeak/LargeIdentitySet.st> >> ) >> >> Mariano commented in the version at http://www.squeaksource.com/** >> FuelExperiments <http://www.squeaksource.com/FuelExperiments> that it's >> slow for them, which I guess is due to not adopting #identityHash calls to >> #basicIdentityHash calls for Pharo: >> ((0 to: 4095) collect: [:each | each << 22 \\ 4096 ]) asSet size -> 1 >> So it basically uses 1 bucket instead of 4096... Whoops. :) >> >> Uploaded a new version to the MC repository which is adapted for Pharo, >> on the same machine my numbers were taken from, it does the same test as I >> used above in 871 ms. (181 with preallocation). >> > > Cool. One more thing: in Squeak the method using primitive 132 directly > was renamed to #instVarsInclude:, so now #pointsTo: works as expected. If > this was also added to Pharo, then the #pointsTo: sends should be changed > to #instVarsInclude:, otherwise Array can be reported as included even if > it wasn't added. > I'll upload my LargeIdentityDictionary implementation to the same place > this evening, since it's still 2-3 factor faster than other solutionts and > there seem to be demand for it. > > > Levente > > >> Cheers, >> Henry >> >> >> > -- Mariano http://marianopeck.wordpress.com

Dec. 16, 2011

Re: [Pharo-project] [COTDC] 97 - CRCError

by Sean P. DeNigris

Hello? Hello? Hello? Is there anybody in there? Just nod if you can hear me. Is there anyone at home? http://www.youtube.com/watch?v=ZB1cNkC71vE -- View this message in context: http://forum.world.st/COTDC-97-CRCError-tp4197055p4205923.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Dec. 16, 2011