December 2011 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] IdentitySet but using #hash rather than #identityHash ?

by Mariano Martinez Peck

Hi Levente. I take a deeper look to see why LargeIdentityDictionary is not working as expected for us. The way we are putting objects in the Dict is always this way: registerIndexesOn: aDictionary self objects do: [ :instance | aDictionary at: instance put: aDictionary size + 1 ]. Soâ¦keys are the objects of the graphs and the values are the internal position in the serialization. However, when I run a serialization it looks like if the follow happens that when we are doing: >> encodeReferenceTo: anObject indexCluster serialize: (objectsIndexes at: anObject) on: stream (objectsIndexes at: anObject) == anObject -> true so (objectsIndexes at: anObject) is answering "self" rather than the number (which was the dict size + 1 at the serialization moment). Something interesting is that most tests seem to pass and the problem is with benchmarks (where graphs are much bigger), so maybe it could be something related to that. For example, the following benchmark for bitmaps is failing: numbers := OrderedCollection new. bitmaps := OrderedCollection new. numbers addAll: ( 1 << 30 to:( ( 1 << 30) + 10000) ) asArray. numbers do: [:each | bitmaps add: (Bitmap with: each with: each + 1) ]. ^ bitmaps it happens the mentioned problem when trying to serialize the collection 'bitmaps'. I tried to reproduce it outside Fuel and I think I succeeded (not sure). The following does work with IdentityDictionary but not with LargeIdentityDictionary. Basically I am simulating the way we use this dict in Fuel: testLargeIdentityDictionary | numbers bitmaps dict | "Create some bitmaps" numbers := OrderedCollection new. bitmaps := OrderedCollection new. numbers addAll: ( 1 << 30 to:( ( 1 << 30) + 10000) ) asArray. numbers do: [:each | bitmaps add: (Bitmap with: each with: each + 1) ]. "Put them in a dictionary using dict as as key" dict := LargeIdentityDictionary new. bitmaps do: [:each | dict at: each put: dict size + 1. ]. "Check they are correct" bitmaps doWithIndex: [:each :index | self assert: index == (dict at: each)] Of course that test works with IdentityDictionary. Thanks for any idea. On Sat, Dec 17, 2011 at 1:50 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr > wrote: > > On Dec 16, 2011, at 3:28 PM, Levente Uzonyi wrote: > > > Cool. One more thing: in Squeak the method using primitive 132 directly > was renamed to #instVarsInclude:, so now #pointsTo: works as expected. If > this was also added to Pharo, then the #pointsTo: sends should be changed > to #instVarsInclude:, otherwise Array can be reported as included even if > it wasn't added. > > I'll upload my LargeIdentityDictionary implementation to the same place > this evening, since it's still 2-3 factor faster than other solutionts and > there seem to be demand for it. > > Levente > > > "in Squeak the method using primitive 132 directly was renamed to > #instVarsInclude:, so now #pointsTo: works as expected." > I do not get the following. Indeed pointTo: looks like instVarsInclude: > now I do not understand the rest of your paragraph. > > Stef > -- Mariano http://marianopeck.wordpress.com

Dec. 17, 2011

Re: [Pharo-project] Instant search

by Benjamin

Should be on the wish list for this new year :) Ben On Dec 17, 2011, at 1:25 PM, StÃ©phane Ducasse wrote: > Nautilus is already better but it relies on rpackage and I got burnt and stopped to work on it sadly. > > >> Hi guys, >> >> What if you enhance search in System Browser so that results will be >> shown instantly and *in the same browser* (not in new window)? That is, >> classes matching criteria and their categories are shown instantly as >> you type in search line. Or with some small delay, like 0.5s. >> >> Or: to drop down results instantly as you type, as you have on Google >> search. After you select some choice, this class is shown immediately in >> the same browser window. >> >> This would be a nice UX improvement for 1.4, in my opinion :) >> >> Of course back button and tabs would be really a big step forward ... >> >> Best regards >> Janko >> >> >> -- >> Janko MivÅ¡ek >> Aida/Web >> Smalltalk Web Application Server >> http://www.aidaweb.si >> > >

Dec. 17, 2011

Re: [Pharo-project] IdentitySet but using #hash rather than #identityHash ?

by StÃ©phane Ducasse

On Dec 16, 2011, at 3:28 PM, Levente Uzonyi wrote: > Cool. One more thing: in Squeak the method using primitive 132 directly was renamed to #instVarsInclude:, so now #pointsTo: works as expected. If this was also added to Pharo, then the #pointsTo: sends should be changed to #instVarsInclude:, otherwise Array can be reported as included even if it wasn't added. > I'll upload my LargeIdentityDictionary implementation to the same place this evening, since it's still 2-3 factor faster than other solutionts and there seem to be demand for it. Levente > "in Squeak the method using primitive 132 directly was renamed to #instVarsInclude:, so now #pointsTo: works as expected." I do not get the following. Indeed pointTo: looks like instVarsInclude: now I do not understand the rest of your paragraph. Stef

Dec. 17, 2011

Re: [Pharo-project] IdentitySet but using #hash rather than #identityHash ?

by StÃ©phane Ducasse

I would love to have that! Stef > > > I also have a LargeIdentityDictionary, which is relatively fast, but not as fast as LargeIdentitySet, because (for some unknown reason) we don't have a primitive that could support it. If we had a primitive like primitive 132 which would return the index of the element if found or 0 if not, then we could have a really fast LargeIdentityDictionary. > > > Levente > >> >> Cheers, >> Henry >> >> >

Dec. 17, 2011

Re: [Pharo-project] NB Bug?

by Serge Stinckwich

2011/12/16 Sean P. DeNigris <sean(a)clipperadams.com>: > > Stefan Marr-3 wrote >> >> LuaJIT2's FFI... specifically the 'cut&past part' >> > > Wow, that's awesome! Why would it ever be any harder than that? Yes really simple to use ! -- Serge Stinckwich UMI UMMISCO 209 (IRD/UPMC), Hanoi, Vietnam Matsuno Laboratory, Kyoto University, Japan (until 12/2011) http://www.mechatronics.me.kyoto-u.ac.jp/ Every DSL ends up being Smalltalk http://doesnotunderstand.org/

Dec. 17, 2011

Re: [Pharo-project] [COTDC] 97 - CRCError

by StÃ©phane Ducasse

you have also the monty python flying circus start with the guy coming out of the see :) Stef On Dec 16, 2011, at 8:29 PM, Sean P. DeNigris wrote: > Hello? Hello? Hello? > Is there anybody in there? > Just nod if you can hear me. > Is there anyone at home? > > http://www.youtube.com/watch?v=ZB1cNkC71vE > > -- > View this message in context: http://forum.world.st/COTDC-97-CRCError-tp4197055p4205923.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. >

Dec. 17, 2011

Re: [Pharo-project] NB Bug?

by StÃ©phane Ducasse

On Dec 16, 2011, at 2:05 PM, Sean P. DeNigris wrote: > > Stefan Marr-3 wrote >> >> LuaJIT2's FFI... specifically the 'cut&past part' >> > > Wow, that's awesome! Why would it ever be any harder than that? before starting pharo I was wondering if I should not develop a smalltalk on top of lua. Somedays I think that I should have. Because we still do not have a vm that can be embedded in C and all the restâ¦. :( Stef > -- > View this message in context: http://forum.world.st/NB-Bug-tp4192637p4204556.html > Sent from the Pharo Smalltalk mailing list archive at Nabble.com. >

Dec. 17, 2011

Re: [Pharo-project] Instant search

by StÃ©phane Ducasse

Nautilus is already better but it relies on rpackage and I got burnt and stopped to work on it sadly. > Hi guys, > > What if you enhance search in System Browser so that results will be > shown instantly and *in the same browser* (not in new window)? That is, > classes matching criteria and their categories are shown instantly as > you type in search line. Or with some small delay, like 0.5s. > > Or: to drop down results instantly as you type, as you have on Google > search. After you select some choice, this class is shown immediately in > the same browser window. > > This would be a nice UX improvement for 1.4, in my opinion :) > > Of course back button and tabs would be really a big step forward ... > > Best regards > Janko > > > -- > Janko MivÅ¡ek > Aida/Web > Smalltalk Web Application Server > http://www.aidaweb.si >

Dec. 17, 2011

Re: [Pharo-project] Time to rename Object>>#name ?

by StÃ©phane Ducasse

> Hi guys, > > Isn't a time come to finally rename this unfortunate method #name in > Object to something more internal? From its comment it seems it is using > just for debugging: > > Object>>name > "Answer a name for the receiver. This is used generically in the > title of certain inspectors, such as the referred-to inspector, and > specificially by various subsystems. By default, we let the object > just print itself out.. " > > ^self printString > > I namely just crashed my image and spend quite some time to find why, by > implementing: > > MyClass>>printString > > ^'aMyClass', self name > > Later I renamed #name to say #myName but forgot to rename a call in this > #printString method too. Boom, infinite recursion! > > Please allow us therefore to use #name in our classes for things a word > "name" is meant! We would love but this is not that easy. Stef > > Best regards > Janko > > -- > Janko MivÅ¡ek > Aida/Web > Smalltalk Web Application Server > http://www.aidaweb.si >

Dec. 17, 2011

[Pharo-project] Time to rename Object>>#name ?

by Janko MivÅ¡ek

Hi guys, Isn't a time come to finally rename this unfortunate method #name in Object to something more internal? From its comment it seems it is using just for debugging: Object>>name "Answer a name for the receiver. This is used generically in the title of certain inspectors, such as the referred-to inspector, and specificially by various subsystems. By default, we let the object just print itself out.. " ^self printString I namely just crashed my image and spend quite some time to find why, by implementing: MyClass>>printString ^'aMyClass', self name Later I renamed #name to say #myName but forgot to rename a call in this #printString method too. Boom, infinite recursion! Please allow us therefore to use #name in our classes for things a word "name" is meant! Best regards Janko -- Janko MivÅ¡ek Aida/Web Smalltalk Web Application Server http://www.aidaweb.si

Dec. 17, 2011