January 2011 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Issue 3624 in pharo: LeftOver of Smalltalk and SystemDictionary

by pharo＠googlecode.com

Updates: Status: Fixed Comment #1 on issue 3624 by stephane...(a)gmail.com: LeftOver of Smalltalk and SystemDictionary http://code.google.com/p/pharo/issues/detail?id=3624 Here is the fix. So far only one method getting wrong Attachments: environment.1.cs 644 bytes

Jan. 30, 2011

Re: [Pharo-project] Beware, self environment is a SystemDictionary, not a SmalltalkImage

by StÃ©phane Ducasse

Ok thanks. I verified them all and published a fix for that one. Stef On Jan 30, 2011, at 10:07 PM, Nicolas Cellier wrote: > No, I was just browsing Kernel differences with MC from Squeak and > found this usage in Pharo/#removeUninstantiatedSubclassesSilently. > > Nicolas > > 2011/1/30 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: >> Hi nicolas >> >> did you check in pharo because if I remember correctly I spent a lot of time doing such a kind of review >> and fixes? >> >> Stef >> >> On Jan 30, 2011, at 9:43 PM, Nicolas Cellier wrote: >> >>> Untill recent past, Smalltalk was a SystemDictionary representing both >>> the namespace and the System. >>> It was bloated with many messages, and sending messages like: >>> self environment garbageCollect. >>> was correct. >>> >>> Now, self environment is supposed to answer the namespace object (a >>> SystemDictionary) not the system object (a SmalltalkImage). >>> So, some usages are not correct anymore. >>> >>> See for example #removeUninstantiatedSubclassesSilently. >>> Fortunately, this message is unsent (quite dangerous isn't it ?). >>> But IMHO, all senders of #environment should be reviewed. >>> >>> Nicolas >>> >> >> >> >

Jan. 30, 2011

Re: [Pharo-project] Issue 3482 in pharo: InterimSoundMorph references to SketchMorph

by pharo＠googlecode.com

Updates: Status: FixedProposed Labels: Milestone-1.3 Comment #8 on issue 3482 by stephane...(a)gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 I integrate the core part in 12327

Jan. 30, 2011

Re: [Pharo-project] Beware, self environment is a SystemDictionary, not a SmalltalkImage

by Nicolas Cellier

No, I was just browsing Kernel differences with MC from Squeak and found this usage in Pharo/#removeUninstantiatedSubclassesSilently. Nicolas 2011/1/30 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: > Hi nicolas > > did you check in pharo because if I remember correctly I spent a lot of time doing such a kind of review > and fixes? > > Stef > > On Jan 30, 2011, at 9:43 PM, Nicolas Cellier wrote: > >> Untill recent past, Smalltalk was a SystemDictionary representing both >> the namespace and the System. >> It was bloated with many messages, and sending messages like: >> Â Â Â self environment garbageCollect. >> was correct. >> >> Now, self environment is supposed to answer the namespace object (a >> SystemDictionary) not the system object (a SmalltalkImage). >> So, some usages are not correct anymore. >> >> See for example #removeUninstantiatedSubclassesSilently. >> Fortunately, this message is unsent (quite dangerous isn't it ?). >> But IMHO, all senders of #environment should be reviewed. >> >> Nicolas >> > > >

Jan. 30, 2011

[Pharo-project] Issue 3624 in pharo: LeftOver of Smalltalk and SystemDictionary

by pharo＠googlecode.com

Status: Accepted Owner: stephane...(a)gmail.com Labels: Milestone-1.3 New issue 3624 by stephane...(a)gmail.com: LeftOver of Smalltalk and SystemDictionary http://code.google.com/p/pharo/issues/detail?id=3624 there are wrong messages sent to self environment.... here garbageCollect. removeUninstantiatedSubclassesSilently "Remove the classes of any subclasses that have neither instances nor subclasses. Answer the number of bytes reclaimed" "Player removeUninstantiatedSubclassesSilently" | candidatesForRemoval oldFree | oldFree := self environment garbageCollect. candidatesForRemoval := self subclasses select: [:c | (c instanceCount = 0) and: [c subclasses size = 0]]. candidatesForRemoval do: [:c | c removeFromSystem]. ^ self environment garbageCollect - oldFree

Jan. 30, 2011

[Pharo-project] [update 1.2] #12327

by StÃ©phane Ducasse

12327 ----- - Issue 3482: InterimSoundMorph references to SketchMorph. Fixing the SoundService registration + making sure that it delegates to the registered sound system when available. After the Sound packages can be updated. Marcus I published the other sounds fixes in the sound packages. Now I do not know how the dev image is specified. May be the script should be changed to load the new packages versions I published. Do you know where is this script? Stef

Jan. 30, 2011

Re: [Pharo-project] Beware, self environment is a SystemDictionary, not a SmalltalkImage

by StÃ©phane Ducasse

Hi nicolas did you check in pharo because if I remember correctly I spent a lot of time doing such a kind of review and fixes? Stef On Jan 30, 2011, at 9:43 PM, Nicolas Cellier wrote: > Untill recent past, Smalltalk was a SystemDictionary representing both > the namespace and the System. > It was bloated with many messages, and sending messages like: > self environment garbageCollect. > was correct. > > Now, self environment is supposed to answer the namespace object (a > SystemDictionary) not the system object (a SmalltalkImage). > So, some usages are not correct anymore. > > See for example #removeUninstantiatedSubclassesSilently. > Fortunately, this message is unsent (quite dangerous isn't it ?). > But IMHO, all senders of #environment should be reviewed. > > Nicolas >

Jan. 30, 2011

Re: [Pharo-project] Issue 3482 in pharo: InterimSoundMorph references to SketchMorph

by pharo＠googlecode.com

Comment #7 on issue 3482 by stephane...(a)gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 I published a new Slice named 3482-FixSoundService It is probably necessary to do a SoundService reset (newly introduced method) and DummySoundSystem initialize. as postload action Then I published another slice

Jan. 30, 2011

[Pharo-project] Beware, self environment is a SystemDictionary, not a SmalltalkImage

by Nicolas Cellier

Untill recent past, Smalltalk was a SystemDictionary representing both the namespace and the System. It was bloated with many messages, and sending messages like: self environment garbageCollect. was correct. Now, self environment is supposed to answer the namespace object (a SystemDictionary) not the system object (a SmalltalkImage). So, some usages are not correct anymore. See for example #removeUninstantiatedSubclassesSilently. Fortunately, this message is unsent (quite dangerous isn't it ?). But IMHO, all senders of #environment should be reviewed. Nicolas

Jan. 30, 2011

Re: [Pharo-project] Issue 3482 in pharo: InterimSoundMorph references to SketchMorph

by pharo＠googlecode.com

Comment #6 on issue 3482 by stephane...(a)gmail.com: InterimSoundMorph references to SketchMorph http://code.google.com/p/pharo/issues/detail?id=3482 So apparently I should move the behavior from BaseSoundSystem to AsbtractSoundSystem. Then there is a problem since the registeredClasses contain instances!!!! So I will fix that too.

Jan. 30, 2011