August 2010 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Question: How can I add a items to System Browser Window menu?

by HernÃ¡n Morales Durand

Hi Carla, 2010/8/7 Carla F. Griggio <carla.griggio(a)gmail.com>: > Hello! > > I want to add an item to the menu that appears when you right click on a > category in the System Browser window. > System Browser or OmniBrowser on system categories? HernÃ¡n

Aug. 8, 2010

Re: [Pharo-project] Instance variable pull up broken

by Niko Schwarz

Hmm, I can't reproduce it in a fresh image, either. Sorry for the noise. Niko On Sat, Aug 7, 2010 at 10:39 PM, Lukas Renggli <renggli(a)gmail.com> wrote: > I cannot reproduce. If you look at the code you should see that what > you describe should not happen: > > transform > Â Â Â Â class allSubclasses do: > Â Â Â Â Â Â Â Â Â Â Â Â [:each | > Â Â Â Â Â Â Â Â Â Â Â Â (each directlyDefinesInstanceVariable: variableName) > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ifTrue: [each removeInstanceVariable: variableName]]. > Â Â Â Â class addInstanceVariable: variableName > > Maybe your class hierarchy is broken? > > Lukas > > On 7 August 2010 22:18, Niko Schwarz <niko.schwarz(a)googlemail.com> wrote: >> Here's a funny way to crash your image. Works in: >> >> Pharo-1.1-11367-Beta >> Latest update: #11367 >> >> Make a class named AbstractBla, with two subclasses: SubA, SubB. Then, >> add to both SubA and SubB the identically named instance variable: >> instVar. Now, use the "pull up" refactoring in OmniBrowser on SubA to >> pull up instVar into the superclass. As you correctly guess, that >> breaks SubB, because now both its superclass and SubB have an instance >> variable named instVar. But, instead of refusing to refactor, >> OmniBrowser dutifully refactors and takes the image with it. >> >> I hope that was understandable. >> >> Cheers, >> >> Niko >> >> >> -- >> http://scg.unibe.ch/staff/Schwarz >> twitter.com/nes1983 >> Tel: +41 076 235 8683 >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- http://scg.unibe.ch/staff/Schwarz twitter.com/nes1983 Tel: +41 076 235 8683

Aug. 7, 2010

Re: [Pharo-project] Question: How can I add a items to System Browser Window menu?

by Carla F. Griggio

Yes! I looked for other examples with the pragma, but they were for the World menu (thanks anyway!). I meant the menu that Guille captured. 2010/8/7 Guillermo Polito <guillermopolito(a)gmail.com> > I think Car meant the context menu when you right-clic a category in the > System Browser. I don't know how, but maybe my screenshot help someone to > help you :). > > > On Sat, Aug 7, 2010 at 8:11 AM, StÃ©phane Ducasse < > stephane.ducasse(a)inria.fr> wrote: > >> >> >> >> On Aug 7, 2010, at 12:22 PM, Carla F. Griggio wrote: >> >> > Hello! >> > >> > I want to add an item to the menu that appears when you right click on a >> category in the System Browser window. >> > >> > I think that menu is built here: >> > >> > Morph>>buildMetaMenu: evt >> > >> > But I don't want to touch that method, not SystemWindow>>buildMetaMenu: >> evt either, because that option would have to be visible only if my project >> has been loaded. >> >> exactly nobody should change the core methods just declare intention. >> > >> > Is there a way to do that? >> >> sure. >> you should use a pragma <menu> >> >> here is for example how this is done for ScriptLoader >> >> menuCommandOn: aBuilder >> <worldMenu> >> >> (aBuilder item: #'Integrator Menu') >> order: 1.5; >> precondition: [self currentlyIntegratingChanges]; >> parent: #System; >> action: [ScriptLoader releaseMenu] >> >> >> >> > >> > Thanks! >> > Carla >> > _______________________________________________ >> > Pharo-project mailing list >> > Pharo-project(a)lists.gforge.inria.fr >> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Aug. 7, 2010

Re: [Pharo-project] XML Parser, Monticello and unicode?

by Norbert Hartl

On 07.08.2010, at 20:58, Philippe Marschall wrote: > On 07.08.2010 13:08, Norbert Hartl wrote: >> .... >> To estimate the possibility to change this I think we should fix this. I scanned all of my cached monticello packages. Most of them are 7bit clean. No problem for them if we change encoding. Besides XML Parser I didn't find any that contain WideString so no problem here. Some of them are latin1 encoded (like Seaside 2.8 or Seaside-InternetExplorer from 3.0). That is the biggest problem because there is no fallback and monticello does not have a version number on file format, right? >> I think it is still feasible to change this in monticello as the fix for users of older images will be probably only a few lines that you can apply to any version of monticello if I'm not wrong. But the change is not that easy. > > We try to be 7bit clean in Seaside. Can you report the methods you have > trouble with to either the seaside mailing list or the issue tracker [1]? > I don't have troubles with any of the seaside methods. It just seems impossible for me to state things clear enough :) There was a real problem. There was WideStrings creeping into the monticello package of XML Parser. There is no way monticello can handle multi byte strings as it uses latin1 for encoding. The latin1 encoded WideStrings cannot be read by gemstone. But the troublesome piece of code has already been removed from the XML Parser package. Seaside is not completely 7bit clean. As an example take Seaside-InternetExplorer-lr.6.mcz. There is a sentence "...we have introduced a mechanism to help prevent the untrusted content from compromising your site<92>s security...". The <92> is a RIGHT SINGLE QUOTATION MARK that Microsoft put into the latin1 gap. So I guess this is CP1252 which means it has been copied from a windows system into the squeak image. Norbert

Aug. 7, 2010

Re: [Pharo-project] Issue 2756: Morphic Cleansing - Remove use of findA:

by Guillermo Polito

Hi! I realized that because *Morphic>>findA: aClass "Return the first submorph of the receiver that is descended from the given class. Return nil if there is no such submorph. Clients of this code should always check for a nil return value so that the code will be robust if the user takes the morph apart." ^self submorphs detect: [:p | p isKindOf: aClass] ifNone: [nil]* we can simply replace MenuMorph>>doButtonAction by *MenuMorph>>doButtonAction "Do the receiver's inherent button action. A MenuMorph that is a wrapper for a single menu-item -- pass it on the the item. We should enhance or think what to do with a MenuMorph with multiple items" self menuItems notEmpty ifTrue:[ self menuItems first doActionButton ]* I'll look at that a few minutes to give a little fix :). On Fri, Aug 6, 2010 at 6:28 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>wrote: > > On Aug 6, 2010, at 4:54 AM, Guillermo Polito wrote: > > > Hi, removing some findA: message sendings > > Yes yes yes!!! > We only need a few of them. > > > i've found: > > > > MenuMorph>>doButtonAction > > "Do the receiver's inherent button action. Makes sense for the kind > of MenuMorph that is a wrapper for a single menu-item -- pass it on the the > item" > > > > (self findA: MenuItemMorph) ifNotNil: [:aMenuItem | aMenuItem > doButtonAction] > > > > > > And for me it doesn't make sense :). Even the comment doesn't make > sense, because it isn't considering the case where a MenuMorph has multiple > MenuItemMorph s. > > > > What should be done in cases like that? If it's my code, i should be > tempted to delete it or maybe to deprecate it. And I'm really upset because > it is a very difficult thing to verify not to break too much other things. > So, what is the "official policy" about this cases? :P I don't like to > leave it as it is... > > Get one or more scenario where the code behavior normally > and rewrite so that it does not use findA: > What I suggest is that you start with the easy findA: and publish often so > that we integrate them in the system > and slowly we learn and fix the ugly. > > Stef > > > > > > > Cheers, > > Guille > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Aug. 7, 2010

Re: [Pharo-project] Question: How can I add a items to System Browser Window menu?

by Guillermo Polito

I think Car meant the context menu when you right-clic a category in the System Browser. I don't know how, but maybe my screenshot help someone to help you :). On Sat, Aug 7, 2010 at 8:11 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>wrote: > > > > On Aug 7, 2010, at 12:22 PM, Carla F. Griggio wrote: > > > Hello! > > > > I want to add an item to the menu that appears when you right click on a > category in the System Browser window. > > > > I think that menu is built here: > > > > Morph>>buildMetaMenu: evt > > > > But I don't want to touch that method, not SystemWindow>>buildMetaMenu: > evt either, because that option would have to be visible only if my project > has been loaded. > > exactly nobody should change the core methods just declare intention. > > > > Is there a way to do that? > > sure. > you should use a pragma <menu> > > here is for example how this is done for ScriptLoader > > menuCommandOn: aBuilder > <worldMenu> > > (aBuilder item: #'Integrator Menu') > order: 1.5; > precondition: [self currentlyIntegratingChanges]; > parent: #System; > action: [ScriptLoader releaseMenu] > > > > > > > Thanks! > > Carla > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Aug. 7, 2010

Re: [Pharo-project] Instance variable pull up broken

by Lukas Renggli

I cannot reproduce. If you look at the code you should see that what you describe should not happen: transform class allSubclasses do: [:each | (each directlyDefinesInstanceVariable: variableName) ifTrue: [each removeInstanceVariable: variableName]]. class addInstanceVariable: variableName Maybe your class hierarchy is broken? Lukas On 7 August 2010 22:18, Niko Schwarz <niko.schwarz(a)googlemail.com> wrote: > Here's a funny way to crash your image. Works in: > > Pharo-1.1-11367-Beta > Latest update: #11367 > > Make a class named AbstractBla, with two subclasses: SubA, SubB. Then, > add to both SubA and SubB the identically named instance variable: > instVar. Now, use the "pull up" refactoring in OmniBrowser on SubA to > pull up instVar into the superclass. As you correctly guess, that > breaks SubB, because now both its superclass and SubB have an instance > variable named instVar. But, instead of refusing to refactor, > OmniBrowser dutifully refactors and takes the image with it. > > I hope that was understandable. > > Cheers, > > Niko > > > -- > http://scg.unibe.ch/staff/Schwarz > twitter.com/nes1983 > Tel: +41 076 235 8683 > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli www.lukas-renggli.ch

Aug. 7, 2010

[Pharo-project] Instance variable pull up broken

by Niko Schwarz

Here's a funny way to crash your image. Works in: Pharo-1.1-11367-Beta Latest update: #11367 Make a class named AbstractBla, with two subclasses: SubA, SubB. Then, add to both SubA and SubB the identically named instance variable: instVar. Now, use the "pull up" refactoring in OmniBrowser on SubA to pull up instVar into the superclass. As you correctly guess, that breaks SubB, because now both its superclass and SubB have an instance variable named instVar. But, instead of refusing to refactor, OmniBrowser dutifully refactors and takes the image with it. I hope that was understandable. Cheers, Niko -- http://scg.unibe.ch/staff/Schwarz twitter.com/nes1983 Tel: +41 076 235 8683

Aug. 7, 2010

Re: [Pharo-project] XML Parser, Monticello and unicode?

by Philippe Marschall

On 07.08.2010 13:08, Norbert Hartl wrote: > .... > To estimate the possibility to change this I think we should fix this. I scanned all of my cached monticello packages. Most of them are 7bit clean. No problem for them if we change encoding. Besides XML Parser I didn't find any that contain WideString so no problem here. Some of them are latin1 encoded (like Seaside 2.8 or Seaside-InternetExplorer from 3.0). That is the biggest problem because there is no fallback and monticello does not have a version number on file format, right? > I think it is still feasible to change this in monticello as the fix for users of older images will be probably only a few lines that you can apply to any version of monticello if I'm not wrong. But the change is not that easy. We try to be 7bit clean in Seaside. Can you report the methods you have trouble with to either the seaside mailing list or the issue tracker [1]? [1] http://code.google.com/p/seaside/issues/list Cheers Philippe

Aug. 7, 2010

Re: [Pharo-project] TextMorph without being able to be edited?

by Schwab,Wilhelm K

Carla, It's not silly when you can't figure out how to do it. Just glancing at some of my code, I think one approach is to use #newTextEditorFor:getText:setText:. The receiver is a TEasilyThemed user (StandardWindow is a good example). The first argument is the model, and the last two are selectors for message the model should understand. Give nil for the setter, and I *think* you will get what you want. If not, there will be some type of read-only flag to be set. Bill ________________________________________ From: pharo-project-bounces(a)lists.gforge.inria.fr [pharo-project-bounces(a)lists.gforge.inria.fr] On Behalf Of Carla F. Griggio [carla.griggio(a)gmail.com] Sent: Saturday, August 07, 2010 6:26 AM To: Pharo Development Subject: [Pharo-project] TextMorph without being able to be edited? Hi again, everyone! I think this might be really really silly, but I couldn't find a way to show a TextMorph without the ability to edit it's text. If I use a StringMorph to show a paragraph, it looks horrible, but if I use a TextMorph and click on it, a blue border appears and I'm able to edit the text, I don't want that to happen. Is there another morph for showing text that only shows text and nothing else? Or a property of TextMorph that I'm missing? Thanks! Carla

Aug. 7, 2010