March 2010 - Pharo-dev - lists.pharo.org

[Pharo-project] RefactoringManager and RBNamepsace error?

by Fernando olivero

Lukas, i have the following problem: model := RBNamespace new. Then executing successive RenameRefactoring's using the same model yields an Error. 1. ClassA -> ClassA2 OK 2. ClassA2 -> ClassA3 OK 3. ClassA3 -> ClassA4 ERROR! I've tracked it down to this: 1. RenameRefactoring>>execute self primitiveExecute. RefactoringManager instance addRefactoring: self 2. RefactoringManager>>addRefactoring: aRefactoring RefactoryChangeManager instance performChange: aRefactoring changes. refactorings add: aRefactoring class name 3. Refactoring>>changes ^self model changes which answers all the changes! { ClassA rename: #ClassA2! ClassA2 rename: #ClassA3! ClassA3 rename: #ClassA4! } Why does a particular refactoring answers all the models changes? And not just the ones it introduced? The problem is in #performChange: will apply over and over all the changes, and not just the last one. Lukas, do you think i'm incorrectly using the namespace and refactoring's? Are namespace supposed to be used once and later ditched? My goal is to have a GauchoSystem which nows all the changes (with undos!) that have happened, that's why i'm using always the same namespace. Thanks, Fernando pd: a test that reproduces the problem. >>testSucessiveRefactoringsError | namespace | namespace := RBNamespace new. [ | refactoring| Object subclass: 'ClassA' asSymbol instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'TestingNamespaces1234'. refactoring := RenameClassRefactoring model: namespace rename: (Smalltalk classNamed: 'ClassA' asSymbol ) to: 'ClassA2' asSymbol . refactoring execute. refactoring := RenameClassRefactoring model: namespace rename: (Smalltalk classNamed:'ClassA2' asSymbol ) to: 'ClassA3' asSymbol. refactoring execute. refactoring := RenameClassRefactoring model: namespace rename: (Smalltalk classNamed: 'ClassA3' asSymbol ) to: 'ClassA4' asSymbol. self shouldnt:[refactoring execute] raise: Error description: 'Valid refactoring should not raise error'. ] ensure:[ SystemOrganization removeSystemCategory: 'TestingNamespaces1234' ]

March 19, 2010

Re: [Pharo-project] Here's my problems...

by Igor Stasenko

On 19 March 2010 11:48, Henrik Johansen <henrik.s.johansen(a)veloxit.no> wrote: > > On Mar 19, 2010, at 10:07 20AM, Igor Stasenko wrote: > >> I tried different VM >> http://gforge.inria.fr/frs/download.php/26654/PharoVM-Win32-3.11.8.zip >> after 40 minutes of updating , i got an error, and still were unable to do anything , because image can't react on any events :( >> no changes... >> >> >> Any ideas why interrupt key makes image unresponsive? >> >> -- >> Best regards, >> Igor Stasenko AKA sig. > > http://code.google.com/p/pharo/issues/detail?id=1628 > > Update your image. > > Cheers, > Henry > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Best regards, Igor Stasenko AKA sig.

March 19, 2010

Re: [Pharo-project] unused temporal variables

by Lukas Renggli

Refactoring engine. 2010/3/19 Mariano Martinez Peck <marianopeck(a)gmail.com>: > Hi. I remember in previous Pharo images when you save a method that has > unused temporal variables you have a popup that said "XXX is unused, don't > you want to remove it ?" or something similar.... > We then removed that. Ok, cool. > > Now...suppose I want to examine all the system to detect all those unused > temporal variables and remove them (yes, recompiling), does someone have an > idea how to do that ? > > Thanks! > > Mariano > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

March 19, 2010

[Pharo-project] unused temporal variables

by Mariano Martinez Peck

Hi. I remember in previous Pharo images when you save a method that has unused temporal variables you have a popup that said "XXX is unused, don't you want to remove it ?" or something similar.... We then removed that. Ok, cool. Now...suppose I want to examine all the system to detect all those unused temporal variables and remove them (yes, recompiling), does someone have an idea how to do that ? Thanks! Mariano

March 19, 2010

Re: [Pharo-project] for 1.0 did we put the welcome message

by Henrik Johansen

On Mar 19, 2010, at 9:37 40AM, Mariano Martinez Peck wrote: > Not yet. We should merge the current welcome workspace with the actions done in 1.0. > > Any ideas how to do that ? There was someone asking a question which was answered in the lower half of the welcome workspace on IRC yesterday, so from a usability viewpoint, it might be better to just put them in a separate workspace. ;) Cheers, Henry

March 19, 2010

Re: [Pharo-project] Here's my problems...

by Henrik Johansen

On Mar 19, 2010, at 10:07 20AM, Igor Stasenko wrote: > I tried different VM > http://gforge.inria.fr/frs/download.php/26654/PharoVM-Win32-3.11.8.zip > > no changes... > > > Any ideas why interrupt key makes image unresponsive? > > -- > Best regards, > Igor Stasenko AKA sig. http://code.google.com/p/pharo/issues/detail?id=1628 Update your image. Cheers, Henry

March 19, 2010

[Pharo-project] Deprecation TheWorldMenu in Pharo 1.1

by Lukas Renggli

What is the point of leaving the empty class TheWorldMenu in Pharo 1.1? Obviously it is deprecated, but then all its methods are removed. I run across code like the following one in numerous packages: Smalltalk at: #TheWorldMenu ifPresent: [:theWorldMenu | theWorldMenu registerOpenCommand: { 'RFB/VNC Server' . { RFBServerGUI . #open } . 'Configure access to this desktop from remote VNC viewers.' }] Of course this now fails, because the class is there but none of its code? Would it be possible to either entirely remove the class or add deprecated methods (they don't even need to do anything)? Lukas -- Lukas Renggli http://www.lukas-renggli.ch

March 19, 2010

Re: [Pharo-project] Here's my problems...

by Igor Stasenko

I tried different VM http://gforge.inria.fr/frs/download.php/26654/PharoVM-Win32-3.11.8.zip no changes... Any ideas why interrupt key makes image unresponsive? -- Best regards, Igor Stasenko AKA sig.

March 19, 2010

Re: [Pharo-project] why we should ban as yet unclassified categories from the core....

by Adrian Lienhard

On Mar 19, 2010, at 09:15 , StÃ©phane Ducasse wrote: >> I understand, but what if people do want classify papers labelled "as yet unclassified"? > > not in the core at home they can eat in the living room, put mess on their sofa, let bottles on the floor.... > mess up the kitchen, do not put the pizza boxed in the trash. ***But not in the core.*** > > Did you read pragmatic programmers (not that they invented something at least they wrote it)? > There is a story about the house with a broken glass. > > Did you ever feel that you would be bad guy if you would throw a paper on the floor when you are > in a beautiful and clean city? But if you walk in a place with dirt everywhere (even if you do not > trhow anything on the floor) you have less pressure not to the do it? > > We should get the same for pharo, the beauty of the system should shout at you: I wan to be clean. > Write class comments..... > > Quality is also in the details because everything is in synergy. +1 Adrian > > Stef > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

March 19, 2010

Re: [Pharo-project] Here's my problems...

by Igor Stasenko

Hmm.. i found that even if i don't do anything and just press Alt-. (interrupt) image stops handling events. :((( So it looks like VM<->Image issue on win32. -- Best regards, Igor Stasenko AKA sig.

March 19, 2010