December 2010 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Issue 3434 in pharo: SharedQueue Fixes

by pharo＠googlecode.com

Comment #1 on issue 3434 by stephane.ducasse: SharedQueue Fixes http://code.google.com/p/pharo/issues/detail?id=3434 it probably depends on other squeak changes

Dec. 14, 2010

Re: [Pharo-project] New SqueakSource (was good news of the year)

by StÃ©phane Ducasse

Smalltalksource is nice. On Dec 14, 2010, at 1:17 PM, Janko MivÅ¡ek wrote: > It would be nice to take an oportunity and think long-term about > Smalltalk-wide hub but for now implement a MC one for Squeak/Pharo for a > start. Later we can nad other repositories like VW Store, even > SqueakMap, etc., with a long-term goal to have all Smalltalk code > accessible from one place. > > Geert will love a proposed link: > > http://source.world.st :) > or maybe: http://code.world.st ? > > And name: SmalltalkHub, SmalltalkSource? > > Having Smalltalk in the name is good from SEO standpoint, much better > than MonticelloHub, for guys outside Smalltalk community to recognise > soon what it is about. > > Best regards > Janko > > On 14. 12. 2010 10:03, Geert Claes wrote: > >> StÃ©phane Ducasse wrote: >>> >>> For SqueakSource, ESUG is paying the iliad guys to show that their >>> technology is cool and they will rewrite from scratch. We are negociating >>> since a couple of months with inria to have a web-dav server so that we >>> can host all the monticello related host. > >> More great news then! Since its a complete re-write and assuming it will >> serve for both Squeak and Pharo projects alike, I am wondering if its just >> me but I reckon it could do with a nice new name too :) If so it probably >> deserves a separate thread > > -- > Janko MivÅ¡ek > AIDA/Web > Smalltalk Web Application Server > http://www.aidaweb.si >

Dec. 14, 2010

[Pharo-project] Issue 3434 in pharo: SharedQueue Fixes

by pharo＠googlecode.com

Status: FixedWaitingToBePharoed Owner: stephane.ducasse CC: siguctua Labels: Milestone-1.3 New issue 3434 by stephane.ducasse: SharedQueue Fixes http://code.google.com/p/pharo/issues/detail?id=3434 A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-ul.412.mcz ==================== Summary ==================== Name: Collections-ul.412 Author: ul Time: 8 December 2010, 4:46:07.6 am UUID: 0d255954-d008-d647-91fa-59be37678e29 Ancestors: Collections-ul.411 - SharedQueue fixes =============== Diff against Collections-ul.411 =============== Item was changed: ----- Method: SharedQueue>>flushAllSuchThat: (in category 'accessing') ----- flushAllSuchThat: aBlock "Remove from the queue all objects that satisfy aBlock." + + accessProtect critical: [ + | newReadPos | - ^accessProtect critical: [ - | value newReadPos | newReadPos := writePosition. + writePosition - 1 to: readPosition by: -1 do: [ :i | + | value | + value := contentsArray at: i. - writePosition-1 to: readPosition by: -1 do: - [:i | value := contentsArray at: i. contentsArray at: i put: nil. + ((aBlock value: value) and: [ (readSynch waitIfLocked: [ nil ]) notNil ]) ifFalse: [ - (aBlock value: value) ifTrue: [ - "We take an element out of the queue, and therefore, we need to decrement - the readSynch signals" - readSynch wait. - ] ifFalse: [ newReadPos := newReadPos - 1. + contentsArray at: newReadPos put: value ] ]. + readPosition := newReadPos ]! - contentsArray at: newReadPos put: value]]. - readPosition := newReadPos. - value]! Item was changed: ----- Method: SharedQueue>>makeRoomAtEnd (in category 'private') ----- makeRoomAtEnd + | contentsSize newContentsArray | - | contentsSize | contentsSize := writePosition - readPosition. + newContentsArray := contentsSize * 2 > contentsArray size + ifTrue: [ contentsArray class new: contentsArray size * 2 ] - contentsSize * 2 > contentsArray size - ifTrue: [ - "grow" - contentsArray := (contentsArray class new: contentsArray size * 2) - replaceFrom: 1 - to: contentsSize - with: contentsArray - startingAt: readPosition; - yourself ] ifFalse: [ (contentsArray size > 10 and: [ contentsSize * 4 <= contentsArray size ]) + ifTrue: [ contentsArray class new: (contentsSize * 2 max: 10) ] + ifFalse: [ contentsArray ] ]. + newContentsArray + replaceFrom: 1 + to: contentsSize + with: contentsArray + startingAt: readPosition. + contentsArray == newContentsArray + ifFalse: [ contentsArray := newContentsArray ] + ifTrue: [ contentsArray from: contentsSize + 1 to: contentsArray size put: nil ]. - ifTrue: [ - "shrink" - contentsArray := (contentsArray class new: (contentsSize * 2 max: 10)) - replaceFrom: 1 - to: contentsSize - with: contentsArray - startingAt: readPosition; - yourself ] - ifFalse: [ - "just move the elements to the front" - contentsArray - replaceFrom: 1 - to: contentsSize - with: contentsArray - startingAt: readPosition. - contentsArray - from: contentsSize + 1 - to: contentsArray size - put: nil ] ]. readPosition := 1. writePosition := contentsSize + 1! Item was changed: ----- Method: SharedQueue>>nextOrNil (in category 'accessing') ----- nextOrNil "Answer the object that was sent through the receiver first and has not yet been received by anyone. If no object has been sent, answer <nil>." + readSynch waitIfLocked: [ ^nil ]. + ^accessProtect + critical: [ + | value | + readPosition = writePosition + ifTrue: + [self error: 'Error in SharedQueue synchronization'. + value := nil] + ifFalse: + [value := contentsArray at: readPosition. + contentsArray at: readPosition put: nil. + readPosition := readPosition + 1]. + value ]! - ^accessProtect critical: [ - | value | - readPosition >= writePosition ifTrue: [ - value := nil - ] ifFalse: [ - value := contentsArray at: readPosition. - contentsArray at: readPosition put: nil. - readPosition := readPosition + 1 - ]. - readPosition >= writePosition ifTrue: [readSynch initSignals]. - value - ].! Item was changed: ----- Method: SharedQueue>>nextOrNilSuchThat: (in category 'accessing') ----- nextOrNilSuchThat: aBlock "Answer the next object that satisfies aBlock, skipping any intermediate objects. If no object has been sent, answer <nil> and leave me intact. NOTA BENE: aBlock MUST NOT contain a non-local return (^)." ^accessProtect critical: [ | value readPos | value := nil. readPos := readPosition. + [ readPos < writePosition and: [ value isNil ] ] whileTrue: [ - [readPos < writePosition and: [value isNil]] whileTrue: [ value := contentsArray at: readPos. readPos := readPos + 1. + (aBlock value: value) + ifFalse: [ value := nil ] + ifTrue: [ + readSynch waitIfLocked: [ ^nil ]. "We found the value, but someone else booked it." + readPosition to: readPos - 1 do: [ :j | contentsArray at: j put: nil ]. + readPosition := readPos ] ]. + value ]. - (aBlock value: value) ifTrue: [ - readPosition to: readPos - 1 do: [ :j | - contentsArray at: j put: nil. - ]. - readPosition := readPos. - ] ifFalse: [ - value := nil. - ]. - ]. - readPosition >= writePosition ifTrue: [readSynch initSignals]. - value. - ]. "=== q := SharedQueue new. 1 to: 10 do: [ :i | q nextPut: i]. c := OrderedCollection new. [ v := q nextOrNilSuchThat: [ :e | e odd]. v notNil ] whileTrue: [ c add: {v. q size} ]. {c. q} explore ==="! Item was changed: ----- Method: SharedQueue>>peek (in category 'accessing') ----- peek "Answer the object that was sent through the receiver first and has not yet been received by anyone but do not remove it from the receiver. If no object has been sent, return nil" + ^readSynch - ^accessProtect critical: [ + accessProtect critical: [ + readPosition >= writePosition ifFalse: [ + contentsArray at: readPosition ] ] ] + ifLocked: [ nil ]! - | value | - readPosition >= writePosition - ifTrue: [readPosition := 1. - writePosition := 1. - value := nil] - ifFalse: [value := contentsArray at: readPosition]. - value].!

Dec. 14, 2010

[Pharo-project] Issue 3433 in pharo: Color improvement

by pharo＠googlecode.com

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 Difficulty-Easy New issue 3433 by stephane.ducasse: Color improvement http://code.google.com/p/pharo/issues/detail?id=3433 Levente Uzonyi uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ul.490.mcz ==================== Summary ==================== Name: Morphic-ul.490 Author: ul Time: 9 December 2010, 3:06:57.133 am UUID: e54bc2a6-58ae-8f42-b64e-f17a63bc00e6 Ancestors: Morphic-laza.489 - simplified Morph >> #colorString: =============== Diff against Morphic-laza.489 =============== Item was changed: ----- Method: Morph>>colorString: (in category 'printing') ----- colorString: aColor + + aColor ifNil: [ ^'nil' ]. + ^aColor name + ifNil: [ aColor storeString ] + ifNotNil: [ :colorName | 'Color ', colorName ]! - aColor ifNil: [^'nil']. - Color colorNames - do: [:colorName | aColor = (Color perform: colorName) ifTrue: [^'Color ' , colorName]]. - ^aColor storeString!

Dec. 14, 2010

Re: [Pharo-project] Issue 3432 in pharo: Color>>fromString fix

by pharo＠googlecode.com

Comment #1 on issue 3432 by stephane.ducasse: Color>>fromString fix http://code.google.com/p/pharo/issues/detail?id=3432 I wonder why a set is better for ColorNames

Dec. 14, 2010

[Pharo-project] Issue 3432 in pharo: Color>>fromString fix

by pharo＠googlecode.com

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Difficulty-Easy Milestone-1.3 New issue 3432 by stephane.ducasse: Color>>fromString fix http://code.google.com/p/pharo/issues/detail?id=3432 Levente Uzonyi uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-ul.160.mcz ==================== Summary ==================== Name: Graphics-ul.160 Author: ul Time: 9 December 2010, 3:05:20.054 am UUID: 822ecf3f-277b-0d45-94d3-ebc44976be4e Ancestors: Graphics-ul.159 - fixed: Color class >> #fromString: - Color's ColorNames is now a Set instead of an OrderedCollection =============== Diff against Graphics-ul.159 =============== Item was changed: ----- Method: Color class>>fromString: (in category 'instance creation') ----- fromString: aString "for HTML color spec: #FFCCAA or white/black" "Color fromString: '#FFCCAA'. Color fromString: 'white'. Color fromString: 'orange'" + | aColorHex | + aString isEmptyOrNil ifTrue: [ ^self white ]. - aString isEmptyOrNil ifTrue: [^ Color white]. aString first = $# + ifTrue: [ aColorHex := aString allButFirst ] + ifFalse: [ aColorHex := aString ]. + (aColorHex size = 6 and: [ + aColorHex allSatisfy: [ :each | '0123456789ABCDEFabcdef' includes: each ] ]) + ifTrue: [ + | green red blue | + red := (Integer readFrom: (aColorHex first: 2) base: 16) / 255. + green := (Integer readFrom: (aColorHex copyFrom: 3 to: 4) base: 16) / 255. + blue := (Integer readFrom: (aColorHex last: 2) base: 16) / 255. + ^self r: red g: green b: blue ]. - ifTrue: [aColorHex := aString copyFrom: 2 to: aString size] - ifFalse: [aColorHex := aString]. - [ | green red blue | - aColorHex size = 6 - ifTrue: - [aColorHex := aColorHex asUppercase. - red := ('16r', (aColorHex copyFrom: 1 to: 2)) asNumber/255. - green := ('16r', (aColorHex copyFrom: 3 to: 4)) asNumber/255. - blue := ('16r', (aColorHex copyFrom: 5 to: 6)) asNumber/255. - ^ self r: red g: green b: blue]] - ifError: [:err :rcvr | "not a hex color triplet" ]. - "try to match aColorHex with known named colors" + ^self perform: (ColorNames like: aColorHex asLowercase ifAbsent: [ #white ])! - aColorHex := aColorHex asLowercase. - - ^self perform: (ColorNames detect: [:i | i asString asLowercase = aColorHex] - ifNone: [#white])! Item was changed: ----- Method: Color class>>initializeNames (in category 'class initialization') ----- initializeNames "Name some colors." "Color initializeNames" + ColorNames := Set new. - ColorNames := OrderedCollection new. self named: #black put: (Color r: 0 g: 0 b: 0). self named: #veryVeryDarkGray put: (Color r: 0.125 g: 0.125 b: 0.125). self named: #veryDarkGray put: (Color r: 0.25 g: 0.25 b: 0.25). self named: #darkGray put: (Color r: 0.375 g: 0.375 b: 0.375). self named: #gray put: (Color r: 0.5 g: 0.5 b: 0.5). self named: #lightGray put: (Color r: 0.625 g: 0.625 b: 0.625). self named: #veryLightGray put: (Color r: 0.75 g: 0.75 b: 0.75). self named: #veryVeryLightGray put: (Color r: 0.875 g: 0.875 b: 0.875). self named: #white put: (Color r: 1.0 g: 1.0 b: 1.0). self named: #red put: (Color r: 1.0 g: 0 b: 0). self named: #yellow put: (Color r: 1.0 g: 1.0 b: 0). self named: #green put: (Color r: 0 g: 1.0 b: 0). self named: #cyan put: (Color r: 0 g: 1.0 b: 1.0). self named: #blue put: (Color r: 0 g: 0 b: 1.0). self named: #magenta put: (Color r: 1.0 g: 0 b: 1.0). self named: #brown put: (Color r: 0.6 g: 0.2 b: 0). self named: #orange put: (Color r: 1.0 g: 0.6 b: 0). self named: #lightRed put: (Color r: 1.0 g: 0.8 b: 0.8). self named: #lightYellow put: (Color r: 1.0 g: 1.0 b: 0.8). self named: #lightGreen put: (Color r: 0.8 g: 1.0 b: 0.6). self named: #lightCyan put: (Color r: 0.4 g: 1.0 b: 1.0). self named: #lightBlue put: (Color r: 0.8 g: 1.0 b: 1.0). self named: #lightMagenta put: (Color r: 1.0 g: 0.8 b: 1.0). self named: #lightBrown put: (Color r: 1.0 g: 0.6 b: 0.2). self named: #lightOrange put: (Color r: 1.0 g: 0.8 b: 0.4). self named: #transparent put: (TranslucentColor new alpha: 0.0). self named: #paleBuff put: (Color r: 254 g: 250 b: 235 range: 255). self named: #paleBlue put: (Color r: 222 g: 249 b: 254 range: 255). self named: #paleYellow put: (Color r: 255 g: 255 b: 217 range: 255). self named: #paleGreen put: (Color r: 223 g: 255 b: 213 range: 255). self named: #paleRed put: (Color r: 255 g: 230 b: 230 range: 255). self named: #veryPaleRed put: (Color r: 255 g: 242 b: 242 range: 255). self named: #paleTan put: (Color r: 235 g: 224 b: 199 range: 255). self named: #paleMagenta put: (Color r: 255 g: 230 b: 255 range: 255). self named: #paleOrange put: (Color r: 253 g: 237 b: 215 range: 255). self named: #palePeach put: (Color r: 255 g: 237 b: 213 range: 255). ! Item was changed: ----- Method: Color class>>named:put: (in category 'class initialization') ----- named: newName put: aColor "Add a new color to the list and create an access message and a class variable for it. The name should start with a lowercase letter. (The class variable will start with an uppercase letter.) (Color colorNames) returns a list of all color names. " | str cap sym accessor csym | (aColor isKindOf: self) ifFalse: [^ self error: 'not a Color']. str := newName asString. sym := str asSymbol. cap := str capitalized. csym := cap asSymbol. (self class canUnderstand: sym) ifFalse: [ "define access message" accessor := str, (String with: Character cr with: Character tab), '^', cap. self class compile: accessor classified: 'named colors']. (self classPool includesKey: csym) ifFalse: [ self addClassVarName: cap]. + ColorNames add: sym. - (ColorNames includes: sym) ifFalse: [ - ColorNames add: sym]. ^ self classPool at: csym put: aColor! Item was changed: ----- Method: Color>>name (in category 'other') ----- name "Return this color's name, or nil if it has no name. Only returns a name if it exactly matches the named color." + ^ColorNames detect: [ :name | (Color perform: name) = self ] ifNone: [ nil ]! - ColorNames do: - [:name | (Color perform: name) = self ifTrue: [^ name]]. - ^ nil - ! Item was changed: (PackageInfo named: 'Graphics') postscript: '"below, add code to be run after the loading of this package" + Color initializeNames'! - StrikeFont installDejaVu.'!

Dec. 14, 2010

[Pharo-project] [update 1.2] #12278

by Marcus Denker

12278 ----- Issue 3408: Remove an unsent message from DialogItemsChooserUI (reference to non-existing ivar) Issue 3409: KillTextConstants class and package needs to be removed -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

Dec. 14, 2010

Re: [Pharo-project] Issue 3431 in pharo: Faster traitNames

by pharo＠googlecode.com

Updates: Labels: Difficulty-Easy Comment #1 on issue 3431 by stephane.ducasse: Faster traitNames http://code.google.com/p/pharo/issues/detail?id=3431 (No comment was entered for this change.)

Dec. 14, 2010

Re: [Pharo-project] super initialize is not a good idea for Behaviors ; )

by Schwab,Wilhelm K

It has certainly been well-known to be potentially disastrous in Dolphin. ________________________________________ From: pharo-project-bounces(a)lists.gforge.inria.fr [pharo-project-bounces(a)lists.gforge.inria.fr] On Behalf Of Mariano Martinez Peck [marianopeck(a)gmail.com] Sent: Monday, December 13, 2010 5:35 PM To: Pharo-project(a)lists.gforge.inria.fr Subject: Re: [Pharo-project] super initialize is not a good idea for Behaviors ; ) On Mon, Dec 13, 2010 at 11:33 PM, Ramon Leon <ramon.leon(a)allresnet.com<mailto:ramon.leon@allresnet.com>> wrote: On 12/13/2010 03:28 PM, Mariano Martinez Peck wrote: Hi folks. After a couple of hours of trying to find a problem, I finally come to the cause: using super initialize is not always good. When I implement #initialize, I ALWAYS do "super initialize" in the first line of such method. Today, I found a problem while doing this in class side #initialize. You should only super init on the instance side, not the class side; pretty sure this is a well known issue. heheheh I leart it today, in the "hard way" ;) thanks ramon -- Ramon Leon http://onsmalltalk.com

Dec. 14, 2010

[Pharo-project] Issue 3431 in pharo: Faster traitNames

by pharo＠googlecode.com

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Milestone-1.3 New issue 3431 by stephane.ducasse: Faster traitNames http://code.google.com/p/pharo/issues/detail?id=3431 Name: System-ul.398 Author: ul Time: 8 December 2010, 9:21:23.04 pm UUID: 8e147d50-061f-6741-8eb3-b8f69182a3de Ancestors: System-ul.397 - fix: SystemDictionary >> #traitNames returns a sorted collection. It also uses the cached nonClassNames which is faster. - added SystemDictionary >> #classAndTraitNames which returns a sorted collection of all class and trait names =============== Diff against System-ul.397 =============== Item was added: + ----- Method: SystemDictionary>>classAndTraitNames (in category 'classes and traits') ----- + classAndTraitNames + "Answer a sorted collection of all class and trait (not including class-traits) names. The performance of this algorithm is O(n) if the classNames are already cached, otherwise O(n*log(n)) where n is self size." + + | classNames traitNames result temporary | + classNames := self classNames. + traitNames := self traitNames. + temporary := Array new: classNames size + traitNames size. + result := temporary shallowCopy. + temporary + replaceFrom: 1 + to: classNames size + with: classNames + startingAt: 1; + replaceFrom: classNames size + 1 + to: temporary size + with: traitNames + startingAt: 1; + mergeFirst: 1 + middle: classNames size + last: temporary size + into: result + by: nil. + ^result! Item was changed: ----- Method: SystemDictionary>>traitNames (in category 'classes and traits') ----- traitNames + "Answer a sorted collection of all traits (not including class-traits) names." + + ^self nonClassNames select: [ :name | + (name beginsWith: 'AnObsolete') not and: [ + self + at: name + ifPresent: [ :global | global isInMemory and: [ global isTrait ] ] + ifAbsent: [ false ] ] ]! - "Answer a SortedCollection of all traits (not including class-traits) names." - | names | - names := OrderedCollection new. - self do: - [:cl | (cl isInMemory - and: [(cl isTrait) - and: [(cl name beginsWith: 'AnObsolete') not]]) - ifTrue: [names add: cl name]]. - ^ names!

Dec. 14, 2010