November 2010 - Pharo-dev - lists.pharo.org

[Pharo-project] Issue 3231 in pharo: Semaphore changes

by pharo＠googlecode.com

Status: FixedWaitingToBePharoed Owner: stephane.ducasse CC: siguctua Labels: Type-Squeak New issue 3231 by stephane.ducasse: Semaphore changes http://code.google.com/p/pharo/issues/detail?id=3231 Needs a really careful review.... A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ul.514.mcz ==================== Summary ==================== Name: Kernel-ul.514 Author: ul Time: 7 November 2010, 4:21:51.529 pm UUID: 5710b62a-4264-9947-acdc-11e0ce45021d Ancestors: Kernel-ul.513 A few changes to Semaphore: - save a block creation + activation + a possible context switch in #critical:ifCurtailed: - save a block creation + activation in #critical:ifError:, this changes the behavior when mutuallyExcludedBlock doesn't understand #ifError: - #critical:ifLocked: is guaranteed to not get locked. The earlier implementation sent #critical: which could cause a context change, so another process could enter the critical section before the original. - added a new method #passIfLocked: which is like #wait, but it doesn't wait for a signal if there's none, but evaluates the argument instead. =============== Diff against Kernel-ul.513 =============== Item was changed: ----- Method: Semaphore>>critical:ifCurtailed: (in category 'mutual exclusion') ----- critical: mutuallyExcludedBlock ifCurtailed: terminationBlock "Evaluate mutuallyExcludedBlock only if the receiver is not currently in the process of running the critical: message. If the receiver is, evaluate mutuallyExcludedBlock after the other critical: message is finished." + ^self critical: [ mutuallyExcludedBlock ifCurtailed: terminationBlock ] - ^self critical:[[mutuallyExcludedBlock value] ifCurtailed: terminationBlock] ! Item was changed: ----- Method: Semaphore>>critical:ifError: (in category 'mutual exclusion') ----- critical: mutuallyExcludedBlock ifError: errorBlock "Evaluate mutuallyExcludedBlock only if the receiver is not currently in the process of running the critical: message. If the receiver is, evaluate mutuallyExcludedBlock after the other critical: message is finished." | blockValue hasError errMsg errRcvr | hasError := false. blockValue := self critical:[ + mutuallyExcludedBlock ifError: [ :msg :rcvr | - [mutuallyExcludedBlock value] ifError:[:msg :rcvr| hasError := true. errMsg := msg. errRcvr := rcvr ]. ]. hasError ifTrue:[ ^errorBlock value: errMsg value: errRcvr]. ^blockValue! Item was changed: ----- Method: Semaphore>>critical:ifLocked: (in category 'mutual exclusion') ----- critical: mutuallyExcludedBlock ifLocked: alternativeBlock "Evaluate mutuallyExcludedBlock only if the receiver is not currently in the process of running the critical: message. If the receiver is, evaluate mutuallyExcludedBlock after the other critical: message is finished." - "Note: The following is tricky and depends on the fact that the VM will not switch between processes while executing byte codes (process switches happen only in real sends). The following test is written carefully so that it will result in bytecodes only." + + | caught | + caught := false. + ^[ + excessSignals = 0 + ifTrue: [ alternativeBlock value ] + ifFalse: [ + excessSignals := excessSignals - 1. + caught := true. + mutuallyExcludedBlock value ] ] + ensure: [ caught ifTrue: [ self signal ] ]! - excessSignals == 0 ifTrue:[ - "If we come here, then the semaphore was locked when the test executed. - Evaluate the alternative block and answer its result." - ^alternativeBlock value - ]. - ^self critical: mutuallyExcludedBlock! Item was added: + ----- Method: Semaphore>>passIfLocked: (in category 'communication') ----- + passIfLocked: aBlock + + excessSignals = 0 ifTrue: [ ^aBlock value ]. + excessSignals := excessSignals - 1!

Nov. 11, 2010

[Pharo-project] Issue 3230 in pharo: Fixes for Latin1Environment from EToys

by pharo＠googlecode.com

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Type-Squeak New issue 3230 by stephane.ducasse: Fixes for Latin1Environment from EToys http://code.google.com/p/pharo/issues/detail?id=3230 ***Need to be really verified if this applies to pharo*** Name: Multilingual-sn.131 Author: sn Time: 8 November 2010, 12:54:12.262 am UUID: 64aa8ddf-9938-4373-a45d-7bde1c0ccced Ancestors: Multilingual-ul.130 Fixes for Latin1Environment from EToys =============== Diff against Multilingual-ul.130 =============== Item was changed: ----- Method: Latin1Environment class>>fileNameConverterClass (in category 'subclass responsibilities') ----- fileNameConverterClass + ^ self systemConverterClass - ^ Latin1TextConverter ! Item was changed: ----- Method: Latin1Environment class>>inputInterpreterClass (in category 'subclass responsibilities') ----- inputInterpreterClass | platformName osVersion | platformName := SmalltalkImage current platformName. osVersion := SmalltalkImage current osVersion. (platformName = 'Win32' and: [osVersion ~= 'CE']) ifTrue: [^ (self win32VMUsesUnicode) ifTrue: [UTF32InputInterpreter] ifFalse: [MacRomanInputInterpreter]]. platformName = 'Mac OS' + ifTrue: [^ MacUnicodeInputInterpreter]. - ifTrue: [^ MacRomanInputInterpreter]. platformName = 'unix' ifTrue: [^ UTF32InputInterpreter]. + ^ MacUnicodeInputInterpreter! - ^ MacRomanInputInterpreter! Item was changed: ----- Method: Latin1Environment class>>systemConverterClass (in category 'subclass responsibilities') ----- systemConverterClass + | platformName osVersion | + platformName := SmalltalkImage current platformName. + osVersion := SmalltalkImage current getSystemAttribute: 1002. + (platformName = 'Win32' + and: [osVersion = 'CE']) + ifTrue: [^ MacRomanTextConverter]. + platformName = 'Win32' + ifTrue: [^ (self win32VMUsesUnicode) ifTrue: [UTF8TextConverter] ifFalse: [Latin1TextConverter]]. + platformName = 'Mac OS' + ifTrue: [^ ('10*' match: SmalltalkImage current osVersion) + ifTrue: [UTF8TextConverter] + ifFalse: [MacRomanTextConverter]]. + platformName = 'unix' + ifTrue: [^ UTF8TextConverter]. + ^ MacRomanTextConverter! - ^ Latin1TextConverter. - ! Item was changed: ----- Method: MacUnicodeInputInterpreter>>initialize (in category 'initialization') ----- initialize | satisfiesVersion | satisfiesVersion := self majorMinorBuildFrom: SmalltalkImage current vmVersion + satisfies: [:major :minor :build | + major >= 4 or: [ + major >= 3 and: [minor >= 8 and: [build >= 7]]]]. - satisfies: [:major :minor :build | (major >= 3 - and: [minor >= 8 - and: [build >= 7]]) or: [major >= 4]]. - satisfiesVersion ifTrue: [keyValueIndex := 6] ifFalse: [keyValueIndex := 3]!

Nov. 11, 2010

[Pharo-project] Issue 3229 in pharo: More robust MCFileRepositoryInspector

by pharo＠googlecode.com

Status: Fixed Owner: stephane.ducasse Labels: Milestone-1.2 Difficulty-Easy Type-Squeak New issue 3229 by stephane.ducasse: More robust MCFileRepositoryInspector http://code.google.com/p/pharo/issues/detail?id=3229 Name: Monticello-ul.408 Author: ul Time: 8 November 2010, 3:18:30.762 am UUID: e00c2051-a20d-e145-a1d9-c7a67bc4e30d Ancestors: Monticello-ul.407 - fix for http://bugs.squeak.org/view.php?id=6439 =============== Diff against Monticello-ul.407 =============== Item was changed: ----- Method: MCFileRepositoryInspector>>refresh (in category 'as yet unclassified') ----- refresh | packageNames | packageNames := Set new. packageList := nil. versions := repository readableFileNames collect: [ :each | | name | name := (each copyUpToLast: $.) copyUpTo: $(. name last isDigit ifFalse: [Array with: name with: '' with: '' with: each] ifTrue: [Array with: (packageNames add: (name copyUpToLast: $-)) "pkg name" with: ((name copyAfterLast: $-) copyUpTo: $.) "user" + with: (((name copyAfterLast: $-) copyAfter: $.) asInteger ifNil: [ 0 ]) "version" - with: ((name copyAfterLast: $-) copyAfter: $.) asInteger "version" with: each]]. newer := Set new. inherited := Set new. loaded := Set new. (MCWorkingCopy allManagers " select: [ :each | packageNames includes: each packageName]") do: [:each | | latest | each ancestors do: [ :ancestor | loaded add: ancestor name. ancestor ancestorsDoWhileTrue: [:heir | (inherited includes: heir name) ifTrue: [false] ifFalse: [inherited add: heir name. true]]]. latest := (versions select: [:v | v first = each package name]) detectMax: [:v | v third]. (latest notNil and: [ each ancestors allSatisfy: [:ancestor | | av | av := ((ancestor name copyAfterLast: $-) copyAfter: $.) asInteger. av < latest third or: [ av = latest third and: [((ancestor name copyAfterLast: $-) copyUpTo: $.) ~= latest second]]]]) ifTrue: [newer add: each package name ]]. self changed: #packageList; changed: #versionList!

Nov. 11, 2010

[Pharo-project] Issue 3228 in pharo: fixed font rendering to support translucent colors

by pharo＠googlecode.com

Status: FixedWaitingToBePharoed Owner: stephane.ducasse Labels: Type-Squeak New issue 3228 by stephane.ducasse: fixed font rendering to support translucent colors http://code.google.com/p/pharo/issues/detail?id=3228 To be verified Name: Graphics-mt.152 Author: mt Time: 10 November 2010, 4:14:35.129 pm UUID: 04582fa8-3ca1-e440-987a-74483e96950d Ancestors: Graphics-dtl.151 - fixed font rendering to support translucent colors =============== Diff against Graphics-dtl.151 =============== Item was changed: ----- Method: BitBlt>>installStrikeFont:foregroundColor:backgroundColor: (in category 'private') ----- installStrikeFont: aStrikeFont foregroundColor: foregroundColor backgroundColor: backgroundColor | lastSourceDepth targetColor | sourceForm ifNotNil:[lastSourceDepth := sourceForm depth]. sourceForm := aStrikeFont glyphs. "Ignore any halftone pattern since we use a color map approach here" halftoneForm := nil. sourceY := 0. height := aStrikeFont height. sourceForm depth = 1 ifTrue: [ self combinationRule: Form paint. (colorMap notNil and:[lastSourceDepth = sourceForm depth]) ifFalse: [ "Set up color map for a different source depth (color font)" "Uses caching for reasonable efficiency" colorMap := self cachedFontColormapFrom: sourceForm depth to: destForm depth. colorMap at: 1 put: (destForm pixelValueFor: backgroundColor)]. colorMap at: 2 put: (destForm pixelValueFor: foregroundColor). ] ifFalse: [ (Preferences subPixelRenderFonts and: [ foregroundColor = Color black or: [ Preferences subPixelRenderColorFonts ]]) ifTrue: [ destForm depth > 8 ifTrue: [ + "Only force #rgbMul if color is not translucent for better result quality. Alpha values are ignored with #rgbMul." + foregroundColor isTranslucent + ifFalse: [self combinationRule: Form rgbMul]. - "rgbMul is equivalent to component alpha blend if text is black (only faster, hehe)" - self combinationRule: 37. "RGBMul" colorMap := (destForm depth = 32 or: [ (foregroundColor = Color black) not ]) ifTrue: [ "rgbMul / rgbAdd IS component alpha blend for any color of text (neat trick, eh!!)" "This colorMap is to be used on the second pass with rule 20 (rgbAdd) See #displayString:from:to:at:strikeFont:kern:" "Note: In 32bpp we always need the second pass, as the source could have transparent pixels, and we need to add to the alpha channel" self colorConvertingMap: foregroundColor from: sourceForm depth to: destForm depth keepSubPixelAA: true]] ifFalse: [ self combinationRule: 25. "Paint" targetColor := foregroundColor = Color black ifFalse: [ foregroundColor ]. colorMap := self colorConvertingMap: targetColor from: sourceForm depth to: destForm depth keepSubPixelAA: true] ] ifFalse: [ "Do not use rule 34 for 16bpp display. TTCFont uses it, but it builds a glyphs cache for each color used!!" self combinationRule: (destForm depth = 32 ifTrue: [34 "alphaBlendScaled"] ifFalse: [25 "Paint"]). colorMap := self colorConvertingMap: foregroundColor from: sourceForm depth to: destForm depth keepSubPixelAA: false ] ].!

Nov. 11, 2010

Re: [Pharo-project] Adding method to Character

by Tony Fleig

After a little research... Great! The last time I used Smalltalk there were no packages. What a useful concept class extensions are. Is the best way to see a package's extensions to just browse the package (i.e. Ctrl-P in the packages pane of the browser)? TF On Nov 11, 2010, at 8:56, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > > On Nov 11, 2010, at 5:14 PM, Tony Fleig wrote: > >> Hi, >> >> I find myself wanting a Character>>isConsonant method in addition to the existing Character>>isVowel method. It might be defined as >> >> Character>>isConsonant >> ^ self isLetter & self isVowel not >> >> My question is: what is the best way to do this? >> >> Should I simply add the method to Character? If I do, I guess I must remember to merge my Monticello changes into each new version of Character? Is there some way to bundle this change in my package so I don't forget? > > but if you add this method in the character class as a class extension of your package then the addition will be done automatically each time > you load it. > >> >> I have created a method in my class MyClass>>characterIsConsonant: aCharacter, but it doesn't read well in the code. >> >> I suppose I could add the method dynamically in my class's initialize method... Not sure how to do that exactly. >> >> Is there another way to do this that I haven't thought of? >> >> Thanks, >> TF > >

Nov. 11, 2010

Re: [Pharo-project] Issue 3226 in pharo: New finder enh

by pharo＠googlecode.com

Comment #1 on issue 3226 by gazzaguru2: New finder enh http://code.google.com/p/pharo/issues/detail?id=3226 Also, for the browse buttons, better use enablement rather than state for indicating whether the action is available or not.

Nov. 11, 2010

[Pharo-project] Issue 3227 in pharo: Remove all MethodFinder

by pharo＠googlecode.com

Status: Accepted Owner: stephane.ducasse Labels: Milestone-1.2 New issue 3227 by stephane.ducasse: Remove all MethodFinder http://code.google.com/p/pharo/issues/detail?id=3227 Now that ben rewrote the finder we can remove the old one.

Nov. 11, 2010

[Pharo-project] Issue 3226 in pharo: New finder enh

by pharo＠googlecode.com

Status: Accepted Owner: stephane.ducasse CC: Benjamin.VanRyseghem Labels: Milestone-1.2 New issue 3226 by stephane.ducasse: New finder enh http://code.google.com/p/pharo/issues/detail?id=3226 Ben it would be good that - pattern -> renamed as examples - we do not need to type * when we look for something - if we use *classVar* and regex it explodes :) - we could expand all the nodes (by doubleclicking or whatever)

Nov. 11, 2010

Re: [Pharo-project] Adding method to Character

by StÃ©phane Ducasse

On Nov 11, 2010, at 5:14 PM, Tony Fleig wrote: > Hi, > > I find myself wanting a Character>>isConsonant method in addition to the existing Character>>isVowel method. It might be defined as > > Character>>isConsonant > ^ self isLetter & self isVowel not > > My question is: what is the best way to do this? > > Should I simply add the method to Character? If I do, I guess I must remember to merge my Monticello changes into each new version of Character? Is there some way to bundle this change in my package so I don't forget? but if you add this method in the character class as a class extension of your package then the addition will be done automatically each time you load it. > > I have created a method in my class MyClass>>characterIsConsonant: aCharacter, but it doesn't read well in the code. > > I suppose I could add the method dynamically in my class's initialize method... Not sure how to do that exactly. > > Is there another way to do this that I haven't thought of? > > Thanks, > TF

Nov. 11, 2010

[Pharo-project] Adding method to Character

by Tony Fleig

Hi, I find myself wanting a Character>>isConsonant method in addition to the existing Character>>isVowel method. It might be defined as Character>>isConsonant ^ self isLetter & self isVowel not My question is: what is the best way to do this? Should I simply add the method to Character? If I do, I guess I must remember to merge my Monticello changes into each new version of Character? Is there some way to bundle this change in my package so I don't forget? I have created a method in my class MyClass>>characterIsConsonant: aCharacter, but it doesn't read well in the code. I suppose I could add the method dynamically in my class's initialize method... Not sure how to do that exactly. Is there another way to do this that I haven't thought of? Thanks, TF

Nov. 11, 2010