January 2010 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Mac VM 5.4b1 ships

by Henrik Johansen

Den 25.01.2010 19:22, skrev John M McIntosh: > Well it's not a VM issue. The VM has no idea what the file contains, the Smalltalk code has to figure those details. > > I know. Which is why I tried to point out DragPlugin not working isn't that big a loss. Using it currently will likely lead to subtle errors untill the image code is fixed. (Like invalid utf8-characters in the changes, etc.) Cheers, Henry.

Jan. 25, 2010

Re: [Pharo-project] Monticello diff between chosen revisionsisbroken

by Gary Chambers

Yes, in this case it is a bug with Polymorph. Try with MCVersionInspector>>changes "Open a patch morph for the changes." self viewChanges: self version changes Hopefully no bad side-effects... With a bit more work it may be possible to show both versions between which the changes apply (unlike the old MC tools) ;-) Regards, Gary ----- Original Message ----- From: Gary Chambers To: Pharo-project(a)lists.gforge.inria.fr Sent: Monday, January 25, 2010 6:05 PM Subject: Re: [Pharo-project] Monticello diff between chosen revisionsisbroken MCVersionInspector>>diff | ancestorVersion | self pickAncestor ifNotNil: [:ancestor | ancestorVersion := self version workingCopy repositoryGroup versionWithInfo: ancestor. (self version asDiffAgainst: ancestorVersion) open] Regards, Gary ----- Original Message ----- From: Gary Chambers To: Pharo-project(a)lists.gforge.inria.fr Sent: Monday, January 25, 2010 5:50 PM Subject: Re: [Pharo-project] Monticello diff between chosen revisionsisbroken Needs looking at since it is confusing. IIRC the Diff button creates a .mcd file of the changes between some versions... Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Sent: Monday, January 25, 2010 5:34 PM Subject: Re: [Pharo-project] Monticello diff between chosen revisionsisbroken 2010/1/25 Gary Chambers <gazzaguru2(a)btinternet.com> The "Diff" button on the Monticello repository browser does what its balloon help says... 'Create an equivalent version based on an earlier release'. This is a diff version. I never use them as they can be confusing :-) Ok...I never used before...but something is clear: the second ask about a version, has no sense, and even is wrong if it compares to the last version. See step 6 of Stefan. Then, we have to options: - Or we remove that second prompt, as it always will use the last version - Or we change the diff implementation so that it uses the selected version instead of the last. What do you think ? Does someone really know what this "diff" should do ? Cheers Mariano If you want to compare two existing versions you should: 1. Open Monticello Browser 2. Select a repo 3. click open 4. Select a revision, not the latest one 5. Click HISTORY 6. chose an ancestor from the list Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Cc: Lukas Renggli Sent: Sunday, January 24, 2010 12:59 PM Subject: Re: [Pharo-project] Monticello diff between chosen revisions isbroken On Sat, Jan 23, 2010 at 9:51 PM, Stefan Marr <pharo(a)stefan-marr.de> wrote: Hi: In the current dev image (10508), Monticello is broken with respect to showing the differences of between chosen revisions. However, that seems to be broken already in 10496. (and maybe earlier) To reproduce: 1. Open Monticello Browser 2. Select a repo 3. click open 4. Select a revision, not the latest one 5. Click diff 6. chose an ancestor from the list Now you got a window 'Version: ...5' Saying (Diff against ...2) Here I would expect the changes button to open a window showing the changes between the chosen revisions, but it always diffs against the latest version. Yes, I could reproduce the problem. Can you open a ticket ? Maybe Lukas Monticello guru can help us ? hahaha Cheers Mariano Best Stefan -- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 3956 Fax: +32 2 629 3525 _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ---------------------------------------------------------------------- _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -------------------------------------------------------------------------- _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ---------------------------------------------------------------------------- _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ------------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 25, 2010

Re: [Pharo-project] Mac VM 5.4b1 ships

by Marcus Denker

Hi, For me it would be good enough as a first step if it would just file on the .cs (even tough not correctly encoded)... Marcus On Jan 25, 2010, at 7:22 PM, John M McIntosh wrote: > Well it's not a VM issue. The VM has no idea what the file contains, the Smalltalk code has to figure those details. > > On 2010-01-25, at 10:14 AM, Henrik Johansen wrote: >>> Ok, is that the file name that interpreted as mac roman? Or the contents of the text file? >>> Both are bugs, please make an pharo bug entry. >> http://code.google.com/p/pharo/issues/detail?id=1608 >> >> Same thing happens for any file dropped on the image (when dropping works). >> The offending method is MultiByteBinaryOrTextStream>>setConverterForCode. >> >> Not sure if Squeak used to save all files MacRoman encoded, but now they >> definately do not. (As evidenced by the example .mcz attached to the issue) >> >> Cheers, >> Henry > > -- > =========================================================================== > John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 > Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com > =========================================================================== > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

Jan. 25, 2010

Re: [Pharo-project] Monticello diff between chosen revisionsisbroken

by Marcus Denker

On Jan 25, 2010, at 7:10 PM, Lukas Renggli wrote: >> Needs looking at since it is confusing. IIRC the Diff button creates a .mcd >> file of the changes between some versions... > > No this has nothing to do with .mcd. The .mcd thing was an experiment > (that should probably better be removed again) that did not always > safe a complete package but only a delta to the ancestor. I think it > has never been used in production and is quite buggy. > Doesn't the Squeak trunk generate .mcds on the fly for faster updates? We used this mechanism at the beginning of 3.9, but it failed miserably when using changesets (or just using MC pre/post scripts) that modified code by reflection. Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

Jan. 25, 2010

Re: [Pharo-project] Mac VM 5.4b1 ships

by John M McIntosh

Well it's not a VM issue. The VM has no idea what the file contains, the Smalltalk code has to figure those details. On 2010-01-25, at 10:14 AM, Henrik Johansen wrote: >> Ok, is that the file name that interpreted as mac roman? Or the contents of the text file? >> Both are bugs, please make an pharo bug entry. > http://code.google.com/p/pharo/issues/detail?id=1608 > > Same thing happens for any file dropped on the image (when dropping works). > The offending method is MultiByteBinaryOrTextStream>>setConverterForCode. > > Not sure if Squeak used to save all files MacRoman encoded, but now they > definately do not. (As evidenced by the example .mcz attached to the issue) > > Cheers, > Henry -- =========================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com ===========================================================================

Jan. 25, 2010

Re: [Pharo-project] Mac VM 5.4b1 ships

by Henrik Johansen

Den 25.01.2010 19:03, skrev John M McIntosh: > On 2010-01-25, at 7:06 AM, Henrik Johansen wrote: > > >> Den 25.01.2010 15:34, skrev Marcus Denker: >> >>> Hi John, >>> >>> Somehow drag-and-drop from the Finder into Pharo is not working for me... If I drag a changeset on the Pharo desktop, in the old vm it would >>> be filed in. Now, it can not be dragged to the Pharo window anymore. >>> >>> Strange... it worked in the 4er series ok, never in the new 5er. >>> >>> Marcus >>> >>> >> Considering any file dropped on the image is interpreted as if in >> MacRoman encoding, I'd consider that a good thing (tm) ;) >> (Unless, of course, you're quaint enough to never use anything of >> character value > 127) >> >> Cheers, >> Henry >> > Ok, is that the file name that interpreted as mac roman? Or the contents of the text file? > Both are bugs, please make an pharo bug entry. http://code.google.com/p/pharo/issues/detail?id=1608 Same thing happens for any file dropped on the image (when dropping works). The offending method is MultiByteBinaryOrTextStream>>setConverterForCode. Not sure if Squeak used to save all files MacRoman encoded, but now they definately do not. (As evidenced by the example .mcz attached to the issue) Cheers, Henry

Jan. 25, 2010

Re: [Pharo-project] Monticello diff between chosen revisionsisbroken

by Lukas Renggli

> Needs looking at since it is confusing. IIRC the Diff button creates a .mcd > file of the changes between some versions... No this has nothing to do with .mcd. The .mcd thing was an experiment (that should probably better be removed again) that did not always safe a complete package but only a delta to the ancestor. I think it has never been used in production and is quite buggy. Lukas > Regards, Gary > > ----- Original Message ----- > From: Mariano Martinez Peck > To: Pharo-project(a)lists.gforge.inria.fr > Sent: Monday, January 25, 2010 5:34 PM > Subject: Re: [Pharo-project] Monticello diff between chosen > revisionsisbroken > > > 2010/1/25 Gary Chambers <gazzaguru2(a)btinternet.com> >> >> The "Diff" button on the Monticello repository browser does what its >> balloon help says... >> >> Â 'Create an equivalent version based on an earlier release'. This is a >> diff version. I never use them as they can be confusing :-) >> > > Ok...I never used before...but something is clear: the second ask about a > version, has no sense, and even is wrong if it compares to the last version. > See step 6 of Stefan. Then, we have to options: > - Or we remove that second prompt, as it always will use the last version > - Or we change the diff implementation so that it uses the selected version > instead of the last. > What do you think ? > Does someone really know what this "diff" should do ? > Cheers > Mariano > >> >> If you want to compare two existing versions you should: >> >> 1. Open Monticello Browser >> 2. Select a repo >> 3. click open >> 4. Select a revision, not the latest one >> 5. Click HISTORY >> 6. chose an ancestor from the list >> >> Regards, Gary >> >> ----- Original Message ----- >> From: Mariano Martinez Peck >> To: Pharo-project(a)lists.gforge.inria.fr >> Cc: Lukas Renggli >> Sent: Sunday, January 24, 2010 12:59 PM >> Subject: Re: [Pharo-project] Monticello diff between chosen revisions >> isbroken >> >> >> On Sat, Jan 23, 2010 at 9:51 PM, Stefan Marr <pharo(a)stefan-marr.de> wrote: >>> >>> Hi: >>> >>> In the current dev image (10508), Monticello is broken with respect to >>> showing the differences of between chosen revisions. >>> >>> However, that seems to be broken already in 10496. (and maybe earlier) >>> >>> To reproduce: >>> >>> 1. Open Monticello Browser >>> 2. Select a repo >>> 3. click open >>> 4. Select a revision, not the latest one >>> 5. Click diff >>> 6. chose an ancestor from the list >>> Now you got a window 'Version: Â ...5' >>> Saying (Diff against ...2) >>> Here I would expect the changes button to open a window showing the >>> changes between the chosen revisions, but it always diffs against the latest >>> version. >>> >> >> Yes, I could reproduce the problem. Can you open a ticket ? >> >> Maybe Lukas Monticello guru can help us ? hahaha >> >> Cheers >> >> Mariano >> >>> >>> Best >>> Stefan >>> >>> -- >>> Stefan Marr >>> Software Languages Lab >>> Vrije Universiteit Brussel >>> Pleinlaan 2 / B-1050 Brussels / Belgium >>> http://soft.vub.ac.be/~smarr >>> Phone: +32 2 629 3956 >>> Fax: Â +32 2 629 3525 >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> ________________________________ >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > ________________________________ > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 25, 2010

Re: [Pharo-project] Monticello diff between chosen revisions isbroken

by Lukas Renggli

> Does someone really know what this "diff" should do ? Sure, that's absolutely essential. I use it all day. - The "Diff" calculates the delta between two arbitrary selected versions. None of these versions (or a different one) has to be loaded in the image to be able to do that. - The "Changes" calculates the delta between the selected version and the working copy. Obviously you need a version of the package to be loaded. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 25, 2010

Re: [Pharo-project] Monticello diff between chosen revisionsisbroken

by Gary Chambers

MCVersionInspector>>diff | ancestorVersion | self pickAncestor ifNotNil: [:ancestor | ancestorVersion := self version workingCopy repositoryGroup versionWithInfo: ancestor. (self version asDiffAgainst: ancestorVersion) open] Regards, Gary ----- Original Message ----- From: Gary Chambers To: Pharo-project(a)lists.gforge.inria.fr Sent: Monday, January 25, 2010 5:50 PM Subject: Re: [Pharo-project] Monticello diff between chosen revisionsisbroken Needs looking at since it is confusing. IIRC the Diff button creates a .mcd file of the changes between some versions... Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Sent: Monday, January 25, 2010 5:34 PM Subject: Re: [Pharo-project] Monticello diff between chosen revisionsisbroken 2010/1/25 Gary Chambers <gazzaguru2(a)btinternet.com> The "Diff" button on the Monticello repository browser does what its balloon help says... 'Create an equivalent version based on an earlier release'. This is a diff version. I never use them as they can be confusing :-) Ok...I never used before...but something is clear: the second ask about a version, has no sense, and even is wrong if it compares to the last version. See step 6 of Stefan. Then, we have to options: - Or we remove that second prompt, as it always will use the last version - Or we change the diff implementation so that it uses the selected version instead of the last. What do you think ? Does someone really know what this "diff" should do ? Cheers Mariano If you want to compare two existing versions you should: 1. Open Monticello Browser 2. Select a repo 3. click open 4. Select a revision, not the latest one 5. Click HISTORY 6. chose an ancestor from the list Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Cc: Lukas Renggli Sent: Sunday, January 24, 2010 12:59 PM Subject: Re: [Pharo-project] Monticello diff between chosen revisions isbroken On Sat, Jan 23, 2010 at 9:51 PM, Stefan Marr <pharo(a)stefan-marr.de> wrote: Hi: In the current dev image (10508), Monticello is broken with respect to showing the differences of between chosen revisions. However, that seems to be broken already in 10496. (and maybe earlier) To reproduce: 1. Open Monticello Browser 2. Select a repo 3. click open 4. Select a revision, not the latest one 5. Click diff 6. chose an ancestor from the list Now you got a window 'Version: ...5' Saying (Diff against ...2) Here I would expect the changes button to open a window showing the changes between the chosen revisions, but it always diffs against the latest version. Yes, I could reproduce the problem. Can you open a ticket ? Maybe Lukas Monticello guru can help us ? hahaha Cheers Mariano Best Stefan -- Stefan Marr Software Languages Lab Vrije Universiteit Brussel Pleinlaan 2 / B-1050 Brussels / Belgium http://soft.vub.ac.be/~smarr Phone: +32 2 629 3956 Fax: +32 2 629 3525 _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ---------------------------------------------------------------------------- _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ------------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 25, 2010

Re: [Pharo-project] Mac VM 5.4b1 ships

by John M McIntosh

On 2010-01-25, at 7:06 AM, Henrik Johansen wrote: > Den 25.01.2010 15:34, skrev Marcus Denker: >> Hi John, >> >> Somehow drag-and-drop from the Finder into Pharo is not working for me... If I drag a changeset on the Pharo desktop, in the old vm it would >> be filed in. Now, it can not be dragged to the Pharo window anymore. >> >> Strange... it worked in the 4er series ok, never in the new 5er. >> >> Marcus >> > Considering any file dropped on the image is interpreted as if in > MacRoman encoding, I'd consider that a good thing (tm) ;) > (Unless, of course, you're quaint enough to never use anything of > character value > 127) > > Cheers, > Henry Ok, is that the file name that interpreted as mac roman? Or the contents of the text file? Both are bugs, please make an pharo bug entry. -- =========================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com ===========================================================================

Jan. 25, 2010