January 2010 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] CUIS new Text Editor Classes

by Fernando olivero

Stef, i've started from CUIS. This is what i have done so far. 1. Added the System-TextAttributes category 2. Moved the classes from Collections-Text to System-TextAttributes 3. Added System-Text category 4. Move Text from Collections-Text to System-Text. 5. File in CUIS new classes: Editor, SimpleEditor, TextEditor and SmalltalkEditor. 6. Removed Collections-Text category. Problems started here: 7. Merge CUIS Text class with Pharo Text class. (Cuis) Text has an attribute named initialStyle not present in (Pharo) Text. This is the main diff from both images. 8. Merge CUIS NewParagraph with Pharo NewParagraph (Pharo) NewParagraph has an attribute named textStyle not present in (Cuis) Pharo. In several NewParagraph methods CUIS doesn't care is some strings are isOctetString, and the Pharo NewParagraph does. For example #composeAll. I've preserved the Pharo behavior. Maybe i should start with the Squeak port then? Further steps: 9. Merge (cuis) TextMorph and (pharo) TextMorph, making it have a non-smalltalk,TextEditor. 10. Create (pharo) CodeMorph, replacing a TextMorph with a SmalltalkEditor. To my opinion , this will the major contribution, separating TextEditor and SmalltlakEditor concernes and their proper views , TextMorph and CodeMorph. Fernando On Jan 10, 2010, at 10:43 PM, StÃ©phane Ducasse wrote: > Excellent fernando! > Did you start from squeak or cuis > I was planning to start from Squeak since they ported back CUIS code in the context > of WideStrings (CUIS is pre unicode support) > > Stef > >> Juan re-factored the smalltalk behavior in the editors, creating the following hierarchy >> >> Editor >> TextEditor SimpleEditor >> SmalltalkEditor >> >> >> See the comment in Editor class in Cuis image http://www.jvuletich.org/Cuis/Index.html. >> >> New text editors. >> TextEditor provides most of the functionality that used to be in TextMorphEditor. This class is no longer a Controller! >> >> SmalltalkEditor is has Smalltalk code specific features. >> >> SimpleEditor provides basic functionality for single line text editing. It does not handle fonts and styles, aligning and Smalltalk utilities. It handles one single line. >> >> Would be nice to adopt this refactoring into Pharo, i've started to port it and cleaning up the textmorph in the process. But it's still a work in progress. >> >> Fernando >> >> On Jan 10, 2010, at 3:09 PM, Tudor Girba wrote: >> >>> Hi, >>> >>>> Gary and others >>>> >>>> I really think that we should do an audit of Morphic. In 1.1 we are >>>> going already faster but I'm sure that there is plenty >>>> of space for improvements. >>>> >>>> I see several actions >>>> - checking squeak toolbuilder enhancements and using it for the tools >>>> >>>> - checking CUIS >>>> - juan did an excellent job remocving a lot of unnecessary code >>>> - juan optimize scrollbar >>>> - juan did a new texteditor morph >>> >>> Indeed, a text editor that does not hardcode smalltalk specific >>> behavior would be great :). >>> >>>> - removing/cleaning extra widgets Pluggable/nonpluggable plague. >>>> - integrating better polymorph into the widgets layer. >>>> >>>> What do you think? >>> >>> >>> Doru >>> >>> -- >>> www.tudorgirba.com >>> >>> "Reasonable is what we are accustomed with." >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 12, 2010

Re: [Pharo-project] Object Buffer (implementation tryout)

by CÃ©drick BÃ©ler

2010/1/12 CÃ©drick BÃ©ler <cdrick65(a)gmail.com> > > Maybe you can also add shortcuts: Shift-Cmd-c, Shift-Cmd-v >> > > Yes, I'll do it > > > both are used... but I nevers used them... cmd + V paste initials cmd + C compare to clipboard Do you use them ? BTW, there's a clear problem with menu and shortcuts. For instance, not all hardcoded shortcuts works for keyboard other thant qwerty... :( -- CÃ©drick

Jan. 12, 2010

Re: [Pharo-project] [Vm-dev] SystemTracer64 progress

by David T. Lewis

On Tue, Jan 12, 2010 at 08:31:11AM +0100, Laval Jannik wrote: > > On Jan 12, 2010, at 04:55 , David T. Lewis wrote: > > > Over the weekend I made some progress in getting SystemTracer updated > > to do 64-bit image tracing. Previously SystemTracer64 did not work on > > little-endian machines (Mantis 5240). This is corrected now, and the > > code is on SqueakSource in project "SystemTracing". > > > > I can now trace a Squeak 3.10.2 image to 64-bit format on my Linux > > AMD box (little endian), producing a runnable 64-bit image. For > > an up to date Squeak trunk image, I can trace a 64 image that > > loads and runs (display opens and things start working), but that > > has problems with resuming its background processes (low space > > watcher etc). Possibly it's related to the block closure changes, > > although I believe there was an earlier report of a Pharo image > > with block closures being successfully traced to 64 bit format. > > > > Hi David, > > I cannot write my changes. > So you can have them in attachment. > > In these .cs, there is a merge with your version .15. > And it works with Pharo. Jannik, Thank you for sending this. I will compare and merge as soon as I have some more free time. Also, your PharoCore64-1.1-11152-UNSTABLE image works fine on my Linux box. Dave

Jan. 12, 2010

Re: [Pharo-project] clone vs shallowCopy

by Lukas Renggli

- #copy is the normal copy operation. It should be used by default and never overridden. It calls #postCopy that can be overridden to have class specific copy semantics. - #shallowCopy does a shallow copy. It should never be overridden and only be used if you want to get these very specific semantics. - #deepCopy does a deep copy. It should never be overridden and only be used if you want to get these very specific semantics. - #clone comes from eToys and Morphic (AFAIK). It implements some other copy semantics than #copy. I don't think that anybody should call this method, other than code that depends on this particular copy behavior. This is exactly the same problematic as with #=. There can't be just one #=. Other clients might consider other things when comparing objects. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 12, 2010

Re: [Pharo-project] Error when i try save a image [WAS]Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1

by Gary Chambers

Actually, the VM was the string as from SmalltalkImage current vmVersion. Pharo.exe reports its version (file properties) as 3.11.4.0 Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Sent: Tuesday, January 12, 2010 11:27 AM Subject: Re: [Pharo-project] Error when i try save a image [WAS]Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 2010/1/12 Gary Chambers <gazzaguru2(a)btinternet.com> I am seeing the same behaviour also, on occasion. Which OS do you use ? Mac OS? VM ? maybe there is a problem in the plugin ? Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Sent: Tuesday, January 12, 2010 11:02 AM Subject: Re: [Pharo-project] Error when i try save a image [WAS] Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 The problem is that when you save the image, in the shutDown list, there is freetype and it tries to finish all the handlers. The problem in this case is that one of those handlers that seems to be trying to finish has something in nil or some bad parameter which of course, gives a primitive mail. That's all my idea, maybe I am wrong as it is the first time I look in this code. As a work arround, you can install the StrikeFOnts instead of TrueTypes. It is not the real solution, but works. Just take the dev image with trutype and evaluate: FreeTypeCache clearCurrent. StrikeFont installDejaVu. Cheers On Mon, Jan 11, 2010 at 5:30 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: I could reproduce the problem. epicfan which OS are you using ? VM version ? On Mon, Jan 11, 2010 at 5:18 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: yes, actually that's was the mail about. On Mon, Jan 11, 2010 at 5:11 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: Do Yyou still have the problem with the latest rc version? Stef On Jan 11, 2010, at 5:02 PM, Mariano Martinez Peck wrote: > Sorry epicfan I have no idea at all. I cc Pharo mailing list that maybe someone can help you. > > I was going to cc nullPointer, but I discover it is you!!! hahahahah > > > ---------- Forwarded message ---------- > From: <epicfan(a)gmail.com> > Date: Mon, Jan 11, 2010 at 4:46 PM > Subject: Re: [BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 > To: marianopeck(a)gmail.com > > > The next error: > > http://code.google.com/p/pharo/issues/detail?id=1283&can=7&q=bug%20when%20t… > > In the last version of developer image that error was fix it. But in that 10505 image returns :| > > Regards. > > > > > PD. Could I do something in my code for delete that problem? > > Regards again. > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -------------------------------------------------------------------------- _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ------------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 12, 2010

Re: [Pharo-project] Error when i try save a image [WAS]Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1

by Gary Chambers

PharoCore1.1ALPHA Latest update: #11138 Windows VM 'Squeak3.10.2 of ''5 June 2008'' [latest update: #7179]' Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Sent: Tuesday, January 12, 2010 11:27 AM Subject: Re: [Pharo-project] Error when i try save a image [WAS]Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 2010/1/12 Gary Chambers <gazzaguru2(a)btinternet.com> I am seeing the same behaviour also, on occasion. Which OS do you use ? Mac OS? VM ? maybe there is a problem in the plugin ? Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Sent: Tuesday, January 12, 2010 11:02 AM Subject: Re: [Pharo-project] Error when i try save a image [WAS] Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 The problem is that when you save the image, in the shutDown list, there is freetype and it tries to finish all the handlers. The problem in this case is that one of those handlers that seems to be trying to finish has something in nil or some bad parameter which of course, gives a primitive mail. That's all my idea, maybe I am wrong as it is the first time I look in this code. As a work arround, you can install the StrikeFOnts instead of TrueTypes. It is not the real solution, but works. Just take the dev image with trutype and evaluate: FreeTypeCache clearCurrent. StrikeFont installDejaVu. Cheers On Mon, Jan 11, 2010 at 5:30 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: I could reproduce the problem. epicfan which OS are you using ? VM version ? On Mon, Jan 11, 2010 at 5:18 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: yes, actually that's was the mail about. On Mon, Jan 11, 2010 at 5:11 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: Do Yyou still have the problem with the latest rc version? Stef On Jan 11, 2010, at 5:02 PM, Mariano Martinez Peck wrote: > Sorry epicfan I have no idea at all. I cc Pharo mailing list that maybe someone can help you. > > I was going to cc nullPointer, but I discover it is you!!! hahahahah > > > ---------- Forwarded message ---------- > From: <epicfan(a)gmail.com> > Date: Mon, Jan 11, 2010 at 4:46 PM > Subject: Re: [BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 > To: marianopeck(a)gmail.com > > > The next error: > > http://code.google.com/p/pharo/issues/detail?id=1283&can=7&q=bug%20when%20t… > > In the last version of developer image that error was fix it. But in that 10505 image returns :| > > Regards. > > > > > PD. Could I do something in my code for delete that problem? > > Regards again. > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -------------------------------------------------------------------------- _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ------------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 12, 2010

Re: [Pharo-project] Error when i try save a image [WAS] Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1

by Mariano Martinez Peck

2010/1/12 Gary Chambers <gazzaguru2(a)btinternet.com> > I am seeing the same behaviour also, on occasion. > > Which OS do you use ? Mac OS? VM ? maybe there is a problem in the plugin ? > Regards, Gary > > ----- Original Message ----- > *From:* Mariano Martinez Peck <marianopeck(a)gmail.com> > *To:* Pharo-project(a)lists.gforge.inria.fr > *Sent:* Tuesday, January 12, 2010 11:02 AM > *Subject:* Re: [Pharo-project] Error when i try save a image [WAS] > Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 > > The problem is that when you save the image, in the shutDown list, there is > freetype and it tries to finish all the handlers. The problem in this case > is that one of those handlers that seems to be trying to finish has > something in nil or some bad parameter which of course, gives a primitive > mail. That's all my idea, maybe I am wrong as it is the first time I look in > this code. > > As a work arround, you can install the StrikeFOnts instead of TrueTypes. It > is not > the real solution, but works. Just take the dev image with trutype and > evaluate: > > FreeTypeCache clearCurrent. > StrikeFont installDejaVu. > > > Cheers > > On Mon, Jan 11, 2010 at 5:30 PM, Mariano Martinez Peck < > marianopeck(a)gmail.com> wrote: > >> I could reproduce the problem. epicfan which OS are you using ? VM >> version ? >> >> >> On Mon, Jan 11, 2010 at 5:18 PM, Mariano Martinez Peck < >> marianopeck(a)gmail.com> wrote: >> >>> yes, actually that's was the mail about. >>> >>> >>> >>> On Mon, Jan 11, 2010 at 5:11 PM, StÃ©phane Ducasse < >>> stephane.ducasse(a)inria.fr> wrote: >>> >>>> Do Yyou still have the problem with the latest rc version? >>>> >>>> Stef >>>> On Jan 11, 2010, at 5:02 PM, Mariano Martinez Peck wrote: >>>> >>>> > Sorry epicfan I have no idea at all. I cc Pharo mailing list that >>>> maybe someone can help you. >>>> > >>>> > I was going to cc nullPointer, but I discover it is you!!! hahahahah >>>> > >>>> > >>>> > ---------- Forwarded message ---------- >>>> > From: <epicfan(a)gmail.com> >>>> > Date: Mon, Jan 11, 2010 at 4:46 PM >>>> > Subject: Re: [BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 >>>> > To: marianopeck(a)gmail.com >>>> > >>>> > >>>> > The next error: >>>> > >>>> > >>>> http://code.google.com/p/pharo/issues/detail?id=1283&can=7&q=bug%20when%20t… >>>> > >>>> > In the last version of developer image that error was fix it. But in >>>> that 10505 image returns :| >>>> > >>>> > Regards. >>>> > >>>> > >>>> > >>>> > >>>> > PD. Could I do something in my code for delete that problem? >>>> > >>>> > Regards again. >>>> > >>>> > _______________________________________________ >>>> > Pharo-project mailing list >>>> > Pharo-project(a)lists.gforge.inria.fr >>>> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >> > ------------------------------ > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 12, 2010

Re: [Pharo-project] Error when i try save a image [WAS] Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1

by Gary Chambers

I am seeing the same behaviour also, on occasion. Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project(a)lists.gforge.inria.fr Sent: Tuesday, January 12, 2010 11:02 AM Subject: Re: [Pharo-project] Error when i try save a image [WAS] Fwd:[BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 The problem is that when you save the image, in the shutDown list, there is freetype and it tries to finish all the handlers. The problem in this case is that one of those handlers that seems to be trying to finish has something in nil or some bad parameter which of course, gives a primitive mail. That's all my idea, maybe I am wrong as it is the first time I look in this code. As a work arround, you can install the StrikeFOnts instead of TrueTypes. It is not the real solution, but works. Just take the dev image with trutype and evaluate: FreeTypeCache clearCurrent. StrikeFont installDejaVu. Cheers On Mon, Jan 11, 2010 at 5:30 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: I could reproduce the problem. epicfan which OS are you using ? VM version ? On Mon, Jan 11, 2010 at 5:18 PM, Mariano Martinez Peck <marianopeck(a)gmail.com> wrote: yes, actually that's was the mail about. On Mon, Jan 11, 2010 at 5:11 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: Do Yyou still have the problem with the latest rc version? Stef On Jan 11, 2010, at 5:02 PM, Mariano Martinez Peck wrote: > Sorry epicfan I have no idea at all. I cc Pharo mailing list that maybe someone can help you. > > I was going to cc nullPointer, but I discover it is you!!! hahahahah > > > ---------- Forwarded message ---------- > From: <epicfan(a)gmail.com> > Date: Mon, Jan 11, 2010 at 4:46 PM > Subject: Re: [BetaTesting] [ANN] Pharo1.0-10505-rc1dev10.01.1 > To: marianopeck(a)gmail.com > > > The next error: > > http://code.google.com/p/pharo/issues/detail?id=1283&can=7&q=bug%20when%20t… > > In the last version of developer image that error was fix it. But in that 10505 image returns :| > > Regards. > > > > > PD. Could I do something in my code for delete that problem? > > Regards again. > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ------------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 12, 2010

Re: [Pharo-project] [Feature Request] Better integration with OSX Window Management

by Mariano Martinez Peck

I had the same problem sometime and I don't know how to fix it :( Please open a ticket On Tue, Jan 12, 2010 at 11:49 AM, Stefan Marr <pharo(a)stefan-marr.de> wrote: > Hi Eliot: > > > On 11 Jan 2010, at 19:26, Eliot Miranda wrote: > > > Hi Stefan, > > > > not much of a comfort but as a work-=around I *think* you can fix the > problem either by > > - disconnecting the second monitor, which will rearrange all the windows > onto your laptop screen, and then reattach the second monitor > > or > > - choosing Turn On Mirroring from the displays menu, which will also > rearrange windows, and then turn off mirroring > No, it does not. I have to explicitly go to my monitor arrangement settings > and restore the configuration I have at home. > Just experienced it again. > > Any idea where I could start to look at that? > > Thanks > Stefan > > > > > > > > On Mon, Jan 11, 2010 at 4:34 AM, Stefan Marr <pharo(a)stefan-marr.de> > wrote: > > Hello: > > > > I just had a very annoying experience with the lake of sufficient window > management tools on Mac OS X. (Annoying enough to write this mail...) > > > > > > The following happened: > > > > At home I have a external screen attached to my mac book, it is > configured to be a secondary screen positioned above the main (internal) > screen. > > > > The Pharo window was moved to that screen. > > > > In the office, I have another configuration, and there was no way to get > hold of the Pharo window anymore. > > > > It remembered its positioning and was just of screen. Expose allows me to > see it, and shows even a beautiful animation moving it out of reach after > clicking on it. > > > > Obviously the menu SqueakVM > Quit is not really helpful, since the > question whether to save or not is displayed unreachable off screen, too. > > > > > > > > I am not sure whether the standard OS X window menu functionality with > "minimize" and "zoom" would help here, but might be a start. On the other > hand, I would guess, that the OSX windowing systems sends some events which > could be handled like all other windows do. > > > > > > The only workaround for the moment, is to have a external screen and > fiddle with the screen configuration and positioning until I can get hold of > the window... Not exactly convenient. > > > > > > Best regards > > Stefan > > > > -- > > Stefan Marr > > Software Languages Lab > > Vrije Universiteit Brussel > > Pleinlaan 2 / B-1050 Brussels / Belgium > > http://soft.vub.ac.be/~smarr <http://soft.vub.ac.be/%7Esmarr> > > Phone: +32 2 629 3956 > > Fax: +32 2 629 3525 > > > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > -- > Stefan Marr > Software Languages Lab > Vrije Universiteit Brussel > Pleinlaan 2 / B-1050 Brussels / Belgium > http://soft.vub.ac.be/~smarr <http://soft.vub.ac.be/%7Esmarr> > Phone: +32 2 629 3956 > Fax: +32 2 629 3525 > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 12, 2010

Re: [Pharo-project] Spell check test cases

by Mariano Martinez Peck

Lukas: if you then copy these tests in RB repository let me know so that I can included in Dev image. cheers mariano On Tue, Jan 12, 2010 at 11:57 AM, Lukas Renggli <renggli(a)gmail.com> wrote: > > I think you didn't pick up the other fix in RBBugFixes > > > > RBLiteralValuesSpellingRule>>initialize > > super initialize. > > matcher := RBParseTreeSearcher new. > > matcher matches: '`#literal' > > do: > > [ :node :answer | > > | nodeValue | > > nodeValue := node value. > > (nodeValue isString or: [ nodeValue isSymbol or: [ > nodeValue isCollection > > ] ]) ifTrue: > > [ answer add: nodeValue ]. > > answer ] > > Thank you. Indeed, I did not see this change. I implemented it > slightly different to ignore ByteArrays and to flatten out nested > literal array collections. > > > The tests are on 'RB' 'OK' etc, in the quotes in class comments. Leading > > capitals are stripped off. If $' is passed through, the check gets made > on > > K', and as it is 2 characters doesn't get disallowed. That's why the > tests > > need the pass through of ' taken out at the moment. If instead, where > you > > store the result: > > result add: output contents > > if you strip out trailing $' before storing, this would let you verify > don't > > and smalltalk's as well, I think. > > Then you'd need a different test from the position in the stream for size > = > > 1. > > > > I only hit this edge case because I had a class comment about namespace > > related prefixes- 'WA' 'RB' etc. > > > > So now 'OK' is not checked, under the 'strip out leading capitals' > scenario. > > At some point it might be nice to check these as well - eg WARenderCanvas > > rather than WBRenderCanvas. YAGNI, NASA, other abbreviations. > > > > Code Critics browser still doesn't show Method Protocols in bold. > > In bold? They are highlighted here. > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 12, 2010