January 2010 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Date fromString: '6-Jan-10'

by Matthias Berth

don't know if this addresses your confusion: before: '5-APR-10' got parsed as April 5, 1910 after: '5-APR-10' gets parsed as April 5, 2010 so it kind of fixes the passing of time :-) This kind of cleverness should not be there, IMHO. a) you want to parse special date formats: you should use some explicit format descriptions (that %M%D%Y stuff) and make it explicit. b) you want to make some best effort to parse whatever string as a date: that is a heuristic and it should be in another method, not something as basic as #readFrom:. Maybe call the method guessFrom: aStream ;-) Cheers Matthias On Sat, Jan 16, 2010 at 10:57 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > hi guys > > can one of you give a look at the this fix because I'm confused. Â Kernel-DavidHotham.538 > > year < 20 ifTrue: [year := 2000 + year] > Â Â Â Â was > year < 10 ifTrue: [year := 2000 + year] > > both solutions look strange to me. > > http://code.google.com/p/pharo/issues/detail?id=1749 > > > readFrom: aStream > Â Â Â Â "Read a Date from the stream in any of the forms: > Â Â Â Â Â Â Â Â Â Â Â Â <day> <monthName> <year> Â Â Â Â Â Â Â Â (5 April 1982; 5-APR-82) > Â Â Â Â Â Â Â Â Â Â Â Â <monthName> <day> <year> Â Â Â Â Â Â Â Â (April 5, 1982) > Â Â Â Â Â Â Â Â Â Â Â Â <monthNumber> <day> <year> Â Â Â Â Â Â Â (4/5/82) > Â Â Â Â Â Â Â Â Â Â Â Â <day><monthName><year> Â Â Â Â Â Â Â Â Â (5APR82)" > Â Â Â Â | day month year | > Â Â Â Â aStream peek isDigit > Â Â Â Â Â Â Â Â ifTrue: [day := Integer readFrom: aStream]. > Â Â Â Â [aStream peek isAlphaNumeric] > Â Â Â Â Â Â Â Â whileFalse: [aStream skip: 1]. > Â Â Â Â aStream peek isLetter > Â Â Â Â Â Â Â Â ifTrue: ["number/name... or name..." > Â Â Â Â Â Â Â Â Â Â Â Â month := (String new: 10) writeStream. > Â Â Â Â Â Â Â Â Â Â Â Â [aStream peek isLetter] > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â whileTrue: [month nextPut: aStream next]. > Â Â Â Â Â Â Â Â Â Â Â Â month := month contents. > Â Â Â Â Â Â Â Â Â Â Â Â day isNil > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ifTrue: ["name/number..." > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â [aStream peek isAlphaNumeric] > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â whileFalse: [aStream skip: 1]. > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â day := Integer readFrom: aStream]] > Â Â Â Â Â Â Â Â ifFalse: ["number/number..." > Â Â Â Â Â Â Â Â Â Â Â Â month := Month nameOfMonth: day. > Â Â Â Â Â Â Â Â Â Â Â Â day := Integer readFrom: aStream]. > Â Â Â Â [aStream peek isAlphaNumeric] > Â Â Â Â Â Â Â Â whileFalse: [aStream skip: 1]. > Â Â Â Â year := Integer readFrom: aStream. >>> Â Â Â year < 20 ifTrue: [year := 2000 + year] > Â Â Â Â Â Â Â Â ifFalse: [ year < 1900 ifTrue: [ year := 1900 + year]]. > > Â Â Â Â ^ self > Â Â Â Â Â Â Â Â year: year > Â Â Â Â Â Â Â Â month: month > Â Â Â Â Â Â Â Â day: day > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 16, 2010

[Pharo-project] Date fromString: '6-Jan-10'

by StÃ©phane Ducasse

hi guys can one of you give a look at the this fix because I'm confused. Kernel-DavidHotham.538 year < 20 ifTrue: [year := 2000 + year] was year < 10 ifTrue: [year := 2000 + year] both solutions look strange to me. http://code.google.com/p/pharo/issues/detail?id=1749 readFrom: aStream "Read a Date from the stream in any of the forms: <day> <monthName> <year> (5 April 1982; 5-APR-82) <monthName> <day> <year> (April 5, 1982) <monthNumber> <day> <year> (4/5/82) <day><monthName><year> (5APR82)" | day month year | aStream peek isDigit ifTrue: [day := Integer readFrom: aStream]. [aStream peek isAlphaNumeric] whileFalse: [aStream skip: 1]. aStream peek isLetter ifTrue: ["number/name... or name..." month := (String new: 10) writeStream. [aStream peek isLetter] whileTrue: [month nextPut: aStream next]. month := month contents. day isNil ifTrue: ["name/number..." [aStream peek isAlphaNumeric] whileFalse: [aStream skip: 1]. day := Integer readFrom: aStream]] ifFalse: ["number/number..." month := Month nameOfMonth: day. day := Integer readFrom: aStream]. [aStream peek isAlphaNumeric] whileFalse: [aStream skip: 1]. year := Integer readFrom: aStream. >> year < 20 ifTrue: [year := 2000 + year] ifFalse: [ year < 1900 ifTrue: [ year := 1900 + year]]. ^ self year: year month: month day: day

Jan. 16, 2010

Re: [Pharo-project] Toyota like process for 1.1

by StÃ©phane Ducasse

issue 1827 soon in 11162 Fixed - testComplIsSelfEvaluating removed the compiledMethod from the array since the store on probably changed and compiled methods are not self evaluating SimpleSwicthMorph>>testName removed (no external name anymore) AuthorTest>>testDeprecation removed (since the methods are not there anymore) Changed last line since a test should not rely on something on the harddisc testIsFontAvailable "self debug: #testIsFontAvailable" (Locale isoLanguage: 'ja') languageEnvironment removeFonts. self assert: (Locale isoLanguage: 'en') languageEnvironment isFontAvailable. "Next test should fail after installing Japanese font" self assert: (Locale isoLanguage: 'ja') languageEnvironment isFontAvailable not. (Locale isoLanguage: 'ja') languageEnvironment installFont. self assert: (Locale isoLanguage: 'ja') languageEnvironment isFontAvailable not TextDiffBuilderTest>>expectedFailures "these tests are for the new TextDiffBuilder that should be integrated from Squeak-trunk" ^ #(testIfPatchIsMinimal testIfSequence4 testIfSequence6) more to come Stef

Jan. 16, 2010

Re: [Pharo-project] [ANN] WorkingSet

by StÃ©phane Ducasse

romain for the key why not reusing M instead of S for meaning implementors and others. Stef On Jan 14, 2010, at 2:05 PM, Romain Robbes wrote: > > On Jan 14, 2010, at 7:34 AM, Simon Denier wrote: > >> >> On 14 janv. 2010, at 00:33, Romain Robbes wrote: >> >>>>> >>>>> >>>>>> Future work: integration in the browser :) >>>>>> >>>>> >>>>> How do you envision that? I tried to not be too browser-specific, as these things are moving targets. >>>> >>>> I would not integrate that in browser because it makes the state machine of this brittle tools brittler and like that you >>>> can focus on working set functionality vs browser bugs :) >>>> >>> >>> If anything, WorkingSet makes code browsers look like disposable entities. It opens so many of them that it even includes a shortcut to close all the windows opened by it :-). >> >> I was thinking of a browser focused only on items displayed in a working set. However, this is a slightly different definition of working set (one where you can also pinned down some entities). >> > > well, you could try the "recent submissions window" World > Tools > More ... > Recent Submissions . > WorkingSet is a kind of nicer ui to the same data (so far). > > >> One problem I noticed but related to completion (because I also have this problem with the mercury search bar). When completing a keyword message, spaces are automatically inserted between keyword to put parameters. This fails the search because it does not take the full message, only a part of it. > > yes, I'm aware of this > >> >> On a sidenote, it seems that installing WrokingSet deactivates the shortcut to Algernon (shift-return). Can someone confirm? >> > > that's possible. there's no keyboard shortcut registry, so we both did an override in the same spot, I suppose. > >> >>> >>> What I would like to have now is a better window placement, with possibilities to tile windows. >>> Has anybody done something like that already? >> >> I think that StÃ©phane did a bit of hacking at one point :) >> I know the logic is in the RealEstateAgent class. >> >> At one time, I thought that making the window appears with the title bar right under the mouse pointer could be a good idea. If the window placement does not suite you, you can click and move the window. Besides, if you open windows through the world menu, that means you clicked in an empty space right before, so good location to start. > > One think I need to try is to have windows openInHand and not openInWorld. Then you get to place them > yourself. I have to see if this makes using the tool cumbersome or not. > >> >> -- >> Simon >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > -- > Romain Robbes > http://www.inf.unisi.ch/phd/robbes > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 16, 2010

[Pharo-project] Issue 1829: testIndenting: remove/fix? since rely on the current font

by StÃ©phane Ducasse

Help me taking decision :) Stef http://code.google.com/p/pharo/issues/detail?id=1829 testSetUp "just reminding us all what the paragraph looks like to begin with. assuming Accuny12 font " | cb | cb := para characterBlockForIndex: 1. "p" self assert: cb top = 0. self assert: cb left = 0. self assert: cb right = 7. cb := para characterBlockForIndex: 2. "the tab" self assert: cb top = 0. self assert: cb left = 7. self assert: cb right = 24. cb := para characterBlockForIndex: 3. "w" self assert: cb top = 0. self assert: cb left = 24. self assert: cb right = 34. cb := para characterBlockForIndex: 7. " " "between word and word" self assert: cb top = 0. self assert: cb left = 52. self assert: cb right = 57. cb := para characterBlockForIndex: 11. "d" "last char" self assert: cb top = 0. self assert: cb left = 79. self assert: cb right = 85.

Jan. 16, 2010

[Pharo-project] Broken tests: testAnnotationPane

by StÃ©phane Ducasse

Please help http://code.google.com/p/pharo/issues/detail?id=1828 say that you are working on it on the site. testAnnotationPane | oldPref | oldPref := MCCodeTool showAnnotationPane. CodeHolder showAnnotationPane: false. morph := model buildWindow. self assert: (self morphsOfClass: TextMorph) size = 1. CodeHolder showAnnotationPane: true. morph := model buildWindow. self assert: (self morphsOfClass: TextMorph) size = 2. CodeHolder showAnnotationPane: oldPref

Jan. 16, 2010

[Pharo-project] Object>>#actionMap -> (Object>>#actionMap "a CompiledMethod(1891)")

by StÃ©phane Ducasse

I was wondering if this is of any interest to have the () and the compiled method with number because it breaks self evaluation for nothing. (Object>>#actionMap "a CompiledMethod(1891)") Stef

Jan. 16, 2010

Re: [Pharo-project] Package Browser and Pharo

by Simon Denier

On 16 janv. 2010, at 09:09, StÃ©phane Ducasse wrote: > > On Jan 16, 2010, at 12:16 AM, Alexandre Bergel wrote: > >> Hi! >> >> David arrived today and will spend few days among us. I would like to >> define a roadmap on how to improve the state of O2PackageBrowser. The >> main problem people have with O2PackageBrowser is the overrides made >> by O2PackageBrowser right? These overrides break OB. This is something >> we will fix. >> >> I would like that people who are using O2PackageBrowser to add their >> wishes and bug report on code.google please. Add David and me as Cc. >> We will look for the entries by entering O2 in the search field. > > Alex > > the main point is how to extend OB without breaking it. So may be this requires some coordination with lukas. > Because else we will have the same problem in a couple of months. > > I would drastically simplify the browser: > - focus on packages and traits support > - remove the smart groups management since romain as a orthogonal solution. Actually, after playing a bit with this, it's nice but it does not provide the same feature as smart groups. I find myself almost always going to the search field to look for something and even then, the search sometimes fails even if the method exists. The users/siblings thing is very nice still. -- Simon

Jan. 16, 2010

Re: [Pharo-project] Toyota like process for 1.1

by StÃ©phane Ducasse

ok guys run the tests and send fixes :) On Jan 16, 2010, at 3:11 AM, csrabak(a)bol.com.br wrote: > Em 15/01/2010 19:48, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> escreveu: > >> Hi guys >> may be I'm wrong but I have the impression that fixing tests as >> soon as they are broken in the Unstable branch could be better. Now >> doing that may stall our energy. > > I think it would reduce the [apparent] speed of new functionality, but > not "stall our energy" which I surmise is to have a cool but as bug > free as possible Pharo Smalltalk. > >> So what do you think? > > Doing this way, as some red tests get on the pile without resolution > we can get more attention to the issues. > > It's a mixture of the Toyota process with a Kanban for squashing the > bugs! > >> May be an alternate process is to make progress and to do green >> test session from time to time. > > Except if we could be _so_ assertive about the non importance of some > of the non passing tests, I think the time to time should be as short > as today! > > OK, as a concession could we try to have these gates about every two > weeks? > > -- > Cesar Rabak > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 16, 2010

Re: [Pharo-project] Package Browser and Pharo

by StÃ©phane Ducasse

On Jan 16, 2010, at 12:16 AM, Alexandre Bergel wrote: > Hi! > > David arrived today and will spend few days among us. I would like to > define a roadmap on how to improve the state of O2PackageBrowser. The > main problem people have with O2PackageBrowser is the overrides made > by O2PackageBrowser right? These overrides break OB. This is something > we will fix. > > I would like that people who are using O2PackageBrowser to add their > wishes and bug report on code.google please. Add David and me as Cc. > We will look for the entries by entering O2 in the search field. Alex the main point is how to extend OB without breaking it. So may be this requires some coordination with lukas. Because else we will have the same problem in a couple of months. I would drastically simplify the browser: - focus on packages and traits support - remove the smart groups management since romain as a orthogonal solution. Stef

Jan. 16, 2010