January 2010 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] About mime encoding

by StÃ©phane Ducasse

ok the setup was different and changing the positioning.... On Jan 16, 2010, at 12:26 PM, StÃ©phane Ducasse wrote: > apparently without the repositioning of the stream the mineEncode does not get fed up character > and so nothing happen. > > Stef > > On Jan 16, 2010, at 12:12 PM, StÃ©phane Ducasse wrote: > >> now >> >> >> mimeEncode: aStream >> "Return a ReadWriteStream of characters. The data of aStream is encoded as 65 innocuous characters. (See class comment). 3 bytes in aStream goes to 4 bytes in output." >> >> | me | >> me := self new dataStream: aStream. >> me mimeStream: (ReadWriteStream on: (String new: aStream size + 20 * 4 // 3)). >> me mimeEncode. >> me mimeStream position: 0. >> ^ me mimeStream >> >> testMimeEncodeDecode >> >> | encoded | >> encoded := Base64MimeConverter mimeEncode: message. >> self assert: (encoded contents = 'SGkgVGhlcmUh'). >> self assert: ((Base64MimeConverter mimeDecodeToChars: encoded) contents = message contents). >> >> >> encoded contents = '' >> >> :( >> >> Stef >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 16, 2010

Re: [Pharo-project] Issue 1829: testIndenting: remove/fix? since rely on the current font

by StÃ©phane Ducasse

Yeahhhhhh in the next batch! On Jan 16, 2010, at 12:28 PM, Adrian Lienhard wrote: > Yes, I would remove it. Tests that rely on the current font or similar user settings are just a bad idea because they fail in unexpected ways. > > Adrian > > On Jan 16, 2010, at 10:33 , StÃ©phane Ducasse wrote: > >> Help me taking decision :) >> >> Stef >> >> http://code.google.com/p/pharo/issues/detail?id=1829 >> >> testSetUp >> "just reminding us all what the paragraph looks like to begin with. assuming Accuny12 font " >> | cb | >> >> >> cb := para characterBlockForIndex: 1. "p" >> self assert: cb top = 0. >> self assert: cb left = 0. >> self assert: cb right = 7. >> >> >> cb := para characterBlockForIndex: 2. "the tab" >> self assert: cb top = 0. >> self assert: cb left = 7. >> self assert: cb right = 24. >> >> >> cb := para characterBlockForIndex: 3. "w" >> self assert: cb top = 0. >> self assert: cb left = 24. >> self assert: cb right = 34. >> >> cb := para characterBlockForIndex: 7. " " "between word and word" >> self assert: cb top = 0. >> self assert: cb left = 52. >> self assert: cb right = 57. >> >> cb := para characterBlockForIndex: 11. "d" "last char" >> self assert: cb top = 0. >> self assert: cb left = 79. >> self assert: cb right = 85. >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 16, 2010

Re: [Pharo-project] Issue 1829: testIndenting: remove/fix? since rely on the current font

by Adrian Lienhard

Yes, I would remove it. Tests that rely on the current font or similar user settings are just a bad idea because they fail in unexpected ways. Adrian On Jan 16, 2010, at 10:33 , StÃ©phane Ducasse wrote: > Help me taking decision :) > > Stef > > http://code.google.com/p/pharo/issues/detail?id=1829 > > testSetUp > "just reminding us all what the paragraph looks like to begin with. assuming Accuny12 font " > | cb | > > > cb := para characterBlockForIndex: 1. "p" > self assert: cb top = 0. > self assert: cb left = 0. > self assert: cb right = 7. > > > cb := para characterBlockForIndex: 2. "the tab" > self assert: cb top = 0. > self assert: cb left = 7. > self assert: cb right = 24. > > > cb := para characterBlockForIndex: 3. "w" > self assert: cb top = 0. > self assert: cb left = 24. > self assert: cb right = 34. > > cb := para characterBlockForIndex: 7. " " "between word and word" > self assert: cb top = 0. > self assert: cb left = 52. > self assert: cb right = 57. > > cb := para characterBlockForIndex: 11. "d" "last char" > self assert: cb top = 0. > self assert: cb left = 79. > self assert: cb right = 85. > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 16, 2010

Re: [Pharo-project] About mime encoding

by StÃ©phane Ducasse

apparently without the repositioning of the stream the mineEncode does not get fed up character and so nothing happen. Stef On Jan 16, 2010, at 12:12 PM, StÃ©phane Ducasse wrote: > now > > > mimeEncode: aStream > "Return a ReadWriteStream of characters. The data of aStream is encoded as 65 innocuous characters. (See class comment). 3 bytes in aStream goes to 4 bytes in output." > > | me | > me := self new dataStream: aStream. > me mimeStream: (ReadWriteStream on: (String new: aStream size + 20 * 4 // 3)). > me mimeEncode. > me mimeStream position: 0. > ^ me mimeStream > > testMimeEncodeDecode > > | encoded | > encoded := Base64MimeConverter mimeEncode: message. > self assert: (encoded contents = 'SGkgVGhlcmUh'). > self assert: ((Base64MimeConverter mimeDecodeToChars: encoded) contents = message contents). > > > encoded contents = '' > > :( > > Stef > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 16, 2010

Re: [Pharo-project] About mime encoding

by StÃ©phane Ducasse

now mimeEncode: aStream "Return a ReadWriteStream of characters. The data of aStream is encoded as 65 innocuous characters. (See class comment). 3 bytes in aStream goes to 4 bytes in output." | me | me := self new dataStream: aStream. me mimeStream: (ReadWriteStream on: (String new: aStream size + 20 * 4 // 3)). me mimeEncode. me mimeStream position: 0. ^ me mimeStream testMimeEncodeDecode | encoded | encoded := Base64MimeConverter mimeEncode: message. self assert: (encoded contents = 'SGkgVGhlcmUh'). self assert: ((Base64MimeConverter mimeDecodeToChars: encoded) contents = message contents). encoded contents = '' :( Stef

Jan. 16, 2010

Re: [Pharo-project] Date fromString: '6-Jan-10'

by David Hotham

Hello, The motivation behind this fix is that I am parsing historical stock data obtained from Google, in which dates are provided like this: "15-Jan-10". Of course I want this to read as 2010, not 1910. I agree that the existing solution (with or without my tweak) looks ugly. I gave brief consideration to a bigger fix which first checked what the current year was and then calculated what century to add to a low date. But, frankly, I couldn't be bothered. I figure that a one-character fix that is good for ten years isn't too bad. I am quite content to defer to others as to what the right solution is here. So long as there ends up being a convenient way to read two-digit years correctly, I'll be happy. David "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> wrote in message news:78E0F3D1-D169-43D9-B12E-6C9D4E2860C5@inria.fr... > hi guys > > can one of you give a look at the this fix because I'm confused. > Kernel-DavidHotham.538 > > year < 20 ifTrue: [year := 2000 + year] > was > year < 10 ifTrue: [year := 2000 + year] > > both solutions look strange to me. > > http://code.google.com/p/pharo/issues/detail?id=1749 > > > readFrom: aStream > "Read a Date from the stream in any of the forms: > <day> <monthName> <year> (5 April 1982; 5-APR-82) > <monthName> <day> <year> (April 5, 1982) > <monthNumber> <day> <year> (4/5/82) > <day><monthName><year> (5APR82)" > | day month year | > aStream peek isDigit > ifTrue: [day := Integer readFrom: aStream]. > [aStream peek isAlphaNumeric] > whileFalse: [aStream skip: 1]. > aStream peek isLetter > ifTrue: ["number/name... or name..." > month := (String new: 10) writeStream. > [aStream peek isLetter] > whileTrue: [month nextPut: aStream next]. > month := month contents. > day isNil > ifTrue: ["name/number..." > [aStream peek isAlphaNumeric] > whileFalse: [aStream skip: 1]. > day := Integer readFrom: aStream]] > ifFalse: ["number/number..." > month := Month nameOfMonth: day. > day := Integer readFrom: aStream]. > [aStream peek isAlphaNumeric] > whileFalse: [aStream skip: 1]. > year := Integer readFrom: aStream. >>> year < 20 ifTrue: [year := 2000 + year] > ifFalse: [ year < 1900 ifTrue: [ year := 1900 + year]]. > > ^ self > year: year > month: month > day: day

Jan. 16, 2010

Re: [Pharo-project] Toyota like process for 1.1

by StÃ©phane Ducasse

On Jan 16, 2010, at 11:33 AM, Levente Uzonyi wrote: > On Sat, 16 Jan 2010, StÃ©phane Ducasse wrote: > >> issue 1827 soon in 11162 >> >> Fixed >> - testComplIsSelfEvaluating removed the compiledMethod from the array since the store on probably changed and >> compiled methods are not self evaluating >> >> SimpleSwicthMorph>>testName removed (no external name anymore) >> >> AuthorTest>>testDeprecation removed (since the methods are not there anymore) >> >> >> Changed last line since a test should not rely on something on the harddisc >> >> testIsFontAvailable >> "self debug: #testIsFontAvailable" >> (Locale isoLanguage: 'ja') languageEnvironment removeFonts. >> self assert: (Locale isoLanguage: 'en') languageEnvironment isFontAvailable. >> "Next test should fail after installing Japanese font" >> self assert: (Locale isoLanguage: 'ja') languageEnvironment isFontAvailable not. >> (Locale isoLanguage: 'ja') languageEnvironment installFont. >> self assert: (Locale isoLanguage: 'ja') languageEnvironment isFontAvailable not >> >> >> TextDiffBuilderTest>>expectedFailures >> "these tests are for the new TextDiffBuilder that should be integrated from Squeak-trunk" > > To be exact, these are broken with the current implementation. Integrating the new TextDiffBuilder should be easy. yeap! Stef

Jan. 16, 2010

Re: [Pharo-project] Date fromString: '6-Jan-10'

by StÃ©phane Ducasse

On Jan 16, 2010, at 11:07 AM, Matthias Berth wrote: > don't know if this addresses your confusion: > > before: '5-APR-10' got parsed as April 5, 1910 > after: '5-APR-10' gets parsed as April 5, 2010 > > so it kind of fixes the passing of time :-) > > This kind of cleverness should not be there, IMHO. +1 Confirmed. > > a) you want to parse special date formats: you should use some > explicit format descriptions (that %M%D%Y stuff) and make it explicit. > > b) you want to make some best effort to parse whatever string as a > date: that is a heuristic and it should be in another method, not > something as basic as #readFrom:. Maybe call the method guessFrom: > aStream ;-) I agree because in 10 years we will have to <30 and it is plain wrong anyway :) Stef > > Cheers > > Matthias > > On Sat, Jan 16, 2010 at 10:57 AM, StÃ©phane Ducasse > <stephane.ducasse(a)inria.fr> wrote: >> hi guys >> >> can one of you give a look at the this fix because I'm confused. Kernel-DavidHotham.538 >> >> year < 20 ifTrue: [year := 2000 + year] >> was >> year < 10 ifTrue: [year := 2000 + year] >> >> both solutions look strange to me. >> >> http://code.google.com/p/pharo/issues/detail?id=1749 >> >> >> readFrom: aStream >> "Read a Date from the stream in any of the forms: >> <day> <monthName> <year> (5 April 1982; 5-APR-82) >> <monthName> <day> <year> (April 5, 1982) >> <monthNumber> <day> <year> (4/5/82) >> <day><monthName><year> (5APR82)" >> | day month year | >> aStream peek isDigit >> ifTrue: [day := Integer readFrom: aStream]. >> [aStream peek isAlphaNumeric] >> whileFalse: [aStream skip: 1]. >> aStream peek isLetter >> ifTrue: ["number/name... or name..." >> month := (String new: 10) writeStream. >> [aStream peek isLetter] >> whileTrue: [month nextPut: aStream next]. >> month := month contents. >> day isNil >> ifTrue: ["name/number..." >> [aStream peek isAlphaNumeric] >> whileFalse: [aStream skip: 1]. >> day := Integer readFrom: aStream]] >> ifFalse: ["number/number..." >> month := Month nameOfMonth: day. >> day := Integer readFrom: aStream]. >> [aStream peek isAlphaNumeric] >> whileFalse: [aStream skip: 1]. >> year := Integer readFrom: aStream. >>>> year < 20 ifTrue: [year := 2000 + year] >> ifFalse: [ year < 1900 ifTrue: [ year := 1900 + year]]. >> >> ^ self >> year: year >> month: month >> day: day >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 16, 2010

[Pharo-project] [update 1.1] #11162

by StÃ©phane Ducasse

11162 ----- - Issue 1827: 11161 Test greener - Issue 1823: MC does not need to browse all ancestor just to show changes (from squeak) - Issue 1822: MimeConverter (from Squeak) - Issue 1830: Small Project cleanup - Issue 1818: clean changeset isolation protocol - Issue 1833: remove uninstall changeset since it is quite sure that most of the time it will break. - Issue 1831: remove carefully invokePhase1 and invokePhase2 I have the feeling that we are going fast and making real progress. More to come. Thanks for your feedback and submissions. Stef

Jan. 16, 2010

Re: [Pharo-project] Toyota like process for 1.1

by Levente Uzonyi

On Sat, 16 Jan 2010, StÃ©phane Ducasse wrote: > issue 1827 soon in 11162 > > Fixed > - testComplIsSelfEvaluating removed the compiledMethod from the array since the store on probably changed and > compiled methods are not self evaluating > > SimpleSwicthMorph>>testName removed (no external name anymore) > > AuthorTest>>testDeprecation removed (since the methods are not there anymore) > > > Changed last line since a test should not rely on something on the harddisc > > testIsFontAvailable > "self debug: #testIsFontAvailable" > (Locale isoLanguage: 'ja') languageEnvironment removeFonts. > self assert: (Locale isoLanguage: 'en') languageEnvironment isFontAvailable. > "Next test should fail after installing Japanese font" > self assert: (Locale isoLanguage: 'ja') languageEnvironment isFontAvailable not. > (Locale isoLanguage: 'ja') languageEnvironment installFont. > self assert: (Locale isoLanguage: 'ja') languageEnvironment isFontAvailable not > > > TextDiffBuilderTest>>expectedFailures > "these tests are for the new TextDiffBuilder that should be integrated from Squeak-trunk" To be exact, these are broken with the current implementation. Integrating the new TextDiffBuilder should be easy. Levente > > ^ #(testIfPatchIsMinimal testIfSequence4 testIfSequence6) > > > more to come > > Stef > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 16, 2010