April 2009 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] First contribution...

by Alexandre Bergel

In a Monticello browser, if you select OB-Standard on the left hand side pane, you should see the wiresong repository on the right hand side. Just select it and press 'save'. Alexandre On 29 Apr 2009, at 22:55, Hernan Wilkinson wrote: > Thanks Alex. > How do I save it on source.wiresong.ca/ob ? > > On Wed, Apr 29, 2009 at 2:52 PM, Alexandre Bergel > <alexandre(a)bergel.eu> wrote: > Hi Hernan, > > I read your change and it makes fully sense. However, I suggest you to > save it on source.wiresong.ca/ob. > I think it was agreed that only core packages must be committed in > PharoInbox. > > Probably the test on the website should be adjusted. Shall I do it? > > Cheers, > Alexandre > > On 29 Apr 2009, at 15:58, Hernan Wilkinson wrote: > > > Hi, > > I just made my first contribution!! (not a big deal, just a small > > fix anyway...), but I feel kind of stupid because I can not change > > the issues's status from new to fixed... (as the "how to contribute > > page" says). Could somebody tell me how? The issue is the 781 > > > > Thanks, > > Hernan. > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 29, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by Alexandre Bergel

Does not work for me. The problem is probably different. I still get a 'Socket status must Unconnected before opening a new connection' Alexandre On 29 Apr 2009, at 21:39, Nicolas Cellier wrote: > Could you test if this fix works: > > PharoInbox/SLICE-M7343-Socket-Rollover-bug-nice.2 > > 2009/4/29 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: >> OK guys, I think you loaded my rollover stuff... >> Mea maxima culpa: >> >> #waitForDataUntil: and #waitForDataFor: DID NOT DO THE SAME THING! >> >> the former signals ConnectionClosed, while the later silently >> answer false... >> >> The reason it works on windws is probably I did not load my change (I >> used a different image...). >> >> Strangely, I used Monticello on squeaksource without encountering >> this bug... >> >> Nicolas >> >> 2009/4/29 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: >>> Also note that it fails at the end of the progress bar. >>> And inspecting response tempVar in HTTPSocket>>getRestOfBuffer: >>> leads to: >>> >>> collection copyFrom: readLimit-100 to: readLimit -> >>> 'Standard.39-cwp.1.mcz</a> 18-Aug-2006 19:38 >>> 50K >>> <hr></pre> >>> </body></html> >>> ' >>> >>> I don't want to learn anything about http protocol, but it sounds >>> like >>> the whole stream was correctly retrieved. >>> That means something has changed in the order things are processed. >>> We should test if it is a matter of VM or in image change. >>> >>> Nicolas >>> >>> 2009/4/29 Michael Rueger <m.rueger(a)acm.org>: >>>> Nicolas Cellier wrote: >>>>> I confirm it works on windows and fails on linux (exupery VM) >>>> >>>> as it also fails on Mac it seems it could be the Unix socket code? >>>> >>>> Michael >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 29, 2009

Re: [Pharo-project] First contribution...

by Adrian Lienhard

Hi Hernan, On Apr 29, 2009, at 22:53 , Hernan Wilkinson wrote: > On Wed, Apr 29, 2009 at 4:49 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr >> wrote: > >> Welcome hernan :) >> if you plan (which I hope) to contribute to pharo please sign the >> license agreement available on the wiki. > > > I tried but I did not know how to do it... do I just post my name in > "Comments"? not really ;) You can find the document here: http://pharo.gforge.inria.fr/licenseDocuments/ The idea is to print it, sign it, and then mail it to Stef. Adrian > > >> >> >> >>> Hi, >>> I just made my first contribution!! (not a big deal, just a small >>> fix anyway...), but I feel kind of stupid because I can not change >>> the issues's status from new to fixed... (as the "how to contribute >>> page" says). Could somebody tell me how? The issue is the 781 >>> >>> Thanks, >>> Hernan. >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

April 29, 2009

Re: [Pharo-project] First contribution...

by Hernan Wilkinson

Thanks Alex.How do I save it on source.wiresong.ca/ob ?<http://source.wiresong.ca/ob> On Wed, Apr 29, 2009 at 2:52 PM, Alexandre Bergel <alexandre(a)bergel.eu>wrote: > Hi Hernan, > > I read your change and it makes fully sense. However, I suggest you to > save it on source.wiresong.ca/ob. > I think it was agreed that only core packages must be committed in > PharoInbox. > > Probably the test on the website should be adjusted. Shall I do it? > > Cheers, > Alexandre > > On 29 Apr 2009, at 15:58, Hernan Wilkinson wrote: > > > Hi, > > I just made my first contribution!! (not a big deal, just a small > > fix anyway...), but I feel kind of stupid because I can not change > > the issues's status from new to fixed... (as the "how to contribute > > page" says). Could somebody tell me how? The issue is the 781 > > > > Thanks, > > Hernan. > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 29, 2009

Re: [Pharo-project] First contribution...

by Hernan Wilkinson

On Wed, Apr 29, 2009 at 4:49 PM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr > wrote: > Welcome hernan :) > if you plan (which I hope) to contribute to pharo please sign the > license agreement available on the wiki. I tried but I did not know how to do it... do I just post my name in "Comments"? > > > > > Hi, > > I just made my first contribution!! (not a big deal, just a small > > fix anyway...), but I feel kind of stupid because I can not change > > the issues's status from new to fixed... (as the "how to contribute > > page" says). Could somebody tell me how? The issue is the 781 > > > > Thanks, > > Hernan. > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 29, 2009

Re: [Pharo-project] run all tests from superClass

by Nicolas Cellier

Maybe add a switch runSuperTests "Tells whether test from superclass should be run. By default, this is true. If you don't want to run superclass tests, redefine this as false in your subclass." ^true 2009/4/29 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: > HI guys > > I was coding this afternoon with Cyrille who is working a lot to > improve the test coverage of collections. > And we found a bit strange that when a testcase inherits from another > one the tests of the superclass are not run. > I checked a bit SUnit code and superclass testmethods are only run is > the superclass is abstract or if there are not testmethods. > Imagine > BagTest > IdentityBagTest > > > We could redefine buildSuite on BagTest to invoke allSelectors > but this means in essence that we could do it on a lot of potential > testcase classes that may be subclasses. > > Or we could redefine buildSuite on IdentyBagTest but this means that > the subclasses should specify it. > May be this solution is the best but I wanted to get your thoughts. > > Of course this idea of inheriting test case make sense when superclass > setup can be reused in subclasses one. > So the default behavior of buildSuite always invoking all testmethods > may not be so good but then > via subclassing from BagTest if this is not to reuse it. > > Stef > > > On Apr 29, 2009, at 6:04 PM, Cyrille Delaunay wrote: > >> A change have been saved in 'PharoInBox' for class TestCase in >> package SUnit >> so that suite are now built from allSelectors. >> This makes sense when you have testcase classes which inherits from >> each other and have parametrized (hook-based) setup. >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 29, 2009

Re: [Pharo-project] About Mantis 7343 socket timeout rollover

by Nicolas Cellier

BEWARE: PharoInbox/SLICE-M7343-Socket-Rollover-bug-nice.1 is bogus because there were subtle difference between wait*Until: family and wait*For: family. The former did silently return false on timeout/closed connection. The later did signal an error... USE PharoInbox/SLICE-M7343-Socket-Rollover-bug-nice.2 2009/4/29 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: > http://code.google.com/p/pharo/issues/detail?id=778 > > > On Apr 28, 2009, at 10:25 PM, Nicolas Cellier wrote: > >> PharoInbox/SLICE-M7343-Socket-Rollover-bug-nice.1 >> >> After http://bugs.squeak.org/view.php?id=7343 >> Socket timeout can suffer rollover problem >> (Happens on server with high load and uptime>12 days) >> >> I did not load Andreas change directly >> 1) He still uses questionnable (deadline - Time millisecondClockValue) >> which is potentially >0 forever >> 2) because of above choice, he protected with unecessary 500msecs >> busy loop >> (well necessary in this implementation, but not in absolute) >> 3) he does not answer true when ok: HTTPSocket requires this... >> >> I moved the *Until: family message to a deprecated category, but did >> not send (self deprecated: ...) >> I corrected in image senders. >> Do not remove now, they might be used by packages. > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 29, 2009

Re: [Pharo-project] First contribution...

by StÃ©phane Ducasse

Welcome hernan :) if you plan (which I hope) to contribute to pharo please sign the license agreement available on the wiki. > Hi, > I just made my first contribution!! (not a big deal, just a small > fix anyway...), but I feel kind of stupid because I can not change > the issues's status from new to fixed... (as the "how to contribute > page" says). Could somebody tell me how? The issue is the 781 > > Thanks, > Hernan. > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

April 29, 2009

Re: [Pharo-project] run all tests from superClass

by StÃ©phane Ducasse

HI guys I was coding this afternoon with Cyrille who is working a lot to improve the test coverage of collections. And we found a bit strange that when a testcase inherits from another one the tests of the superclass are not run. I checked a bit SUnit code and superclass testmethods are only run is the superclass is abstract or if there are not testmethods. Imagine BagTest IdentityBagTest We could redefine buildSuite on BagTest to invoke allSelectors but this means in essence that we could do it on a lot of potential testcase classes that may be subclasses. Or we could redefine buildSuite on IdentyBagTest but this means that the subclasses should specify it. May be this solution is the best but I wanted to get your thoughts. Of course this idea of inheriting test case make sense when superclass setup can be reused in subclasses one. So the default behavior of buildSuite always invoking all testmethods may not be so good but then via subclassing from BagTest if this is not to reuse it. Stef On Apr 29, 2009, at 6:04 PM, Cyrille Delaunay wrote: > A change have been saved in 'PharoInBox' for class TestCase in > package SUnit > so that suite are now built from allSelectors. > This makes sense when you have testcase classes which inherits from > each other and have parametrized (hook-based) setup. > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 29, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by Nicolas Cellier

Could you test if this fix works: PharoInbox/SLICE-M7343-Socket-Rollover-bug-nice.2 2009/4/29 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: > OK guys, I think you loaded my rollover stuff... > Mea maxima culpa: > > #waitForDataUntil: and #waitForDataFor: DID NOT DO THE SAME THING! > > the former signals ConnectionClosed, while the later silently answer false... > > The reason it works on windws is probably I did not load my change (I > used a different image...). > > Strangely, I used Monticello on squeaksource without encountering this bug... > > Nicolas > > 2009/4/29 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: >> Also note that it fails at the end of the progress bar. >> And inspecting response tempVar in HTTPSocket>>getRestOfBuffer: leads to: >> >> collection copyFrom: readLimit-100 to: readLimit -> >> 'Standard.39-cwp.1.mcz</a> 18-Aug-2006 19:38 >> 50K >> <hr></pre> >> </body></html> >> ' >> >> I don't want to learn anything about http protocol, but it sounds like >> the whole stream was correctly retrieved. >> That means something has changed in the order things are processed. >> We should test if it is a matter of VM or in image change. >> >> Nicolas >> >> 2009/4/29 Michael Rueger <m.rueger(a)acm.org>: >>> Nicolas Cellier wrote: >>>> I confirm it works on windows and fails on linux (exupery VM) >>> >>> as it also fails on Mac it seems it could be the Unix socket code? >>> >>> Michael >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >

April 29, 2009