April 2009 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] run all tests from superClass

by StÃ©phane Ducasse

Thanks I forgot it. Stef On Apr 30, 2009, at 12:09 AM, Lukas Renggli wrote: > There is already such a switch that can be overridden in TestCase > class>>#shouldInheritSelectors. > > Lukas > > On Wed, Apr 29, 2009 at 10:03 PM, Nicolas Cellier > <nicolas.cellier.aka.nice(a)gmail.com> wrote: >> Maybe add a switch >> runSuperTests >> "Tells whether test from superclass should be run. >> By default, this is true. >> If you don't want to run superclass tests, redefine this as false >> in your subclass." >> >> ^true >> >> 2009/4/29 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: >>> HI guys >>> >>> I was coding this afternoon with Cyrille who is working a lot to >>> improve the test coverage of collections. >>> And we found a bit strange that when a testcase inherits from >>> another >>> one the tests of the superclass are not run. >>> I checked a bit SUnit code and superclass testmethods are only run >>> is >>> the superclass is abstract or if there are not testmethods. >>> Imagine >>> BagTest >>> IdentityBagTest >>> >>> >>> We could redefine buildSuite on BagTest to invoke allSelectors >>> but this means in essence that we could do it on a lot of potential >>> testcase classes that may be subclasses. >>> >>> Or we could redefine buildSuite on IdentyBagTest but this means that >>> the subclasses should specify it. >>> May be this solution is the best but I wanted to get your thoughts. >>> >>> Of course this idea of inheriting test case make sense when >>> superclass >>> setup can be reused in subclasses one. >>> So the default behavior of buildSuite always invoking all >>> testmethods >>> may not be so good but then >>> via subclassing from BagTest if this is not to reuse it. >>> >>> Stef >>> >>> >>> On Apr 29, 2009, at 6:04 PM, Cyrille Delaunay wrote: >>> >>>> A change have been saved in 'PharoInBox' for class TestCase in >>>> package SUnit >>>> so that suite are now built from allSelectors. >>>> This makes sense when you have testcase classes which inherits from >>>> each other and have parametrized (hook-based) setup. >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 30, 2009

Re: [Pharo-project] [FIX] Issue 782: OB is ambiguous when asking to Accept or Discard changes in the code panel

by Adrian Lienhard

On Apr 29, 2009, at 23:48 , Mariano Martinez Peck wrote: > 2009/4/29 Hernan Wilkinson <hernan.wilkinson(a)gmail.com> > >> ups... another question then... where is a list of core pharo >> packages?I >> saw there is a pharo-core image and a pharo (or pharo-dev) image. I >> could >> not find the pharo-core image, the one in the download page is the >> pharo-dev >> image. >> > > In pharo webpage where it says "archive and more...". It is a link > to this: > http://gforge.inria.fr/frs/?group_id=1299 I updated the web page to make this more clear. Adrian

April 30, 2009

Re: [Pharo-project] run all tests from superClass

by Nicolas Cellier

The question is not at all to know if class B inherits from class A. It is that class A and B respond to a common API, whatever the implementation - inheritance or not. In this case, TestA and TestB share a common test protocol for testing the same API. That's why Stef & al started rewriting collection tests by composition with traits. The other more traditional, much simpler (toolwise) but less powerfull way is to use inheritance, so the question makes sense. What I read here indicates you prefer maintaining many duplicates of the test. And when you realize that one of the test was buggy (not the method that is tested, but the test itself), you certainly prefer to track all the copies and probably leave a buggy one here and there... Rethorical debates are fine, but it would be more enlightning to discuss around some chosen examples. Nicolas 2009/4/30 Miguel Enrique CobÃ¡ MartÃnez <miguel.coba(a)gmail.com>: > Hernan Wilkinson wrote: >> I don't think it is a good idea to have hierarchies with test cases... >> depending on how you are doing it, it could couple the test hierarchy >> with the model hierarchy and I don't think that is a good idea... >> It also introduces some complexity, for example the number of tests are >> not only the test methods but for each concrete test class, the test >> methods on it plus the test methods of the abstract superclasses... hmmm >> I don't know, it is not natural at least for me too user inheritance >> with tests... > > +1 > Besides, one of the goals of the testing is to test "external behavior" > of the classes. > This means, to me, that the test cases must test the classes without > knowing if B inherits from A o if both B and C are subclasses of A. > This way, when you for some reason must refactor or reorganize your > classes, the test will not break as long as the external behavior of > them remains unchanged. > > Summary, the inheritance of the classes tested is just an implementation > detail, not something the test cases must care of. > > Cheers, > Miguel CobÃ¡ >> >> On Wed, Apr 29, 2009 at 4:46 PM, StÃ©phane Ducasse >> <stephane.ducasse(a)inria.fr <mailto:stephane.ducasse@inria.fr>> wrote: >> >> Â Â HI guys >> >> Â Â I was coding this afternoon with Cyrille who is working a lot to >> Â Â improve the test coverage of collections. >> Â Â And we found a bit strange that when a testcase inherits from another >> Â Â one the tests of the superclass are not run. >> Â Â I checked a bit SUnit code and superclass testmethods are only run is >> Â Â the superclass is abstract or if there are not testmethods. >> Â Â Imagine >> Â Â Â Â Â Â BagTest >> Â Â Â Â Â Â Â Â Â Â IdentityBagTest >> >> >> Â Â We could redefine buildSuite on BagTest to invoke allSelectors >> Â Â but this means in essence that we could do it on a lot of potential >> Â Â testcase classes that may be subclasses. >> >> Â Â Or we could redefine buildSuite on IdentyBagTest but this means that >> Â Â the subclasses should specify it. >> Â Â May be this solution is the best but I wanted to get your thoughts. >> >> Â Â Of course this idea of inheriting test case make sense when superclass >> Â Â setup can be reused in subclasses one. >> Â Â So the default behavior of buildSuite always invoking all testmethods >> Â Â may not be so good but then >> Â Â via subclassing from BagTest if this is not to reuse it. >> >> Â Â Stef >> >> >> Â Â On Apr 29, 2009, at 6:04 PM, Cyrille Delaunay wrote: >> >> Â Â Â > A change have been saved in 'PharoInBox' for class TestCase in >> Â Â Â > package SUnit >> Â Â Â > so that suite are now built from allSelectors. >> Â Â Â > This makes sense when you have testcase classes which inherits from >> Â Â Â > each other and have parametrized (hook-based) setup. >> Â Â Â > >> Â Â Â > >> Â Â Â > _______________________________________________ >> Â Â Â > Pharo-project mailing list >> Â Â Â > Pharo-project(a)lists.gforge.inria.fr >> Â Â <mailto:Pharo-project@lists.gforge.inria.fr> >> Â Â Â > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> Â Â Â > >> >> >> Â Â _______________________________________________ >> Â Â Pharo-project mailing list >> Â Â Pharo-project(a)lists.gforge.inria.fr >> Â Â <mailto:Pharo-project@lists.gforge.inria.fr> >> Â Â http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 30, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by John M McIntosh

The Socket allInstances size inspect should go in the exception handler block before it throws the execption you don't want to see. On 29-Apr-09, at 8:58 PM, Cameron Sanders wrote: > Alexandre, you did mention having #port: sent to a ByteArray. It looks > like the last line of > FTPClient>>openPassiveDataConnection should be: > self openDataSocket: remoteHostAddress asSocketAddress port: dataPort > > instead of (current code): > self openDataSocket: remoteHostAddress port: dataPort > > With that change, the system drills on down and has a primitive > failure in #port (on a Mac). > > I will add "Socket allInstances size inspect" just above the #port: > method in Socket>>connectTo:port:. > > ... and the answer is SmallInteger: 7. > Anything else I should inspect in here? > > -Cam > PS: I am coming at this from the Monticello/FTP side, because my code > is on an ftp server. -- = = = ======================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================

April 30, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by David T. Lewis

On Wed, Apr 29, 2009 at 08:40:37PM -0700, John M McIntosh wrote: > > In this problem area, if we consider the socket creation fails because > the number of sockets allocated has reached the limit (aka unix limit) > not seen in windows. > then this is because either (a) we are actualy holding onto thousands > of sockets on purpose? > Or we have 1, and thousands of zombies that have been tenured to > OldSpace but not yet GCed, and Unix is unhappy with us. I don't know if this is available on OS X, but on some unices (Linux for sure), a good way to check this out is by looking at the open file descriptors listed in the /proc file system. So for example if you have Squeak running in a process with pid 1234, you can see the open file descriptors with "$ ls -l /proc/1234/fd/*". > Now when the socket create fails that causes well another pointless > attempt at creation (why?) but also a full GC. > The full GC will of course signal to the 'WeakArray finalization > process' for it to gently destroy sockets. And of course relying on finalization to close file/socket handles is a sure-fire way to get into trouble. So if you find lots of open file descriptors in /proc/1234/fd/* that do not correspond to anything being used in the image, then yes you probably do have this kind of issue. On the other hand, if you can see that the number of open file descriptors is well below 1024 (or whatever the limit is on your platform) then the problem lies elsewhere. Dave

April 30, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by Cameron Sanders

Where do I reduce that priority? -cam On Apr 29, 2009, at 11:40 PM, John M McIntosh wrote: > But let's consider what's NEW here is the 'input events fetching > process' is now running at 2x the speed of the older UI process and > consuming 10-30% of the cpu? > I'm not sure why before it was acceptable to look every 1/50 second, > but now it has to be every 1/100 of a second. > > But it's interesting that it''s running at priority 60, which means > it's sucking CPU away from the weak array finalization process.

April 30, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by Cameron Sanders

Alexandre, you did mention having #port: sent to a ByteArray. It looks like the last line of FTPClient>>openPassiveDataConnection should be: self openDataSocket: remoteHostAddress asSocketAddress port: dataPort instead of (current code): self openDataSocket: remoteHostAddress port: dataPort With that change, the system drills on down and has a primitive failure in #port (on a Mac). I will add "Socket allInstances size inspect" just above the #port: method in Socket>>connectTo:port:. ... and the answer is SmallInteger: 7. Anything else I should inspect in here? -Cam PS: I am coming at this from the Monticello/FTP side, because my code is on an ftp server. On Apr 29, 2009, at 5:00 PM, Alexandre Bergel wrote: > Does not work for me. The problem is probably different. I still get a > 'Socket status must Unconnected before opening a new connection' > > Alexandre > > > On 29 Apr 2009, at 21:39, Nicolas Cellier wrote: > >> Could you test if this fix works: >> >> PharoInbox/SLICE-M7343-Socket-Rollover-bug-nice.2 >> >> 2009/4/29 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: >>> OK guys, I think you loaded my rollover stuff... >>> Mea maxima culpa: >>> >>> #waitForDataUntil: and #waitForDataFor: DID NOT DO THE SAME THING! >>> >>> the former signals ConnectionClosed, while the later silently >>> answer false... >>> >>> The reason it works on windws is probably I did not load my change >>> (I >>> used a different image...). >>> >>> Strangely, I used Monticello on squeaksource without encountering >>> this bug... >>> >>> Nicolas >>> >>> 2009/4/29 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: >>>> Also note that it fails at the end of the progress bar. >>>> And inspecting response tempVar in HTTPSocket>>getRestOfBuffer: >>>> leads to: >>>> >>>> collection copyFrom: readLimit-100 to: readLimit -> >>>> 'Standard.39-cwp.1.mcz</a> 18-Aug-2006 19:38 >>>> 50K >>>> <hr></pre> >>>> </body></html> >>>> ' >>>> >>>> I don't want to learn anything about http protocol, but it sounds >>>> like >>>> the whole stream was correctly retrieved. >>>> That means something has changed in the order things are processed. >>>> We should test if it is a matter of VM or in image change. >>>> >>>> Nicolas >>>> >>>> 2009/4/29 Michael Rueger <m.rueger(a)acm.org>: >>>>> Nicolas Cellier wrote: >>>>>> I confirm it works on windows and fails on linux (exupery VM) >>>>> >>>>> as it also fails on Mac it seems it could be the Unix socket code? >>>>> >>>>> Michael >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>>> >>>> >>> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

April 30, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by John M McIntosh

Further to this I"m wondering if there is something else "clever" going on. Should the finalization process run at priority 61? See WeakArray>>restartFinalizationProcess Perhaps someone can check that? Let me ramble on... In the past you had the event polling going on at prioirty 40 in the 'UI process' That would grind away... You also had the 'event tickler' that ran every 500 ms at priority 60. And there in the middle why the key player here, the 'WeakArray finalization process' at 50 In this problem area, if we consider the socket creation fails because the number of sockets allocated has reached the limit (aka unix limit) not seen in windows. then this is because either (a) we are actualy holding onto thousands of sockets on purpose? Or we have 1, and thousands of zombies that have been tenured to OldSpace but not yet GCed, and Unix is unhappy with us. Now when the socket create fails that causes well another pointless attempt at creation (why?) but also a full GC. The full GC will of course signal to the 'WeakArray finalization process' for it to gently destroy sockets. But let's consider what's NEW here is the 'input events fetching process' is now running at 2x the speed of the older UI process and consuming 10-30% of the cpu? I'm not sure why before it was acceptable to look every 1/50 second, but now it has to be every 1/100 of a second. But it's interesting that it''s running at priority 60, which means it's sucking CPU away from the weak array finalization process. Now as we know the weak array finalization process is rather cpu intensive, so I wonder if there is just enough CPU taken away from finalization process so that it can't do enough work before the retry for the socket allocation leaps in and fails for a final time? Well of course I'm not sure why the finalization process wouldn't finalize all the zombie sockets in one go when the full gc completes, but that would require some more testing... On 29-Apr-09, at 8:09 PM, John M McIntosh wrote: > Er maybe someone doing the testing can stick a > Socket allInstances size inspect > in at the pointer where the exception is signaled. I think it would > be enlightening what the value is. > > On 29-Apr-09, at 7:52 PM, Cameron Sanders wrote: > >> Socket status must Unconnected before opening a new >> connection > > -- > = > = > = > = > = > ====================================================================== > John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: > squeaker68882 > Corporate Smalltalk Consulting Ltd. http:// > www.smalltalkconsulting.com > = > = > = > = > = > ====================================================================== > > > > -- = = = ======================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================

April 30, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by John M McIntosh

Er maybe someone doing the testing can stick a Socket allInstances size inspect in at the pointer where the exception is signaled. I think it would be enlightening what the value is. On 29-Apr-09, at 7:52 PM, Cameron Sanders wrote: > Socket status must Unconnected before opening a new > connection -- = = = ======================================================================== John M. McIntosh <johnmci(a)smalltalkconsulting.com> Twitter: squeaker68882 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================

April 30, 2009

Re: [Pharo-project] Monticello/ftp stopped working for me

by Cameron Sanders

Don't worry, I "get it" from the logical view. I just wondered if it was related to 'Socket status must Unconnected before opening a new connection'. -cam On Apr 29, 2009, at 10:27 PM, Cameron Sanders wrote: > Maybe I'm just sleep deprived... but, the method isUnconnected looks > odd. Perhaps it is correct, and there is a good reason for the > implementation, but "socketHandle == nil ifTrue: [^false ]" seems > counter-intuitive. If socketHandle is not defined, then, it seems, we > probably not connected... and hence should answer true. > > My apologies if I am not thinking clearly... or if it is simply more > complex handle management. > > Socket >> > isUnconnected > "Return true if this socket's state is Unconnected." > > socketHandle == nil ifTrue: [^ false]. > ^ (self primSocketConnectionStatus: socketHandle) == Unconnected > > -Cam > > On Apr 29, 2009, at 5:00 PM, Alexandre Bergel wrote: > >> Does not work for me. The problem is probably different. I still >> get a >> 'Socket status must Unconnected before opening a new connection' >> > > Per > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

April 30, 2009