April 2009 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] SUnit History

by Alexandre Bergel

Hi Lukas, Thanks for your review. We made this in a couple of days. You suggested some cool changes, indeed. Cheers, Alexandre On 1 Apr 2009, at 12:07, Lukas Renggli wrote: > I have a few questions to the authors of the SUnit History feature: > > 1. I noticed is that all the results are stored in a dictionary of > TestResult mapping the classes to their last result. When I delete > tests, these obsolete classes remain references from the dictionary > and thus never get garbage collected. Why not save the history in a > class-instance variable of the TestCase itself? That would even make > the code much simpler. > > 2. Why to store the history of test results in nested dictionaries, > sets and arrays? We have a nice TestResult object that remembers > exactly the same information and additionally allows to do all kinds > of queryies like #hasFailures, hasPassed, ... I see that there is one > problem here: the current implementation of TestResult remembers the > test case instances, and thus would reference potentially a lot of > unnecessary state. Maybe TestResult should only remember the method > references of the tests, instead of the test cases? I guess that would > solve other problems people regularly report with SUnit as well. > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

April 1, 2009

Re: [Pharo-project] Changing the size of a font

by Damien Cassou

On Wed, Apr 1, 2009 at 11:24 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > you see damien :) that's why you are a Professor and I'm a student ;-) -- Damien Cassou http://damiencassou.seasidehosting.st

April 1, 2009

Re: [Pharo-project] SUnit History

by Lukas Renggli

3. Why the heck is the timestamp of the last run a String :-( On Wed, Apr 1, 2009 at 12:07 PM, Lukas Renggli <renggli(a)gmail.com> wrote: > I have a few questions to the authors of the SUnit History feature: > > 1. I noticed is that all the results are stored in a dictionary of > TestResult mapping the classes to their last result. When I delete > tests, these obsolete classes remain references from the dictionary > and thus never get garbage collected. Why not save the history in a > class-instance variable of the TestCase itself? That would even make > the code much simpler. > > 2. Why to store the history of test results in nested dictionaries, > sets and arrays? We have a nice TestResult object that remembers > exactly the same information and additionally allows to do all kinds > of queryies like #hasFailures, hasPassed, ... I see that there is one > problem here: the current implementation of TestResult remembers the > test case instances, and thus would reference potentially a lot of > unnecessary state. Maybe TestResult should only remember the method > references of the tests, instead of the test cases? I guess that would > solve other problems people regularly report with SUnit as well. > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > -- Lukas Renggli http://www.lukas-renggli.ch

April 1, 2009

[Pharo-project] SUnit History

by Lukas Renggli

I have a few questions to the authors of the SUnit History feature: 1. I noticed is that all the results are stored in a dictionary of TestResult mapping the classes to their last result. When I delete tests, these obsolete classes remain references from the dictionary and thus never get garbage collected. Why not save the history in a class-instance variable of the TestCase itself? That would even make the code much simpler. 2. Why to store the history of test results in nested dictionaries, sets and arrays? We have a nice TestResult object that remembers exactly the same information and additionally allows to do all kinds of queryies like #hasFailures, hasPassed, ... I see that there is one problem here: the current implementation of TestResult remembers the test case instances, and thus would reference potentially a lot of unnecessary state. Maybe TestResult should only remember the method references of the tests, instead of the test cases? I guess that would solve other problems people regularly report with SUnit as well. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

April 1, 2009

[Pharo-project] [ANN] #10262cl

by Torsten Bergmann

On 01.04.2009, at 11:29, StÃ©phane Ducasse wrote: > Apparently this is realted to the bug I mentioned can you test the > fixes that mike sent. Yes it fixes the problem: '~test' encodeForHTTP now does not give an DNU anymore and OB is loading. Thx Torsten -- Psssst! Schon vom neuen GMX MultiMessenger gehÃ¶rt? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

April 1, 2009

Re: [Pharo-project] [ANN] #10262cl

by Marcus Denker

On 01.04.2009, at 11:29, StÃ©phane Ducasse wrote: > Apparently this is realted to the bug I mentioned can you test the > fixes that mike sent. I added that to the tracker: http://code.google.com/p/pharo/issues/detail?id=706 -- Marcus Denker -- denker(a)acm.org http://www.marcusdenker.de

April 1, 2009

Re: [Pharo-project] about the closure

by Marcus Denker

On 01.04.2009, at 11:31, StÃ©phane Ducasse wrote: > > On Apr 1, 2009, at 11:12 AM, Lukas Renggli wrote: > >>> lukas is it normal that we get 3 tests yellow - did you get the same >>> in your image? >> >> #testToDoOutsideTemp and #testWhileModificationBefore are broken. I >> don't think that should stop us from integrating the closures into >> Pharo. Most "industrial strength" Smalltalk implementations have many >> more closure bugs than Pharo. > > This is integrated already and this is good to have such great test > suites. > I will integrate them this evening. > Lukas' teste should be already in, I think. Marcus -- Marcus Denker -- denker(a)acm.org http://www.marcusdenker.de

April 1, 2009

Re: [Pharo-project] how do replace barVal by barValTmp in a method?

by Lukas Renggli

With the regular expression extensions to OB-Refactory it is possible to search and replace strings across a selected set of methods. I understand that this is not what you want either, but I like the feature ;-) Lukas On Wed, Apr 1, 2009 at 11:31 AM, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > Yes I should have asked without using rb. > I think that any texteditor should have that feature :) > > Stef > > On Apr 1, 2009, at 11:05 AM, Lukas Renggli wrote: > >> The refactoring browser provides "refactor code > rename temporary". >> Make sure to have a temporary variable selected before trying to >> invoke that command. >> >> Lukas >> >> On Tue, Mar 31, 2009 at 9:38 PM, StÃ©phane Ducasse >> <stephane.ducasse(a)inria.fr> wrote: >>> Hi >>> >>> this is several time that I need such simple edit function and I do >>> not suceed. >>> Does one of you know how do replace barVal by barValTmp in a method? >>> >>> Setf >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> >> -- >> Lukas Renggli >> http://www.lukas-renggli.ch >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

April 1, 2009

Re: [Pharo-project] isMorphic left over

by StÃ©phane Ducasse

Thanks marcus. I should undertsand how to get internet in TGV On Apr 1, 2009, at 11:21 AM, Marcus Denker wrote: > > On 31.03.2009, at 20:56, StÃ©phane Ducasse wrote: > >> While playing with closure I got some isMorphic so I cleaned that. >> > > > http://code.google.com/p/pharo/issues/detail?id=703 > > -- > Marcus Denker -- denker(a)acm.org > http://www.marcusdenker.de > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

April 1, 2009

Re: [Pharo-project] about the closure

by StÃ©phane Ducasse

On Apr 1, 2009, at 11:12 AM, Lukas Renggli wrote: >> lukas is it normal that we get 3 tests yellow - did you get the same >> in your image? > > #testToDoOutsideTemp and #testWhileModificationBefore are broken. I > don't think that should stop us from integrating the closures into > Pharo. Most "industrial strength" Smalltalk implementations have many > more closure bugs than Pharo. This is integrated already and this is good to have such great test suites. I will integrate them this evening. > > >> Did you say it to eliot? > > Eliot already fixed the third failure you are observing. Load the > attached change-set and recompile the tests. > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > <TempVariableNode- > analyseClosure.st>_______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

April 1, 2009