October 2009 - Pharo-dev - lists.pharo.org

[Pharo-project] Error getting parseTree formattedCode

by StÃ©phane Ducasse

> From: Lukas Renggli <renggli(a)gmail.com> > Date: October 11, 2009 3:27:38 PM GMT+02:00 > To: Pharo-project(a)lists.gforge.inria.fr > Subject: Re: [Pharo-project] Error getting parseTree formattedCode > Reply-To: Pharo-project(a)lists.gforge.inria.fr > > > The AST package is in an desolate state. There are dozens of methods > that are never used or broken. Part of the NewCompiler infrastructure > is merged into the AST package, so it is not exactly easy to see what > parts are used, what parts are covered by tests, and what parts are > obsolete. > > Lukas argh. Thanks lukas for the update. Stef

Oct. 11, 2009

[Pharo-project] Fwd: [ANN] new pharo core uploaded based on 10470

by StÃ©phane Ducasse

Oct. 11, 2009

[Pharo-project] New Pharo based on core 10470 - Win32 Install

by Torsten Bergmann

is up on http://www.pharo-project.org/pharo-download Bye T. -- GRATIS fÃ¼r alle GMX-Mitglieder: Die maxdome Movie-FLAT! Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01

Oct. 11, 2009

Re: [Pharo-project] Error getting parseTree formattedCode

by Lukas Renggli

The AST package is in an desolate state. There are dozens of methods that are never used or broken. Part of the NewCompiler infrastructure is merged into the AST package, so it is not exactly easy to see what parts are used, what parts are covered by tests, and what parts are obsolete. Lukas 2009/10/11 StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>: > Adrian > > we should pay attention that this may be related to AST > Lukas merged a new version lr-173 > > I tried to recreate a pharo-dev but it crashes. > > Stef > > On Oct 11, 2009, at 12:18 PM, Adrian Lienhard wrote: > >> The most recent Pharo-core image I has no methods #parseTree and >> #formattedCode. What do I miss? >> >> Adrian >> >> On Oct 10, 2009, at 22:33 , Gabriel Brunstein wrote: >> >>> I think there is a bug when you try to get the formattedCode of a >>> parseTree. >>> Try this for example: >>> (Set >> #add:) parseTree formattedCode >>> I'm sure it worked correctly in previous versions of pharo. >>> Any idea? >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

Oct. 11, 2009

Re: [Pharo-project] [BUG]UndefinedObject(Object)>>doesNotUnderstand: #null

by Lukas Renggli

PrimitiveNode and #primitiveNode is referenced by the AST package. Probably used by the NewCompiler. I suggest to get rid of it. If the NewCompiler uses it, it should be packaged with the NewCompiler. #primtiveNode and PrimtiveNode was implemented/referenced by the AST package as well, I killed it too because it is not used by the Refactoring Engine. Lukas 2009/10/11 Adrian Lienhard <adi(a)netstyle.ch>: > CompiledMethod>>primitiveNode refers to PrimitiveNode in Pharo-core. > This method has no senders. Can it be removed? > > Adrian > > > CompiledMethod>>primitiveNode > > Â Â Â Â | primNode n | > Â Â Â Â primNode := PrimitiveNode new num: (n := self primitive). > Â Â Â Â (n = 117 or: [n = 120]) ifTrue: [ > Â Â Â Â Â Â Â Â primNode spec: (self literalAt: 1)]. > Â Â Â Â ^ primNode > > > On Oct 6, 2009, at 17:53 , Lukas Renggli wrote: > >> I think I fixed the issue in the latest AST package. Even >> PrimitiveNode is referenced, it is not really needed anywhere. >> >> Lukas >> >> On Tuesday, October 6, 2009, Damien Cassou <damien.cassou(a)gmail.com> >> wrote: >>> On Tue, Oct 6, 2009 at 8:39 AM, Marcus Denker <denker(a)acm.org> wrote: >>>> Damien, can you add this to the AST package used in the DEV image? >>> >>> Done. Thank you >>> >>> -- >>> Damien Cassou >>> http://damiencassou.seasidehosting.st >>> >>> "Lambdas are relegated to relative obscurity until Java makes them >>> popular by not having them." James Iry >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> -- >> Lukas Renggli >> http://www.lukas-renggli.ch >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

Oct. 11, 2009

Re: [Pharo-project] Closure fixes have reverted changes in the kernel (again)

by StÃ©phane Ducasse

> I started looking at the failing tests and noted that a change > (refactoring of how Traits access the changes/sources) in > CompiledMethod>>getSourceFor:in: have been reverted. I can fix it, but > I wonder which other closure fixes have reverted previous changes that > we applied to Pharo-core. What is the easiest way to review the > changes of the recent closure fixes introduced to Pharo-core? Since > Eliot works against Squeak, I presume, any of his changes may be > problematic and has to be reviewed. The best things would be to take the image just before the fixes and merge the package we pushed in. indeed this is important to do that. Stef

Oct. 11, 2009

Re: [Pharo-project] [BUG]UndefinedObject(Object)>>doesNotUnderstand: #null

by Adrian Lienhard

CompiledMethod>>primitiveNode refers to PrimitiveNode in Pharo-core. This method has no senders. Can it be removed? Adrian CompiledMethod>>primitiveNode | primNode n | primNode := PrimitiveNode new num: (n := self primitive). (n = 117 or: [n = 120]) ifTrue: [ primNode spec: (self literalAt: 1)]. ^ primNode On Oct 6, 2009, at 17:53 , Lukas Renggli wrote: > I think I fixed the issue in the latest AST package. Even > PrimitiveNode is referenced, it is not really needed anywhere. > > Lukas > > On Tuesday, October 6, 2009, Damien Cassou <damien.cassou(a)gmail.com> > wrote: >> On Tue, Oct 6, 2009 at 8:39 AM, Marcus Denker <denker(a)acm.org> wrote: >>> Damien, can you add this to the AST package used in the DEV image? >> >> Done. Thank you >> >> -- >> Damien Cassou >> http://damiencassou.seasidehosting.st >> >> "Lambdas are relegated to relative obscurity until Java makes them >> popular by not having them." James Iry >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 11, 2009

[Pharo-project] Closure fixes have reverted changes in the kernel (again)

by Adrian Lienhard

I started looking at the failing tests and noted that a change (refactoring of how Traits access the changes/sources) in CompiledMethod>>getSourceFor:in: have been reverted. I can fix it, but I wonder which other closure fixes have reverted previous changes that we applied to Pharo-core. What is the easiest way to review the changes of the recent closure fixes introduced to Pharo-core? Since Eliot works against Squeak, I presume, any of his changes may be problematic and has to be reviewed. Cheers, Adrian ___________________ http://www.adrian-lienhard.ch/

Oct. 11, 2009

[Pharo-project] New Pharo based on core 10470

by Damien Cassou

New version of Pharo: http://pharo-project.org/pharo-download -- Damien Cassou http://damiencassou.seasidehosting.st "Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry

Oct. 11, 2009

Re: [Pharo-project] Error getting parseTree formattedCode

by StÃ©phane Ducasse

Adrian we should pay attention that this may be related to AST Lukas merged a new version lr-173 I tried to recreate a pharo-dev but it crashes. Stef On Oct 11, 2009, at 12:18 PM, Adrian Lienhard wrote: > The most recent Pharo-core image I has no methods #parseTree and > #formattedCode. What do I miss? > > Adrian > > On Oct 10, 2009, at 22:33 , Gabriel Brunstein wrote: > >> I think there is a bug when you try to get the formattedCode of a >> parseTree. >> Try this for example: >> (Set >> #add:) parseTree formattedCode >> I'm sure it worked correctly in previous versions of pharo. >> Any idea? >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 11, 2009