January 2009 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Big problem with the implementation of traits

by Adrian Lienhard

ok, I'll see what I can do... BTW, why is this so pressing now? This bug has existed for four years. Adrian On Jan 15, 2009, at 18:11 , Damien Cassou wrote: > On Thu, Jan 15, 2009 at 4:47 PM, Adrian Lienhard <adi(a)netstyle.ch> > wrote: >> No. This will remove the duplicates, but in case traits are removed >> from classes you can still get wrong results if this happens for a >> class with a users set that is inconsistent. > > So, we really need your fix. > > -- > Damien Cassou > http://damiencassou.seasidehosting.st > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 15, 2009

Re: [Pharo-project] Big problem with the implementation of traits

by Damien Cassou

On Thu, Jan 15, 2009 at 4:47 PM, Adrian Lienhard <adi(a)netstyle.ch> wrote: > No. This will remove the duplicates, but in case traits are removed > from classes you can still get wrong results if this happens for a > class with a users set that is inconsistent. So, we really need your fix. -- Damien Cassou http://damiencassou.seasidehosting.st

Jan. 15, 2009

Re: [Pharo-project] Big problem with the implementation of traits

by Adrian Lienhard

On Jan 15, 2009, at 15:43 , Damien Cassou wrote: > On Thu, Jan 15, 2009 at 3:13 PM, Adrian Lienhard <adi(a)netstyle.ch> > wrote: >> The hash of traits is not related to the problem. The problem is that >> classes show up multiple times in IdentitySets. >> >> I found the cause (its a bit complicated to explain because related >> to >> the ClassBuilder and become:). I can fix that during the weekend... > > I've implemented a TraitBehavior>>nsUsers method which does > > nsUsers > ^ self users asOrderedCollection asSet > > to work around the problem for the article. Can you confirm that this > is a valid workaround? No. This will remove the duplicates, but in case traits are removed from classes you can still get wrong results if this happens for a class with a users set that is inconsistent. Adrian

Jan. 15, 2009

Re: [Pharo-project] Big problem with the implementation of traits

by Damien Cassou

On Thu, Jan 15, 2009 at 3:13 PM, Adrian Lienhard <adi(a)netstyle.ch> wrote: > The hash of traits is not related to the problem. The problem is that > classes show up multiple times in IdentitySets. > > I found the cause (its a bit complicated to explain because related to > the ClassBuilder and become:). I can fix that during the weekend... I've implemented a TraitBehavior>>nsUsers method which does nsUsers ^ self users asOrderedCollection asSet to work around the problem for the article. Can you confirm that this is a valid workaround? -- Damien Cassou http://damiencassou.seasidehosting.st

Jan. 15, 2009

Re: [Pharo-project] Big problem with the implementation of traits

by Adrian Lienhard

On Jan 15, 2009, at 12:41 , StÃ©phane Ducasse wrote: > No we check and this is strange. > What is the hash of a trait? The hash of traits is not related to the problem. The problem is that classes show up multiple times in IdentitySets. I found the cause (its a bit complicated to explain because related to the ClassBuilder and become:). I can fix that during the weekend... Adrian > > > Stef > > On Jan 15, 2009, at 12:08 PM, Adrian Lienhard wrote: > >> Confirmed. I created http://code.google.com/p/pharo/issues/detail?id=443 >> Not sure how it is possible that this IdentitySet can get into that >> state. Any ideas? >> >> Adrian >> >> On Jan 15, 2009, at 11:01 , Damien Cassou wrote: >> >>> Hi, >>> >>> if you load the latest version of Collection package in PharoInbox >>> and >>> evaluate the following, you will see a problem: >>> >>> TCreationWithTest users ===> an IdentitySet(SetTest >>> OrderedCollectionTest ArrayTest) >>> >>> TCreationWithTest users size =====> 5 >>> >>> >>> Depending on your image, the results may vary but will probably >>> still >>> be incorrect. >>> >>> Bye >>> >>> -- >>> Damien Cassou >>> http://damiencassou.seasidehosting.st >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 15, 2009