January 2009 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution

by Gary Chambers

Curiously, without the .cs loaded but with the *latest* Polymorph-Widgets the colour gets fixed up (briefly flashes green). Probably something I did in reworking the flow for pane colour adoption... Buttons are working nicer with the .cs though. The .cs was intended as a guide for David to help with changes to OB. Just the sizing of the instance/comment/class/traits selection area to take account of minimum extent (rather than a fixed height for the panel) and the history navigation buttons to go for it to look nice :-) Regards, Gary. ----- Original Message ----- From: "Torsten Bergmann" <astares(a)gmx.de> To: <pharo-project(a)lists.gforge.inria.fr> Sent: Thursday, January 29, 2009 3:16 PM Subject: [Pharo-project] Polymorph and OB Browser Colors Quick Solution Hi Gary, Scenario: Pharo #10213 image with "ScriptLoader loadSuperOB" After applying the changeset from your mail, the color on the scrollbars is OK now. But the line below the top search field of the browser it is still green. Bye T. -- NUR NOCH BIS 31.01.! GMX FreeDSL - Telefonanschluss + DSL fÃ¼r nur 16,37 EURO/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 29, 2009

[Pharo-project] Polymorph and OB Browser Colors Quick Solution

by Torsten Bergmann

Hi Gary, Scenario: Pharo #10213 image with "ScriptLoader loadSuperOB" After applying the changeset from your mail, the color on the scrollbars is OK now. But the line below the top search field of the browser it is still green. Bye T. -- NUR NOCH BIS 31.01.! GMX FreeDSL - Telefonanschluss + DSL fÃ¼r nur 16,37 EURO/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a

Jan. 29, 2009

Re: [Pharo-project] Squeaksource downtime 29.01.2009

by Marcus Denker

On 28.01.2009, at 15:30, Marcus Denker wrote: > Hi, > > Squeaksource will be down for a short while (hopefully <30min) > tomorrow, 29th Jan, 15h local time (Bern, Central Europe). > SqueakSource is up again. Marcus -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Jan. 29, 2009

Re: [Pharo-project] Updated Polymorph

by Gary Chambers

Once SqueakSource is back up there will be an updated version of the DiffTools. Added support for selecting conflicts (and showing the number outstanding) to the merge tools. Polymorph-Tools-Diff-gvc.9 Enjoy. Regards, Gary.

Jan. 29, 2009

Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution

by Gary Chambers

Indeed, the changeset is totally bogus... must have got tripped up in the change sorter (mostly use MC so I don't use the sorters very often)! Found the correct one now... attached. Regards, Gary. ----- Original Message ----- From: "David RÃ¶thlisberger" <squeak(a)webcitas.ch> To: <Pharo-project(a)lists.gforge.inria.fr> Sent: Thursday, January 29, 2009 1:43 PM Subject: Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution > Hi Gary, > >> Not heard from David since I emailed on 30th Dec about getting OB to be >> less hardcoded about direct use of model colours, along with having >> buttons changed to PluggableButtonMorphPlus (to use enablement rather >> than on/off state to indicate enablement)... > > yep, sorry, I was busy with other stuff. > > But still I'm not sure about the question I sent to you beginning of this > year as an > answer to your mail from the 30th of December: > > "Concerning the first issue about #adoptPaneColor: > In my Squeak 3.9 (and I think also in my latest Pharo) image this method > is already > present in Morph. Is your change therefore needed at all, and if so, where > should we > commit it? I don't think it should be part of OB." > > To give you some more context: You once posted to the mailing list a > CS-patch > containing the #adoptPaneColor: as an OB-extension method for Morph. But > as for me > this method (with the same source code) is already present in Morph, I > cannot imagine > that this patch fixes the problem. > I therefore think we should fix this color problem differently. > If you know another solution, please let me know, otherwise I will dive > into it. > > I will in the meantime look at the PluggableButtonMorphPlus issue. > > Cheers, > David > > >> Regards, Gary. >> >> ----- Original Message ----- >> *From:* Rob Rothwell <mailto:r.j.rothwell@gmail.com> >> *To:* Pharo Development <mailto:pharo-project@lists.gforge.inria.fr> >> *Sent:* Tuesday, January 27, 2009 11:32 PM >> *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick >> Solution >> >> I know OB has some issues with the Polymorph themes such that you >> are always left with the standard browser window color border in the >> window panes of an OB Browser. >> >> At any rate, a simple "Preferences setPreference: >> #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" >> seems to set it to a decent color for the Watery2 or Watery theme, >> but I was wondering if there is a better place to set something like >> this more...dynamically...when different themes are chosen. >> >> Thanks, >> >> Rob >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 29, 2009

Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution

by David RÃ¶thlisberger

Hi Gary, > Not heard from David since I emailed on 30th Dec about getting OB to be > less hardcoded about direct use of model colours, along with having > buttons changed to PluggableButtonMorphPlus (to use enablement rather > than on/off state to indicate enablement)... yep, sorry, I was busy with other stuff. But still I'm not sure about the question I sent to you beginning of this year as an answer to your mail from the 30th of December: "Concerning the first issue about #adoptPaneColor: In my Squeak 3.9 (and I think also in my latest Pharo) image this method is already present in Morph. Is your change therefore needed at all, and if so, where should we commit it? I don't think it should be part of OB." To give you some more context: You once posted to the mailing list a CS-patch containing the #adoptPaneColor: as an OB-extension method for Morph. But as for me this method (with the same source code) is already present in Morph, I cannot imagine that this patch fixes the problem. I therefore think we should fix this color problem differently. If you know another solution, please let me know, otherwise I will dive into it. I will in the meantime look at the PluggableButtonMorphPlus issue. Cheers, David > Regards, Gary. > > ----- Original Message ----- > *From:* Rob Rothwell <mailto:r.j.rothwell@gmail.com> > *To:* Pharo Development <mailto:pharo-project@lists.gforge.inria.fr> > *Sent:* Tuesday, January 27, 2009 11:32 PM > *Subject:* [Pharo-project] Polymorph and OB Browser Colors Quick > Solution > > I know OB has some issues with the Polymorph themes such that you > are always left with the standard browser window color border in the > window panes of an OB Browser. > > At any rate, a simple "Preferences setPreference: > #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" > seems to set it to a decent color for the Watery2 or Watery theme, > but I was wondering if there is a better place to set something like > this more...dynamically...when different themes are chosen. > > Thanks, > > Rob > > ------------------------------------------------------------------------ > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > ------------------------------------------------------------------------ > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 29, 2009

Re: [Pharo-project] Polymorph and OB Browser Colors Quick Solution

by Gary Chambers

Not heard from David since I emailed on 30th Dec about getting OB to be less hardcoded about direct use of model colours, along with having buttons changed to PluggableButtonMorphPlus (to use enablement rather than on/off state to indicate enablement)... Regards, Gary. ----- Original Message ----- From: Rob Rothwell To: Pharo Development Sent: Tuesday, January 27, 2009 11:32 PM Subject: [Pharo-project] Polymorph and OB Browser Colors Quick Solution I know OB has some issues with the Polymorph themes such that you are always left with the standard browser window color border in the window panes of an OB Browser. At any rate, a simple "Preferences setPreference: #browserWindowColor toValue: (Color r: 0.815 g: 0.811 b: 0.811)" seems to set it to a decent color for the Watery2 or Watery theme, but I was wondering if there is a better place to set something like this more...dynamically...when different themes are chosen. Thanks, Rob ------------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 29, 2009

Re: [Pharo-project] Updated Polymorph

by Gary Chambers

Sorry about that. A small bugette plus running into some methods removed from Pharo. Try Polymorph-Widgets-gvc.36 Regards, Gary. ----- Original Message ----- From: "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> To: <Pharo-project(a)lists.gforge.inria.fr> Sent: Tuesday, January 27, 2009 8:23 PM Subject: Re: [Pharo-project] Updated Polymorph > HI gary > > I tried to load it into pharo10213 and it crashed even when I closed > the window (except the one of MC). > I will retry closing everything. > > stef > > On Jan 27, 2009, at 6:26 PM, Gary Chambers wrote: > >> Got annoyed with the PreferenceBrowser not fully tying in with >> themes so >> have reworked it a bit. >> Interesting to see that less code is needed when utilising the theme >> helper >> methods. >> Done as overrides for Squeak compatability, of course. Really need >> to start >> thinking of the base being Pharo with patches for Squeak though. >> >> Polymorph-Widgets-gvc.33 on SqueakSource. >> >> Regards, Gary. >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 29, 2009

Re: [Pharo-project] why #ifNotNil: accepts parameter?

by Damien Cassou

On Tue, Jan 27, 2009 at 7:41 PM, Dale Henrichs <dale.henrichs(a)gemstone.com> wrote: > You'll see more '== nil' in my code from now on:) #isNil? -- Damien Cassou http://damiencassou.seasidehosting.st

Jan. 29, 2009

Re: [Pharo-project] why #ifNotNil: accepts parameter?

by Marcus Denker

On 27.01.2009, at 17:56, StÃ©phane Ducasse wrote: > > On Jan 27, 2009, at 5:04 PM, Esteban Lorenzano wrote: > >> Very interesting stef, thanks a lot... >> >> but now, I'm not sure of what I did with OB-Tools (I just replace >> ifNotNil: [ :blah | ... ] with ifNotNilDo: [ :blah | ... ]... I >> understand why the first version of ifNotNil: is done like that in >> pharo... but what I do with compatibility? will pharo still support >> ifNotNilDo:? >> And, I also agree with lukas. blahDo: is ugly, if you have an elegant >> solution... but, what I have to do with OB-Tools? I replace methods >> (like before) or better I create a package OB-Tools-Squeak with >> extensions for Squeak? >> >> I know... this is hardly a "pharo issue", but maybe can provide pharo >> developers of clues of what to do if they are trying to keep >> compatibiity (I know, that's not a pharo goal -compatibility-, but >> sometimes may be necessary). > > May be package extensions separately. > By accident have you seen the dates of the fixes proposed by vassili > 2007 > this is not that long compared to the changes of compiled method that > we are waiting since at least 2001. Wasn't that more like 1998? Marcus -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Jan. 28, 2009