May 2008 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Replacing 'ReadStream on smth:' by 'smth readStream'

by Adrian Lienhard

Have you verified that your change does not inadvertently modify any behavior? Its not likely, but changes like this can introduce subtle bugs. For instance, Matrix overrides readStream. So if there exists any use of "ReadStream on: aMatrix" that is there to bypass the overridden behavior, the code will break. Cheers, Adrian On May 30, 2008, at 10:47 , Damien Cassou wrote: > Hi, > > I've just published in the pharo inbox a package for the System > category. This change has been generated automatically through the > rewriter: > > ParseTreeRewriter new > replace: 'ReadStream on: ``@object' with: '``@object readStream'; > yourself > > The formatting of the changed method is completely different due to > the use of the refactoring browser. This makes the diffs not readable. > Even if it is a real problem, I don't see any simple solution. What do > you think? > > -- > Damien Cassou > Peter von der AhÃ©: Â«I'm beginning to see why Gilad wished us good > luckÂ». (http://blogs.sun.com/ahe/entry/override_snafu) > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

May 30, 2008

Re: [Pharo-project] Replacing 'ReadStream on smth:' by 'smth readStream'

by Bill Schwab

Damien, Interesting! As an aside, I have a love/hate relationship with the RB, and almost never let it rewrite any of my Dolphin code. The XP guys will recoil in horror at this, but I have too often been saved by 18 month old comments to have them disrespectfully scattered around my source. If that is fixed, I will become a believer. I *do* use pull up/down to great advantage, and will sometimes use other refactorings on new code that has not had time to accumulate valuable comments. The above said, I have considered doing something like your rewrite to fix stream method naming snags. Consider #next. As we have discussed, I think it should be named #nextOrNil, allowing #next to behave as it does in Dolphin. Yes, I have a bias toward Dolphin, but I also consider its streams to be elegantly/correctly built. One way to fix it would be to transform #next into #nextOrNil (which is what Squeak's #next does), and then add a #next that signals EndOfStream on exhaustion; EndOfStream would have no default action in this scenario. If we could further transform any idioms such as aStream next ifNotNil:[ :x | ... ] into aStream nextIfPresent:[ :x | ... ] etc., that could be great if we did it well. Even a clean change to #nextOrNil would allow us to make an otherwise breaking change as painlessly as possible. FWIW, I have no direct problem with #on:, though I see where you are going. We might get a similar benefit by simply changing ReadStream in the system dictionary, making it an alias for NSReadStream?? Bill Wilhelm K. Schwab, Ph.D. University of Florida Department of Anesthesiology PO Box 100254 Gainesville, FL 32610-0254 Email: bschwab(a)anest.ufl.edu Tel: (352) 846-1285 FAX: (352) 392-7029 >>> damien.cassou(a)gmail.com 05/30/08 4:47 AM >>> Hi, I've just published in the pharo inbox a package for the System category. This change has been generated automatically through the rewriter: ParseTreeRewriter new replace: 'ReadStream on: ``@object' with: '``@object readStream'; yourself The formatting of the changed method is completely different due to the use of the refactoring browser. This makes the diffs not readable. Even if it is a real problem, I don't see any simple solution. What do you think? -- Damien Cassou Peter von der AhÃ©: Â«I'm beginning to see why Gilad wished us good luckÂ». (http://blogs.sun.com/ahe/entry/override_snafu) _______________________________________________ Pharo-project mailing list Pharo-project(a)lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

May 30, 2008

Re: [Pharo-project] Replacing 'ReadStream on smth:' by 'smth readStream'

by Damien Cassou

On Fri, May 30, 2008 at 10:57 AM, Lukas Renggli <renggli(a)gmail.com> wrote: >> The formatting of the changed method is completely different due to >> the use of the refactoring browser. This makes the diffs not readable. >> Even if it is a real problem, I don't see any simple solution. What do >> you think? > > Fix the RB. Lol That's why I added 'simple' in the sentence :-). I heard StÃ©phane said that someone was looking at this. Is there any news? -- Damien Cassou Peter von der AhÃ©: Â«I'm beginning to see why Gilad wished us good luckÂ». (http://blogs.sun.com/ahe/entry/override_snafu)

May 30, 2008

Re: [Pharo-project] Replacing 'ReadStream on smth:' by 'smth readStream'

by Lukas Renggli

> The formatting of the changed method is completely different due to > the use of the refactoring browser. This makes the diffs not readable. > Even if it is a real problem, I don't see any simple solution. What do > you think? Fix the RB. Lol Lukas > > -- > Damien Cassou > Peter von der AhÃ©: Â«I'm beginning to see why Gilad wished us good > luckÂ». (http://blogs.sun.com/ahe/entry/override_snafu) > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

May 30, 2008

[Pharo-project] Replacing 'ReadStream on smth:' by 'smth readStream'

by Damien Cassou

Hi, I've just published in the pharo inbox a package for the System category. This change has been generated automatically through the rewriter: ParseTreeRewriter new replace: 'ReadStream on: ``@object' with: '``@object readStream'; yourself The formatting of the changed method is completely different due to the use of the refactoring browser. This makes the diffs not readable. Even if it is a real problem, I don't see any simple solution. What do you think? -- Damien Cassou Peter von der AhÃ©: Â«I'm beginning to see why Gilad wished us good luckÂ». (http://blogs.sun.com/ahe/entry/override_snafu)

May 30, 2008

Re: [Pharo-project] new to pharo

by Alexandre Bergel

>> The webpage https://gforge.inria.fr/plugins/wiki/index.php?HowToContribute&id=1299&type… >> should gives the big lines on how to contribute. > thanks, I should have found it myself. The website of Pharo is really. We plan to change it in a near future... >> Feel free to request for help if necessary. > > ok, I'm starting by chasing all senders to the isMorphic message Let us know about your progress... Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

May 30, 2008

Re: [Pharo-project] new to pharo

by Alexandre Bergel

Hi Alain, Welcome!! The webpage https://gforge.inria.fr/plugins/wiki/index.php?HowToContribute&id=1299&type… should gives the big lines on how to contribute. Feel free to request for help if necessary. Cheers, Alexandre On 29 May 2008, at 23:22, Alain Plantec wrote: > Hi all, > I would like to help. > MVC removeall is a task I can achieve. > now the question is how do I must proceed? > what kind of result ? .cs, .mcz, script ... > thanks > alain > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

May 29, 2008

[Pharo-project] new to pharo

by Alain Plantec

Hi all, I would like to help. MVC removeall is a task I can achieve. now the question is how do I must proceed? what kind of result ? .cs, .mcz, script ... thanks alain

May 29, 2008

Re: [Pharo-project] Some more cleaning...

by StÃ©phane Ducasse

cool :) stef On May 28, 2008, at 4:15 PM, Alexandre Bergel wrote: > Dear all, > > I put two changes in the PharoInBox that remove some unused and > obsolete code related to MVC and the menu on Projects. > > Cheers, > Alexandre > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

May 28, 2008

[Pharo-project] Some more cleaning...

by Alexandre Bergel

Dear all, I put two changes in the PharoInBox that remove some unused and obsolete code related to MVC and the menu on Projects. Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

May 28, 2008