November 2008 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Sunit Extensions breaking the TestRunner

by Keith Hodges

David RÃ¶thlisberger wrote: > >> Can you check and see if it was in your code or a mistake we did? > > ah, I see what happened. > We had Kerala loaded when we committed this SUnit version, but Kerala > overrides method in SUnit such as TestResult>>runCase:, so those > methods didn't get committed. Very bad. Not bad, typical, and you get used to it winding you up if you are an MC1.0 user. So you have to adopt a strategy for maintaining each package, such as maintainng an image specifically for each package that you may have overrides in. So that is what MC1.5 was written for, to fix this bug! But people have failed to see the need for it. Because many of you folks are package writers, rather than package users/tweakers you don't find this problem an issue. But if the package writer will not take on board requests for modifications what can you do. > I committed a new version to Pharo: SUnit-DavidRoethlisberger.42 in > which I also merged changes of stephane_ducassse.denker.41. > Let me know if you need anything else to make SUnit work. > > David the only reason you would need to override runCase: is if your SUnit doesnt include runCaseWith: aBlock as a specific place intended as a hook for test cases to wrap all tests in contexts/exception handlers. (e.g. WACurrentSession) SUnit in www.squeaksource.com/Testing includes runCaseWith: Keith

Nov. 10, 2008

Re: [Pharo-project] SUnit extensions and icons OB support

by Alexandre Bergel

I have seen this. We should continue this discussion offline, then propose a robust and stable version to the pharo community. Cheers, Alexandre On 10 Nov 2008, at 12:53, Simon Denier wrote: > > On 10 nov. 08, at 11:07, David RÃ¶thlisberger wrote: > >> >>> So let me know when I can load again and integrate your extension. >> >> Could you please check with SUnit-DavidRoethlisberger.42 in http://www.squeaksource.com/Pharo >> and execute ScriptLoader class >> loadOB? > > It is not enough > > Starting from a fresh 10144 image, loading OB with scriptloader, > then your latest commit for sunit, I do get the icons in the > browser, but cant update their state: not lastRun method is > generated and it fails when I try to save the results in the > TestRunner. Best guess: the code generating lastRun on the class > side is lost. > >> >> >>> Then after it would be great to have a button to run the tests and >> >> yes, we should have something like that in the browser. >> >> David >> >> >>>> Hi Stef, >>>> >>>> as you as the SUnit extensions are integrated, you just need to >>>> load OB. Any OB load method in ScriptLoader can be used for this >>>> as this extension is also in the stable OB version now. >>>> >>>> David >>>> >>>>> can you tell me what I should do to get the icons showing the >>>>> status of tests in your browser? >>>>> I should harvest the Sunit extensions and then? >>>>> Stef >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- >>>>> project >>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > -- > Simon > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Nov. 10, 2008

Re: [Pharo-project] SUnit extensions and icons OB support

by Simon Denier

On 10 nov. 08, at 11:07, David RÃ¶thlisberger wrote: > >> So let me know when I can load again and integrate your extension. > > Could you please check with SUnit-DavidRoethlisberger.42 in http://www.squeaksource.com/Pharo > and execute ScriptLoader class >> loadOB? It is not enough Starting from a fresh 10144 image, loading OB with scriptloader, then your latest commit for sunit, I do get the icons in the browser, but cant update their state: not lastRun method is generated and it fails when I try to save the results in the TestRunner. Best guess: the code generating lastRun on the class side is lost. > > >> Then after it would be great to have a button to run the tests and > > yes, we should have something like that in the browser. > > David > > >>> Hi Stef, >>> >>> as you as the SUnit extensions are integrated, you just need to >>> load OB. Any OB load method in ScriptLoader can be used for this >>> as this extension is also in the stable OB version now. >>> >>> David >>> >>>> can you tell me what I should do to get the icons showing the >>>> status of tests in your browser? >>>> I should harvest the Sunit extensions and then? >>>> Stef >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Simon

Nov. 10, 2008

Re: [Pharo-project] SUnit extensions and icons OB support

by Alexandre Bergel

Let's do some tests first. I found some bugs already. Alexandre On 10 Nov 2008, at 07:07, David RÃ¶thlisberger wrote: > >> So let me know when I can load again and integrate your extension. > > Could you please check with SUnit-DavidRoethlisberger.42 in http://www.squeaksource.com/Pharo > and execute ScriptLoader class >> loadOB? > >> Then after it would be great to have a button to run the tests and > > yes, we should have something like that in the browser. > > David > > >>> Hi Stef, >>> >>> as you as the SUnit extensions are integrated, you just need to >>> load OB. Any OB load method in ScriptLoader can be used for this >>> as this extension is also in the stable OB version now. >>> >>> David >>> >>>> can you tell me what I should do to get the icons showing the >>>> status of tests in your browser? >>>> I should harvest the Sunit extensions and then? >>>> Stef >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Nov. 10, 2008

Re: [Pharo-project] update #10144

by Igor Stasenko

2008/11/10 Marcus Denker <denker(a)iam.unibe.ch>: > > On 10.11.2008, at 15:56, Marcus Denker wrote: > >> >> On 10.11.2008, at 15:42, Igor Stasenko wrote: >> >>> 2008/11/10 Marcus Denker <denker(a)iam.unibe.ch>: >>>> >>>> - ifNotNilDo: calls renamed to ifNotNil: >>> >>> does it means that #ifNotNil: now accepts monadic blocks? >>> If yes, then cool :) >> >> Yes. And it optimizes them even, same like ifNotNil: without an argument. > > This was done by Vassili Bykov > > http://blog.3plus4.org/2007/04/22/notnil-then-what/ > Right, it was written at the same time, when i reported it more than a year ago :) http://bugs.squeak.org/view.php?id=6426 i'm glad, that this isssue finally will be harvested. Looking back, it is not very important, but more like aesterically right and logical one. Needless to say it helps write more concise code. i avoid using #ifNotNilDo: , but surely i'm using #ifNotNil: but only with niladic blocks because of this issue. > The only problem remaining is that the decompiler does not decompile it > correctly... > > Smalltalk > ifNotNil: [:each | 1 + 4] > > is decompiles to: > > tt > | each | > (each := Smalltalk) ifNotNil: [1 + 4] > > > So the decompiler needs to be enhanced to be a bit cleverer. (I will add a > bug-report for that). > > Marcus > > -- > Marcus Denker -- denker(a)iam.unibe.ch > http://www.iam.unibe.ch/~denker > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Best regards, Igor Stasenko AKA sig.

Nov. 10, 2008

Re: [Pharo-project] update #10144

by Marcus Denker

On 10.11.2008, at 15:56, Marcus Denker wrote: > > On 10.11.2008, at 15:42, Igor Stasenko wrote: > >> 2008/11/10 Marcus Denker <denker(a)iam.unibe.ch>: >>> - ifNotNilDo: calls renamed to ifNotNil: >> >> does it means that #ifNotNil: now accepts monadic blocks? >> If yes, then cool :) > > Yes. And it optimizes them even, same like ifNotNil: without an > argument. This was done by Vassili Bykov http://blog.3plus4.org/2007/04/22/notnil-then-what/ The only problem remaining is that the decompiler does not decompile it correctly... Smalltalk ifNotNil: [:each | 1 + 4] is decompiles to: tt | each | (each := Smalltalk) ifNotNil: [1 + 4] So the decompiler needs to be enhanced to be a bit cleverer. (I will add a bug-report for that). Marcus -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Nov. 10, 2008

Re: [Pharo-project] update #10144

by Marcus Denker

On 10.11.2008, at 15:42, Igor Stasenko wrote: > 2008/11/10 Marcus Denker <denker(a)iam.unibe.ch>: >> - ifNotNilDo: calls renamed to ifNotNil: > > does it means that #ifNotNil: now accepts monadic blocks? > If yes, then cool :) Yes. And it optimizes them even, same like ifNotNil: without an argument. Marcus -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Nov. 10, 2008

Re: [Pharo-project] Sunit Extensions breaking the TestRunner

by Alexandre Bergel

Pfffff... But our greatest mistake is to not have loaded the all thing again. Alexandre On 10 Nov 2008, at 07:05, David RÃ¶thlisberger wrote: > >> Can you check and see if it was in your code or a mistake we did? > > ah, I see what happened. > We had Kerala loaded when we committed this SUnit version, but > Kerala overrides method in SUnit such as TestResult>>runCase:, so > those methods didn't get committed. Very bad. > I committed a new version to Pharo: SUnit-DavidRoethlisberger.42 in > which I also merged changes of stephane_ducassse.denker.41. > Let me know if you need anything else to make SUnit work. > > David > >>> >>> >>>> However there is something strange, the following method has >>>> disappeared from the image (I tried with an Core 10133 updated): >>>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= >>>> TestResult>>runCase: aTestCase >>> [...] >>>> Is there any reason for this? Our extension on storing results >>>> will have to be updated then... >>> >>> So yes, why has this method disappeared? Me too would like to know >>> that. >>> >>> David >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

Nov. 10, 2008

Re: [Pharo-project] update #10144

by Igor Stasenko

2008/11/10 Marcus Denker <denker(a)iam.unibe.ch>: > - ifNotNilDo: calls renamed to ifNotNil: does it means that #ifNotNil: now accepts monadic blocks? If yes, then cool :) > - Issue 232: Recreate Special Objects Array should preserve external > semaphores + Fix > > -- > Marcus Denker -- denker(a)iam.unibe.ch > http://www.iam.unibe.ch/~denker > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Best regards, Igor Stasenko AKA sig.

Nov. 10, 2008

Re: [Pharo-project] SUnit extensions and icons OB support

by David RÃ¶thlisberger

> So let me know when I can load again and integrate your extension. Could you please check with SUnit-DavidRoethlisberger.42 in http://www.squeaksource.com/Pharo and execute ScriptLoader class >> loadOB? > Then after it would be great to have a button to run the tests and yes, we should have something like that in the browser. David >> Hi Stef, >> >> as you as the SUnit extensions are integrated, you just need to load >> OB. Any OB load method in ScriptLoader can be used for this as this >> extension is also in the stable OB version now. >> >> David >> >>> can you tell me what I should do to get the icons showing the status >>> of tests in your browser? >>> I should harvest the Sunit extensions and then? >>> Stef >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Nov. 10, 2008