October 2008 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] How to find methods sent but not implemented?

by Oscar Nierstrasz

SystemNavigation default browseAllUnimplementedCalls shows 272 messages sent but unimplemented in the pharo-dev image :-( At least we know where to continue cleaning! ;-) - on On Oct 25, 2008, at 15:55, Marcus Denker wrote: > Yes, there is > > SystemNavigation>>#browseAllUnimplementedCalls > > The only problem is that it does not highlight the message that is > detected. That can be a problem in large methods to find the > problematic one. > > Marcus

Oct. 25, 2008

Re: [Pharo-project] How to find methods sent but not implemented?

by Oscar Nierstrasz

Yes, I just saw that. I ran the code critics on the Regex package and immediately found 4 methods that send unimplemented messages. RxParser class>>#rareMatchProfile RxParser class>>#singleCharPrefixMatchProfile RxParser class>>#frequentMatchProfile send valueNowOrOnUnwindDo: RxParser class>>#bigHonkingStream sends asFilename I am using the latest pharo-dev with the latest updates. - on On Oct 25, 2008, at 16:44, Lukas Renggli wrote: > Code Critics from the Refactoring browser finds that kind of problems. > It also highlights its findings. > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 25, 2008

[Pharo-project] A process point

by StÃ©phane Ducasse

Hi all after discussing with marcus we would like that everybody publishing to the inbox also open an issue in the tracker. Stef

Oct. 25, 2008

Re: [Pharo-project] facetious Splitter

by Gary Chambers

Not to mention the reorganisations in SystemWindow... :-) Regards, Gary. ----- Original Message ----- From: "StÃ©phane Ducasse" <stephane.ducasse(a)inria.fr> To: "Pharo Development" <pharo-project(a)lists.gforge.inria.fr> Sent: Saturday, October 25, 2008 8:05 AM Subject: Re: [Pharo-project] facetious Splitter > Yes this is bug I introduced when removing etoy and that gary fixed but I > harvested part of the solution. > The problem was splitter used x and y of morphs and only them so gary > replaced that with left right > but I should harvest bottomBoundary from UIEnhancements/ > polymorphWidgets.latest > Now I got some problems to see what I have to extract exactly. If you get > a list that is working I would be happy. > > gary said > "More to the point... the overrides for bottomBoundary etc. are missing > in > ProportionalSplitterMorph." > > > On Oct 25, 2008, at 12:44 AM, nicolas cellier wrote: > >> Recipe for a nice scrambling of layouts in Pharo 10102: >> >> open a FileList; >> single click the splitter above text; >> you should see an annoying mess in the pane layouts. >> >> This happens with some other tools (like FileContentsBrowser). >> Removing the list of files morph with the halos, I discovered a hidden >> splitter under top buttons. >> You can see the mess in Pharo when acting on these two splitters. >> Note that 3.9 ad 3.10.2 images have the hidden splitter too, but the >> splitters behaves better. >> So it has to be a Pharo change. >> Unfortunately morphs are hard to debug! >> It would probably be easier to trace recent Morphic changes. Any clue? >> >> Nicolas >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Oct. 25, 2008

Re: [Pharo-project] How to find methods sent but not implemented?

by Lukas Renggli

Code Critics from the Refactoring browser finds that kind of problems. It also highlights its findings. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Oct. 25, 2008

Re: [Pharo-project] SmallLint broken -- no literalsDo: in CompiledMethod ?

by Lukas Renggli

I fixed that problem last week. Make sure you have the latest version of Refactoring-Core loaded. Cheers, Lukas On Sat, Oct 25, 2008 at 3:51 PM, Marcus Denker <denker(a)iam.unibe.ch> wrote: > > On 25.10.2008, at 12:35, Adrian Lienhard wrote: > >> Probably, "literals do:" instead of "literalsDo:" will work. >> (Normally, methods to be removed should first be deprecated, which >> apparently was not done in this case.) >> > > Sorry, yes, I forgot to put in the deprecation... I will do that in the > future. > > Marcus > >> Adrian >> >> On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote: >> >>> >>> Hi, >>> >>> I was trying out the refactoring engine, and tried to run the code >>> critic. >>> >>> I got a message not understood in SmalllintContext>>addLiteralsFor: which >>> sends literalsDo: to its argument aCompiledMethod. >>> >>> This appears to be the only method in the Pharo-dev image that sends this >>> msg. >>> >>> Any ida what the fix should be? >>> >>> - on >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > -- > Marcus Denker -- denker(a)iam.unibe.ch > http://www.iam.unibe.ch/~denker > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

Oct. 25, 2008

Re: [Pharo-project] OldSocket removal

by Dan Corneanu

I have uploaded Network-DanCorneanu.50.mcz to pharoInbox. It fixes what I think it was a copy-paste error in Socket>>discardReceivedData.

Oct. 25, 2008

Re: [Pharo-project] How to find methods sent but not implemented?

by Marcus Denker

On 25.10.2008, at 12:49, Oscar Nierstrasz wrote: > > BTW, it would be cool to check this in the Pharo image. > > What would be the Smalltalk expression to pop open a browser on all > methods that send messages that are not implemented? (Or simply to > return a list of those messages?) > Yes, there is SystemNavigation>>#browseAllUnimplementedCalls The only problem is that it does not highlight the message that is detected. That can be a problem in large methods to find the problematic one. Marcus > - on > > On Oct 25, 2008, at 12:35, Adrian Lienhard wrote: > >> Probably, "literals do:" instead of "literalsDo:" will work. >> (Normally, methods to be removed should first be deprecated, which >> apparently was not done in this case.) >> >> Adrian >> >> On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote: >> >>> >>> Hi, >>> >>> I was trying out the refactoring engine, and tried to run the code >>> critic. >>> >>> I got a message not understood in >>> SmalllintContext>>addLiteralsFor: which sends literalsDo: to its >>> argument aCompiledMethod. >>> >>> This appears to be the only method in the Pharo-dev image that >>> sends this msg. >>> >>> Any ida what the fix should be? >>> >>> - on >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Oct. 25, 2008

Re: [Pharo-project] SmallLint broken -- no literalsDo: in CompiledMethod ?

by Marcus Denker

On 25.10.2008, at 12:35, Adrian Lienhard wrote: > Probably, "literals do:" instead of "literalsDo:" will work. > (Normally, methods to be removed should first be deprecated, which > apparently was not done in this case.) > Sorry, yes, I forgot to put in the deprecation... I will do that in the future. Marcus > Adrian > > On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote: > >> >> Hi, >> >> I was trying out the refactoring engine, and tried to run the code >> critic. >> >> I got a message not understood in SmalllintContext>>addLiteralsFor: >> which sends literalsDo: to its argument aCompiledMethod. >> >> This appears to be the only method in the Pharo-dev image that >> sends this msg. >> >> Any ida what the fix should be? >> >> - on >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- Marcus Denker -- denker(a)iam.unibe.ch http://www.iam.unibe.ch/~denker

Oct. 25, 2008

Re: [Pharo-project] SmallLint broken -- no literalsDo: in CompiledMethod ?

by StÃ©phane Ducasse

yes I will add a deprecated method. I do not know which changes did that. stef On Oct 25, 2008, at 12:35 PM, Adrian Lienhard wrote: > Probably, "literals do:" instead of "literalsDo:" will work. > (Normally, methods to be removed should first be deprecated, which > apparently was not done in this case.) > > Adrian > > On Oct 25, 2008, at 12:22 , Oscar Nierstrasz wrote: > >> >> Hi, >> >> I was trying out the refactoring engine, and tried to run the code >> critic. >> >> I got a message not understood in SmalllintContext>>addLiteralsFor: >> which sends literalsDo: to its argument aCompiledMethod. >> >> This appears to be the only method in the Pharo-dev image that >> sends this msg. >> >> Any ida what the fix should be? >> >> - on >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Oct. 25, 2008