[Issue Tracker] reviews needed

MD
Marcus Denker
Thu, Jan 26, 2023 9:21 AM

Hi,

I wanted again to make some noise about the issue tracker.

Yes, we merge 20-40 PRs per week, but even with that, there are many PRs in the queue…

e.g.

We have open 35 PRs, the complete list is here: https://github.com/pharo-project/pharo/pulls

some random notes:

  • reviews are always helpful, and even if there is already a positive review, a second one helps.

  • one part of a review is to check that the code is not doing obvious bad things (like un-doing older changes, dumb mistakes….)
    if you feel unsure what you can do as you do not really understand the change, that one you can check (and just say that in the review).

  • if you do PRs e.g with a pair, ask the person that did not commit to add a real review so it is clear that there where already
    two eyes on the code

  • if you work in a team, ask your team mates to review your code
    especially if you use that fix already internally

  • if you use the fix in your project already, add a review to just state that

  • if you see a fix where you think “I hope this will be merged soon”, if you review, you will make it much easier…

  • if you see a fix that is reviewed, green and not merged and you do not understand why: do a review

  • consider just reviewing / doing something once every week. or even once every day, instead of letting it all pile up.

    Marcus

Hi, I wanted again to make some noise about the issue tracker. Yes, we merge 20-40 PRs per week, but even with that, there are many PRs in the queue… e.g. - Complete symbols #11918 https://github.com/pharo-project/pharo/pull/11918 - 12128-Poor-performance-with-large-WriteStreams #12205 https://github.com/pharo-project/pharo/pull/12205 - Fix Calypso browsing unloaded package artifacts from Iceberg #12425 https://github.com/pharo-project/pharo/pull/12425 - Introducing a Color Palette to cache the allocation of Color objects by tht UITheme #12419 https://github.com/pharo-project/pharo/pull/12419 We have open 35 PRs, the complete list is here: https://github.com/pharo-project/pharo/pulls some random notes: - reviews are always helpful, and even if there is already a positive review, a second one helps. - one part of a review is to check that the code is not doing obvious bad things (like un-doing older changes, dumb mistakes….) if you feel unsure what you can do as you do not really understand the change, that one you can check (and just say that in the review). - if you do PRs e.g with a pair, ask the person that did not commit to add a real review so it is clear that there where already two eyes on the code - if you work in a team, ask your team mates to review your code especially if you use that fix already internally - if you use the fix in your project already, add a review to just state that - if you see a fix where you think “I hope this will be merged soon”, if you review, you will make it much easier… - if you see a fix that is reviewed, green and not merged and you do not understand why: do a review - consider just reviewing / doing *something* once every week. or even once every day, instead of letting it all pile up. Marcus