This week (50/2020) on the Issue Tracker

MD
Marcus Denker
Fri, Dec 11, 2020 8:46 AM

Another week with ~50 merged pull requests.

Class Definitions

Mostly stabilizing the last changes...

Halt Cleanup

Finished: we now have a release test. There can never be a #halt left without the
test failing.

Fixes

Refactoring

Work has begun to check (and fix) refactorings. More to come.

AST Improvements / Cleanups

The visitor now calls #visitGlobalVariableNode:, visitClassVariableNode:, if you
inherit (or use the trait) the change is backward compatible (it makes sure to call the
same methods as before).

Cleanups and improvements Code Critique

Dead Code

Other Cleanups

Another week with ~50 merged pull requests. Class Definitions ================== Mostly stabilizing the last changes... - Class>>#asRingDefinition should not send #definition but #definitionString #8024 https://github.com/pharo-project/pharo/pull/8024 - ReSearchStringSourceAnchor>>#interval should not use deprecated #definition #8022 https://github.com/pharo-project/pharo/pull/8022 - 7980-fix-checkClassRebuild #7982 https://github.com/pharo-project/pharo/pull/7982 - Move old definition printing to a the legacy printer #7894 https://github.com/pharo-project/pharo/pull/7894 Halt Cleanup ============= Finished: we now have a release test. There can never be a #halt left without the test failing. - 7925-halt-left-in-FFIFunctionParsersetOn #7932 https://github.com/pharo-project/pharo/pull/7932 - 7928-halt-left-in-FBDDecompilerpushFullClosurenumCopiedreceiverOnStackignoreOuterContext #7970 https://github.com/pharo-project/pharo/pull/7970 - 7975-ReleaseTesttestMethodsContainNoHalt #7977 https://github.com/pharo-project/pharo/pull/7977 - "Browse Breakpoints" should not show implementation methods #7969 https://github.com/pharo-project/pharo/pull/7969 Fixes ===== - Lazily file open in Zip archive #7999 https://github.com/pharo-project/pharo/pull/7999 - 8037-Scrolling-messages-leads-to-red-square-of-death #8039 https://github.com/pharo-project/pharo/pull/8039 - Fixed #8014. Renamed Random >> nextInt: and nextIntBetween:and: to nextInteger: and nextIntegerBetween:and: #8021 https://github.com/pharo-project/pharo/pull/8021 - Fix win32 library name for freetype #7778 https://github.com/pharo-project/pharo/pull/7778 - 7966-Temporary-Variables-Cannot-be-used-in-loops-in-a-playground #7983 https://github.com/pharo-project/pharo/pull/7983 - Only concrete Font descriptions should be installable #7986 https://github.com/pharo-project/pharo/pull/7986 - Fixed #7612. The bug that happened when an IntegerArray was added to a FloatArray #7622 https://github.com/pharo-project/pharo/pull/7622 - Fixed #7937. Implemented Random>>nextBetween:and:, nextIntBetween:and:, and wrote tests for them #7938 https://github.com/pharo-project/pharo/pull/7938 - 7956-Completion-broken-in-Transcript #7958 https://github.com/pharo-project/pharo/pull/7958 - fixing-FFIBackend-initialization #7973 https://github.com/pharo-project/pharo/pull/7973 - Fixing mem leak after debugger proceeding #7992 https://github.com/pharo-project/pharo/pull/7992 - 7953 huge debugger st pharo application memory leak #7976 https://github.com/pharo-project/pharo/pull/7976 - 8005-ClassHierarchyPrinter-glitches #8012 https://github.com/pharo-project/pharo/pull/8012 - 8001-Improving-ClassHierarchyPrinter #8003 https://github.com/pharo-project/pharo/pull/8003 - tagsForClasses #8008 https://github.com/pharo-project/pharo/pull/8008 - add Trait>>#isUsed. #7981 https://github.com/pharo-project/pharo/pull/7981 Refactoring ============ Work has begun to check (and fix) refactorings. More to come. - Review refactorings #7965 https://github.com/pharo-project/pharo/pull/7965 - Fix rename refactoring issue - 7947 #7978 https://github.com/pharo-project/pharo/pull/7978 AST Improvements / Cleanups ============================ The visitor now calls #visitGlobalVariableNode:, visitClassVariableNode:, if you inherit (or use the trait) the change is backward compatible (it makes sure to call the same methods as before). - AST-add-more-Variable-visit-methods #7929 https://github.com/pharo-project/pharo/pull/7929 - TRBProgramNodeVisitor-methods-missing #7962 https://github.com/pharo-project/pharo/pull/7962 - AST-Cleanup-visitUnreachableStatement #7951 https://github.com/pharo-project/pharo/pull/7951 - CoTypeInferencer should inherit from RBProgramNodeVisitor #8040 https://github.com/pharo-project/pharo/pull/8040 - 7993-Completion-broken-while-editing #7998 https://github.com/pharo-project/pharo/pull/7998 Cleanups and improvements Code Critique ====================== - ReSendsUnknownMessageToGlobalRule laments wrongly on class variables #8031 https://github.com/pharo-project/pharo/pull/8031 - Mark abstract test classes in Renraku-Tests #8029 https://github.com/pharo-project/pharo/pull/8029 - Cleanup ReAbstractRule #8057 https://github.com/pharo-project/pharo/pull/8057 - Clean selector casing in Renraku #8063 https://github.com/pharo-project/pharo/pull/8063 - Add script pragmas to CriticBrowser #8035 https://github.com/pharo-project/pharo/pull/8035 - Simplify-ReUnaryAccessingMethodWithoutReturnRule #7839 https://github.com/pharo-project/pharo/pull/7839 Dead Code ========= - Gofer-UI package should be removed in Pharo 9 #8027 https://github.com/pharo-project/pharo/pull/8027 - Deprecate leadingChar and old encoders. #7892 https://github.com/pharo-project/pharo/pull/7892 - remove-unused-charScannerPrimitive #7884 https://github.com/pharo-project/pharo/pull/7884 - Cleanup-EncoderForV3PlusClosures #7972 https://github.com/pharo-project/pharo/pull/7972 - Remove unused lastKeyboardFocus ivare from OSSDL2BackendWindow #7946 https://github.com/pharo-project/pharo/pull/7946 Other Cleanups ============== - ReSourceAnchor typo in class comment #8066 https://github.com/pharo-project/pharo/pull/8066 - Tag uncategorized classes in package Morphic-Widgets-Tabs #8015 https://github.com/pharo-project/pharo/pull/8015 - EpApplyPreviewerTest calls deprecated method #8007 https://github.com/pharo-project/pharo/pull/8007 - HDTestCoverage and HDCoverageReport use obsolete actualClass #7991 https://github.com/pharo-project/pharo/pull/7991 - fixes #7924: Enhance CodeImporter with better comment #7988 https://github.com/pharo-project/pharo/pull/7988