Progress Report -> Refactoring Project - ( May 10 - May 14)

EC
Evelyn Cusi Lopez
Mon, May 17, 2021 12:19 PM

Hi everyone,

Last week I did these tasks:

Tasks for this week:
https://github.com/pharo-project/pharo/issues/9142

Regards,

Evelyn C.

Hi everyone, Last week I did these tasks: - Improve presenter of scope list using trees, add modal to show details of scopes - Add RBClassHierarchyEnvironment - Add commands to add HierarchyScope (from simple class), add NOT command to do operations in scopeList. - Add direct access from the toolbar. Check these changes in the branch: DefaultScope branch <https://github.com/pharo-project/pharo/compare/Pharo9.0...Lin777:DefaultScope?expand=1> Check the behavior in this video: Youtube video <https://youtu.be/Ex5P49Lyx_E>. - Change preview of refactorings from Modal to Dialog, refactor some components of refactoring presenters and add focus order in rename method preview. Check changes here: PR <https://github.com/pharo-project/pharo/pull/9285> Tasks for this week: <https://github.com/pharo-project/pharo/issues/9142> - Use the scopeList with refactorings (as default environments). - Fix issues: #9060 <https://github.com/pharo-project/pharo/issues/9060> and #5894 <https://github.com/pharo-project/pharo/issues/5894>. Now refactoring preview presenter is already a Dialog, Still missing to convert the renaming, select methods, variables, etc.presents to dialogs - Improve messages: No understable message #9229 <https://github.com/pharo-project/pharo/issues/9241> - Fix issue: RB - Inline all senders of class methods (instance creation) doesn't work, need improve pattern to search #9142 <https://github.com/pharo-project/pharo/issues/9142> - Fix issue: RB - Improve instance variable refactoring #8665 <https://github.com/pharo-project/pharo/issues/8665> <https://github.com/pharo-project/pharo/issues/9241> Regards, Evelyn C.
GC
Gabriel Cotelli
Mon, May 17, 2021 12:39 PM

Evelyn,
It is really good to see these improvements. May I suggest allowing the
user to give a name to a specific scope?. Because having a large list of
packages or classes in the scope and using them to infer the name will not
scale well. I'm envisioning creating these scopes programmatically for our
packages and having the possibility of giving them a proper name is a must.

Another idea that I think can be useful is to allow combining existing
scopes into a new one.

Keep up the good work.

On Mon, May 17, 2021 at 9:19 AM Evelyn Cusi Lopez cusi.evelyn@gmail.com
wrote:

Hi everyone,

Last week I did these tasks:

Tasks for this week:
https://github.com/pharo-project/pharo/issues/9142

Regards,

Evelyn C.

Evelyn, It is really good to see these improvements. May I suggest allowing the user to give a name to a specific scope?. Because having a large list of packages or classes in the scope and using them to infer the name will not scale well. I'm envisioning creating these scopes programmatically for our packages and having the possibility of giving them a proper name is a must. Another idea that I think can be useful is to allow combining existing scopes into a new one. Keep up the good work. On Mon, May 17, 2021 at 9:19 AM Evelyn Cusi Lopez <cusi.evelyn@gmail.com> wrote: > Hi everyone, > > Last week I did these tasks: > > - Improve presenter of scope list using trees, add modal to show details > of scopes > - Add RBClassHierarchyEnvironment > - Add commands to add HierarchyScope (from simple class), add NOT command > to do operations in scopeList. > - Add direct access from the toolbar. Check these changes in the branch: DefaultScope > branch > <https://github.com/pharo-project/pharo/compare/Pharo9.0...Lin777:DefaultScope?expand=1> Check > the behavior in this video: Youtube video <https://youtu.be/Ex5P49Lyx_E>. > - Change preview of refactorings from Modal to Dialog, refactor some > components of refactoring presenters and add focus order in rename method > preview. Check changes here: PR > <https://github.com/pharo-project/pharo/pull/9285> > > Tasks for this week: > <https://github.com/pharo-project/pharo/issues/9142> > > - Use the scopeList with refactorings (as default environments). > - Fix issues: #9060 <https://github.com/pharo-project/pharo/issues/9060> > and #5894 <https://github.com/pharo-project/pharo/issues/5894>. Now > refactoring preview presenter is already a Dialog, Still missing to convert > the renaming, select methods, variables, etc.presents to dialogs > - Improve messages: No understable message #9229 > <https://github.com/pharo-project/pharo/issues/9241> > - Fix issue: RB - Inline all senders of class methods (instance creation) > doesn't work, need improve pattern to search #9142 > <https://github.com/pharo-project/pharo/issues/9142> > - Fix issue: RB - Improve instance variable refactoring #8665 > <https://github.com/pharo-project/pharo/issues/8665> > <https://github.com/pharo-project/pharo/issues/9241> > > Regards, > > Evelyn C. >
EC
Evelyn Cusi Lopez
Mon, May 17, 2021 2:04 PM

Hello Gabriel,

Thank you very much for the suggestions, at the moment they have a default
name, but of course I could add the option to rename them.

Right now we are making the combination of environments accessible, using
the RBAndEnvironment, RBOrEnvironment and RBNotEnvironment classes.

Regards,

Evelyn Cusi

El lun, 17 may 2021 a las 8:41, Gabriel Cotelli (g.cotelli@gmail.com)
escribió:

Evelyn,
It is really good to see these improvements. May I suggest allowing the
user to give a name to a specific scope?. Because having a large list of
packages or classes in the scope and using them to infer the name will not
scale well. I'm envisioning creating these scopes programmatically for our
packages and having the possibility of giving them a proper name is a must.

Another idea that I think can be useful is to allow combining existing
scopes into a new one.

Keep up the good work.

On Mon, May 17, 2021 at 9:19 AM Evelyn Cusi Lopez cusi.evelyn@gmail.com
wrote:

Hi everyone,

Last week I did these tasks:

Tasks for this week:
https://github.com/pharo-project/pharo/issues/9142

Regards,

Evelyn C.

Hello Gabriel, Thank you very much for the suggestions, at the moment they have a default name, but of course I could add the option to rename them. Right now we are making the combination of environments accessible, using the RBAndEnvironment, RBOrEnvironment and RBNotEnvironment classes. Regards, Evelyn Cusi El lun, 17 may 2021 a las 8:41, Gabriel Cotelli (<g.cotelli@gmail.com>) escribió: > Evelyn, > It is really good to see these improvements. May I suggest allowing the > user to give a name to a specific scope?. Because having a large list of > packages or classes in the scope and using them to infer the name will not > scale well. I'm envisioning creating these scopes programmatically for our > packages and having the possibility of giving them a proper name is a must. > > Another idea that I think can be useful is to allow combining existing > scopes into a new one. > > Keep up the good work. > > > On Mon, May 17, 2021 at 9:19 AM Evelyn Cusi Lopez <cusi.evelyn@gmail.com> > wrote: > >> Hi everyone, >> >> Last week I did these tasks: >> >> - Improve presenter of scope list using trees, add modal to show details >> of scopes >> - Add RBClassHierarchyEnvironment >> - Add commands to add HierarchyScope (from simple class), add NOT command >> to do operations in scopeList. >> - Add direct access from the toolbar. Check these changes in the branch: DefaultScope >> branch >> <https://github.com/pharo-project/pharo/compare/Pharo9.0...Lin777:DefaultScope?expand=1> Check >> the behavior in this video: Youtube video <https://youtu.be/Ex5P49Lyx_E>. >> - Change preview of refactorings from Modal to Dialog, refactor some >> components of refactoring presenters and add focus order in rename method >> preview. Check changes here: PR >> <https://github.com/pharo-project/pharo/pull/9285> >> >> Tasks for this week: >> <https://github.com/pharo-project/pharo/issues/9142> >> >> - Use the scopeList with refactorings (as default environments). >> - Fix issues: #9060 <https://github.com/pharo-project/pharo/issues/9060> >> and #5894 <https://github.com/pharo-project/pharo/issues/5894>. Now >> refactoring preview presenter is already a Dialog, Still missing to convert >> the renaming, select methods, variables, etc.presents to dialogs >> - Improve messages: No understable message #9229 >> <https://github.com/pharo-project/pharo/issues/9241> >> - Fix issue: RB - Inline all senders of class methods (instance >> creation) doesn't work, need improve pattern to search #9142 >> <https://github.com/pharo-project/pharo/issues/9142> >> - Fix issue: RB - Improve instance variable refactoring #8665 >> <https://github.com/pharo-project/pharo/issues/8665> >> <https://github.com/pharo-project/pharo/issues/9241> >> >> Regards, >> >> Evelyn C. >> >